<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54851] trunk/.github/workflows: Build/Test Tools: Various minor GitHub Action improvements.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54851">54851</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54851","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-11-16 19:32:57 +0000 (Wed, 16 Nov 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Various minor GitHub Action improvements.
This applies several types of improvements to GitHub Action workflows:
- Updates to inline documentation to ensure accuracy.
- Removal of repetitive or unnecessary debug logging.
- Reorganization of some steps to have configuration steps towards the beginning of jobs.
- Step name updates for consistency across workflows.
Props desrosj, jrf.
See <a href="https://core.trac.wordpress.org/ticket/56793">#56793</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowscodingstandardsyml">trunk/.github/workflows/coding-standards.yml</a></li>
<li><a href="#trunkgithubworkflowsendtoendtestsyml">trunk/.github/workflows/end-to-end-tests.yml</a></li>
<li><a href="#trunkgithubworkflowsjavascripttestsyml">trunk/.github/workflows/javascript-tests.yml</a></li>
<li><a href="#trunkgithubworkflowsphpcompatibilityyml">trunk/.github/workflows/php-compatibility.yml</a></li>
<li><a href="#trunkgithubworkflowsphpunittestsyml">trunk/.github/workflows/phpunit-tests.yml</a></li>
<li><a href="#trunkgithubworkflowstestandzipdefaultthemesyml">trunk/.github/workflows/test-and-zip-default-themes.yml</a></li>
<li><a href="#trunkgithubworkflowstestcoverageyml">trunk/.github/workflows/test-coverage.yml</a></li>
<li><a href="#trunkgithubworkflowstestnpmyml">trunk/.github/workflows/test-npm.yml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowscodingstandardsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/coding-standards.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/coding-standards.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/coding-standards.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,14 +48,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Sets up PHP.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs debug information.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Configures caching for PHPCS scans.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Composer dependencies (use cache if possible).
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs Composer dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Make Composer packages available globally.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs PHP_CodeSniffer debug information.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Runs PHPCS on the full codebase with warnings suppressed.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Generate a report for displaying issues as pull request annotations.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Runs PHPCS on the `tests` directory without warnings suppressed.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Generate a report for displaying `test` directory issues as pull request annotations.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> phpcs:
</span><span class="cx" style="display: block; padding: 0 10px"> name: PHP coding standards
</span><span class="cx" style="display: block; padding: 0 10px"> runs-on: ubuntu-latest
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -73,11 +74,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> coverage: none
</span><span class="cx" style="display: block; padding: 0 10px"> tools: composer, cs2pr
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Log debug information
- run: |
- php --version
- composer --version
-
</del><span class="cx" style="display: block; padding: 0 10px"> # This date is used to ensure that the PHPCS cache is cleared at least once every week.
</span><span class="cx" style="display: block; padding: 0 10px"> # http://man7.org/linux/man-pages/man1/date.1.html
</span><span class="cx" style="display: block; padding: 0 10px"> - name: "Get last Monday's date"
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -98,9 +94,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Make Composer packages available globally
</span><span class="cx" style="display: block; padding: 0 10px"> run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Log PHPCS debug information
- run: phpcs -i
-
</del><span class="cx" style="display: block; padding: 0 10px"> - name: Run PHPCS on all Core files
</span><span class="cx" style="display: block; padding: 0 10px"> id: phpcs-core
</span><span class="cx" style="display: block; padding: 0 10px"> run: phpcs -n --report-full --report-checkstyle=./.cache/phpcs-report.xml
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -126,10 +119,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about the GitHub Action runner.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Node.js.
- # - Logs updated debug information.
- # _ Installs npm dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs npm dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Run the WordPress JSHint checks.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> jshint:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -144,14 +136,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Log debug information
- run: |
- npm --version
- node --version
- git --version
- svn --version
-
- - name: Install Node.js
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
</ins><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> node-version-file: '.nvmrc'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -161,8 +146,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm --version
</span><span class="cx" style="display: block; padding: 0 10px"> node --version
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ git --version
+ svn --version
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Install npm Dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Run JSHint
</span></span></pre></div>
<a id="trunkgithubworkflowsendtoendtestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/end-to-end-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/end-to-end-tests.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/end-to-end-tests.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,12 +35,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Sets environment variables.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about the GitHub Action runner.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Node.js.
- # _ Installs npm dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs npm dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Builds WordPress to run from the `build` directory.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Starts the WordPress Docker container.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs general debug information.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Logs the running Docker containers.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Logs Docker debug information (about both the Docker installation within the runner and the WordPress container).
</span><span class="cx" style="display: block; padding: 0 10px"> # - Install WordPress within the Docker container.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -61,6 +60,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
+ uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
+ with:
+ node-version-file: '.nvmrc'
+ cache: npm
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm --version
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -68,17 +73,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> curl --version
</span><span class="cx" style="display: block; padding: 0 10px"> git --version
</span><span class="cx" style="display: block; padding: 0 10px"> svn --version
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php --version
- php -i
</del><span class="cx" style="display: block; padding: 0 10px"> locale -a
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Node.js
- uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
- with:
- node-version-file: '.nvmrc'
- cache: npm
-
- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Install npm Dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Build WordPress
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -88,14 +85,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm run env:start
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: General debug information
- run: |
- npm --version
- node --version
- curl --version
- git --version
- svn --version
-
</del><span class="cx" style="display: block; padding: 0 10px"> - name: Log running Docker containers
</span><span class="cx" style="display: block; padding: 0 10px"> run: docker ps -a
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgithubworkflowsjavascripttestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/javascript-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/javascript-tests.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/javascript-tests.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -43,10 +43,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about the GitHub Action runner.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Node.js.
- # - Logs updated debug information.
- # _ Installs npm dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs npm dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Run the WordPress QUnit tests.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> test-js:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -59,14 +58,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Log debug information
- run: |
- npm --version
- node --version
- git --version
- svn --version
-
- - name: Install Node.js
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
</ins><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> node-version-file: '.nvmrc'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -76,8 +68,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm --version
</span><span class="cx" style="display: block; padding: 0 10px"> node --version
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ git --version
+ svn --version
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Install npm Dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Run QUnit tests
</span></span></pre></div>
<a id="trunkgithubworkflowsphpcompatibilityyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/php-compatibility.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/php-compatibility.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/php-compatibility.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -46,10 +46,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # - Sets up PHP.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Configures caching for PHP compatibility scans.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Composer dependencies (use cache if possible).
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs Composer dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Make Composer packages available globally.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs PHP_CodeSniffer debug information.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Runs the PHP compatibility tests.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Generate a report for displaying issues as pull request annotations.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> php-compatibility:
</span><span class="cx" style="display: block; padding: 0 10px"> name: Check PHP compatibility
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -70,7 +70,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php --version
</del><span class="cx" style="display: block; padding: 0 10px"> composer --version
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # This date is used to ensure that the PHP compatibility cache is cleared at least once every week.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -93,9 +92,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Make Composer packages available globally
</span><span class="cx" style="display: block; padding: 0 10px"> run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Log PHPCS debug information
- run: phpcs -i
-
</del><span class="cx" style="display: block; padding: 0 10px"> - name: Run PHP compatibility tests
</span><span class="cx" style="display: block; padding: 0 10px"> id: phpcs
</span><span class="cx" style="display: block; padding: 0 10px"> run: phpcs --standard=phpcompat.xml.dist --report-full --report-checkstyle=./.cache/phpcs-compat-report.xml
</span></span></pre></div>
<a id="trunkgithubworkflowsphpunittestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/phpunit-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/phpunit-tests.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/phpunit-tests.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,22 +36,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Sets environment variables.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Sets up the environment variables needed for testing with memcached (if desired).
- # - Installs Node.js.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Checks out the repository.
+ # - Sets up Node.js.
+ # - Logs general debug information about the runner.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Installs npm dependencies
</span><span class="cx" style="display: block; padding: 0 10px"> # - Configures caching for Composer.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Installs Composer dependencies.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Logs Docker debug information (about the Docker installation within the runner).
</span><span class="cx" style="display: block; padding: 0 10px"> # - Starts the WordPress Docker container.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs general debug information about the runner.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Logs the running Docker containers.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs debug information from inside the WordPress Docker container.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about what's installed within the WordPress Docker containers.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Install WordPress within the Docker container.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Run the PHPUnit tests.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the WordPress Test reporter repository.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Reconnect the directory to the Git repository.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Submit the test results to the WordPress.org host test results.
</span><span class="cx" style="display: block; padding: 0 10px"> test-php:
</span><span class="cx" style="display: block; padding: 0 10px"> name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }}${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -108,13 +106,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Node.js
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
</ins><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> node-version-file: '.nvmrc'
</span><span class="cx" style="display: block; padding: 0 10px"> cache: npm
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: General debug information
+ run: |
+ npm --version
+ node --version
+ curl --version
+ git --version
+ svn --version
+
+ - name: Install npm dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # This date is used to ensure that the Composer cache is refreshed at least once every week.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -155,14 +161,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm run env:start
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: General debug information
- run: |
- npm --version
- node --version
- curl --version
- git --version
- svn --version
-
</del><span class="cx" style="display: block; padding: 0 10px"> - name: Log running Docker containers
</span><span class="cx" style="display: block; padding: 0 10px"> run: docker ps -a
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgithubworkflowstestandzipdefaultthemesyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-and-zip-default-themes.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-and-zip-default-themes.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/test-and-zip-default-themes.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,9 +49,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Node.js (only when theme has a build process)
- # - Installs npm dependencies (only when theme has a build process)
- # - Runs the theme build script (only when theme has a build process)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
+ # - Installs npm dependencies.
+ # - Runs the theme build script.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> test-build-scripts:
</span><span class="cx" style="display: block; padding: 0 10px"> name: Test ${{ matrix.theme }} build script
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -77,7 +77,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> ref: ${{ github.event_name == 'workflow_dispatch' && inputs.branch || github.ref }}
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Node.js
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
</ins><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> node-version-file: '.nvmrc'
</span></span></pre></div>
<a id="trunkgithubworkflowstestcoverageyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-coverage.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-coverage.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/test-coverage.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -32,26 +32,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> LOCAL_PHP_MEMCACHED: ${{ false }}
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> jobs:
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Sets up WordPress for testing or development use.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # Runs the PHPUnit tests for WordPress.
</ins><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Sets environment variables.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
- # - Logs debug information about the GitHub Action runner.
- # - Installs Node.js.
- # _ Installs npm dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
+ # - Logs general debug information about the runner.
+ # - Installs npm dependencies
+ # - Configures caching for Composer.
+ # - Installs Composer dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Logs Docker debug information (about the Docker installation within the runner).
</span><span class="cx" style="display: block; padding: 0 10px"> # - Starts the WordPress Docker container.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs debug general information.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Logs the running Docker containers.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Logs WordPress Docker container debug information.
</del><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about what's installed within the WordPress Docker containers.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Install WordPress within the Docker container.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Run the PHPUnit tests as a single site.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Upload the single site code coverage report to Codecov.io.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Run the PHPUnit tests as a multisite.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Run the PHPUnit tests as a multisite installation.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Upload the multisite code coverage report to Codecov.io.
</span><span class="cx" style="display: block; padding: 0 10px"> test-coverage-report:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -73,6 +72,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
+ uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
+ with:
+ node-version-file: '.nvmrc'
+ cache: npm
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> echo "$GITHUB_REF"
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -82,17 +87,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> curl --version
</span><span class="cx" style="display: block; padding: 0 10px"> git --version
</span><span class="cx" style="display: block; padding: 0 10px"> svn --version
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php --version
- php -i
</del><span class="cx" style="display: block; padding: 0 10px"> locale -a
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Node.js
- uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
- with:
- node-version-file: '.nvmrc'
- cache: npm
-
- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Install npm Dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # This date is used to ensure that the Composer cache is refreshed at least once every week.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -129,14 +126,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm run env:start
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: General debug information
- run: |
- npm --version
- node --version
- curl --version
- git --version
- svn --version
-
</del><span class="cx" style="display: block; padding: 0 10px"> - name: Log running Docker containers
</span><span class="cx" style="display: block; padding: 0 10px"> run: docker ps -a
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgithubworkflowstestnpmyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-npm.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-npm.yml 2022-11-16 16:34:29 UTC (rev 54850)
+++ trunk/.github/workflows/test-npm.yml 2022-11-16 19:32:57 UTC (rev 54851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -41,9 +41,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about the GitHub Action runner.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Node.js.
- # _ Installs npm dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs npm dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Builds WordPress to run from the `build` directory.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Cleans up after building WordPress to the `build` directory.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,6 +64,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
+ uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
+ with:
+ node-version-file: '.nvmrc'
+ cache: npm
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm --version
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -72,13 +78,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> git --version
</span><span class="cx" style="display: block; padding: 0 10px"> svn --version
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Node.js
- uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
- with:
- node-version-file: '.nvmrc'
- cache: npm
-
- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Install npm Dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Build WordPress in /src
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -106,9 +106,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><span class="cx" style="display: block; padding: 0 10px"> # - Checks out the repository.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Sets up Node.js.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Logs debug information about the GitHub Action runner.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # - Installs Node.js.
- # _ Installs npm dependencies.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Installs npm dependencies.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Builds WordPress to run from the `build` directory.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Cleans up after building WordPress to the `build` directory.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Ensures version-controlled files are not modified or deleted.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -124,6 +124,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Set up Node.js
+ uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
+ with:
+ node-version-file: '.nvmrc'
+ cache: npm
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Log debug information
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> npm --version
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -132,13 +138,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> git --version
</span><span class="cx" style="display: block; padding: 0 10px"> svn --version
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- - name: Install Node.js
- uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
- with:
- node-version-file: '.nvmrc'
- cache: npm
-
- - name: Install Dependencies
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Install npm Dependencies
</ins><span class="cx" style="display: block; padding: 0 10px"> run: npm ci
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Build WordPress in /src
</span></span></pre>
</div>
</div>
</body>
</html>