<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54710] trunk/tests/phpunit/tests: Tests: Move the tests for `WP` class methods to the `wp` directory.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54710">54710</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54710","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-10-28 14:08:20 +0000 (Fri, 28 Oct 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Move the tests for `WP` class methods to the `wp` directory.
This aims to bring some consistency to the location of the tests for this class.
Includes adding the missing `@covers` tags.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/36177">[36177]</a>, <a href="https://core.trac.wordpress.org/changeset/51622">[51622]</a>, <a href="https://core.trac.wordpress.org/changeset/54250">[54250]</a>.
Props pbearne, SergeyBiryukov.
See <a href="https://core.trac.wordpress.org/ticket/56793">#56793</a>, <a href="https://core.trac.wordpress.org/ticket/56782">#56782</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestswpparseRequestphp">trunk/tests/phpunit/tests/wp/parseRequest.php</a></li>
<li><a href="#trunktestsphpunittestswpsendHeadersphp">trunk/tests/phpunit/tests/wp/sendHeaders.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestswpaddQueryVarphp">trunk/tests/phpunit/tests/wp/addQueryVar.php</a></li>
<li><a href="#trunktestsphpunittestswpremoveQueryVarphp">trunk/tests/phpunit/tests/wp/removeQueryVar.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestswpphp">trunk/tests/phpunit/tests/wp.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestswpaddQueryVarphpfromrev54642trunktestsphpunittestswpphp"></a>
<div class="copfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Copied: trunk/tests/phpunit/tests/wp/addQueryVar.php (from rev 54642, trunk/tests/phpunit/tests/wp.php)</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/wp/addQueryVar.php (rev 0)
+++ trunk/tests/phpunit/tests/wp/addQueryVar.php 2022-10-28 14:08:20 UTC (rev 54710)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,31 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group wp
+ *
+ * @covers WP::add_query_var
+ */
+class Tests_WP_AddQueryVar extends WP_UnitTestCase {
+
+ /**
+ * @var WP
+ */
+ protected $wp;
+
+ public function set_up() {
+ parent::set_up();
+ $this->wp = new WP();
+ }
+
+ public function test_add_query_var() {
+ $public_qv_count = count( $this->wp->public_query_vars );
+
+ $this->wp->add_query_var( 'test' );
+ $this->wp->add_query_var( 'test2' );
+ $this->wp->add_query_var( 'test' );
+
+ $this->assertCount( $public_qv_count + 2, $this->wp->public_query_vars );
+ $this->assertContains( 'test', $this->wp->public_query_vars );
+ $this->assertContains( 'test2', $this->wp->public_query_vars );
+ }
+}
</ins></span></pre></div>
<a id="trunktestsphpunittestswpparseRequestphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/wp/parseRequest.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/wp/parseRequest.php 2022-10-27 17:35:45 UTC (rev 54709)
+++ trunk/tests/phpunit/tests/wp/parseRequest.php 2022-10-28 14:08:20 UTC (rev 54710)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2,9 +2,11 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group wp
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @covers WP::parse_request
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_WP_ParseRequest extends WP_UnitTestCase {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @var WP
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span></span></pre></div>
<a id="trunktestsphpunittestswpremoveQueryVarphpfromrev54642trunktestsphpunittestswpphp"></a>
<div class="copfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Copied: trunk/tests/phpunit/tests/wp/removeQueryVar.php (from rev 54642, trunk/tests/phpunit/tests/wp.php)</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/wp/removeQueryVar.php (rev 0)
+++ trunk/tests/phpunit/tests/wp/removeQueryVar.php 2022-10-28 14:08:20 UTC (rev 54710)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,29 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group wp
+ *
+ * @covers WP::remove_query_var
+ */
+class Tests_WP_RemoveQueryVar extends WP_UnitTestCase {
+
+ /**
+ * @var WP
+ */
+ protected $wp;
+
+ public function set_up() {
+ parent::set_up();
+ $this->wp = new WP();
+ }
+
+ public function test_remove_query_var() {
+ $public_qv_count = count( $this->wp->public_query_vars );
+
+ $this->wp->add_query_var( 'test' );
+ $this->assertContains( 'test', $this->wp->public_query_vars );
+ $this->wp->remove_query_var( 'test' );
+
+ $this->assertCount( $public_qv_count, $this->wp->public_query_vars );
+ }
+}
</ins></span></pre></div>
<a id="trunktestsphpunittestswpsendHeadersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/wp/sendHeaders.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/wp/sendHeaders.php 2022-10-27 17:35:45 UTC (rev 54709)
+++ trunk/tests/phpunit/tests/wp/sendHeaders.php 2022-10-28 14:08:20 UTC (rev 54710)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2,6 +2,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group wp
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @covers WP::send_headers
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_WP_SendHeaders extends WP_UnitTestCase {
</span></span></pre></div>
<a id="trunktestsphpunittestswpphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/tests/phpunit/tests/wp.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/wp.php 2022-10-27 17:35:45 UTC (rev 54709)
+++ trunk/tests/phpunit/tests/wp.php 2022-10-28 14:08:20 UTC (rev 54710)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,38 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-
-/**
- * @group wp
- */
-class Tests_WP extends WP_UnitTestCase {
- /**
- * @var WP
- */
- protected $wp;
-
- public function set_up() {
- parent::set_up();
- $this->wp = new WP();
- }
-
- public function test_add_query_var() {
- $public_qv_count = count( $this->wp->public_query_vars );
-
- $this->wp->add_query_var( 'test' );
- $this->wp->add_query_var( 'test2' );
- $this->wp->add_query_var( 'test' );
-
- $this->assertCount( $public_qv_count + 2, $this->wp->public_query_vars );
- $this->assertContains( 'test', $this->wp->public_query_vars );
- $this->assertContains( 'test2', $this->wp->public_query_vars );
- }
-
- public function test_remove_query_var() {
- $public_qv_count = count( $this->wp->public_query_vars );
-
- $this->wp->add_query_var( 'test' );
- $this->assertContains( 'test', $this->wp->public_query_vars );
- $this->wp->remove_query_var( 'test' );
-
- $this->assertCount( $public_qv_count, $this->wp->public_query_vars );
- }
-}
</del></span></pre>
</div>
</div>
</body>
</html>