<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54479] trunk/tests/phpunit/tests: Tests: Relocate the tests for recommended PHP, MySQL, and MariaDB versions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54479">54479</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54479","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-10-11 14:25:47 +0000 (Tue, 11 Oct 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Relocate the tests for recommended PHP, MySQL, and MariaDB versions.
This commit moves the tests for recommended versions of dependencies referenced in `readme.html` to a new location for better context. Also updates test class name for clarity, and `@covers` annotations to `@coversNothing`.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/26166">[26166]</a>, <a href="https://core.trac.wordpress.org/changeset/33946">[33946]</a>, <a href="https://core.trac.wordpress.org/changeset/35172">[35172]</a>, <a href="https://core.trac.wordpress.org/changeset/52418">[52418]</a>, <a href="https://core.trac.wordpress.org/changeset/52424">[52424]</a>.
Props ironprogrammer, bbobnis, antonvlasenko, azaozz, chaion07, priyomukul.
Fixes <a href="https://core.trac.wordpress.org/ticket/45867">#45867</a>.</pre>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsreadmephp">trunk/tests/phpunit/tests/readme.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li>trunk/tests/phpunit/tests/external-http/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsreadmephpfromrev54478trunktestsphpunittestsexternalhttpbasicphp"></a>
<div class="copfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Copied: trunk/tests/phpunit/tests/readme.php (from rev 54478, trunk/tests/phpunit/tests/external-http/basic.php)</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/readme.php (rev 0)
+++ trunk/tests/phpunit/tests/readme.php 2022-10-11 14:25:47 UTC (rev 54479)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,120 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+/**
+ * Validate recommended versions for dependencies referenced in `readme.html`,
+ * based on external site support pages.
+ *
+ * @group external-http
+ */
+class Tests_Readme extends WP_UnitTestCase {
+
+ /**
+ * @coversNothing
+ */
+ public function test_readme_php_version() {
+ $this->markTestSkipped(
+ 'Temporarily disabled. Test should be re-enabled once WordPress is fully compatible with PHP 8.0+.'
+ );
+
+ // This test is designed to only run on trunk.
+ $this->skipOnAutomatedBranches();
+
+ $readme = file_get_contents( ABSPATH . 'readme.html' );
+
+ preg_match( '#Recommendations.*PHP</a> version <strong>([0-9.]*)#s', $readme, $matches );
+
+ $response_body = $this->get_response_body( 'https://www.php.net/supported-versions.php' );
+
+ preg_match_all( '#<tr class="stable">\s*<td>\s*<a [^>]*>\s*([0-9.]*)#s', $response_body, $php_matches );
+
+ $this->assertContains( $matches[1], $php_matches[1], "readme.html's Recommended PHP version is too old. Remember to update the WordPress.org Requirements page, too." );
+ }
+
+ /**
+ * @coversNothing
+ */
+ public function test_readme_mysql_version() {
+ // This test is designed to only run on trunk.
+ $this->skipOnAutomatedBranches();
+
+ $readme = file_get_contents( ABSPATH . 'readme.html' );
+
+ preg_match( '#Recommendations.*MySQL</a> version <strong>([0-9.]*)#s', $readme, $matches );
+
+ $response_body = $this->get_response_body( "https://dev.mysql.com/doc/relnotes/mysql/{$matches[1]}/en/" );
+
+ // Retrieve the date of the first GA release for the recommended branch.
+ preg_match( '#.*(\d{4}-\d{2}-\d{2}), General Availability#s', $response_body, $mysql_matches );
+
+ /*
+ * Per https://www.mysql.com/support/, Oracle actively supports MySQL releases for 5 years from GA release.
+ *
+ * The currently recommended MySQL 5.7 branch moved from active support to extended support on 2020-10-21.
+ * As WordPress core is not fully compatible with MySQL 8.0 at this time, the "supported" period here
+ * is increased to 8 years to include extended support.
+ *
+ * TODO: Reduce this back to 5 years once MySQL 8.0 compatibility is achieved.
+ */
+ $mysql_eol = gmdate( 'Y-m-d', strtotime( $mysql_matches[1] . ' +8 years' ) );
+ $current_date = gmdate( 'Y-m-d' );
+
+ $this->assertLessThan( $mysql_eol, $current_date, "readme.html's Recommended MySQL version is too old. Remember to update the WordPress.org Requirements page, too." );
+ }
+
+ /**
+ * @coversNothing
+ */
+ public function test_readme_mariadb_version() {
+ // This test is designed to only run on trunk.
+ $this->skipOnAutomatedBranches();
+
+ $readme = file_get_contents( ABSPATH . 'readme.html' );
+
+ preg_match( '#Recommendations.*MariaDB</a> version <strong>([0-9.]*)#s', $readme, $matches );
+ $matches[1] = str_replace( '.', '', $matches[1] );
+
+ $response_body = $this->get_response_body( "https://mariadb.com/kb/en/release-notes-mariadb-{$matches[1]}-series/" );
+
+ // Retrieve the date of the first stable release for the recommended branch.
+ preg_match( '#.*Stable.*?(\d{2} [A-Za-z]{3} \d{4})#s', $response_body, $mariadb_matches );
+
+ // Per https://mariadb.org/about/#maintenance-policy, MariaDB releases are supported for 5 years.
+ $mariadb_eol = gmdate( 'Y-m-d', strtotime( $mariadb_matches[1] . ' +5 years' ) );
+ $current_date = gmdate( 'Y-m-d' );
+
+ $this->assertLessThan( $mariadb_eol, $current_date, "readme.html's Recommended MariaDB version is too old. Remember to update the WordPress.org Requirements page, too." );
+ }
+
+ /**
+ * Helper function to retrieve the response body or skip the test on HTTP timeout.
+ *
+ * @param string $url The URL to retrieve the response from.
+ * @return string The response body.
+ */
+ public function get_response_body( $url ) {
+ $response = wp_remote_get( $url );
+
+ $this->skipTestOnTimeout( $response );
+
+ $response_code = wp_remote_retrieve_response_code( $response );
+ $response_body = wp_remote_retrieve_body( $response );
+
+ if ( 200 !== $response_code ) {
+ $parsed_url = parse_url( $url );
+
+ $error_message = sprintf(
+ 'Could not contact %1$s to check versions. Response code: %2$s. Response body: %3$s',
+ $parsed_url['host'],
+ $response_code,
+ $response_body
+ );
+
+ if ( 503 === $response_code ) {
+ $this->markTestSkipped( $error_message );
+ }
+
+ $this->fail( $error_message );
+ }
+
+ return $response_body;
+ }
+}
</ins></span></pre>
</div>
</div>
</body>
</html>