<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54271] trunk: Posts, Post Types: Fix `WP_Query` parameter used by `get_page_by_title()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54271">54271</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54271","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>peterwilsoncc</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-09-21 05:27:12 +0000 (Wed, 21 Sep 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Posts, Post Types: Fix `WP_Query` parameter used by `get_page_by_title()`.
Fixes the call to `WP_Query` within `get_page_by_title()` by using the correct title parameter, `title`.
Modify the `orderby` parameter to prioritize the oldest published date over the smallest post ID. This ensures the behaviour matches that of the previous version of `get_page_by_title()`.
The tests have been modified to include a populated post table to ensure the posts returned are matched by design rather than coincidence.
Follow up to <a href="https://core.trac.wordpress.org/changeset/54234">[54234]</a>.
Props dd32, timothyblynjacobs, peterwilsoncc.
Fixes <a href="https://core.trac.wordpress.org/ticket/56609">#56609</a>.
See <a href="https://core.trac.wordpress.org/ticket/36905">#36905</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludespostphp">trunk/src/wp-includes/post.php</a></li>
<li><a href="#trunktestsphpunittestspostgetPageByTitlephp">trunk/tests/phpunit/tests/post/getPageByTitle.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post.php 2022-09-21 01:07:52 UTC (rev 54270)
+++ trunk/src/wp-includes/post.php 2022-09-21 05:27:12 UTC (rev 54271)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5775,7 +5775,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function get_page_by_title( $page_title, $output = OBJECT, $post_type = 'page' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $args = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'post_title' => $page_title,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'title' => $page_title,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'post_type' => $post_type,
</span><span class="cx" style="display: block; padding: 0 10px"> 'post_status' => get_post_stati(),
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 1,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5782,7 +5782,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_post_term_cache' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_post_meta_cache' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'no_found_rows' => true,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'orderby' => 'ID',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'orderby' => 'post_date ID',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'order' => 'ASC',
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $query = new WP_Query( $args );
</span></span></pre></div>
<a id="trunktestsphpunittestspostgetPageByTitlephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/post/getPageByTitle.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/getPageByTitle.php 2022-09-21 01:07:52 UTC (rev 54270)
+++ trunk/tests/phpunit/tests/post/getPageByTitle.php 2022-09-21 05:27:12 UTC (rev 54271)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,7 +5,42 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::get_page_by_title
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Post_GetPageByTitle extends WP_UnitTestCase {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Generate shared fixtures.
+ *
+ * These are not used in the tests but are rather used to populate the
+ * posts table and ensure that the tests return the correct post object
+ * by design rather than through chance.
+ */
+ public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+ // Fill the database with some pages.
+ $factory->post->create_many(
+ 2,
+ array(
+ 'post_type' => 'page',
+ )
+ );
+
+ // Fill the database with some attachments.
+ $factory->post->create_many(
+ 2,
+ array(
+ 'post_type' => 'attachment',
+ )
+ );
+
+ // Fill the database with some test post types.
+ register_post_type( 'wptests_pt' );
+ $factory->post->create_many(
+ 2,
+ array(
+ 'post_type' => 'wptests_pt',
+ )
+ );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 36905
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_page_by_title_priority() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,7 +80,54 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 36905
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 56609
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_should_be_case_insensitive_match() {
+ $page = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_title' => 'Foo',
+ )
+ );
+
+ $found = get_page_by_title( 'foo' );
+
+ $this->assertSame( $page, $found->ID );
+ }
+
+ /**
+ * Test the oldest published post is matched first.
+ *
+ * Per the docs: in case of more than one post having the same title,
+ * it will check the oldest publication date, not the smallest ID.
+ *
+ * @ticket 36905
+ * @ticket 56609
+ */
+ public function test_should_match_oldest_published_date_when_titles_match() {
+ self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_title' => 'foo',
+ )
+ );
+
+ $old_page = self::factory()->post->create(
+ array(
+ 'post_type' => 'page',
+ 'post_title' => 'foo',
+ 'post_date' => '1984-01-11 05:00:00',
+ )
+ );
+
+ $found = get_page_by_title( 'foo' );
+
+ $this->assertSame( $old_page, $found->ID );
+ }
+
+ /**
+ * @ticket 36905
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_inherit() {
</span><span class="cx" style="display: block; padding: 0 10px"> $page = self::factory()->post->create(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span></span></pre>
</div>
</div>
</body>
</html>