<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54223] trunk/src/wp-admin/includes/class-wp-list-table.php: Coding Standards: Move `WP_List_Table::get_views_links()` to a more appropriate place.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54223">54223</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54223","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-09-19 22:22:08 +0000 (Mon, 19 Sep 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Coding Standards: Move `WP_List_Table::get_views_links()` to a more appropriate place.
This moves the newly introduced `::get_views_links()` method to a more predictable location, next to the the `::get_views()` and `::views()` methods.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/54215">[54215]</a>.
See <a href="https://core.trac.wordpress.org/ticket/42066">#42066</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2022-09-19 22:13:21 UTC (rev 54222)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2022-09-19 22:22:08 UTC (rev 54223)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -377,6 +377,79 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Generates views links.
+ *
+ * @since 6.1.0
+ *
+ * @param array $link_data {
+ * An array of link data.
+ *
+ * @type string $url The link URL.
+ * @type string $label The link label.
+ * @type bool $current Optional. Whether this is the currently selected view.
+ * }
+ * @return array An array of link markup. Keys match the `$link_data` input array.
+ */
+ protected function get_views_links( $link_data = array() ) {
+ if ( ! is_array( $link_data ) ) {
+ _doing_it_wrong(
+ __METHOD__,
+ sprintf(
+ /* translators: %s: The $link_data argument. */
+ __( 'The %s argument must be an array.' ),
+ '<code>$link_data</code>'
+ ),
+ '6.1.0'
+ );
+
+ return array( '' );
+ }
+
+ $views_links = array();
+
+ foreach ( $link_data as $view => $link ) {
+ if ( empty( $link['url'] ) || ! is_string( $link['url'] ) || '' === trim( $link['url'] ) ) {
+ _doing_it_wrong(
+ __METHOD__,
+ sprintf(
+ /* translators: %1$s: The argument name. %2$s: The view name. */
+ __( 'The %1$s argument must be a non-empty string for %2$s.' ),
+ '<code>url</code>',
+ '<code>' . esc_html( $view ) . '</code>'
+ ),
+ '6.1.0'
+ );
+
+ continue;
+ }
+
+ if ( empty( $link['label'] ) || ! is_string( $link['label'] ) || '' === trim( $link['label'] ) ) {
+ _doing_it_wrong(
+ __METHOD__,
+ sprintf(
+ /* translators: %1$s: The argument name. %2$s: The view name. */
+ __( 'The %1$s argument must be a non-empty string for %2$s.' ),
+ '<code>label</code>',
+ '<code>' . esc_html( $view ) . '</code>'
+ ),
+ '6.1.0'
+ );
+
+ continue;
+ }
+
+ $views_links[ $view ] = sprintf(
+ '<a href="%s"%s>%s</a>',
+ esc_url( $link['url'] ),
+ isset( $link['current'] ) && true === $link['current'] ? ' class="current" aria-current="page"' : '',
+ $link['label']
+ );
+ }
+
+ return $views_links;
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Gets the list of views available on this table.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * The format is an associative array:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1514,78 +1587,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Generates views links.
- *
- * @since 6.1.0
- *
- * @param array $link_data {
- * An array of link data.
- *
- * @type string $url The link URL.
- * @type string $label The link label.
- * @type bool $current Optional. Whether this is the currently selected view.
- * }
- * @return array An array of link markup. Keys match the $link_data input array.
- */
- protected function get_views_links( $link_data = array() ) {
- if ( ! is_array( $link_data ) ) {
- _doing_it_wrong(
- __METHOD__,
- sprintf(
- /* translators: %s: The $link_data argument. */
- __( 'The %s argument must be an array.' ),
- '<code>$link_data</code>'
- ),
- '6.1.0'
- );
-
- return array( '' );
- }
-
- $views_links = array();
- foreach ( $link_data as $view => $link ) {
- if ( empty( $link['url'] ) || ! is_string( $link['url'] ) || '' === trim( $link['url'] ) ) {
- _doing_it_wrong(
- __METHOD__,
- sprintf(
- /* translators: %1$s: The argument name. %2$s: The view name. */
- __( 'The %1$s argument must be a non-empty string for %2$s.' ),
- '<code>url</code>',
- '<code>' . esc_html( $view ) . '</code>'
- ),
- '6.1.0'
- );
-
- continue;
- }
-
- if ( empty( $link['label'] ) || ! is_string( $link['label'] ) || '' === trim( $link['label'] ) ) {
- _doing_it_wrong(
- __METHOD__,
- sprintf(
- /* translators: %1$s: The argument name. %2$s: The view name. */
- __( 'The %1$s argument must be a non-empty string for %2$s.' ),
- '<code>label</code>',
- '<code>' . esc_html( $view ) . '</code>'
- ),
- '6.1.0'
- );
-
- continue;
- }
-
- $views_links[ $view ] = sprintf(
- '<a href="%s"%s>%s</a>',
- esc_url( $link['url'] ),
- isset( $link['current'] ) && true === $link['current'] ? ' class="current" aria-current="page"' : '',
- $link['label']
- );
- }
-
- return $views_links;
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * Sends required variables to JavaScript land.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.1.0
</span></span></pre>
</div>
</div>
</body>
</html>