<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[54128] trunk: Media: Add muted property for video elements.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/54128">54128</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/54128","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>antpb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-09-11 22:17:04 +0000 (Sun, 11 Sep 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Add muted property for video elements.
This change allows for the muted property to be used in video elements which solves for content that wishes to `autoPlay` when a page is viewed. Adding `muted` to video elements adhears to the requirements browsers have to honor `autoPlay` functionality.
Props prokium, peterwilsoncc, costdev, johnbillion, Benouare.
Fixes <a href="https://core.trac.wordpress.org/ticket/54788">#54788</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesmediaphp">trunk/src/wp-includes/media.php</a></li>
<li><a href="#trunktestsphpunittestsmediaphp">trunk/tests/phpunit/tests/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media.php 2022-09-11 22:00:16 UTC (rev 54127)
+++ trunk/src/wp-includes/media.php 2022-09-11 22:17:04 UTC (rev 54128)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3219,6 +3219,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $poster The 'poster' attribute for the `<video>` element. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $loop The 'loop' attribute for the `<video>` element. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $autoplay The 'autoplay' attribute for the `<video>` element. Default empty.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type string $muted The 'muted' attribute for the `<video>` element. Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type string $preload The 'preload' attribute for the `<video>` element.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default 'metadata'.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $class The 'class' attribute for the `<video>` element.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3263,6 +3264,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'poster' => '',
</span><span class="cx" style="display: block; padding: 0 10px"> 'loop' => '',
</span><span class="cx" style="display: block; padding: 0 10px"> 'autoplay' => '',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'muted' => 'false',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'preload' => 'metadata',
</span><span class="cx" style="display: block; padding: 0 10px"> 'width' => 640,
</span><span class="cx" style="display: block; padding: 0 10px"> 'height' => 360,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3390,11 +3392,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'poster' => esc_url( $atts['poster'] ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'loop' => wp_validate_boolean( $atts['loop'] ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'muted' => wp_validate_boolean( $atts['muted'] ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'preload' => $atts['preload'],
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // These ones should just be omitted altogether if they are blank.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( array( 'poster', 'loop', 'autoplay', 'preload' ) as $a ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( array( 'poster', 'loop', 'autoplay', 'preload', 'muted' ) as $a ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $html_atts[ $a ] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $html_atts[ $a ] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media.php 2022-09-11 22:00:16 UTC (rev 54127)
+++ trunk/tests/phpunit/tests/media.php 2022-09-11 22:17:04 UTC (rev 54128)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1023,6 +1023,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 35367
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 54788
</ins><span class="cx" style="display: block; padding: 0 10px"> * @depends test_video_shortcode_body
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_video_shortcode_attributes() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1035,6 +1036,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'src="https://example.com/foo.mp4', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringNotContainsString( 'loop', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringNotContainsString( 'autoplay', $actual );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertStringNotContainsString( 'muted', $actual );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'preload="metadata"', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'width="640"', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'height="360"', $actual );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1046,6 +1048,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'poster' => 'https://example.com/foo.png',
</span><span class="cx" style="display: block; padding: 0 10px"> 'loop' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'autoplay' => true,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'muted' => true,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'preload' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'width' => 123,
</span><span class="cx" style="display: block; padding: 0 10px"> 'height' => 456,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1057,6 +1060,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'poster="https://example.com/foo.png', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'loop="1"', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'autoplay="1"', $actual );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertStringContainsString( 'muted', $actual );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'preload="1"', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'width="123"', $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertStringContainsString( 'height="456"', $actual );
</span></span></pre>
</div>
</div>
</body>
</html>