<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[53904] trunk: Script Loader: Remove default DNS prefetch entry for s.w.org.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/53904">53904</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/53904","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>audrasjb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-08-18 08:43:19 +0000 (Thu, 18 Aug 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Script Loader: Remove default DNS prefetch entry for s.w.org.
A default DNS prefetch entry for s.w.org was previously included to save a few ms in case an emoji is used that is not supported by the browser. It appears this use case doesn't justify a prefetch to s.w.org on every WordPress website.
This changesets removes `emoji_svg_url` prefetch from `wp_resource_hints()`. It also updates unit tests in `Tests_General_wpResourceHints` by removing `test_should_have_defaults_on_frontend()` entirely and removing s.w.org prefetch from expected output of ten other test functions.
Plugin authors can use the `wp_resource_hints` filter if they need to re-add the DNS prefetch entry for s.w.org.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/37920">[37920]</a>, <a href="https://core.trac.wordpress.org/changeset/38122">[38122]</a>.
Props joelhardi, superpoincare, jhabdas, garrett-eclipse, sabernhardt, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/40426">#40426</a>.
See <a href="https://core.trac.wordpress.org/ticket/37387">#37387</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesgeneraltemplatephp">trunk/src/wp-includes/general-template.php</a></li>
<li><a href="#trunktestsphpunittestsgeneralwpResourceHintsphp">trunk/tests/phpunit/tests/general/wpResourceHints.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesgeneraltemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/general-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/general-template.php 2022-08-17 21:12:44 UTC (rev 53903)
+++ trunk/src/wp-includes/general-template.php 2022-08-18 08:43:19 UTC (rev 53904)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3317,13 +3317,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'prerender' => array(),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * Add DNS prefetch for the Emoji CDN.
- * The path is removed in the foreach loop below.
- */
- /** This filter is documented in wp-includes/formatting.php */
- $hints['dns-prefetch'][] = apply_filters( 'emoji_svg_url', 'https://s.w.org/images/core/emoji/13.0.0/svg/' );
-
</del><span class="cx" style="display: block; padding: 0 10px"> foreach ( $hints as $relation_type => $urls ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $unique_urls = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsgeneralwpResourceHintsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/general/wpResourceHints.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/general/wpResourceHints.php 2022-08-17 21:12:44 UTC (rev 53903)
+++ trunk/tests/phpunit/tests/general/wpResourceHints.php 2022-08-18 08:43:19 UTC (rev 53904)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -30,17 +30,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> parent::tear_down();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_should_have_defaults_on_frontend() {
- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n";
-
- $this->expectOutputString( $expected );
-
- wp_resource_hints();
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> public function test_dns_prefetching() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n" .
- "<link rel='dns-prefetch' href='//wordpress.org' />\n" .
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='dns-prefetch' href='//wordpress.org' />\n" .
</ins><span class="cx" style="display: block; padding: 0 10px"> "<link rel='dns-prefetch' href='//google.com' />\n" .
</span><span class="cx" style="display: block; padding: 0 10px"> "<link rel='dns-prefetch' href='//make.wordpress.org' />\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -70,8 +61,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 37652
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_preconnect() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n" .
- "<link rel='preconnect' href='//wordpress.org' />\n" .
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='preconnect' href='//wordpress.org' />\n" .
</ins><span class="cx" style="display: block; padding: 0 10px"> "<link rel='preconnect' href='https://make.wordpress.org' />\n" .
</span><span class="cx" style="display: block; padding: 0 10px"> "<link rel='preconnect' href='http://google.com' />\n" .
</span><span class="cx" style="display: block; padding: 0 10px"> "<link rel='preconnect' href='http://w.org' />\n";
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -98,8 +88,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_prerender() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n" .
- "<link rel='prerender' href='https://make.wordpress.org/great-again' />\n" .
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='prerender' href='https://make.wordpress.org/great-again' />\n" .
</ins><span class="cx" style="display: block; padding: 0 10px"> "<link rel='prerender' href='http://jobs.wordpress.net' />\n" .
</span><span class="cx" style="display: block; padding: 0 10px"> "<link rel='prerender' href='//core.trac.wordpress.org' />\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -124,8 +113,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_parse_url_dns_prefetch() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n" .
- "<link rel='dns-prefetch' href='//make.wordpress.org' />\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='dns-prefetch' href='//make.wordpress.org' />\n";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'wp_resource_hints', array( $this, 'add_dns_prefetch_long_urls' ), 10, 2 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -145,8 +133,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_dns_prefetch_styles() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//fonts.googleapis.com' />\n" .
- "<link rel='dns-prefetch' href='//s.w.org' />\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='dns-prefetch' href='//fonts.googleapis.com' />\n";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $args = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'family' => 'Open+Sans:400',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -164,8 +151,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_dns_prefetch_scripts() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//fonts.googleapis.com' />\n" .
- "<link rel='dns-prefetch' href='//s.w.org' />\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='dns-prefetch' href='//fonts.googleapis.com' />\n";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $args = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'family' => 'Open+Sans:400',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -185,7 +171,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 37385
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_dns_prefetch_scripts_does_not_include_registered_only() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '';
</ins><span class="cx" style="display: block; padding: 0 10px"> $unexpected = "<link rel='dns-prefetch' href='//wordpress.org' />\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_register_script( 'jquery-elsewhere', 'https://wordpress.org/wp-includes/js/jquery/jquery.js' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -202,7 +188,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 37502
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_deregistered_scripts_are_ignored() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'test-script', 'http://example.org/script.js' );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_deregister_script( 'test-script' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -215,7 +201,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 37652
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_malformed_urls() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Errant colon.
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'wp_resource_hints', array( $this, 'add_malformed_url_errant_colon' ), 10, 2 );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -250,8 +236,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 38121
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_custom_attributes() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<link rel='dns-prefetch' href='//s.w.org' />\n" .
- "<link rel='preconnect' href='https://make.wordpress.org' />\n" .
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<link rel='preconnect' href='https://make.wordpress.org' />\n" .
</ins><span class="cx" style="display: block; padding: 0 10px"> "<link crossorigin as='image' pr='0.5' href='https://example.com/foo.jpeg' rel='prefetch' />\n" .
</span><span class="cx" style="display: block; padding: 0 10px"> "<link crossorigin='use-credentials' as='style' href='https://example.com/foo.css' rel='prefetch' />\n" .
</span><span class="cx" style="display: block; padding: 0 10px"> "<link href='http://wordpress.org' rel='prerender' />\n";
</span></span></pre>
</div>
</div>
</body>
</html>