<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[53864] trunk/tests/phpunit/tests/import: Build/Test Tools: Add @covers tags to the import tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/53864">53864</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/53864","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-08-08 23:22:43 +0000 (Mon, 08 Aug 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Add @covers tags to the import tests.
Props pbearne, jrf, hellofromTonya, patopaiar, ironprogrammer, antonvlasenko, SergeyBiryukov, costdev.
See <a href="https://core.trac.wordpress.org/ticket/39265">#39265</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsimportimportphp">trunk/tests/phpunit/tests/import/import.php</a></li>
<li><a href="#trunktestsphpunittestsimportparserphp">trunk/tests/phpunit/tests/import/parser.php</a></li>
<li><a href="#trunktestsphpunittestsimportpostmetaphp">trunk/tests/phpunit/tests/import/postmeta.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsimportimportphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/import/import.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/import/import.php 2022-08-08 23:12:30 UTC (rev 53863)
+++ trunk/tests/phpunit/tests/import/import.php 2022-08-08 23:22:43 UTC (rev 53864)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -33,6 +33,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers WP_Import::import
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_small_import() {
</span><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -201,6 +204,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertCount( 1, $cats );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers WP_Import::import
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_double_import() {
</span><span class="cx" style="display: block; padding: 0 10px"> $authors = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'admin' => false,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -242,6 +248,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 1, $comment_count->total_comments );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::get_importers
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_ordering_of_importers() {
</span><span class="cx" style="display: block; padding: 0 10px"> global $wp_importers;
</span><span class="cx" style="display: block; padding: 0 10px"> $_wp_importers = $wp_importers; // Preserve global state.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -267,6 +276,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 21007
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers WP_Import::import
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_slashes_should_not_be_stripped() {
</span><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span></span></pre></div>
<a id="trunktestsphpunittestsimportparserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/import/parser.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/import/parser.php 2022-08-08 23:12:30 UTC (rev 53863)
+++ trunk/tests/phpunit/tests/import/parser.php 2022-08-08 23:22:43 UTC (rev 53864)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,6 +24,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> require_once DIR_TESTDATA . '/plugins/wordpress-importer/wordpress-importer.php';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers WXR_Parser_SimpleXML::parse
+ * @covers WXR_Parser_XML::parse
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_malformed_wxr() {
</span><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/malformed.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,6 +40,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers WXR_Parser_SimpleXML::parse
+ * @covers WXR_Parser_XML::parse
+ * @covers WXR_Parser_Regex::parse
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_invalid_wxr() {
</span><span class="cx" style="display: block; padding: 0 10px"> $f1 = DIR_TESTDATA . '/export/missing-version-tag.xml';
</span><span class="cx" style="display: block; padding: 0 10px"> $f2 = DIR_TESTDATA . '/export/invalid-version-tag.xml';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,6 +59,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers WXR_Parser_SimpleXML::parse
+ * @covers WXR_Parser_XML::parse
+ * @covers WXR_Parser_Regex::parse
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_wxr_version_1_1() {
</span><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/valid-wxr-1.1.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -143,6 +157,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers WXR_Parser_SimpleXML::parse
+ * @covers WXR_Parser_XML::parse
+ * @covers WXR_Parser_Regex::parse
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_wxr_version_1_0() {
</span><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/valid-wxr-1.0.xml';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -236,6 +255,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * sections that contain escaped closing tags ("]]>" -> "]]]]><![CDATA[>").
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @link https://core.trac.wordpress.org/ticket/15203
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers WXR_Parser_SimpleXML::parse
+ * @covers WXR_Parser_XML::parse
+ * @covers WXR_Parser_Regex::parse
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_escaped_cdata_closing_sequence() {
</span><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/crazy-cdata-escaped.xml';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -269,6 +292,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Ensure that the regex parser can still parse invalid CDATA blocks (i.e. those
</span><span class="cx" style="display: block; padding: 0 10px"> * with "]]>" unescaped within a CDATA section).
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers WXR_Parser_Regex::parse
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_unescaped_cdata_closing_sequence() {
</span><span class="cx" style="display: block; padding: 0 10px"> $file = DIR_TESTDATA . '/export/crazy-cdata.xml';
</span></span></pre></div>
<a id="trunktestsphpunittestsimportpostmetaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/import/postmeta.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/import/postmeta.php 2022-08-08 23:12:30 UTC (rev 53863)
+++ trunk/tests/phpunit/tests/import/postmeta.php 2022-08-08 23:22:43 UTC (rev 53864)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4,6 +4,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group import
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers WP_Import::import
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Import_Postmeta extends WP_Import_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px"> public function set_up() {
</span></span></pre>
</div>
</div>
</body>
</html>