<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[53682] trunk/tests/phpunit/tests: Build/Test Tools: Add @covers tags to the url test group.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/53682">53682</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/53682","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-07-07 22:43:37 +0000 (Thu, 07 Jul 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Add @covers tags to the url test group.
Props pbeane, hellofromTonya, ironprogrammer, antonvlasenko, SergeyBiryukov, costdev.
See <a href="https://core.trac.wordpress.org/ticket/39265">#39265</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsurlgetPrivacyPolicyUrlphp">trunk/tests/phpunit/tests/url/getPrivacyPolicyUrl.php</a></li>
<li><a href="#trunktestsphpunittestsurlphp">trunk/tests/phpunit/tests/url.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsurlgetPrivacyPolicyUrlphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/url/getPrivacyPolicyUrl.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/url/getPrivacyPolicyUrl.php 2022-07-07 22:20:18 UTC (rev 53681)
+++ trunk/tests/phpunit/tests/url/getPrivacyPolicyUrl.php 2022-07-07 22:43:37 UTC (rev 53682)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -12,9 +12,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @group url
</span><span class="cx" style="display: block; padding: 0 10px"> * @group privacy
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @covers ::get_privacy_policy_url
</del><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.9.6
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::get_privacy_policy_url
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Url_GetPrivacyPolicyUrl extends WP_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -56,6 +57,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * The function should return the privacy policy URL when `wp_page_for_privacy_policy` is set.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @uses ::get_permalink
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_privacy_policy_url_should_return_valid_url_when_policy_page_set() {
</span><span class="cx" style="display: block; padding: 0 10px"> $privacy_policy_url = get_permalink( self::$privacy_policy_page_id );
</span></span></pre></div>
<a id="trunktestsphpunittestsurlphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/url.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/url.php 2022-07-07 22:20:18 UTC (rev 53681)
+++ trunk/tests/phpunit/tests/url.php 2022-07-07 22:43:37 UTC (rev 53682)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -14,6 +14,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @dataProvider data_is_ssl
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::is_ssl
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_is_ssl( $value, $expected ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $_SERVER['HTTPS'] = $value;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -47,6 +49,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::is_ssl
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_is_ssl_by_port() {
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $_SERVER['HTTPS'] );
</span><span class="cx" style="display: block; padding: 0 10px"> $_SERVER['SERVER_PORT'] = '443';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -55,6 +60,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( $is_ssl );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::is_ssl
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_is_ssl_with_no_value() {
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $_SERVER['HTTPS'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -67,6 +75,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $url Test URL.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $expected Expected result.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::admin_url
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_admin_url( $url, $expected ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $siteurl_http = get_option( 'siteurl' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -135,6 +145,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $url Test URL.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $expected Expected result.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::home_url
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_home_url( $url, $expected ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $homeurl_http = get_option( 'home' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -198,6 +210,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::home_url
+ *
+ * @uses ::get_option
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_home_url_from_admin() {
</span><span class="cx" style="display: block; padding: 0 10px"> // Pretend to be in the site admin.
</span><span class="cx" style="display: block; padding: 0 10px"> set_current_screen( 'dashboard' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -243,6 +260,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> update_option( 'home', set_url_scheme( $home, 'http' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::network_home_url
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_network_home_url_from_admin() {
</span><span class="cx" style="display: block; padding: 0 10px"> // Pretend to be in the site admin.
</span><span class="cx" style="display: block; padding: 0 10px"> set_current_screen( 'dashboard' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -264,6 +284,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $home_https, network_home_url() );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::set_url_scheme
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_set_url_scheme() {
</span><span class="cx" style="display: block; padding: 0 10px"> $links = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'http://wordpress.org/',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -324,6 +347,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> force_ssl_admin( $forced_admin );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @covers ::get_adjacent_post
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_get_adjacent_post() {
</span><span class="cx" style="display: block; padding: 0 10px"> $now = time();
</span><span class="cx" style="display: block; padding: 0 10px"> $post_id = self::factory()->post->create( array( 'post_date' => gmdate( 'Y-m-d H:i:s', $now - 1 ) ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -358,6 +384,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Test get_adjacent_post returns the next private post when the author is the currently logged in user.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 30287
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::get_adjacent_post
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_adjacent_post_should_return_private_posts_belonging_to_the_current_user() {
</span><span class="cx" style="display: block; padding: 0 10px"> $u = self::factory()->user->create( array( 'role' => 'author' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -395,6 +423,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 30287
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::get_adjacent_post
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_adjacent_post_should_return_private_posts_belonging_to_other_users_if_the_current_user_can_read_private_posts() {
</span><span class="cx" style="display: block; padding: 0 10px"> $u1 = self::factory()->user->create( array( 'role' => 'author' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -433,6 +463,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 30287
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::get_adjacent_post
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_get_adjacent_post_should_not_return_private_posts_belonging_to_other_users_if_the_current_user_cannot_read_private_posts() {
</span><span class="cx" style="display: block; padding: 0 10px"> $u1 = self::factory()->user->create( array( 'role' => 'author' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -479,6 +511,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Test that *_url functions handle paths with ".."
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 19032
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @covers ::site_url
+ * @covers ::home_url
+ * @covers ::admin_url
+ * @covers ::network_admin_url
+ * @covers ::user_admin_url
+ * @covers ::includes_url
+ * @covers ::network_site_url
+ * @covers ::network_home_url
+ * @covers ::content_url
+ * @covers ::plugins_url
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_url_functions_for_dots_in_paths() {
</span><span class="cx" style="display: block; padding: 0 10px"> $functions = array(
</span></span></pre>
</div>
</div>
</body>
</html>