<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52984] trunk/tests/phpunit/tests/media/getPostGalleries.php: Docs: Adjust documentation in `get_post_galleries()` tests per the documentation standards.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/52984">52984</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/52984","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-03-23 15:01:48 +0000 (Wed, 23 Mar 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Docs: Adjust documentation in `get_post_galleries()` tests per the documentation standards.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/52190">[52190]</a>, <a href="https://core.trac.wordpress.org/changeset/52797">[52797]</a>.
Props azouamauriac, SergeyBiryukov.
See <a href="https://core.trac.wordpress.org/ticket/54725">#54725</a>, <a href="https://core.trac.wordpress.org/ticket/54729">#54729</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsmediagetPostGalleriesphp">trunk/tests/phpunit/tests/media/getPostGalleries.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsmediagetPostGalleriesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/media/getPostGalleries.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media/getPostGalleries.php 2022-03-23 14:48:28 UTC (rev 52983)
+++ trunk/tests/phpunit/tests/media/getPostGalleries.php 2022-03-23 15:01:48 UTC (rev 52984)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16,7 +16,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that an empty array is returned for a post that does not exist.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that an empty array is returned for a post that does not exist.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -26,7 +26,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that an empty array is returned for a post that has no gallery.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that an empty array is returned for a post that has no gallery.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,7 +42,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that only galleries are returned.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that only galleries are returned.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @dataProvider data_returns_only_galleries
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -118,7 +118,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that no srcs are returned for a shortcode gallery
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that no srcs are returned for a shortcode gallery
</ins><span class="cx" style="display: block; padding: 0 10px"> * in a post with no attached images.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 39304
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -150,8 +150,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -165,7 +167,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that no srcs are returned for a gallery block
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that no srcs are returned for a gallery block
</ins><span class="cx" style="display: block; padding: 0 10px"> * in a post with no attached images.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -197,15 +199,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of strings
- // instead of an array of arrays.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of strings
+ * instead of an array of arrays.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsArray(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'The returned data does not contain an array.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -219,7 +225,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that no srcs are returned for a gallery block v2
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that no srcs are returned for a gallery block v2
</ins><span class="cx" style="display: block; padding: 0 10px"> * in a post with no attached images.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -272,15 +278,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of strings
- // instead of an array of arrays.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of strings
+ * instead of an array of arrays.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsArray(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'The returned data does not contain an array.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -295,7 +305,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that HTML is returned for a shortcode gallery.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that HTML is returned for a shortcode gallery.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -332,8 +342,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of arrays
- // instead of an array of strings.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of arrays
+ * instead of an array of strings.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsString(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'Did not return the data as a string.'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -347,7 +359,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that HTML is returned for a block gallery.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that HTML is returned for a block gallery.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -393,8 +405,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of arrays
- // instead of an array of strings.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of arrays
+ * instead of an array of strings.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsString(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'Did not return the data as a string.'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -408,7 +422,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that HTML is returned for a block gallery v2.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that HTML is returned for a block gallery v2.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -459,8 +473,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of arrays
- // instead of an array of strings.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of arrays
+ * instead of an array of strings.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsString(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'Did not return the data as a string.'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -474,7 +490,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that the global post object does not override
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that the global post object does not override
</ins><span class="cx" style="display: block; padding: 0 10px"> * a provided post ID with a shortcode gallery.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 39304
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -515,8 +531,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -531,7 +549,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that the global post object does not override
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that the global post object does not override
</ins><span class="cx" style="display: block; padding: 0 10px"> * a provided post ID with a block gallery.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -601,8 +619,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -622,7 +642,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that the global post object does not override
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that the global post object does not override
</ins><span class="cx" style="display: block; padding: 0 10px"> * a provided post ID with a block gallery v2.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -694,8 +714,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -715,7 +737,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that the gallery only contains images specified in
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that the gallery only contains images specified in
</ins><span class="cx" style="display: block; padding: 0 10px"> * the shortcode's id attribute.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 39304
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -764,15 +786,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of strings
- // instead of an array of arrays.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of strings
+ * instead of an array of arrays.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsArray(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'The returned data does not contain an array.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -787,7 +813,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that galleries only contain images specified in the
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that galleries only contain images specified in the
</ins><span class="cx" style="display: block; padding: 0 10px"> * id attribute of their respective shortcode and block.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -796,7 +822,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group shortcode
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_respects_shortcode_and_block_id_attributes() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Test the get_post_galleries() function in $html=false mode, with both shortcode and block galleries
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * Test the get_post_galleries() function in `$html = false` mode,
+ * with both shortcode and block galleries.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $ids = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $imgs = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $ids_srcs = array();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -848,7 +877,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that galleries contain the additional attributes
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that galleries contain the additional attributes
</ins><span class="cx" style="display: block; padding: 0 10px"> * specified for their respective shortcode and block.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -857,7 +886,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group shortcode
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_respects_additional_shortcode_and_block_attributes() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Test attributes returned by get_post_galleries() function in $html=false mode, with both shortcode and block galleries
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * Test attributes returned by get_post_galleries() function in `$html = false` mode,
+ * with both shortcode and block galleries.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $ids = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $imgs = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $ids_srcs = array();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -895,7 +927,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'ids' => $ids1_joined,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The shortcode code passes arbitrary attributes
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // The shortcode code passes arbitrary attributes.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'type' => 'type',
</span><span class="cx" style="display: block; padding: 0 10px"> 'foo' => 'bar',
</span><span class="cx" style="display: block; padding: 0 10px"> 'src' => array_slice( $ids_srcs, 0, 3 ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -902,7 +934,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'ids' => $ids2_joined,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The block only passes ids, no other attributes
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // The block only passes ids, no other attributes.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'src' => array_slice( $ids_srcs, 3, 3 ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -912,7 +944,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that srcs are retrieved from the HTML of a block gallery
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that srcs are retrieved from the HTML of a block gallery
</ins><span class="cx" style="display: block; padding: 0 10px"> * that has no JSON blob.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -958,15 +990,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of strings
- // instead of an array of arrays.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of strings
+ * instead of an array of arrays.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsArray(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'The returned data does not contain an array.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -981,7 +1017,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test that srcs are returned for a block gallery nested within
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests that srcs are returned for a block gallery nested within
</ins><span class="cx" style="display: block; padding: 0 10px"> * other blocks.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43826
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1022,15 +1058,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'The galleries array is empty.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // The method can return an array of strings
- // instead of an array of arrays.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * The method can return an array of strings
+ * instead of an array of arrays.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertIsArray(
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span><span class="cx" style="display: block; padding: 0 10px"> 'The returned data does not contain an array.'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // This prevents future changes from causing
- // backwards compatibility breaks.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * This prevents future changes from causing
+ * backwards compatibility breaks.
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey(
</span><span class="cx" style="display: block; padding: 0 10px"> 'src',
</span><span class="cx" style="display: block; padding: 0 10px"> $galleries[0],
</span></span></pre>
</div>
</div>
</body>
</html>