<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52921] trunk: Taxonomy: Use `get_terms` instead of a database lookup in `term_exists()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/52921">52921</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/52921","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>spacedmonkey</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-03-11 11:05:02 +0000 (Fri, 11 Mar 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Taxonomy: Use `get_terms` instead of a database lookup in `term_exists()`.
Replace raw SQL queries to the terms table, with a call to the `get_terms` function. Using `get_terms` means that `term_exists` is now cached. For developers using `term_exists` where cache invalidation is disabled, such as importing, a workaround was added to ensure that queries are uncached.
Props Spacedmonkey, boonebgorges, flixos90, peterwilsoncc.
Fixes <a href="https://core.trac.wordpress.org/ticket/36949">#36949</a>. </pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludestaxonomyphp">trunk/src/wp-includes/taxonomy.php</a></li>
<li><a href="#trunktestsphpunitteststermgetTermphp">trunk/tests/phpunit/tests/term/getTerm.php</a></li>
<li><a href="#trunktestsphpunitteststermsplitSharedTermphp">trunk/tests/phpunit/tests/term/splitSharedTerm.php</a></li>
<li><a href="#trunktestsphpunitteststermtermExistsphp">trunk/tests/phpunit/tests/term/termExists.php</a></li>
<li><a href="#trunktestsphpunitteststermwpGetObjectTermsphp">trunk/tests/phpunit/tests/term/wpGetObjectTerms.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludestaxonomyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/taxonomy.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/taxonomy.php 2022-03-11 02:31:20 UTC (rev 52920)
+++ trunk/src/wp-includes/taxonomy.php 2022-03-11 11:05:02 UTC (rev 52921)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1519,8 +1519,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Conditional Tags} article in the Theme Developer Handbook.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 6.0.0 Converted to use `get_terms()`.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @global wpdb $wpdb WordPress database abstraction object.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @global bool $_wp_suspend_cache_invalidation
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int|string $term The term to check. Accepts term ID, slug, or name.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $taxonomy Optional. The taxonomy name to use.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1531,65 +1532,71 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Returns 0 if term ID 0 is passed to the function.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function term_exists( $term, $taxonomy = '', $parent = null ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- global $wpdb;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ global $_wp_suspend_cache_invalidation;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( null === $term ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return null;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $select = "SELECT term_id FROM $wpdb->terms as t WHERE ";
- $tax_select = "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE ";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $defaults = array(
+ 'get' => 'all',
+ 'fields' => 'ids',
+ 'number' => 1,
+ 'update_term_meta_cache' => false,
+ 'order' => 'ASC',
+ 'orderby' => 'term_id',
+ 'suppress_filter' => true,
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Ensure that while importing, queries are not cached.
+ if ( ! empty( $_wp_suspend_cache_invalidation ) ) {
+ // @todo Disable caching once #52710 is merged.
+ $defaults['cache_domain'] = microtime();
+ }
+
+ if ( ! empty( $taxonomy ) ) {
+ $defaults['taxonomy'] = $taxonomy;
+ $defaults['fields'] = 'all';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( is_int( $term ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 0 === $term ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $where = 't.term_id = %d';
- if ( ! empty( $taxonomy ) ) {
- // phpcs:ignore WordPress.DB.PreparedSQLPlaceholders.ReplacementsWrongNumber
- return $wpdb->get_row( $wpdb->prepare( $tax_select . $where . ' AND tt.taxonomy = %s', $term, $taxonomy ), ARRAY_A );
- } else {
- return $wpdb->get_var( $wpdb->prepare( $select . $where, $term ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = wp_parse_args( array( 'include' => array( $term ) ), $defaults );
+ $terms = get_terms( $args );
+ } else {
+ $term = trim( wp_unslash( $term ) );
+ if ( '' === $term ) {
+ return null;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- }
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $term = trim( wp_unslash( $term ) );
- $slug = sanitize_title( $term );
-
- $where = 't.slug = %s';
- $else_where = 't.name = %s';
- $where_fields = array( $slug );
- $else_where_fields = array( $term );
- $orderby = 'ORDER BY t.term_id ASC';
- $limit = 'LIMIT 1';
- if ( ! empty( $taxonomy ) ) {
- if ( is_numeric( $parent ) ) {
- $parent = (int) $parent;
- $where_fields[] = $parent;
- $else_where_fields[] = $parent;
- $where .= ' AND tt.parent = %d';
- $else_where .= ' AND tt.parent = %d';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! empty( $taxonomy ) && is_numeric( $parent ) ) {
+ $defaults['parent'] = (int) $parent;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $where_fields[] = $taxonomy;
- $else_where_fields[] = $taxonomy;
-
- $result = $wpdb->get_row( $wpdb->prepare( "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE $where AND tt.taxonomy = %s $orderby $limit", $where_fields ), ARRAY_A );
- if ( $result ) {
- return $result;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = wp_parse_args( array( 'slug' => sanitize_title( $term ) ), $defaults );
+ $terms = get_terms( $args );
+ if ( empty( $terms ) || is_wp_error( $terms ) ) {
+ $args = wp_parse_args( array( 'name' => $term ), $defaults );
+ $terms = get_terms( $args );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return $wpdb->get_row( $wpdb->prepare( "SELECT tt.term_id, tt.term_taxonomy_id FROM $wpdb->terms AS t INNER JOIN $wpdb->term_taxonomy as tt ON tt.term_id = t.term_id WHERE $else_where AND tt.taxonomy = %s $orderby $limit", $else_where_fields ), ARRAY_A );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( empty( $terms ) || is_wp_error( $terms ) ) {
+ return null;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // phpcs:ignore WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
- $result = $wpdb->get_var( $wpdb->prepare( "SELECT term_id FROM $wpdb->terms as t WHERE $where $orderby $limit", $where_fields ) );
- if ( $result ) {
- return $result;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $_term = array_shift( $terms );
+
+ if ( ! empty( $taxonomy ) ) {
+ return array(
+ 'term_id' => (string) $_term->term_id,
+ 'term_taxonomy_id' => (string) $_term->term_taxonomy_id,
+ );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // phpcs:ignore WordPress.DB.PreparedSQLPlaceholders.UnfinishedPrepare
- return $wpdb->get_var( $wpdb->prepare( "SELECT term_id FROM $wpdb->terms as t WHERE $else_where $orderby $limit", $else_where_fields ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return (string) $_term;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunitteststermgetTermphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/term/getTerm.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/term/getTerm.php 2022-03-11 02:31:20 UTC (rev 52920)
+++ trunk/tests/phpunit/tests/term/getTerm.php 2022-03-11 11:05:02 UTC (rev 52921)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -31,6 +31,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $t1['term_id'] );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> return array(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'term_id' => $t1['term_id'],
</span></span></pre></div>
<a id="trunktestsphpunitteststermsplitSharedTermphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/term/splitSharedTerm.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/term/splitSharedTerm.php 2022-03-11 02:31:20 UTC (rev 52920)
+++ trunk/tests/phpunit/tests/term/splitSharedTerm.php 2022-03-11 11:05:02 UTC (rev 52921)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -54,6 +54,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $t1['term_id'], 'category' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $t2_child = wp_insert_term(
</span><span class="cx" style="display: block; padding: 0 10px"> 'Foo Child',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -151,6 +152,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $t1['term_id'], 'category' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $th = _get_term_hierarchy( 'wptests_tax_4' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $new_term_id = _split_shared_term( $t1['term_id'], $t3['term_taxonomy_id'] );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -179,6 +181,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $t1['term_id'], 'category' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $t1['term_id'], get_option( 'default_category', -1 ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -207,6 +210,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( '%d' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $t1['term_id'], 'category' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $menu_id = wp_create_nav_menu( 'Nav Menu Bar' );
</span><span class="cx" style="display: block; padding: 0 10px"> $cat_menu_item = wp_update_nav_menu_item(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -245,6 +249,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'term_id' => $shared_term_id ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'term_taxonomy_id' => $nav_term->term_taxonomy_id )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $shared_term_id, 'category' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> set_theme_mod( 'nav_menu_locations', array( 'foo' => $shared_term_id ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -274,6 +279,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'term_id' => $shared_term_id ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'term_taxonomy_id' => $nav_term->term_taxonomy_id )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( $shared_term_id, 'category' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $t1 = wp_insert_term( 'Random term', 'category' );
</span><span class="cx" style="display: block; padding: 0 10px"> $cat_menu_item = wp_update_nav_menu_item(
</span></span></pre></div>
<a id="trunktestsphpunitteststermtermExistsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/term/termExists.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/term/termExists.php 2022-03-11 02:31:20 UTC (rev 52920)
+++ trunk/tests/phpunit/tests/term/termExists.php 2022-03-11 11:05:02 UTC (rev 52921)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -271,6 +271,132 @@
</span><span class="cx" style="display: block; padding: 0 10px"> _unregister_taxonomy( 'wptests_tax' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 36949
+ * @covers ::term_exists()
+ */
+ public function test_term_lookup_by_id_and_update() {
+ register_taxonomy( 'wptests_tax', 'post' );
+
+ $slug = __FUNCTION__;
+ $t = self::factory()->term->create(
+ array(
+ 'slug' => $slug,
+ 'taxonomy' => 'wptests_tax',
+ )
+ );
+ $this->assertEquals( $t, term_exists( $t ) );
+ $this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
+ $this->assertNull( term_exists( $t ) );
+
+ // Clean up.
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ /**
+ * @ticket 36949
+ * @covers ::term_exists()
+ */
+ public function test_term_lookup_by_slug_and_update() {
+ register_taxonomy( 'wptests_tax', 'post' );
+
+ $slug = __FUNCTION__;
+ $t = self::factory()->term->create(
+ array(
+ 'slug' => $slug,
+ 'taxonomy' => 'wptests_tax',
+ )
+ );
+ $this->assertEquals( $t, term_exists( $slug ) );
+ $this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
+ $this->assertNull( term_exists( $slug ) );
+
+ // Clean up.
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ /**
+ * @ticket 36949
+ * @covers ::term_exists()
+ */
+ public function test_term_exists_caching() {
+ global $wpdb;
+ register_taxonomy( 'wptests_tax', 'post' );
+
+ $slug = __FUNCTION__;
+ $t = self::factory()->term->create(
+ array(
+ 'slug' => $slug,
+ 'taxonomy' => 'wptests_tax',
+ )
+ );
+ $this->assertEquals( $t, term_exists( $slug ) );
+ $num_queries = $wpdb->num_queries;
+ $this->assertEquals( $t, term_exists( $slug ) );
+ $this->assertSame( $num_queries, $wpdb->num_queries );
+
+ $this->assertTrue( wp_delete_term( $t, 'wptests_tax' ) );
+ $num_queries = $wpdb->num_queries;
+ $this->assertNull( term_exists( $slug ) );
+ $this->assertSame( $num_queries + 2, $wpdb->num_queries );
+
+ // Clean up.
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ /**
+ * @ticket 36949
+ * @covers ::term_exists()
+ */
+ public function test_term_exists_caching_suspend_cache_invalidation() {
+ global $wpdb;
+ register_taxonomy( 'wptests_tax', 'post' );
+
+ wp_suspend_cache_invalidation( true );
+ $slug = __FUNCTION__;
+ $t = self::factory()->term->create(
+ array(
+ 'slug' => $slug,
+ 'taxonomy' => 'wptests_tax',
+ )
+ );
+
+ $this->assertEquals( $t, term_exists( $slug ) );
+ $num_queries = $wpdb->num_queries;
+ $this->assertEquals( $t, term_exists( $slug ) );
+ $this->assertSame( $num_queries + 1, $wpdb->num_queries );
+ wp_suspend_cache_invalidation( false );
+
+ // Clean up.
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ /**
+ * @ticket 36949
+ * @covers ::term_exists()
+ */
+ public function test_term_exists_caching_by_int_suspend_cache_invalidation() {
+ register_taxonomy( 'wptests_tax', 'post' );
+
+ $slug = __FUNCTION__;
+ $t = self::factory()->term->create(
+ array(
+ 'slug' => $slug,
+ 'taxonomy' => 'wptests_tax',
+ )
+ );
+
+ // Warm cache in get_term() via term_exists().
+ term_exists( $t );
+ wp_suspend_cache_invalidation( true );
+ wp_delete_term( $t, 'wptests_tax' );
+ $this->assertNull( term_exists( $t ) );
+
+ // Reneable cache invalidation.
+ wp_suspend_cache_invalidation( false );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_term_exists_unknown() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertNull( term_exists( rand_str() ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 0, term_exists( 0 ) );
</span></span></pre></div>
<a id="trunktestsphpunitteststermwpGetObjectTermsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/term/wpGetObjectTerms.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/term/wpGetObjectTerms.php 2022-03-11 02:31:20 UTC (rev 52920)
+++ trunk/tests/phpunit/tests/term/wpGetObjectTerms.php 2022-03-11 11:05:02 UTC (rev 52921)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -447,6 +447,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $wpdb->update( $wpdb->term_taxonomy, array( 'term_taxonomy_id' => 100006 ), array( 'term_taxonomy_id' => $term_2->term_taxonomy_id ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $wpdb->update( $wpdb->term_taxonomy, array( 'term_taxonomy_id' => 100005 ), array( 'term_taxonomy_id' => $term_3->term_taxonomy_id ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clean_term_cache( array( $t1, $t2, $t3 ), $this->taxonomy );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $set = wp_set_object_terms( $p, array( $t1, $t2, $t3 ), $this->taxonomy );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $found = wp_get_object_terms(
</span></span></pre>
</div>
</div>
</body>
</html>