<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52228] trunk/src/js/_enqueues/admin/post.js: Coding Standards: Wrap some long lines in `js/_enqueues/admin/post.js` per the JS coding standards for better readability.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/52228">52228</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/52228","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-11-20 02:48:08 +0000 (Sat, 20 Nov 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Coding Standards: Wrap some long lines in `js/_enqueues/admin/post.js` per the JS coding standards for better readability.
See <a href="https://core.trac.wordpress.org/ticket/53359">#53359</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminpostjs">trunk/src/js/_enqueues/admin/post.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminpostjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/post.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/post.js 2021-11-20 02:21:15 UTC (rev 52227)
+++ trunk/src/js/_enqueues/admin/post.js 2021-11-20 02:48:08 UTC (rev 52228)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -135,9 +135,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @global
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> window.WPRemoveThumbnail = function(nonce){
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $.post(ajaxurl, {
- action: 'set-post-thumbnail', post_id: $( '#post_ID' ).val(), thumbnail_id: -1, _ajax_nonce: nonce, cookie: encodeURIComponent( document.cookie )
- },
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $.post(
+ ajaxurl, {
+ action: 'set-post-thumbnail',
+ post_id: $( '#post_ID' ).val(),
+ thumbnail_id: -1,
+ _ajax_nonce: nonce,
+ cookie: encodeURIComponent( document.cookie )
+ },
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Handle server response
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -144,12 +149,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {string} str Response, will be '0' when an error occurred otherwise contains link to add Featured Image.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function(str){
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( str == '0' ) {
- alert( __( 'Could not set that as the thumbnail image. Try a different attachment.' ) );
- } else {
- WPSetThumbnailHTML(str);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( str == '0' ) {
+ alert( __( 'Could not set that as the thumbnail image. Try a different attachment.' ) );
+ } else {
+ WPSetThumbnailHTML(str);
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- }
</del><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -207,7 +212,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> height: 64,
</span><span class="cx" style="display: block; padding: 0 10px"> alt: '',
</span><span class="cx" style="display: block; padding: 0 10px"> src: received.lock_error.avatar_src,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- srcset: received.lock_error.avatar_src_2x ? received.lock_error.avatar_src_2x + ' 2x' : undefined
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ srcset: received.lock_error.avatar_src_2x ?
+ received.lock_error.avatar_src_2x + ' 2x' :
+ undefined
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> wrap.find('div.post-locked-avatar').empty().append( avatar );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -666,11 +673,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Sync checked items between "All {taxonomy}" and "Most used" lists.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#' + taxonomy + 'checklist, #' + taxonomy + 'checklist-pop').on( 'click', 'li.popular-category > label input[type="checkbox"]', function() {
- var t = $(this), c = t.is(':checked'), id = t.val();
- if ( id && t.parents('#taxonomy-'+taxonomy).length )
- $('#in-' + taxonomy + '-' + id + ', #in-popular-' + taxonomy + '-' + id).prop( 'checked', c );
- });
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('#' + taxonomy + 'checklist, #' + taxonomy + 'checklist-pop').on(
+ 'click',
+ 'li.popular-category > label input[type="checkbox"]',
+ function() {
+ var t = $(this), c = t.is(':checked'), id = t.val();
+ if ( id && t.parents('#taxonomy-'+taxonomy).length )
+ $('#in-' + taxonomy + '-' + id + ', #in-popular-' + taxonomy + '-' + id).prop( 'checked', c );
+ }
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }); // End cats.
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -749,11 +760,28 @@
</span><span class="cx" style="display: block; padding: 0 10px"> mm = $('#mm').val(), jj = $('#jj').val(), hh = $('#hh').val(), mn = $('#mn').val();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> attemptedDate = new Date( aa, mm - 1, jj, hh, mn );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- originalDate = new Date( $('#hidden_aa').val(), $('#hidden_mm').val() -1, $('#hidden_jj').val(), $('#hidden_hh').val(), $('#hidden_mn').val() );
- currentDate = new Date( $('#cur_aa').val(), $('#cur_mm').val() -1, $('#cur_jj').val(), $('#cur_hh').val(), $('#cur_mn').val() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ originalDate = new Date(
+ $('#hidden_aa').val(),
+ $('#hidden_mm').val() -1,
+ $('#hidden_jj').val(),
+ $('#hidden_hh').val(),
+ $('#hidden_mn').val()
+ );
+ currentDate = new Date(
+ $('#cur_aa').val(),
+ $('#cur_mm').val() -1,
+ $('#cur_jj').val(),
+ $('#cur_hh').val(),
+ $('#cur_mn').val()
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Catch unexpected date problems.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( attemptedDate.getFullYear() != aa || (1 + attemptedDate.getMonth()) != mm || attemptedDate.getDate() != jj || attemptedDate.getMinutes() != mn ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if (
+ attemptedDate.getFullYear() != aa ||
+ (1 + attemptedDate.getMonth()) != mm ||
+ attemptedDate.getDate() != jj ||
+ attemptedDate.getMinutes() != mn
+ ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $timestampdiv.find('.timestamp-wrap').addClass('form-invalid');
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -820,7 +848,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Show or hide the "Save Draft" button.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $('option:selected', postStatus).val() == 'private' || $('option:selected', postStatus).val() == 'publish' ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if (
+ $('option:selected', postStatus).val() == 'private' ||
+ $('option:selected', postStatus).val() == 'publish'
+ ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#save-post').hide();
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $('#save-post').show();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -994,7 +1025,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $el = $( '#editable-post-name' );
</span><span class="cx" style="display: block; padding: 0 10px"> revert_e = $el.html();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- buttons.html( '<button type="button" class="save button button-small">' + __( 'OK' ) + '</button> <button type="button" class="cancel button-link">' + __( 'Cancel' ) + '</button>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ buttons.html(
+ '<button type="button" class="save button button-small">' + __( 'OK' ) + '</button> ' +
+ '<button type="button" class="cancel button-link">' + __( 'Cancel' ) + '</button>'
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Save permalink changes.
</span><span class="cx" style="display: block; padding: 0 10px"> buttons.children( '.save' ).on( 'click', function() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1050,7 +1084,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> slug_value = ( c > full.length / 4 ) ? '' : full;
</span><span class="cx" style="display: block; padding: 0 10px"> slug_label = __( 'URL Slug' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $el.html( '<label for="new-post-slug" class="screen-reader-text">' + slug_label + '</label><input type="text" id="new-post-slug" value="' + slug_value + '" autocomplete="off" spellcheck="false" />' ).children( 'input' ).on( 'keydown', function( e ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $el.html(
+ '<label for="new-post-slug" class="screen-reader-text">' + slug_label + '</label>' +
+ '<input type="text" id="new-post-slug" value="' + slug_value + '" autocomplete="off" spellcheck="false" />'
+ ).children( 'input' ).on( 'keydown', function( e ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> var key = e.which;
</span><span class="cx" style="display: block; padding: 0 10px"> // On [Enter], just save the new slug, don't save the post.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 13 === key ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1224,7 +1261,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $textarea.on( 'keydown.wp-autosave', function( event ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Key [S] has code 83.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( event.which === 83 ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( event.shiftKey || event.altKey || ( isMac && ( ! event.metaKey || event.ctrlKey ) ) || ( ! isMac && ! event.ctrlKey ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if (
+ event.shiftKey ||
+ event.altKey ||
+ ( isMac && ( ! event.metaKey || event.ctrlKey ) ) ||
+ ( ! isMac && ! event.ctrlKey )
+ ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>