<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[52166] trunk: Menus: Add audible notice on menu item add or remove.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/52166">52166</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/52166","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-11-15 19:58:04 +0000 (Mon, 15 Nov 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Menus: Add audible notice on menu item add or remove.
Call `wp.a11y.speak()` to add audible notification when a menu item is added or removed from a menu.
Props joedolson, costdev, hellofromTonya.
Fixes <a href="https://core.trac.wordpress.org/ticket/53840">#53840</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueueslibnavmenujs">trunk/src/js/_enqueues/lib/nav-menu.js</a></li>
<li><a href="#trunksrcwpadminnavmenusphp">trunk/src/wp-admin/nav-menus.php</a></li>
<li><a href="#trunktestsqunitwpadminjsnavmenujs">trunk/tests/qunit/wp-admin/js/nav-menu.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueueslibnavmenujs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/lib/nav-menu.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/lib/nav-menu.js 2021-11-15 19:57:28 UTC (rev 52165)
+++ trunk/src/js/_enqueues/lib/nav-menu.js 2021-11-15 19:58:04 UTC (rev 52166)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -311,7 +311,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> nextItemDepth = parseInt( nextItem.menuItemDepth(), 10 ) + 1,
</span><span class="cx" style="display: block; padding: 0 10px"> prevItem = thisItem.prev(),
</span><span class="cx" style="display: block; padding: 0 10px"> prevItemDepth = parseInt( prevItem.menuItemDepth(), 10 ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- prevItemId = prevItem.getItemData()['menu-item-db-id'];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ prevItemId = prevItem.getItemData()['menu-item-db-id'],
+ a11ySpeech = menus[ 'moved' + dir.charAt(0).toUpperCase() + dir.slice(1) ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> switch ( dir ) {
</span><span class="cx" style="display: block; padding: 0 10px"> case 'up':
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -399,6 +400,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> api.registerChange();
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshKeyboardAccessibility();
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshAdvancedAccessibility();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ if ( a11ySpeech ) {
+ wp.a11y.speak( a11ySpeech );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> initAccessibility : function() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1224,6 +1229,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $menuMarkup.hideAdvancedMenuItemFields().appendTo( api.targetList );
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshKeyboardAccessibility();
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshAdvancedAccessibility();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ wp.a11y.speak( menus.itemAdded );
</ins><span class="cx" style="display: block; padding: 0 10px"> $( document ).trigger( 'menu-item-added', [ $menuMarkup ] );
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1239,6 +1245,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $menuMarkup.hideAdvancedMenuItemFields().prependTo( api.targetList );
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshKeyboardAccessibility();
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshAdvancedAccessibility();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ wp.a11y.speak( menus.itemAdded );
</ins><span class="cx" style="display: block; padding: 0 10px"> $( document ).trigger( 'menu-item-added', [ $menuMarkup ] );
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1513,6 +1520,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ins.removeClass( 'menu-instructions-inactive' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> api.refreshAdvancedAccessibility();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ wp.a11y.speak( menus.itemRemoved );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminnavmenusphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/nav-menus.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/nav-menus.php 2021-11-15 19:57:28 UTC (rev 52165)
+++ trunk/src/wp-admin/nav-menus.php 2021-11-15 19:58:04 UTC (rev 52166)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -499,6 +499,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'menuItemDeletion' => __( 'item %s' ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Item name. */
</span><span class="cx" style="display: block; padding: 0 10px"> 'itemsDeleted' => __( 'Deleted menu item: %s.' ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'itemAdded' => __( 'Menu item added' ),
+ 'itemRemoved' => __( 'Menu item removed' ),
+ 'movedUp' => __( 'Menu item moved up' ),
+ 'movedDown' => __( 'Menu item moved down' ),
+ 'movedTop' => __( 'Menu item moved to the top' ),
+ 'movedLeft' => __( 'Menu item moved out of submenu' ),
+ 'movedRight' => __( 'Menu item is now a sub-item' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_localize_script( 'nav-menu', 'menus', $nav_menus_l10n );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsqunitwpadminjsnavmenujs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/qunit/wp-admin/js/nav-menu.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/qunit/wp-admin/js/nav-menu.js 2021-11-15 19:57:28 UTC (rev 52165)
+++ trunk/tests/qunit/wp-admin/js/nav-menu.js 2021-11-15 19:58:04 UTC (rev 52166)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -23,6 +23,20 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> var testString = '<div>Hello World</div>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Mock global menus.
+ if ( ! window.hasOwnProperty( 'menus' ) ) {
+ window.menus = {
+ 'itemAdded': false,
+ 'itemDeleted': false
+ };
+ }
+
+ // Mock global wp.a11y.
+ window.wp = window.wp || {};
+ window.wp.a11y = {
+ 'speak': function() {}
+ };
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Mock the internal function calls so the don't fail.
</span><span class="cx" style="display: block; padding: 0 10px"> $.fn.hideAdvancedMenuItemFields = function() {
</span><span class="cx" style="display: block; padding: 0 10px"> return {
</span></span></pre>
</div>
</div>
</body>
</html>