<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[51934] trunk/.github/workflows/slack-notifications.yml: Build/Test Tools: Restore Slack notifications for older branches.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/51934">51934</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/51934","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-10-25 19:28:04 +0000 (Mon, 25 Oct 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Restore Slack notifications for older branches.
In <a href="https://core.trac.wordpress.org/changeset/51921">[51921]</a>, the GitHub Actions workflows were updated to utilize the Slack notifications workflow as a callable one instead of on the `workflow_run` event.
This eliminated the need for an additional {U+201C}Slack Notifications{U+201D} workflow run for every completed workflow, but only when other workflows are updated as well. This resulted in notifications from older branches breaking, as the changes in <a href="https://core.trac.wordpress.org/changeset/51921">[51921]</a> were not backported.
Instead of backporting the needed changes now (the Slack workflow is still being polished), this commit partially restores the `workflow_run` event for older branches so that notifications will resume.
See <a href="https://core.trac.wordpress.org/ticket/53363">#53363</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowsslacknotificationsyml">trunk/.github/workflows/slack-notifications.yml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowsslacknotificationsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/slack-notifications.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/slack-notifications.yml 2021-10-25 19:16:32 UTC (rev 51933)
+++ trunk/.github/workflows/slack-notifications.yml 2021-10-25 19:28:04 UTC (rev 51934)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,6 +6,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: Slack Notifications
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> on:
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ workflow_run:
+ workflows:
+ - Code Coverage Report
+ - Coding Standards
+ - End-to-end Tests
+ - JavaScript Tests
+ - PHP Compatibility
+ - PHPUnit Tests
+ - Test NPM
+ - Test old branches
+ types:
+ - completed
+ branches:
+ - '[3-4].[0-9]'
+ - '5.[0-8]'
+
</ins><span class="cx" style="display: block; padding: 0 10px"> workflow_call:
</span><span class="cx" style="display: block; padding: 0 10px"> secrets:
</span><span class="cx" style="display: block; padding: 0 10px"> SLACK_GHA_SUCCESS_WEBHOOK:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,6 +37,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> description: 'The Slack webhook URL for a failed build.'
</span><span class="cx" style="display: block; padding: 0 10px"> required: true
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+env:
+ CURRENT_BRANCH: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_branch || github.ref_name }}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> jobs:
</span><span class="cx" style="display: block; padding: 0 10px"> # Gathers the details needed for Slack notifications.
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -28,8 +47,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # submit data to Slack webhook URLs configured to post messages.
</span><span class="cx" style="display: block; padding: 0 10px"> #
</span><span class="cx" style="display: block; padding: 0 10px"> # Performs the following steps:
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Retrieves the workflow ID (if necessary).
+ # - Retrieves the workflow URL (if necessary).
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Retrieves the previous workflow run and stores its conclusion.
</span><span class="cx" style="display: block; padding: 0 10px"> # - Sets the previous conclusion as an output.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ # - Prepares the commit message.
</ins><span class="cx" style="display: block; padding: 0 10px"> # - Constructs and stores a message payload as an output.
</span><span class="cx" style="display: block; padding: 0 10px"> prepare:
</span><span class="cx" style="display: block; padding: 0 10px"> name: Prepare notifications
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,6 +64,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Get the workflow ID
</span><span class="cx" style="display: block; padding: 0 10px"> id: current-workflow-id
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ github.event_name == 'push' }}
</ins><span class="cx" style="display: block; padding: 0 10px"> uses: actions/github-script@441359b1a30438de65712c2fbca0abe4816fa667 # v5.0.0
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> script: |
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -55,6 +78,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Get the workflow URL
</span><span class="cx" style="display: block; padding: 0 10px"> id: current-workflow-url
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/github-script@441359b1a30438de65712c2fbca0abe4816fa667 # v5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ github.event_name == 'push' }}
</ins><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> script: |
</span><span class="cx" style="display: block; padding: 0 10px"> const workflow_run = await github.rest.actions.getWorkflowRun({
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -72,8 +96,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> const previous_runs = await github.rest.actions.listWorkflowRuns({
</span><span class="cx" style="display: block; padding: 0 10px"> owner: '${{ github.repository_owner }}',
</span><span class="cx" style="display: block; padding: 0 10px"> repo: 'wordpress-develop',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- workflow_id: ${{ steps.current-workflow-id.outputs.result }},
- branch: '${{ github.ref_name }}',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ workflow_id: ${{ github.event_name == 'workflow_run' && github.event.workflow_run.workflow_id || steps.current-workflow-id.outputs.result }},
+ branch: '${{ env.CURRENT_BRANCH }}',
</ins><span class="cx" style="display: block; padding: 0 10px"> per_page: 1,
</span><span class="cx" style="display: block; padding: 0 10px"> page: 2,
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -87,7 +111,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> id: commit-message
</span><span class="cx" style="display: block; padding: 0 10px"> run: |
</span><span class="cx" style="display: block; padding: 0 10px"> COMMIT_MESSAGE=$(cat <<'EOF' | awk 'NR==1' | sed 's/`/\\`/g' | sed 's/\"/\\\\"/g'
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- ${{ github.event.head_commit.message }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ${{ github.event_name == 'workflow_run' && github.event.workflow_run.head_commit.message || github.event.head_commit.message }}
</ins><span class="cx" style="display: block; padding: 0 10px"> EOF
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> echo "::set-output name=commit_message_escaped::${COMMIT_MESSAGE}"
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -94,7 +118,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Construct payload and store as an output
</span><span class="cx" style="display: block; padding: 0 10px"> id: create-payload
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- run: echo "::set-output name=payload::{\"workflow_name\":\"${{ github.workflow }}\",\"ref_name\":\"${{ github.ref_name }}\",\"run_url\":\"${{ steps.current-workflow-url.outputs.result }}\",\"commit_message\":\"${{ steps.commit-message.outputs.commit_message_escaped }}\"}"
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ run: echo "::set-output name=payload::{\"workflow_name\":\"${{ github.workflow }}\",\"ref_name\":\"${{ env.CURRENT_BRANCH }}\",\"run_url\":\"${{ github.event_name == 'workflow_run' && github.event.workflow_run.html_url || steps.current-workflow-url.outputs.result }}\",\"commit_message\":\"${{ steps.commit-message.outputs.commit_message_escaped }}\"}"
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> # Posts notifications when a workflow fails.
</span><span class="cx" style="display: block; padding: 0 10px"> failure:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -101,7 +125,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: Failure notifications
</span><span class="cx" style="display: block; padding: 0 10px"> runs-on: ubuntu-latest
</span><span class="cx" style="display: block; padding: 0 10px"> needs: [ prepare ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ failure() }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ github.event_name == 'push' && failure() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure' }}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Post failure notifications to Slack
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -116,7 +140,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: Fixed notifications
</span><span class="cx" style="display: block; padding: 0 10px"> runs-on: ubuntu-latest
</span><span class="cx" style="display: block; padding: 0 10px"> needs: [ prepare ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && success() }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && ( github.event_name == 'push' && success() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' ) }}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Post failure notifications to Slack
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -131,7 +155,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: Success notifications
</span><span class="cx" style="display: block; padding: 0 10px"> runs-on: ubuntu-latest
</span><span class="cx" style="display: block; padding: 0 10px"> needs: [ prepare ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ success() }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ github.event_name == 'push' && success() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' }}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Post success notifications to Slack
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -146,7 +170,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: Cancelled notifications
</span><span class="cx" style="display: block; padding: 0 10px"> runs-on: ubuntu-latest
</span><span class="cx" style="display: block; padding: 0 10px"> needs: [ prepare ]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if: ${{ cancelled() }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if: ${{ github.event_name == 'push' && cancelled() || github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'cancelled' }}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Post cancelled notifications to Slack
</span></span></pre>
</div>
</div>
</body>
</html>