<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[51663] trunk/tests/phpunit/tests/functions: Tests: Move `wp_list_pluck()` tests to their own file.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/51663">51663</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/51663","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-08-26 15:54:29 +0000 (Thu, 26 Aug 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Move `wp_list_pluck()` tests to their own file.
The tests were partially duplicated in two separate files.
Follow-up to [431/tests], <a href="https://core.trac.wordpress.org/changeset/28900">[28900]</a>, <a href="https://core.trac.wordpress.org/changeset/38928">[38928]</a>, <a href="https://core.trac.wordpress.org/changeset/42527">[42527]</a>.
See <a href="https://core.trac.wordpress.org/ticket/53363">#53363</a>, <a href="https://core.trac.wordpress.org/ticket/53987">#53987</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsfunctionswpListFilterphp">trunk/tests/phpunit/tests/functions/wpListFilter.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsfunctionswpListPluckphp">trunk/tests/phpunit/tests/functions/wpListPluck.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsfunctionswpListFilterphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/functions/wpListFilter.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/functions/wpListFilter.php 2021-08-26 14:04:55 UTC (rev 51662)
+++ trunk/tests/phpunit/tests/functions/wpListFilter.php 2021-08-26 15:54:29 UTC (rev 51663)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,11 +1,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test wp_filter_object_list(), wp_list_filter(), wp_list_pluck().
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Test wp_filter_object_list().
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @group functions.php
</span><span class="cx" style="display: block; padding: 0 10px"> * @covers ::wp_filter_object_list
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @covers ::wp_list_pluck
</del><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Functions_wpListFilter extends WP_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px"> public $object_list = array();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -135,157 +134,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( array( 'baz' => 'baz' ), $list );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function test_wp_list_pluck() {
- $list = wp_list_pluck( $this->object_list, 'name' );
- $this->assertSame(
- array(
- 'foo' => 'foo',
- 'bar' => 'bar',
- 'baz' => 'baz',
- ),
- $list
- );
-
- $list = wp_list_pluck( $this->array_list, 'name' );
- $this->assertSame(
- array(
- 'foo' => 'foo',
- 'bar' => 'bar',
- 'baz' => 'baz',
- ),
- $list
- );
- }
-
- /**
- * @ticket 28666
- */
- function test_wp_list_pluck_index_key() {
- $list = wp_list_pluck( $this->array_list, 'name', 'id' );
- $this->assertSame(
- array(
- 'f' => 'foo',
- 'b' => 'bar',
- 'z' => 'baz',
- ),
- $list
- );
- }
-
- /**
- * @ticket 28666
- */
- function test_wp_list_pluck_object_index_key() {
- $list = wp_list_pluck( $this->object_list, 'name', 'id' );
- $this->assertSame(
- array(
- 'f' => 'foo',
- 'b' => 'bar',
- 'z' => 'baz',
- ),
- $list
- );
- }
-
- /**
- * @ticket 28666
- */
- function test_wp_list_pluck_missing_index_key() {
- $list = wp_list_pluck( $this->array_list, 'name', 'nonexistent' );
- $this->assertSame(
- array(
- 0 => 'foo',
- 1 => 'bar',
- 2 => 'baz',
- ),
- $list
- );
- }
-
- /**
- * @ticket 28666
- */
- function test_wp_list_pluck_partial_missing_index_key() {
- $array_list = $this->array_list;
- unset( $array_list['bar']['id'] );
- $list = wp_list_pluck( $array_list, 'name', 'id' );
- $this->assertSame(
- array(
- 'f' => 'foo',
- 0 => 'bar',
- 'z' => 'baz',
- ),
- $list
- );
- }
-
- /**
- * @ticket 28666
- */
- function test_wp_list_pluck_mixed_index_key() {
- $mixed_list = $this->array_list;
- $mixed_list['bar'] = (object) $mixed_list['bar'];
- $list = wp_list_pluck( $mixed_list, 'name', 'id' );
- $this->assertSame(
- array(
- 'f' => 'foo',
- 'b' => 'bar',
- 'z' => 'baz',
- ),
- $list
- );
- }
-
- /**
- * @ticket 16895
- */
- function test_wp_list_pluck_containing_references() {
- $ref_list = array(
- & $this->object_list['foo'],
- & $this->object_list['bar'],
- );
-
- $this->assertInstanceOf( 'stdClass', $ref_list[0] );
- $this->assertInstanceOf( 'stdClass', $ref_list[1] );
-
- $list = wp_list_pluck( $ref_list, 'name' );
- $this->assertSame(
- array(
- 'foo',
- 'bar',
- ),
- $list
- );
-
- $this->assertInstanceOf( 'stdClass', $ref_list[0] );
- $this->assertInstanceOf( 'stdClass', $ref_list[1] );
- }
-
- /**
- * @ticket 16895
- */
- function test_wp_list_pluck_containing_references_keys() {
- $ref_list = array(
- & $this->object_list['foo'],
- & $this->object_list['bar'],
- );
-
- $this->assertInstanceOf( 'stdClass', $ref_list[0] );
- $this->assertInstanceOf( 'stdClass', $ref_list[1] );
-
- $list = wp_list_pluck( $ref_list, 'name', 'id' );
- $this->assertSame(
- array(
- 'f' => 'foo',
- 'b' => 'bar',
- ),
- $list
- );
-
- $this->assertInstanceOf( 'stdClass', $ref_list[0] );
- $this->assertInstanceOf( 'stdClass', $ref_list[1] );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function test_filter_object_list_nested_array_and() {
</span><span class="cx" style="display: block; padding: 0 10px"> $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'blue' ) ), 'AND' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertCount( 1, $list );
</span></span></pre></div>
<a id="trunktestsphpunittestsfunctionswpListPluckphpfromrev51609trunktestsphpunittestsfunctionswpListFilterphp"></a>
<div class="copfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Copied: trunk/tests/phpunit/tests/functions/wpListPluck.php (from rev 51609, trunk/tests/phpunit/tests/functions/wpListFilter.php)</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/functions/wpListPluck.php (rev 0)
+++ trunk/tests/phpunit/tests/functions/wpListPluck.php 2021-08-26 15:54:29 UTC (rev 51663)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,353 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * Test wp_list_pluck().
+ *
+ * @group functions.php
+ * @covers ::wp_list_pluck
+ */
+class Tests_Functions_wpListPluck extends WP_UnitTestCase {
+ public $object_list = array();
+ public $array_list = array();
+
+ function set_up() {
+ parent::set_up();
+ $this->array_list['foo'] = array(
+ 'name' => 'foo',
+ 'id' => 'f',
+ 'field1' => true,
+ 'field2' => true,
+ 'field3' => true,
+ 'field4' => array( 'red' ),
+ );
+ $this->array_list['bar'] = array(
+ 'name' => 'bar',
+ 'id' => 'b',
+ 'field1' => true,
+ 'field2' => true,
+ 'field3' => false,
+ 'field4' => array( 'green' ),
+ );
+ $this->array_list['baz'] = array(
+ 'name' => 'baz',
+ 'id' => 'z',
+ 'field1' => true,
+ 'field2' => false,
+ 'field3' => false,
+ 'field4' => array( 'blue' ),
+ );
+ foreach ( $this->array_list as $key => $value ) {
+ $this->object_list[ $key ] = (object) $value;
+ }
+ }
+
+ function test_wp_list_pluck_array_and_object() {
+ $list = wp_list_pluck( $this->object_list, 'name' );
+ $this->assertSame(
+ array(
+ 'foo' => 'foo',
+ 'bar' => 'bar',
+ 'baz' => 'baz',
+ ),
+ $list
+ );
+
+ $list = wp_list_pluck( $this->array_list, 'name' );
+ $this->assertSame(
+ array(
+ 'foo' => 'foo',
+ 'bar' => 'bar',
+ 'baz' => 'baz',
+ ),
+ $list
+ );
+ }
+
+ /**
+ * @ticket 28666
+ */
+ function test_wp_list_pluck_index_key() {
+ $list = wp_list_pluck( $this->array_list, 'name', 'id' );
+ $this->assertSame(
+ array(
+ 'f' => 'foo',
+ 'b' => 'bar',
+ 'z' => 'baz',
+ ),
+ $list
+ );
+ }
+
+ /**
+ * @ticket 28666
+ */
+ function test_wp_list_pluck_object_index_key() {
+ $list = wp_list_pluck( $this->object_list, 'name', 'id' );
+ $this->assertSame(
+ array(
+ 'f' => 'foo',
+ 'b' => 'bar',
+ 'z' => 'baz',
+ ),
+ $list
+ );
+ }
+
+ /**
+ * @ticket 28666
+ */
+ function test_wp_list_pluck_missing_index_key() {
+ $list = wp_list_pluck( $this->array_list, 'name', 'nonexistent' );
+ $this->assertSame(
+ array(
+ 0 => 'foo',
+ 1 => 'bar',
+ 2 => 'baz',
+ ),
+ $list
+ );
+ }
+
+ /**
+ * @ticket 28666
+ */
+ function test_wp_list_pluck_partial_missing_index_key() {
+ $array_list = $this->array_list;
+ unset( $array_list['bar']['id'] );
+ $list = wp_list_pluck( $array_list, 'name', 'id' );
+ $this->assertSame(
+ array(
+ 'f' => 'foo',
+ 0 => 'bar',
+ 'z' => 'baz',
+ ),
+ $list
+ );
+ }
+
+ /**
+ * @ticket 28666
+ */
+ function test_wp_list_pluck_mixed_index_key() {
+ $mixed_list = $this->array_list;
+ $mixed_list['bar'] = (object) $mixed_list['bar'];
+ $list = wp_list_pluck( $mixed_list, 'name', 'id' );
+ $this->assertSame(
+ array(
+ 'f' => 'foo',
+ 'b' => 'bar',
+ 'z' => 'baz',
+ ),
+ $list
+ );
+ }
+
+ /**
+ * @ticket 16895
+ */
+ function test_wp_list_pluck_containing_references() {
+ $ref_list = array(
+ & $this->object_list['foo'],
+ & $this->object_list['bar'],
+ );
+
+ $this->assertInstanceOf( 'stdClass', $ref_list[0] );
+ $this->assertInstanceOf( 'stdClass', $ref_list[1] );
+
+ $list = wp_list_pluck( $ref_list, 'name' );
+ $this->assertSame(
+ array(
+ 'foo',
+ 'bar',
+ ),
+ $list
+ );
+
+ $this->assertInstanceOf( 'stdClass', $ref_list[0] );
+ $this->assertInstanceOf( 'stdClass', $ref_list[1] );
+ }
+
+ /**
+ * @ticket 16895
+ */
+ function test_wp_list_pluck_containing_references_keys() {
+ $ref_list = array(
+ & $this->object_list['foo'],
+ & $this->object_list['bar'],
+ );
+
+ $this->assertInstanceOf( 'stdClass', $ref_list[0] );
+ $this->assertInstanceOf( 'stdClass', $ref_list[1] );
+
+ $list = wp_list_pluck( $ref_list, 'name', 'id' );
+ $this->assertSame(
+ array(
+ 'f' => 'foo',
+ 'b' => 'bar',
+ ),
+ $list
+ );
+
+ $this->assertInstanceOf( 'stdClass', $ref_list[0] );
+ $this->assertInstanceOf( 'stdClass', $ref_list[1] );
+ }
+
+ /**
+ * @dataProvider data_test_wp_list_pluck
+ *
+ * @param array $list List of objects or arrays.
+ * @param int|string $field Field from the object to place instead of the entire object
+ * @param int|string $index_key Field from the object to use as keys for the new array.
+ * @param array $expected Expected result.
+ */
+ public function test_wp_list_pluck( $list, $field, $index_key, $expected ) {
+ $this->assertSameSetsWithIndex( $expected, wp_list_pluck( $list, $field, $index_key ) );
+ }
+
+ public function data_test_wp_list_pluck() {
+ return array(
+ 'arrays' => array(
+ array(
+ array(
+ 'foo' => 'bar',
+ 'bar' => 'baz',
+ 'abc' => 'xyz',
+ ),
+ array(
+ 'foo' => 'foo',
+ '123' => '456',
+ 'lorem' => 'ipsum',
+ ),
+ array( 'foo' => 'baz' ),
+ ),
+ 'foo',
+ null,
+ array( 'bar', 'foo', 'baz' ),
+ ),
+ 'arrays with index key' => array(
+ array(
+ array(
+ 'foo' => 'bar',
+ 'bar' => 'baz',
+ 'abc' => 'xyz',
+ 'key' => 'foo',
+ ),
+ array(
+ 'foo' => 'foo',
+ '123' => '456',
+ 'lorem' => 'ipsum',
+ 'key' => 'bar',
+ ),
+ array(
+ 'foo' => 'baz',
+ 'key' => 'value',
+ ),
+ ),
+ 'foo',
+ 'key',
+ array(
+ 'foo' => 'bar',
+ 'bar' => 'foo',
+ 'value' => 'baz',
+ ),
+ ),
+ 'arrays with index key missing' => array(
+ array(
+ array(
+ 'foo' => 'bar',
+ 'bar' => 'baz',
+ 'abc' => 'xyz',
+ ),
+ array(
+ 'foo' => 'foo',
+ '123' => '456',
+ 'lorem' => 'ipsum',
+ 'key' => 'bar',
+ ),
+ array(
+ 'foo' => 'baz',
+ 'key' => 'value',
+ ),
+ ),
+ 'foo',
+ 'key',
+ array(
+ 'bar',
+ 'bar' => 'foo',
+ 'value' => 'baz',
+ ),
+ ),
+ 'objects' => array(
+ array(
+ (object) array(
+ 'foo' => 'bar',
+ 'bar' => 'baz',
+ 'abc' => 'xyz',
+ ),
+ (object) array(
+ 'foo' => 'foo',
+ '123' => '456',
+ 'lorem' => 'ipsum',
+ ),
+ (object) array( 'foo' => 'baz' ),
+ ),
+ 'foo',
+ null,
+ array( 'bar', 'foo', 'baz' ),
+ ),
+ 'objects with index key' => array(
+ array(
+ (object) array(
+ 'foo' => 'bar',
+ 'bar' => 'baz',
+ 'abc' => 'xyz',
+ 'key' => 'foo',
+ ),
+ (object) array(
+ 'foo' => 'foo',
+ '123' => '456',
+ 'lorem' => 'ipsum',
+ 'key' => 'bar',
+ ),
+ (object) array(
+ 'foo' => 'baz',
+ 'key' => 'value',
+ ),
+ ),
+ 'foo',
+ 'key',
+ array(
+ 'foo' => 'bar',
+ 'bar' => 'foo',
+ 'value' => 'baz',
+ ),
+ ),
+ 'objects with index key missing' => array(
+ array(
+ (object) array(
+ 'foo' => 'bar',
+ 'bar' => 'baz',
+ 'abc' => 'xyz',
+ ),
+ (object) array(
+ 'foo' => 'foo',
+ '123' => '456',
+ 'lorem' => 'ipsum',
+ 'key' => 'bar',
+ ),
+ (object) array(
+ 'foo' => 'baz',
+ 'key' => 'value',
+ ),
+ ),
+ 'foo',
+ 'key',
+ array(
+ 'bar',
+ 'bar' => 'foo',
+ 'value' => 'baz',
+ ),
+ ),
+ );
+ }
+}
</ins></span></pre>
</div>
</div>
</body>
</html>