<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[51535] trunk: Build/Test Tools: Expand Slack notifications for GitHub Actions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/51535">51535</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/51535","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-08-03 13:45:02 +0000 (Tue, 03 Aug 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Expand Slack notifications for GitHub Actions.
This expands Slack notifications to include success, cancelled, and {U+201C}fixed{U+201D} GitHub Action workflow run outcomes in addition to failures.
A {U+201C}fixed{U+201D} outcome occurs when the previous run for a workflow failed and the current one succeeds. This matches the behavior that was native to TravisCI by setting `on_success` for notifications to `change`.
The message details and where each outcome is posted is controlled by Slack workflows.
The Slack notification logic has also been pulled into a separate workflow to prevent repeating code in every workflow.
See <a href="https://core.trac.wordpress.org/ticket/52644">#52644</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowscodingstandardsyml">trunk/.github/workflows/coding-standards.yml</a></li>
<li><a href="#trunkgithubworkflowsendtoendtestsyml">trunk/.github/workflows/end-to-end-tests.yml</a></li>
<li><a href="#trunkgithubworkflowsjavascripttestsyml">trunk/.github/workflows/javascript-tests.yml</a></li>
<li><a href="#trunkgithubworkflowsphpcompatibilityyml">trunk/.github/workflows/php-compatibility.yml</a></li>
<li><a href="#trunkgithubworkflowsphpunittestsyml">trunk/.github/workflows/phpunit-tests.yml</a></li>
<li><a href="#trunkgithubworkflowstestcoverageyml">trunk/.github/workflows/test-coverage.yml</a></li>
<li><a href="#trunkgithubworkflowstestnpmyml">trunk/.github/workflows/test-npm.yml</a></li>
<li><a href="#trunkgithubworkflowstestoldbranchesyml">trunk/.github/workflows/test-old-branches.yml</a></li>
<li><a href="#trunkgithubworkflowswelcomenewcontributorsyml">trunk/.github/workflows/welcome-new-contributors.yml</a></li>
<li><a href="#trunksrcwpcronphp">trunk/src/wp-cron.php</a></li>
<li><a href="#trunktestsphpunittestsfunctionsphp">trunk/tests/phpunit/tests/functions.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowsslacknotificationsyml">trunk/.github/workflows/slack-notifications.yml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowscodingstandardsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/coding-standards.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/coding-standards.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/coding-standards.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -146,22 +146,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Ensure version-controlled files are not modified or deleted
</span><span class="cx" style="display: block; padding: 0 10px"> run: git diff --exit-code
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ phpcs, jshint ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowsendtoendtestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/end-to-end-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/end-to-end-tests.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/end-to-end-tests.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -116,22 +116,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Ensure version-controlled files are not modified or deleted
</span><span class="cx" style="display: block; padding: 0 10px"> run: git diff --exit-code
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ e2e-tests ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowsjavascripttestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/javascript-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/javascript-tests.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/javascript-tests.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -85,22 +85,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Ensure version-controlled files are not modified or deleted
</span><span class="cx" style="display: block; padding: 0 10px"> run: git diff --exit-code
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ test-js ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowsphpcompatibilityyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/php-compatibility.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/php-compatibility.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/php-compatibility.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -87,22 +87,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Ensure version-controlled files are not modified or deleted
</span><span class="cx" style="display: block; padding: 0 10px"> run: git diff --exit-code
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ php-compatibility ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowsphpunittestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/phpunit-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/phpunit-tests.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/phpunit-tests.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -236,22 +236,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> env:
</span><span class="cx" style="display: block; padding: 0 10px"> WPT_REPORT_API_KEY: "${{ secrets.WPT_REPORT_API_KEY }}"
</span><span class="cx" style="display: block; padding: 0 10px"> run: docker-compose run --rm -e WPT_REPORT_API_KEY -e WPT_PREPARE_DIR=/var/www -e WPT_TEST_DIR=/var/www php php test-runner/report.php
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ test-php ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowsslacknotificationsyml"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/.github/workflows/slack-notifications.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/slack-notifications.yml (rev 0)
+++ trunk/.github/workflows/slack-notifications.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,121 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+##
+# Posts messages to the Making WordPress Core Slack Instance by
+# submitting data to Slack webhook URLs received by Slack Workflows.
+##
+name: Slack Notifications
+
+on:
+ workflow_run:
+ workflows:
+ - Code Coverage Report
+ - Coding Standards
+ - End-to-end Tests
+ - JavaScript Tests
+ - PHP Compatibility
+ - PHPUnit Tests
+ - Test NPM
+ - Test old branches
+ types:
+ - completed
+
+jobs:
+ # Gathers the details needed for Slack notifications.
+ #
+ # These details are passed as outputs to the subsequent, dependant jobs that
+ # submit data to Slack webhook URLs configured to post messages.
+ #
+ # Performs the following steps:
+ # - Retrieves the previous workflow run and stores its conclusion.
+ # - Sets the previous conclusion as an output.
+ # - Constructs and stores a message payload as an output.
+ prepare:
+ name: Prepare notifications
+ runs-on: ubuntu-latest
+ if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event.workflow_run.conclusion != 'skipped' && github.event_name != 'pull_request' }}
+ outputs:
+ previous_conclusion: ${{ steps.previous-conclusion.outputs.previous_conclusion }}
+ payload: ${{ steps.create-payload.outputs.payload }}
+
+ steps:
+ - name: Get details about the workflow
+ id: previous-result
+ uses: actions/github-script@a3e7071a34d7e1f219a8a4de9a5e0a34d1ee1293 # v4.0.2
+ with:
+ script: |
+ const workflow_runs = await github.actions.listWorkflowRuns({
+ owner: context.repo.owner,
+ repo: context.repo.repo,
+ workflow_id: ${{ github.event.workflow_run.workflow_id }},
+ branch: '${{ github.event.workflow_run.head_branch }}',
+ per_page: 1,
+ page: 2,
+ });
+ return workflow_runs.data.workflow_runs[0].conclusion;
+
+ - name: Store previous conclusion as an output
+ id: previous-conclusion
+ run: echo "::set-output name=previous_conclusion::${{ steps.previous-result.outputs.result }}"
+
+ - name: Construct payload and store as an output
+ id: create-payload
+ run: echo "::set-output name=payload::\"{\"workflow_name\":\"${{ github.event.workflow_run.name }}\",\"ref_name\":\"${{ github.event.workflow_run.head_branch }}\",\"run_url\":\"${{ github.event.workflow_run.html_url }}\"}\""
+
+ # Posts notifications when a workflow fails.
+ failure:
+ name: Failure notifications
+ runs-on: ubuntu-latest
+ needs: [ prepare ]
+ if: ${{ github.event.workflow_run.conclusion == 'failure' }}
+
+ steps:
+ - name: Post failure notifications to Slack
+ uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
+ with:
+ payload: ${{ needs.prepare.outputs.payload }}
+ env:
+ SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
+
+ # Posts notifications the first time a workflow run succeeds after previously failing.
+ fixed:
+ name: Fixed notifications
+ runs-on: ubuntu-latest
+ needs: [ prepare ]
+ if: ${{ needs.prepare.outputs.previous_conclusion == 'failure' && github.event.workflow_run.conclusion == 'success' }}
+
+ steps:
+ - name: Post failure notifications to Slack
+ uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
+ with:
+ payload: ${{ needs.prepare.outputs.payload }}
+ env:
+ SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
+
+ # Posts notifications when a workflow is successful.
+ success:
+ name: Success notifications
+ runs-on: ubuntu-latest
+ needs: [ prepare ]
+ if: ${{ github.event.workflow_run.conclusion == 'success' }}
+
+ steps:
+ - name: Post success notifications to Slack
+ uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
+ with:
+ payload: ${{ needs.prepare.outputs.payload }}
+ env:
+ SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
+
+ # Posts notifications when a workflow is cancelled.
+ cancelled:
+ name: Cancelled notifications
+ runs-on: ubuntu-latest
+ needs: [ prepare ]
+ if: ${{ github.event.workflow_run.conclusion == 'cancelled' }}
+
+ steps:
+ - name: Post cancelled notifications to Slack
+ uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
+ with:
+ payload: ${{ needs.prepare.outputs.payload }}
+ env:
+ SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
</ins></span></pre></div>
<a id="trunkgithubworkflowstestcoverageyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-coverage.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-coverage.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/test-coverage.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -146,22 +146,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> file: wp-code-coverage-multisite-clover-${{ github.sha }}.xml
</span><span class="cx" style="display: block; padding: 0 10px"> flags: multisite,php
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ test-coverage-report ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowstestnpmyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-npm.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-npm.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/test-npm.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -154,22 +154,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Ensure version-controlled files are not modified or deleted during building and cleaning
</span><span class="cx" style="display: block; padding: 0 10px"> run: git diff --exit-code
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ test-npm, test-npm-macos ]
- if: ${{ failure() && github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowstestoldbranchesyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/test-old-branches.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/test-old-branches.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/test-old-branches.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -69,22 +69,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> workflow_id: '${{ matrix.workflow }}',
</span><span class="cx" style="display: block; padding: 0 10px"> ref: '${{ matrix.branch }}'
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ dispatch-workflows-for-old-branches ]
- if: ${{ failure() }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunkgithubworkflowswelcomenewcontributorsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/welcome-new-contributors.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/welcome-new-contributors.yml 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/.github/workflows/welcome-new-contributors.yml 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -57,22 +57,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> Thank you,
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> The WordPress Project
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- # Post workflow related status updates to Slack.
- #
- # When a job in this workflow fails, a message is posted to #core.
- #
- # This job should always require all other jobs in this workflow to complete before running.
- slack-notifications:
- name: Slack Notifications
- runs-on: ubuntu-latest
- needs: [ post-welcome-message ]
- if: ${{ failure() }}
-
- steps:
- - name: Post failure notification to Slack
- uses: slackapi/slack-github-action@d5d276d7ae0f38f29322b80da9baf985cc80f8b1 # v1.15.0
- with:
- payload: "{\"workflow_name\":\"${{ github.workflow }}\",\"run_url\":\"https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}\"}"
- env:
- SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_WEBHOOK_URL }}
</del></span></pre></div>
<a id="trunksrcwpcronphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-cron.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-cron.php 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/src/wp-cron.php 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -60,7 +60,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $value = 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( wp_using_ext_object_cache() ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if (wp_using_ext_object_cache()) {
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Skip local cache and force re-fetch of doing_cron transient
</span><span class="cx" style="display: block; padding: 0 10px"> * in case another process updated the cache.
</span></span></pre></div>
<a id="trunktestsphpunittestsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/functions.php 2021-08-03 12:17:54 UTC (rev 51534)
+++ trunk/tests/phpunit/tests/functions.php 2021-08-03 13:45:02 UTC (rev 51535)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -27,7 +27,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( array(), wp_parse_args( $a ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $b = array(
</span><span class="cx" style="display: block; padding: 0 10px"> '_baba' => 5,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'yZ' => 'baba',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'yZ' => 'bab',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'a' => array( 5, 111, 'x' ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame(
</span></span></pre>
</div>
</div>
</body>
</html>