<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[51212] trunk: Build/Test Tools: Add the `regenerator-runtime` script as a dependency to `wp-polyfill`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/51212">51212</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/51212","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-06-23 00:04:47 +0000 (Wed, 23 Jun 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Add the `regenerator-runtime` script as a dependency to `wp-polyfill`.
In <a href="https://core.trac.wordpress.org/changeset/51146">[51146]</a>, the `core-js` package replaced the deprecated `@babel//polyfill` one. The `core-js` package builds `wp-polyfill` from a configuration provided by `@wordpress/babel-preset-default` instead of copying a one size fits all polyfill.
That change caused an issue where plugins and themes relying on the `regenerator-runtime` script being included in the `wp-polyfill.js` file encountering fatal JavaScript errors.
This adds the `regenerator-runtime` package to Core and registers it as a dependency for `wp-polyfill`. While Core does not require `regenerator-runtime`, it will allow for a smoother transition to using `core-js`.
This dependency will be removed in a future version of WordPress, so developers are encouraged to add `regenerator-runtime` as a dependency for any custom script that requires it.
Follow up to <a href="https://core.trac.wordpress.org/changeset/51146">[51146]</a>.
Props gziolo, herregroen, jeherve, hellofromtonya, peterwilsoncc.
Fixes <a href="https://core.trac.wordpress.org/ticket/52941">#52941</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkpackagejson">trunk/package.json</a></li>
<li><a href="#trunksrcwpincludesscriptloaderphp">trunk/src/wp-includes/script-loader.php</a></li>
<li><a href="#trunktestsphpunittestsdependenciesscriptsphp">trunk/tests/phpunit/tests/dependencies/scripts.php</a></li>
<li><a href="#trunktoolswebpackpackagesjs">trunk/tools/webpack/packages.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkpackagejson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/package.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/package.json 2021-06-22 23:11:02 UTC (rev 51211)
+++ trunk/package.json 2021-06-23 00:04:47 UTC (rev 51212)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -147,6 +147,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "polyfill-library": "3.105.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "react": "16.13.1",
</span><span class="cx" style="display: block; padding: 0 10px"> "react-dom": "16.13.1",
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "regenerator-runtime": "0.13.7",
</ins><span class="cx" style="display: block; padding: 0 10px"> "twemoji": "13.1.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "underscore": "1.13.1",
</span><span class="cx" style="display: block; padding: 0 10px"> "whatwg-fetch": "3.0.0"
</span></span></pre></div>
<a id="trunksrcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/script-loader.php 2021-06-22 23:11:02 UTC (rev 51211)
+++ trunk/src/wp-includes/script-loader.php 2021-06-23 00:04:47 UTC (rev 51212)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -80,8 +80,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $suffix = wp_scripts_get_suffix();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $vendor_scripts = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'react' => array( 'wp-polyfill' ),
- 'react-dom' => array( 'react' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'react' => array( 'wp-polyfill' ),
+ 'react-dom' => array( 'react' ),
+ 'regenerator-runtime',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'moment',
</span><span class="cx" style="display: block; padding: 0 10px"> 'lodash',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-fetch',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -91,12 +92,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-dom-rect',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-element-closest',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-object-fit',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'wp-polyfill',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'wp-polyfill' => array( 'regenerator-runtime' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $vendor_scripts_versions = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'react' => '16.13.1',
</span><span class="cx" style="display: block; padding: 0 10px"> 'react-dom' => '16.13.1',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'regenerator-runtime' => '0.13.7',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'moment' => '2.29.1',
</span><span class="cx" style="display: block; padding: 0 10px"> 'lodash' => '4.17.19',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-fetch' => '3.0.0',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -106,7 +108,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-dom-rect' => '3.104.0',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-element-closest' => '2.0.2',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-object-fit' => '2.3.5',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'wp-polyfill' => '7.4.4',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'wp-polyfill' => '3.15.0',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $vendor_scripts as $handle => $dependencies ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -121,8 +123,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $scripts->add( $handle, $path, $dependencies, $version, 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $scripts->add( 'wp-polyfill', null, array( 'wp-polyfill' ) );
-
</del><span class="cx" style="display: block; padding: 0 10px"> did_action( 'init' ) && $scripts->add_inline_script( 'lodash', 'window.lodash = _.noConflict();' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> did_action( 'init' ) && $scripts->add_inline_script(
</span></span></pre></div>
<a id="trunktestsphpunittestsdependenciesscriptsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/dependencies/scripts.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/dependencies/scripts.php 2021-06-22 23:11:02 UTC (rev 51211)
+++ trunk/tests/phpunit/tests/dependencies/scripts.php 2021-06-23 00:04:47 UTC (rev 51212)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -723,7 +723,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $ver = get_bloginfo( 'version' );
</span><span class="cx" style="display: block; padding: 0 10px"> $suffix = wp_scripts_get_suffix();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = "<script type='text/javascript' src='/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,wp-polyfill,wp-dom-ready,wp-hooks&ver={$ver}'></script>\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = "<script type='text/javascript' src='/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,regenerator-runtime,wp-polyfill,wp-dom-ready,wp-hooks&ver={$ver}'></script>\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> $expected .= "<script type='text/javascript' id='test-example-js-before'>\nconsole.log(\"before\");\n</script>\n";
</span><span class="cx" style="display: block; padding: 0 10px"> $expected .= "<script type='text/javascript' src='http://example.com' id='test-example-js'></script>\n";
</span><span class="cx" style="display: block; padding: 0 10px"> $expected .= "<script type='text/javascript' src='/wp-includes/js/dist/i18n{$suffix}.js' id='wp-i18n-js'></script>\n";
</span></span></pre></div>
<a id="trunktoolswebpackpackagesjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tools/webpack/packages.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tools/webpack/packages.js 2021-06-22 23:11:02 UTC (rev 51211)
+++ trunk/tools/webpack/packages.js 2021-06-23 00:04:47 UTC (rev 51212)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -84,6 +84,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'moment.js': 'moment/moment.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'react.js': 'react/umd/react.development.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'react-dom.js': 'react-dom/umd/react-dom.development.js',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'regenerator-runtime.js': 'regenerator-runtime/runtime.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> const minifiedVendors = {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -98,6 +99,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> const minifyVendors = {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'regenerator-runtime.min.js': 'regenerator-runtime/runtime.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-fetch.min.js': 'whatwg-fetch/dist/fetch.umd.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-element-closest.min.js': 'element-closest/element-closest.js',
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-node-contains.min.js': 'polyfill-library/polyfills/__dist/Node.prototype.contains/raw.js',
</span></span></pre>
</div>
</div>
</body>
</html>