<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[50491] trunk/tests/phpunit/tests: Docs: Update inline comments in some test files per the documentation standards.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/50491">50491</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/50491","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-03-04 10:11:38 +0000 (Thu, 04 Mar 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Docs: Update inline comments in some test files per the documentation standards.
See <a href="https://core.trac.wordpress.org/ticket/52628">#52628</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsformattingSanitizeFileNamephp">trunk/tests/phpunit/tests/formatting/SanitizeFileName.php</a></li>
<li><a href="#trunktestsphpunittestsimageeditorGdphp">trunk/tests/phpunit/tests/image/editorGd.php</a></li>
<li><a href="#trunktestsphpunittestsimageeditorImagickphp">trunk/tests/phpunit/tests/image/editorImagick.php</a></li>
<li><a href="#trunktestsphpunittestsrestapirestthemescontrollerphp">trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php</a></li>
<li><a href="#trunktestsphpunittestssitemapsfunctionsphp">trunk/tests/phpunit/tests/sitemaps/functions.php</a></li>
<li><a href="#trunktestsphpunittestsusercapabilitiesphp">trunk/tests/phpunit/tests/user/capabilities.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsformattingSanitizeFileNamephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/formatting/SanitizeFileName.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/formatting/SanitizeFileName.php 2021-03-04 00:12:55 UTC (rev 50490)
+++ trunk/tests/phpunit/tests/formatting/SanitizeFileName.php 2021-03-04 10:11:38 UTC (rev 50491)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,7 +5,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Formatting_SanitizeFileName extends WP_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px"> function test_munges_extensions() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # r17990
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // r17990
</ins><span class="cx" style="display: block; padding: 0 10px"> $file_name = sanitize_file_name( 'test.phtml.txt' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'test.phtml_.txt', $file_name );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsimageeditorGdphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/image/editorGd.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/image/editorGd.php 2021-03-04 00:12:55 UTC (rev 50490)
+++ trunk/tests/phpunit/tests/image/editorGd.php 2021-03-04 10:11:38 UTC (rev 50491)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -89,7 +89,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $resized = $gd_image_editor->multi_resize( $sizes_array );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # First, check to see if returned array is as expected
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // First, check to see if returned array is as expected.
</ins><span class="cx" style="display: block; padding: 0 10px"> $expected_array = array(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'file' => 'waffles-50x33.jpg',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -217,7 +217,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * By aspect, should be 30x20 output.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'width' => 9999, # Arbitrary High Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'width' => 9999, // Arbitrary high value.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'height' => 20,
</span><span class="cx" style="display: block; padding: 0 10px"> 'crop' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -228,7 +228,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'width' => 45,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'height' => 9999, # Arbitrary High Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'height' => 9999, // Arbitrary high value.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'crop' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -271,7 +271,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * By aspect, should be 105x70 output.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'width' => -9999, # Arbitrary Negative Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'width' => -9999, // Arbitrary negative value.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'height' => 70,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -281,7 +281,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'width' => 200,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'height' => -9999, # Arbitrary Negative Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'height' => -9999, // Arbitrary negative value.
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsimageeditorImagickphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/image/editorImagick.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/image/editorImagick.php 2021-03-04 00:12:55 UTC (rev 50490)
+++ trunk/tests/phpunit/tests/image/editorImagick.php 2021-03-04 10:11:38 UTC (rev 50491)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -83,7 +83,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $resized = $imagick_image_editor->multi_resize( $sizes_array );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # First, check to see if returned array is as expected
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // First, check to see if returned array is as expected.
</ins><span class="cx" style="display: block; padding: 0 10px"> $expected_array = array(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'file' => 'waffles-50x33.jpg',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -211,7 +211,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * By aspect, should be 30x20 output.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'width' => 9999, # Arbitrary High Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'width' => 9999, // Arbitrary high value.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'height' => 20,
</span><span class="cx" style="display: block; padding: 0 10px"> 'crop' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -222,7 +222,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'width' => 45,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'height' => 9999, # Arbitrary High Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'height' => 9999, // Arbitrary high value.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'crop' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -265,7 +265,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * By aspect, should be 105x70 output.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'width' => -9999, # Arbitrary Negative Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'width' => -9999, // Arbitrary negative value.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'height' => 70,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -275,7 +275,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'width' => 200,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'height' => -9999, # Arbitrary Negative Value
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'height' => -9999, // Arbitrary negative value.
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsrestapirestthemescontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php 2021-03-04 00:12:55 UTC (rev 50490)
+++ trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php 2021-03-04 10:11:38 UTC (rev 50491)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1205,7 +1205,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_update_item() {}
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Test single theme
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Test single theme.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 50152
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span></span></pre></div>
<a id="trunktestsphpunittestssitemapsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/sitemaps/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/sitemaps/functions.php 2021-03-04 00:12:55 UTC (rev 50490)
+++ trunk/tests/phpunit/tests/sitemaps/functions.php 2021-03-04 10:11:38 UTC (rev 50491)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -101,22 +101,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'post', 0, home_url( '/?sitemap=posts&sitemap-subtype=post&paged=1' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'page', 1, home_url( '/?sitemap=posts&sitemap-subtype=page&paged=1' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'page', 5, home_url( '/?sitemap=posts&sitemap-subtype=page&paged=5' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // post_type doesn't exist.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Post type doesn't exist.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'foo', 5, false ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'taxonomies', 'category', 1, home_url( '/?sitemap=taxonomies&sitemap-subtype=category&paged=1' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'taxonomies', 'post_tag', 1, home_url( '/?sitemap=taxonomies&sitemap-subtype=post_tag&paged=1' ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Negative paged, gets converted to its absolute value.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'taxonomies', 'post_tag', -1, home_url( '/?sitemap=taxonomies&sitemap-subtype=post_tag&paged=1' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // negative paged, gets converted to it's absolute value.
</del><span class="cx" style="display: block; padding: 0 10px"> array( 'users', '', 4, home_url( '/?sitemap=users&paged=4' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // users provider doesn't allow subtypes.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Users provider doesn't allow subtypes.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'users', 'foo', 4, false ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // provider doesn't exist.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Provider doesn't exist.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'foo', '', 4, false ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Data provider for test_get_sitemap_url_pretty_permalinks
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Data provider for test_get_sitemap_url_pretty_permalinks.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array[] {
</span><span class="cx" style="display: block; padding: 0 10px"> * Data to test with.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,16 +133,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'post', 0, home_url( '/wp-sitemap-posts-post-1.xml' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'page', 1, home_url( '/wp-sitemap-posts-page-1.xml' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'page', 5, home_url( '/wp-sitemap-posts-page-5.xml' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // post_type doesn't exist.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Post type doesn't exist.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'posts', 'foo', 5, false ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'taxonomies', 'category', 1, home_url( '/wp-sitemap-taxonomies-category-1.xml' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'taxonomies', 'post_tag', 1, home_url( '/wp-sitemap-taxonomies-post_tag-1.xml' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // negative paged, gets converted to it's absolute value.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Negative paged, gets converted to its absolute value.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'taxonomies', 'post_tag', -1, home_url( '/wp-sitemap-taxonomies-post_tag-1.xml' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( 'users', '', 4, home_url( '/wp-sitemap-users-4.xml' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // users provider doesn't allow subtypes.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Users provider doesn't allow subtypes.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'users', 'foo', 4, false ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // provider doesn't exist.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Provider doesn't exist.
</ins><span class="cx" style="display: block; padding: 0 10px"> array( 'foo', '', 4, false ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsusercapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/user/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user/capabilities.php 2021-03-04 00:12:55 UTC (rev 50490)
+++ trunk/tests/phpunit/tests/user/capabilities.php 2021-03-04 10:11:38 UTC (rev 50491)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -645,13 +645,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_do_not_allow_is_denied_for_all_roles() {
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( self::$users as $role => $user ) {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Test adding the cap directly to the user
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Test adding the cap directly to the user.
</ins><span class="cx" style="display: block; padding: 0 10px"> $user->add_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_cap = $user->has_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> $user->remove_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( $has_cap, "User with the {$role} role should not have the do_not_allow capability" );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Test adding the cap via a filter
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Test adding the cap via a filter.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'user_has_cap', array( $this, 'grant_do_not_allow' ), 10, 4 );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_cap = $user->has_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> remove_filter( 'user_has_cap', array( $this, 'grant_do_not_allow' ), 10, 4 );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -662,7 +662,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> continue;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Test adding the cap to the user's role
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Test adding the cap to the user's role.
</ins><span class="cx" style="display: block; padding: 0 10px"> $role_obj = get_role( $role );
</span><span class="cx" style="display: block; padding: 0 10px"> $role_obj->add_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_cap = $user->has_cap( 'do_not_allow' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -676,13 +676,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 41059
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_do_not_allow_is_denied_for_super_admins() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Test adding the cap directly to the user
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Test adding the cap directly to the user.
</ins><span class="cx" style="display: block; padding: 0 10px"> self::$super_admin->add_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_cap = self::$super_admin->has_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> self::$super_admin->remove_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( $has_cap, 'Super admins should not have the do_not_allow capability' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- # Test adding the cap via a filter
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Test adding the cap via a filter.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'user_has_cap', array( $this, 'grant_do_not_allow' ), 10, 4 );
</span><span class="cx" style="display: block; padding: 0 10px"> $has_cap = self::$super_admin->has_cap( 'do_not_allow' );
</span><span class="cx" style="display: block; padding: 0 10px"> remove_filter( 'user_has_cap', array( $this, 'grant_do_not_allow' ), 10, 4 );
</span></span></pre>
</div>
</div>
</body>
</html>