<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[50367] trunk/src/js: External Libraries: Further fix jQuery deprecations in WordPress core.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/50367">50367</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/50367","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-02-16 20:23:19 +0000 (Tue, 16 Feb 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>External Libraries: Further fix jQuery deprecations in WordPress core.
This addresses `JQMIGRATE` warnings in some admin files and the Thickbox library.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/50001">[50001]</a>, <a href="https://core.trac.wordpress.org/changeset/50270">[50270]</a>.
Props bordoni, poena.
See <a href="https://core.trac.wordpress.org/ticket/51812">#51812</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminapplicationpasswordsjs">trunk/src/js/_enqueues/admin/application-passwords.js</a></li>
<li><a href="#trunksrcjs_enqueuesadminprivacytoolsjs">trunk/src/js/_enqueues/admin/privacy-tools.js</a></li>
<li><a href="#trunksrcjs_enqueuesadminsitehealthjs">trunk/src/js/_enqueues/admin/site-health.js</a></li>
<li><a href="#trunksrcjs_enqueuesadminxfnjs">trunk/src/js/_enqueues/admin/xfn.js</a></li>
<li><a href="#trunksrcjs_enqueueslibpointerjs">trunk/src/js/_enqueues/lib/pointer.js</a></li>
<li><a href="#trunksrcjs_enqueuesvendorthickboxthickboxjs">trunk/src/js/_enqueues/vendor/thickbox/thickbox.js</a></li>
<li><a href="#trunksrcjsmediaviewsattachmentdetailsjs">trunk/src/js/media/views/attachment/details.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminapplicationpasswordsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/application-passwords.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/application-passwords.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/_enqueues/admin/application-passwords.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,7 +25,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var name = $newAppPassField.val();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 0 === name.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $newAppPassField.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $newAppPassField.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -60,7 +60,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> name: response.name,
</span><span class="cx" style="display: block; padding: 0 10px"> password: response.password
</span><span class="cx" style="display: block; padding: 0 10px"> } ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '.new-application-password-notice' ).focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '.new-application-password-notice' ).trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $appPassTbody.prepend( tmplAppPassRow( response ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -105,7 +105,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $tr.remove();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- addNotice( wp.i18n.__( 'Application password revoked.' ), 'success' ).focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ addNotice( wp.i18n.__( 'Application password revoked.' ), 'success' ).trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } ).fail( handleErrorResponse );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,7 +133,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $appPassSection.children( '.new-application-password' ).remove();
</span><span class="cx" style="display: block; padding: 0 10px"> $appPassTwrapper.hide();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- addNotice( wp.i18n.__( 'All application passwords revoked.' ), 'success' ).focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ addNotice( wp.i18n.__( 'All application passwords revoked.' ), 'success' ).trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } ).fail( handleErrorResponse );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -145,7 +145,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $el.fadeTo( 100, 0, function () {
</span><span class="cx" style="display: block; padding: 0 10px"> $el.slideUp( 100, function () {
</span><span class="cx" style="display: block; padding: 0 10px"> $el.remove();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $newAppPassField.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $newAppPassField.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span></span></pre></div>
<a id="trunksrcjs_enqueuesadminprivacytoolsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/privacy-tools.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/privacy-tools.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/_enqueues/admin/privacy-tools.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -72,7 +72,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $rowActions.addClass( 'processing' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $action.blur();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $action.trigger( 'blur' );
</ins><span class="cx" style="display: block; padding: 0 10px"> clearResultsAfterRow( $requestRow );
</span><span class="cx" style="display: block; padding: 0 10px"> setExportProgress( 0 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -177,7 +177,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $rowActions.addClass( 'processing' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $action.blur();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $action.trigger( 'blur' );
</ins><span class="cx" style="display: block; padding: 0 10px"> clearResultsAfterRow( $requestRow );
</span><span class="cx" style="display: block; padding: 0 10px"> setErasureProgress( 0 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcjs_enqueuesadminsitehealthjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/site-health.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/site-health.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/_enqueues/admin/site-health.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,7 +24,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Clear the selection and move focus back to the trigger.
</span><span class="cx" style="display: block; padding: 0 10px"> e.clearSelection();
</span><span class="cx" style="display: block; padding: 0 10px"> // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- triggerElement.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ triggerElement.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Show success visual feedback.
</span><span class="cx" style="display: block; padding: 0 10px"> clearTimeout( successTimeout );
</span></span></pre></div>
<a id="trunksrcjs_enqueuesadminxfnjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/xfn.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/xfn.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/_enqueues/admin/xfn.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,7 +6,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( document ).ready(function( $ ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $( '#link_rel' ).prop( 'readonly', true );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '#linkxfndiv input' ).bind( 'click keyup', function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '#linkxfndiv input' ).on( 'click keyup', function() {
</ins><span class="cx" style="display: block; padding: 0 10px"> var isMe = $( '#me' ).is( ':checked' ), inputs = '';
</span><span class="cx" style="display: block; padding: 0 10px"> $( 'input.valinp' ).each( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isMe ) {
</span></span></pre></div>
<a id="trunksrcjs_enqueueslibpointerjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/lib/pointer.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/lib/pointer.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/_enqueues/lib/pointer.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19,7 +19,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> buttons: function( event, t ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var button = $('<a class="close" href="#"></a>').text( wp.i18n.__( 'Dismiss' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return button.bind( 'click.pointer', function(e) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return button.on( 'click.pointer', function(e) {
</ins><span class="cx" style="display: block; padding: 0 10px"> e.preventDefault();
</span><span class="cx" style="display: block; padding: 0 10px"> t.element.pointer('close');
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span></span></pre></div>
<a id="trunksrcjs_enqueuesvendorthickboxthickboxjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/vendor/thickbox/thickbox.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/vendor/thickbox/thickbox.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/_enqueues/vendor/thickbox/thickbox.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,7 +35,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var a = this.href || this.alt;
</span><span class="cx" style="display: block; padding: 0 10px"> var g = this.rel || false;
</span><span class="cx" style="display: block; padding: 0 10px"> tb_show(t,a,g);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.blur();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.trigger( 'blur' );
</ins><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,12 +49,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("html").css("overflow","hidden");
</span><span class="cx" style="display: block; padding: 0 10px"> if (document.getElementById("TB_HideSelect") === null) {//iframe to hide select elements in ie6
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("body").append("<iframe id='TB_HideSelect'>"+thickboxL10n.noiframes+"</iframe><div id='TB_overlay'></div><div id='TB_window' class='thickbox-loading'></div>");
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_overlay").click(tb_remove);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_overlay").trigger( 'click', tb_remove );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }else{//all others
</span><span class="cx" style="display: block; padding: 0 10px"> if(document.getElementById("TB_overlay") === null){
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("body").append("<div id='TB_overlay'></div><div id='TB_window' class='thickbox-loading'></div>");
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_overlay").click(tb_remove);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_overlay").trigger( 'click', tb_remove );
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery( 'body' ).addClass( 'modal-open' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -141,17 +141,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> TB_HEIGHT = imageHeight + 60;
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").append("<a href='' id='TB_ImageOff'><span class='screen-reader-text'>"+thickboxL10n.close+"</span><img id='TB_Image' src='"+url+"' width='"+imageWidth+"' height='"+imageHeight+"' alt='"+caption+"'/></a>" + "<div id='TB_caption'>"+caption+"<div id='TB_secondLine'>" + TB_imageCount + TB_PrevHTML + TB_NextHTML + "</div></div><div id='TB_closeWindow'><button type='button' id='TB_closeWindowButton'><span class='screen-reader-text'>"+thickboxL10n.close+"</span><span class='tb-close-icon'></span></button></div>");
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_closeWindowButton").click(tb_remove);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_closeWindowButton").trigger( 'click', tb_remove );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if (!(TB_PrevHTML === "")) {
</span><span class="cx" style="display: block; padding: 0 10px"> function goPrev(){
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if(jQuery(document).unbind("click",goPrev)){jQuery(document).unbind("click",goPrev);}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if(jQuery(document).off("click",goPrev)){jQuery(document).off("click",goPrev);}
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").remove();
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("body").append("<div id='TB_window'></div>");
</span><span class="cx" style="display: block; padding: 0 10px"> tb_show(TB_PrevCaption, TB_PrevURL, imageGroup);
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_prev").click(goPrev);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_prev").trigger( 'click', goPrev );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if (!(TB_NextHTML === "")) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -161,22 +161,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> tb_show(TB_NextCaption, TB_NextURL, imageGroup);
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_next").click(goNext);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_next").trigger( 'click', goNext );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery(document).bind('keydown.thickbox', function(e){
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery(document).on('keydown.thickbox', function(e){
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( e.which == 27 ){ // close
</span><span class="cx" style="display: block; padding: 0 10px"> tb_remove();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( e.which == 190 ){ // display previous image
</span><span class="cx" style="display: block; padding: 0 10px"> if(!(TB_NextHTML == "")){
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery(document).unbind('thickbox');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery(document).off('thickbox');
</ins><span class="cx" style="display: block; padding: 0 10px"> goNext();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( e.which == 188 ){ // display next image
</span><span class="cx" style="display: block; padding: 0 10px"> if(!(TB_PrevHTML == "")){
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery(document).unbind('thickbox');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery(document).off('thickbox');
</ins><span class="cx" style="display: block; padding: 0 10px"> goPrev();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -185,7 +185,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> tb_position();
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_load").remove();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_ImageOff").click(tb_remove);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_ImageOff").trigger( 'click', tb_remove );
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").css({'visibility':'visible'}); //for safari using css instead of show
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -206,7 +206,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if(params['modal'] != "true"){//iframe no modal
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").append("<div id='TB_title'><div id='TB_ajaxWindowTitle'>"+caption+"</div><div id='TB_closeAjaxWindow'><button type='button' id='TB_closeWindowButton'><span class='screen-reader-text'>"+thickboxL10n.close+"</span><span class='tb-close-icon'></span></button></div></div><iframe frameborder='0' hspace='0' allowtransparency='true' src='"+urlNoQuery[0]+"' id='TB_iframeContent' name='TB_iframeContent"+Math.round(Math.random()*1000)+"' onload='tb_showIframe()' style='width:"+(ajaxContentW + 29)+"px;height:"+(ajaxContentH + 17)+"px;' >"+thickboxL10n.noiframes+"</iframe>");
</span><span class="cx" style="display: block; padding: 0 10px"> }else{//iframe modal
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_overlay").unbind();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_overlay").off();
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").append("<iframe frameborder='0' hspace='0' allowtransparency='true' src='"+urlNoQuery[0]+"' id='TB_iframeContent' name='TB_iframeContent"+Math.round(Math.random()*1000)+"' onload='tb_showIframe()' style='width:"+(ajaxContentW + 29)+"px;height:"+(ajaxContentH + 17)+"px;'>"+thickboxL10n.noiframes+"</iframe>");
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }else{// not an iframe, ajax
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -214,7 +214,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if(params['modal'] != "true"){//ajax no modal
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").append("<div id='TB_title'><div id='TB_ajaxWindowTitle'>"+caption+"</div><div id='TB_closeAjaxWindow'><button type='button' id='TB_closeWindowButton'><span class='screen-reader-text'>"+thickboxL10n.close+"</span><span class='tb-close-icon'></span></button></div></div><div id='TB_ajaxContent' style='width:"+ajaxContentW+"px;height:"+ajaxContentH+"px'></div>");
</span><span class="cx" style="display: block; padding: 0 10px"> }else{//ajax modal
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_overlay").unbind();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_overlay").off();
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_window").append("<div id='TB_ajaxContent' class='TB_modal' style='width:"+ajaxContentW+"px;height:"+ajaxContentH+"px;'></div>");
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }else{//this means the window is already up, we are just loading new content via ajax
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -225,11 +225,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_closeWindowButton").click(tb_remove);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_closeWindowButton").trigger( 'click', tb_remove );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if(url.indexOf('TB_inline') != -1){
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("#TB_ajaxContent").append(jQuery('#' + params['inlineId']).children());
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_window").bind('tb_unload', function () {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_window").on('tb_unload', function () {
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery('#' + params['inlineId']).append( jQuery("#TB_ajaxContent").children() ); // move elements back when you're finished
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> tb_position();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -253,7 +253,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if(!params['modal']){
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery(document).bind('keydown.thickbox', function(e){
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery(document).on('keydown.thickbox', function(e){
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( e.which == 27 ){ // close
</span><span class="cx" style="display: block; padding: 0 10px"> tb_remove();
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -268,7 +268,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * In other admin screens is hidden and replaced by a different icon.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $closeBtn.find( '.tb-close-icon' ).is( ':visible' ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $closeBtn.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $closeBtn.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> } catch(e) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -283,10 +283,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function tb_remove() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery("#TB_imageOff").unbind("click");
- jQuery("#TB_closeWindowButton").unbind("click");
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery("#TB_imageOff").off("click");
+ jQuery("#TB_closeWindowButton").off("click");
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery( '#TB_window' ).fadeOut( 'fast', function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery( '#TB_window, #TB_overlay, #TB_HideSelect' ).trigger( 'tb_unload' ).unbind().remove();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery( '#TB_window, #TB_overlay, #TB_HideSelect' ).trigger( 'tb_unload' ).off().remove();
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery( 'body' ).trigger( 'thickbox:removed' );
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( 'body' ).removeClass( 'modal-open' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -295,7 +295,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("body","html").css({height: "auto", width: "auto"});
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery("html").css("overflow","");
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery(document).unbind('.thickbox');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery(document).off('.thickbox');
</ins><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcjsmediaviewsattachmentdetailsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/media/views/attachment/details.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/media/views/attachment/details.js 2021-02-16 20:22:36 UTC (rev 50366)
+++ trunk/src/js/media/views/attachment/details.js 2021-02-16 20:23:19 UTC (rev 50367)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,7 +48,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Clear the selection and move focus back to the trigger.
</span><span class="cx" style="display: block; padding: 0 10px"> event.clearSelection();
</span><span class="cx" style="display: block; padding: 0 10px"> // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- triggerElement.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ triggerElement.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Show success visual feedback.
</span><span class="cx" style="display: block; padding: 0 10px"> clearTimeout( successTimeout );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -105,18 +105,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> moveFocus: function() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( this.previousAttachment.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.previousAttachment.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.previousAttachment.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( this.nextAttachment.length ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.nextAttachment.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.nextAttachment.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fallback: move focus to the "Select Files" button in the media modal.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( this.controller.uploader && this.controller.uploader.$browser ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.controller.uploader.$browser.focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.controller.uploader.$browser.trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,7 +133,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Last fallback: make the frame focusable and move focus to it.
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.media-frame' )
</span><span class="cx" style="display: block; padding: 0 10px"> .attr( 'tabindex', '-1' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .focus();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .trigger( 'focus' );
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>