<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[50120] trunk/src: Posts, Post Types: Introduce "Filter by date" and "Filter by category" as post type and taxonomy labels, respectively.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/50120">50120</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/50120","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-02-01 14:11:57 +0000 (Mon, 01 Feb 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Posts, Post Types: Introduce "Filter by date" and "Filter by category" as post type and taxonomy labels, respectively.
This provides a more consistent location for these strings and allows for reusing them in other places without hardcoding them in the markup.
Props nicolalaserra, audrasjb, johnjamesjacoby, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/42421">#42421</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswplinkslisttablephp">trunk/src/wp-admin/includes/class-wp-links-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunksrcwpincludespostphp">trunk/src/wp-includes/post.php</a></li>
<li><a href="#trunksrcwpincludestaxonomyphp">trunk/src/wp-includes/taxonomy.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswplinkslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-links-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-links-list-table.php 2021-02-01 11:53:16 UTC (rev 50119)
+++ trunk/src/wp-admin/includes/class-wp-links-list-table.php 2021-02-01 14:11:57 UTC (rev 50120)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -114,7 +114,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'orderby' => 'name',
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo '<label class="screen-reader-text" for="cat_id">' . __( 'Filter by category' ) . '</label>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo '<label class="screen-reader-text" for="cat_id">' . get_taxonomy( 'link_category' )->labels->filter_by_item . '</label>';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_dropdown_categories( $dropdown_options );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2021-02-01 11:53:16 UTC (rev 50119)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2021-02-01 14:11:57 UTC (rev 50120)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -633,7 +633,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $m = isset( $_GET['m'] ) ? (int) $_GET['m'] : 0;
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label for="filter-by-date" class="screen-reader-text"><?php _e( 'Filter by date' ); ?></label>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label for="filter-by-date" class="screen-reader-text"><?php echo get_post_type_object( $post_type )->labels->filter_by_date; ?></label>
</ins><span class="cx" style="display: block; padding: 0 10px"> <select name="m" id="filter-by-date">
</span><span class="cx" style="display: block; padding: 0 10px"> <option<?php selected( $m, 0 ); ?> value="0"><?php _e( 'All dates' ); ?></option>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2021-02-01 11:53:16 UTC (rev 50119)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2021-02-01 14:11:57 UTC (rev 50120)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -456,7 +456,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'selected' => $cat,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo '<label class="screen-reader-text" for="cat">' . __( 'Filter by category' ) . '</label>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo '<label class="screen-reader-text" for="cat">' . get_taxonomy( 'category' )->labels->filter_by_item . '</label>';
+
</ins><span class="cx" style="display: block; padding: 0 10px"> wp_dropdown_categories( $dropdown_options );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post.php 2021-02-01 11:53:16 UTC (rev 50119)
+++ trunk/src/wp-includes/post.php 2021-02-01 14:11:57 UTC (rev 50120)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1689,6 +1689,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * - `menu_name` - Label for the menu name. Default is the same as `name`.
</span><span class="cx" style="display: block; padding: 0 10px"> * - `filter_items_list` - Label for the table views hidden heading. Default is 'Filter posts list' /
</span><span class="cx" style="display: block; padding: 0 10px"> * 'Filter pages list'.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * - `filter_by_date` - Label for the date filter in list tables. Default is 'Filter by date'.
</ins><span class="cx" style="display: block; padding: 0 10px"> * - `items_list_navigation` - Label for the table pagination hidden heading. Default is 'Posts list navigation' /
</span><span class="cx" style="display: block; padding: 0 10px"> * 'Pages list navigation'.
</span><span class="cx" style="display: block; padding: 0 10px"> * - `items_list` - Label for the table hidden heading. Default is 'Posts list' / 'Pages list'.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1715,6 +1716,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7.0 Added the `view_items` and `attributes` labels.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0 Added the `item_published`, `item_published_privately`, `item_reverted_to_draft`,
</span><span class="cx" style="display: block; padding: 0 10px"> * `item_scheduled`, and `item_updated` labels.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 5.7.0 Added the `filter_by_date` label.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @access private
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1745,6 +1747,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'remove_featured_image' => array( _x( 'Remove featured image', 'post' ), _x( 'Remove featured image', 'page' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'use_featured_image' => array( _x( 'Use as featured image', 'post' ), _x( 'Use as featured image', 'page' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'filter_items_list' => array( __( 'Filter posts list' ), __( 'Filter pages list' ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'filter_by_date' => array( __( 'Filter by date' ), __( 'Filter by date' ) ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'items_list_navigation' => array( __( 'Posts list navigation' ), __( 'Pages list navigation' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'items_list' => array( __( 'Posts list' ), __( 'Pages list' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'item_published' => array( __( 'Post published.' ), __( 'Page published.' ) ),
</span></span></pre></div>
<a id="trunksrcwpincludestaxonomyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/taxonomy.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/taxonomy.php 2021-02-01 11:53:16 UTC (rev 50119)
+++ trunk/src/wp-includes/taxonomy.php 2021-02-01 14:11:57 UTC (rev 50120)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -537,6 +537,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.3.0 Added the `no_terms` label.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.4.0 Added the `items_list_navigation` and `items_list` labels.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.9.0 Added the `most_used` and `back_to_items` labels.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 5.7.0 Added the `filter_by_item` label.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Taxonomy $tax Taxonomy object.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return object {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -569,6 +570,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * the meta box and taxonomy list table.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $no_terms Default 'No tags'/'No categories', used in the posts and media
</span><span class="cx" style="display: block; padding: 0 10px"> * list tables.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type string $filter_by_item This label is only used for hierarchical taxonomies. Default
+ * 'Filter by category', used in the posts list table.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type string $items_list_navigation Label for the table pagination hidden heading.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $items_list Label for the table hidden heading.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $most_used Title for the Most Used tab. Default 'Most Used'.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -604,6 +607,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'choose_from_most_used' => array( __( 'Choose from the most used tags' ), null ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'not_found' => array( __( 'No tags found.' ), __( 'No categories found.' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'no_terms' => array( __( 'No tags' ), __( 'No categories' ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'filter_by_item' => array( null, __( 'Filter by category' ) ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'items_list_navigation' => array( __( 'Tags list navigation' ), __( 'Categories list navigation' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'items_list' => array( __( 'Tags list' ), __( 'Categories list' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Tab heading when selecting from the most used terms. */
</span></span></pre>
</div>
</div>
</body>
</html>