<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[50067] trunk/src/js/media/models: Media: Remove caching from filter by date in media library.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/50067">50067</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/50067","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>antpb</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-01-29 01:34:05 +0000 (Fri, 29 Jan 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Remove caching from filter by date in media library.
Previously, newly uploaded media attachments were missing when filtering media items by date due to lack of cache invalidation.
Props adamsilverstein, teamdnk, afercia, Mista-Flo, joedolson, youknowriad, talldanwp.
Fixes <a href="https://core.trac.wordpress.org/ticket/50025">#50025</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjsmediamodelsattachmentsjs">trunk/src/js/media/models/attachments.js</a></li>
<li><a href="#trunksrcjsmediamodelsqueryjs">trunk/src/js/media/models/query.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjsmediamodelsattachmentsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/media/models/attachments.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/media/models/attachments.js 2021-01-29 00:25:34 UTC (rev 50066)
+++ trunk/src/js/media/models/attachments.js 2021-01-29 01:34:05 UTC (rev 50067)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -390,7 +390,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var props;
</span><span class="cx" style="display: block; padding: 0 10px"> if ( this.props.get('query') ) {
</span><span class="cx" style="display: block; padding: 0 10px"> props = this.props.toJSON();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- props.cache = ( true !== refresh );
</del><span class="cx" style="display: block; padding: 0 10px"> this.mirror( wp.media.model.Query.get( props ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span></span></pre></div>
<a id="trunksrcjsmediamodelsqueryjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/media/models/query.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/media/models/query.js 2021-01-29 00:25:34 UTC (rev 50066)
+++ trunk/src/js/media/models/query.js 2021-01-29 01:34:05 UTC (rev 50067)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -213,7 +213,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @method
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {object} [props]
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param {Object} [props.cache=true] Whether to use the query cache or not.
</del><span class="cx" style="display: block; padding: 0 10px"> * @param {Object} [props.order]
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {Object} [props.orderby]
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {Object} [props.include]
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -243,13 +242,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var args = {},
</span><span class="cx" style="display: block; padding: 0 10px"> orderby = Query.orderby,
</span><span class="cx" style="display: block; padding: 0 10px"> defaults = Query.defaultProps,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- query,
- cache = !! props.cache || _.isUndefined( props.cache );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ query;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Remove the `query` property. This isn't linked to a query,
</span><span class="cx" style="display: block; padding: 0 10px"> // this *is* the query.
</span><span class="cx" style="display: block; padding: 0 10px"> delete props.query;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- delete props.cache;
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fill default args.
</span><span class="cx" style="display: block; padding: 0 10px"> _.defaults( props, defaults );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -288,14 +285,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Substitute exceptions specified in orderby.keymap.
</span><span class="cx" style="display: block; padding: 0 10px"> args.orderby = orderby.valuemap[ props.orderby ] || props.orderby;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Search the query cache for a matching query.
- if ( cache ) {
- query = _.find( queries, function( query ) {
- return _.isEqual( query.args, args );
- });
- } else {
- queries = [];
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ queries = [];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Otherwise, create a new query and add it to the cache.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! query ) {
</span></span></pre>
</div>
</div>
</body>
</html>