<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[49981] trunk: Blocks: Add i18n support to register_block_type_from_metadata</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/49981">49981</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/49981","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>gziolo</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-01-19 11:04:03 +0000 (Tue, 19 Jan 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Blocks: Add i18n support to register_block_type_from_metadata
Related Gutenberg issue: https://github.com/WordPress/gutenberg/issues/23636.
Related WP-CLI PR: https://github.com/wp-cli/i18n-command/pull/210.
Related documentation proposal: https://github.com/WordPress/gutenberg/blob/master/docs/designers-developers/developers/block-api/block-metadata.md#internationalization-not-implemented
Adds programatic i18n support to `register_block_type_from_metadata` function for block settings registered from `block.json` file that provides `textdomain` field.
Props swissspidy, ocean90.
Fixes <a href="https://core.trac.wordpress.org/ticket/52301">#52301</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesblocksphp">trunk/src/wp-includes/blocks.php</a></li>
<li><a href="#trunktestsphpunittestsblocksregisterphp">trunk/tests/phpunit/tests/blocks/register.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>trunk/tests/phpunit/data/blocks/notice/</li>
<li><a href="#trunktestsphpunitdatablocksnoticeblockassetphp">trunk/tests/phpunit/data/blocks/notice/block.asset.php</a></li>
<li><a href="#trunktestsphpunitdatablocksnoticeblockcss">trunk/tests/phpunit/data/blocks/notice/block.css</a></li>
<li><a href="#trunktestsphpunitdatablocksnoticeblockjs">trunk/tests/phpunit/data/blocks/notice/block.js</a></li>
<li><a href="#trunktestsphpunitdatablocksnoticeblockjson">trunk/tests/phpunit/data/blocks/notice/block.json</a></li>
<li><a href="#trunktestsphpunitdatalanguagespluginsnoticepl_PLmo">trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.mo</a></li>
<li><a href="#trunktestsphpunitdatalanguagespluginsnoticepl_PLpo">trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.po</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li>trunk/tests/phpunit/tests/blocks/fixtures/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesblocksphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/blocks.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/blocks.php 2021-01-18 17:51:58 UTC (rev 49980)
+++ trunk/src/wp-includes/blocks.php 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -134,7 +134,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $script_asset['dependencies'],
</span><span class="cx" style="display: block; padding: 0 10px"> $script_asset['version']
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return $result ? $script_handle : false;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $result ) {
+ return false;
+ }
+
+ if ( ! empty( $metadata['textdomain'] ) ) {
+ wp_set_script_translations( $script_handle, $metadata['textdomain'] );
+ }
+
+ return $script_handle;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -229,7 +237,48 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $property_mappings as $key => $mapped_key ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $metadata[ $key ] ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $settings[ $mapped_key ] = $metadata[ $key ];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $value = $metadata[ $key ];
+ if ( empty( $metadata['textdomain'] ) ) {
+ $settings[ $mapped_key ] = $value;
+ continue;
+ }
+ $textdomain = $metadata['textdomain'];
+ switch ( $key ) {
+ case 'title':
+ case 'description':
+ // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralContext,WordPress.WP.I18n.NonSingularStringLiteralDomain
+ $settings[ $mapped_key ] = translate_with_gettext_context( $value, sprintf( 'block %s', $key ), $textdomain );
+ break;
+ case 'keywords':
+ $settings[ $mapped_key ] = array();
+ if ( ! is_array( $value ) ) {
+ continue 2;
+ }
+
+ foreach ( $value as $keyword ) {
+ // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralDomain
+ $settings[ $mapped_key ][] = translate_with_gettext_context( $keyword, 'block keyword', $textdomain );
+ }
+
+ break;
+ case 'styles':
+ $settings[ $mapped_key ] = array();
+ if ( ! is_array( $value ) ) {
+ continue 2;
+ }
+
+ foreach ( $value as $style ) {
+ if ( ! empty( $style['label'] ) ) {
+ // phpcs:ignore WordPress.WP.I18n.LowLevelTranslationFunction,WordPress.WP.I18n.NonSingularStringLiteralText,WordPress.WP.I18n.NonSingularStringLiteralDomain
+ $style['label'] = translate_with_gettext_context( $style['label'], 'block style label', $textdomain );
+ }
+ $settings[ $mapped_key ][] = $style;
+ }
+
+ break;
+ default:
+ $settings[ $mapped_key ] = $value;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunitdatablocksnoticeblockassetphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/data/blocks/notice/block.asset.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/data/blocks/notice/block.asset.php (rev 0)
+++ trunk/tests/phpunit/data/blocks/notice/block.asset.php 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,6 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+return array(
+ 'dependencies' => array(),
+ 'version' => 'test',
+);
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/data/blocks/notice/block.asset.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunitdatablocksnoticeblockcss"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/data/blocks/notice/block.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/data/blocks/notice/block.css (rev 0)
+++ trunk/tests/phpunit/data/blocks/notice/block.css 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* Test CSS file */
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/data/blocks/notice/block.css
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunitdatablocksnoticeblockjs"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/data/blocks/notice/block.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/data/blocks/notice/block.js (rev 0)
+++ trunk/tests/phpunit/data/blocks/notice/block.js 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* Test JavaScript file. */
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/data/blocks/notice/block.js
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunitdatablocksnoticeblockjson"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/data/blocks/notice/block.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/data/blocks/notice/block.json (rev 0)
+++ trunk/tests/phpunit/data/blocks/notice/block.json 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,53 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+{
+ "apiVersion": 2,
+ "name": "tests/notice",
+ "title": "Notice",
+ "category": "common",
+ "parent": [
+ "core/group"
+ ],
+ "providesContext": {
+ "tests/message": "message"
+ },
+ "usesContext": [
+ "groupId"
+ ],
+ "icon": "star",
+ "description": "Shows warning, error or success notices…",
+ "keywords": [
+ "alert",
+ "message"
+ ],
+ "textdomain": "notice",
+ "attributes": {
+ "message": {
+ "type": "string",
+ "source": "html",
+ "selector": ".message"
+ }
+ },
+ "supports": {
+ "align": true,
+ "lightBlockWrapper": true
+ },
+ "styles": [
+ {
+ "name": "default",
+ "label": "Default",
+ "isDefault": true
+ },
+ {
+ "name": "other",
+ "label": "Other"
+ }
+ ],
+ "example": {
+ "attributes": {
+ "message": "This is a notice!"
+ }
+ },
+ "editorScript": "tests-notice-editor-script",
+ "script": "tests-notice-script",
+ "editorStyle": "tests-notice-editor-style",
+ "style": "tests-notice-style"
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/data/blocks/notice/block.json
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunitdatalanguagespluginsnoticepl_PLmo"></a>
<div class="binary"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.mo</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx" style="display: block; padding: 0 10px">Index: trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.mo
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.mo 2021-01-18 17:51:58 UTC (rev 49980)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.mo 2021-01-19 11:04:03 UTC (rev 49981)
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.mo
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:mime-type</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+application/octet-stream
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunitdatalanguagespluginsnoticepl_PLpo"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.po</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.po (rev 0)
+++ trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.po 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,43 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+msgid ""
+msgstr ""
+"Project-Id-Version: \n"
+"POT-Creation-Date: 2015-12-31 16:31+0100\n"
+"PO-Revision-Date: 2021-01-14 18:26+0100\n"
+"Language: pl_PL\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"X-Generator: Poedit 2.4.2\n"
+"X-Poedit-Basepath: .\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Poedit-KeywordsList: __;_e;_x:1,2c;_ex:1,2c;_n:1,2;_nx:1,2,4c;_n_noop:1,2;"
+"_nx_noop:1,2,3c;esc_attr__;esc_html__;esc_attr_e;esc_html_e;esc_attr_x:1,2c;"
+"esc_html_x:1,2c\n"
+"X-Textdomain-Support: yes\n"
+"Last-Translator: \n"
+"Language-Team: \n"
+"X-Poedit-SearchPath-0: .\n"
+
+msgctxt "block title"
+msgid "Notice"
+msgstr "Powiadomienie"
+
+msgctxt "block description"
+msgid "Shows warning, error or success notices…"
+msgstr "Wyświetla ostrzeżenie, błąd lub powiadomienie o sukcesie…"
+
+msgctxt "block keyword"
+msgid "alert"
+msgstr "ostrzeżenie"
+
+msgctxt "block keyword"
+msgid "message"
+msgstr "wiadomość"
+
+msgctxt "block style label"
+msgid "Default"
+msgstr "Domyślny"
+
+msgctxt "block style label"
+msgid "Other"
+msgstr "Inny"
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/data/languages/plugins/notice-pl_PL.po
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunittestsblocksregisterphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/blocks/register.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/blocks/register.php 2021-01-18 17:51:58 UTC (rev 49980)
+++ trunk/tests/phpunit/tests/blocks/register.php 2021-01-19 11:04:03 UTC (rev 49981)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -62,7 +62,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $registry = WP_Block_Type_Registry::get_instance();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( array( 'core/test-static', 'core/test-dynamic', 'my-plugin/notice' ) as $block_name ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( array( 'core/test-static', 'core/test-dynamic', 'tests/notice' ) as $block_name ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $registry->is_registered( $block_name ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $registry->unregister( $block_name );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -193,7 +193,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $metadata = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'file' => __FILE__,
</span><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'unit-tests/test-block',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'script' => 'file:./fixtures/missing-asset.js',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'script' => 'file:./blocks/notice/missing-asset.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $result = register_block_script_handle( $metadata, 'script' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -217,9 +217,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_success_register_block_script_handle() {
</span><span class="cx" style="display: block; padding: 0 10px"> $metadata = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'file' => __FILE__,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'file' => DIR_TESTDATA . '/blocks/notice/block.json',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'unit-tests/test-block',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'script' => 'file:./fixtures/block.js',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'script' => 'file:./block.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $result = register_block_script_handle( $metadata, 'script' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -262,9 +262,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_success_register_block_style_handle() {
</span><span class="cx" style="display: block; padding: 0 10px"> $metadata = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'file' => __FILE__,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'file' => DIR_TESTDATA . '/blocks/notice/block.json',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'unit-tests/test-block',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'style' => 'file:./fixtures/block.css',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'style' => 'file:./block.css',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $result = register_block_style_handle( $metadata, 'style' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -303,12 +303,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_block_registers_with_metadata_fixture() {
</span><span class="cx" style="display: block; padding: 0 10px"> $result = register_block_type_from_metadata(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- __DIR__ . '/fixtures'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ DIR_TESTDATA . '/blocks/notice'
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertInstanceOf( 'WP_Block_Type', $result );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 2, $result->api_version );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( 'my-plugin/notice', $result->name );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( 'tests/notice', $result->name );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'Notice', $result->title );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 'common', $result->category );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSameSets( array( 'core/group' ), $result->parent );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -327,7 +327,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'my-plugin/message' => 'message',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'tests/message' => 'message',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> $result->provides_context
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -361,13 +361,51 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> $result->example
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( 'my-plugin-notice-editor-script', $result->editor_script );
- $this->assertSame( 'my-plugin-notice-script', $result->script );
- $this->assertSame( 'my-plugin-notice-editor-style', $result->editor_style );
- $this->assertSame( 'my-plugin-notice-style', $result->style );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( 'tests-notice-editor-script', $result->editor_script );
+ $this->assertSame( 'tests-notice-script', $result->script );
+ $this->assertSame( 'tests-notice-editor-style', $result->editor_style );
+ $this->assertSame( 'tests-notice-style', $result->style );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 52301
+ */
+ function test_block_registers_with_metadata_i18n_support() {
+ function filter_set_locale_to_polish() {
+ return 'pl_PL';
+ }
+ add_filter( 'locale', 'filter_set_locale_to_polish' );
+ load_textdomain( 'notice', WP_LANG_DIR . '/plugins/notice-pl_PL.mo' );
+
+ $result = register_block_type_from_metadata(
+ DIR_TESTDATA . '/blocks/notice'
+ );
+
+ unload_textdomain( 'notice' );
+ remove_filter( 'locale', 'filter_set_locale_to_polish' );
+
+ $this->assertInstanceOf( 'WP_Block_Type', $result );
+ $this->assertSame( 'tests/notice', $result->name );
+ $this->assertSame( 'Powiadomienie', $result->title );
+ $this->assertSame( 'Wyświetla ostrzeżenie, błąd lub powiadomienie o sukcesie…', $result->description );
+ $this->assertSameSets( array( 'ostrzeżenie', 'wiadomość' ), $result->keywords );
+ $this->assertSame(
+ array(
+ array(
+ 'name' => 'default',
+ 'label' => 'Domyślny',
+ 'isDefault' => true,
+ ),
+ array(
+ 'name' => 'other',
+ 'label' => 'Inny',
+ ),
+ ),
+ $result->styles
+ );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 45109
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_get_dynamic_block_names() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -433,7 +471,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'block_type_metadata', $filter_metadata_registration, 10, 2 );
</span><span class="cx" style="display: block; padding: 0 10px"> $result = register_block_type_from_metadata(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- __DIR__ . '/fixtures'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ DIR_TESTDATA . '/blocks/notice'
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> remove_filter( 'block_type_metadata', $filter_metadata_registration );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -451,7 +489,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'block_type_metadata_settings', $filter_metadata_registration, 10, 2 );
</span><span class="cx" style="display: block; padding: 0 10px"> $result = register_block_type_from_metadata(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- __DIR__ . '/fixtures'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ DIR_TESTDATA . '/blocks/notice'
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> remove_filter( 'block_type_metadata_settings', $filter_metadata_registration );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>