<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[49549] trunk/src: App Passwords: Further accessibility improvements.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/49549">49549</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/49549","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>TimothyBlynJacobs</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-11-09 18:03:57 +0000 (Mon, 09 Nov 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>App Passwords: Further accessibility improvements.
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.
Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes <a href="https://core.trac.wordpress.org/ticket/51580">#51580</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminapplicationpasswordsjs">trunk/src/js/_enqueues/admin/application-passwords.js</a></li>
<li><a href="#trunksrcjs_enqueuesadminauthappjs">trunk/src/js/_enqueues/admin/auth-app.js</a></li>
<li><a href="#trunksrcwpadminauthorizeapplicationphp">trunk/src/wp-admin/authorize-application.php</a></li>
<li><a href="#trunksrcwpadmincssformscss">trunk/src/wp-admin/css/forms.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswpapplicationpasswordslisttablephp">trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php</a></li>
<li><a href="#trunksrcwpadminusereditphp">trunk/src/wp-admin/user-edit.php</a></li>
<li><a href="#trunksrcwpincludesscriptloaderphp">trunk/src/wp-includes/script-loader.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminapplicationpasswordsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/application-passwords.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/application-passwords.js 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/js/_enqueues/admin/application-passwords.js 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -29,7 +29,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- clearErrors();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clearNotices();
</ins><span class="cx" style="display: block; padding: 0 10px"> $newAppPassButton.prop( 'aria-disabled', true ).addClass( 'disabled' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> var request = {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -90,7 +90,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $tr = $submitButton.closest( 'tr' ),
</span><span class="cx" style="display: block; padding: 0 10px"> uuid = $tr.data( 'uuid' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- clearErrors();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clearNotices();
</ins><span class="cx" style="display: block; padding: 0 10px"> $submitButton.prop( 'disabled', true );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp.apiRequest( {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -105,7 +105,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $tr.remove();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp.a11y.speak( wp.i18n.__( 'Application password revoked.' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ addNotice( wp.i18n.__( 'Application password revoked.' ), 'success' ).focus();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } ).fail( handleErrorResponse );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -119,7 +119,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> var $submitButton = $( this );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- clearErrors();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ clearNotices();
</ins><span class="cx" style="display: block; padding: 0 10px"> $submitButton.prop( 'disabled', true );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp.apiRequest( {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,17 +133,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $appPassSection.children( '.new-application-password' ).remove();
</span><span class="cx" style="display: block; padding: 0 10px"> $appPassTwrapper.hide();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp.a11y.speak( wp.i18n.__( 'All application passwords revoked.' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ addNotice( wp.i18n.__( 'All application passwords revoked.' ), 'success' ).focus();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } ).fail( handleErrorResponse );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( document ).on( 'click', '.new-application-password-notice .notice-dismiss', function( e ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $appPassSection.on( 'click', '.notice-dismiss', function( e ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> e.preventDefault();
</span><span class="cx" style="display: block; padding: 0 10px"> var $el = $( this ).parent();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $el.removeAttr( 'role' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $el.fadeTo( 100, 0, function () {
</span><span class="cx" style="display: block; padding: 0 10px"> $el.slideUp( 100, function () {
</span><span class="cx" style="display: block; padding: 0 10px"> $el.remove();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $newAppPassField.focus();
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -169,31 +171,42 @@
</span><span class="cx" style="display: block; padding: 0 10px"> errorMessage = xhr.responseJSON.message;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- addError( errorMessage );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ addNotice( errorMessage, 'error' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Displays an error message in the Application Passwords section.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Displays a message in the Application Passwords section.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.6.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param {string} message The error message to display.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param {string} message The message to display.
+ * @param {string} type The notice type. Either 'success' or 'error'.
+ * @returns {jQuery} The notice element.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function addError( message ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function addNotice( message, type ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> var $notice = $( '<div></div>' )
</span><span class="cx" style="display: block; padding: 0 10px"> .attr( 'role', 'alert' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .addClass( 'notice notice-error' )
- .append( $( '<p></p>' ).text( message ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .attr( 'tabindex', '-1' )
+ .addClass( 'is-dismissible notice notice-' + type )
+ .append( $( '<p></p>' ).text( message ) )
+ .append(
+ $( '<button></button>' )
+ .attr( 'type', 'button' )
+ .addClass( 'notice-dismiss' )
+ .append( $( '<span></span>' ).addClass( 'screen-reader-text' ).text( wp.i18n.__( 'Dismiss this notice.' ) ) )
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $newAppPassForm.after( $notice );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ return $notice;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Clears error messages from the Application Passwords section.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Clears notice messages from the Application Passwords section.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.6.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function clearErrors() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function clearNotices() {
</ins><span class="cx" style="display: block; padding: 0 10px"> $( '.notice', $appPassSection ).remove();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }( jQuery ) );
</span></span></pre></div>
<a id="trunksrcjs_enqueuesadminauthappjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/auth-app.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/auth-app.js 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/js/_enqueues/admin/auth-app.js 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -83,15 +83,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> window.location = url;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> message = wp.i18n.sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp.i18n.__( 'Your new password for %1$s is: %2$s.' ),
- '<strong></strong>',
- '<input type="text" class="code" readonly="readonly" value="" />'
- );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* translators: %s: Application name */
+ '<label for="new-application-password-value">' + wp.i18n.__( 'Your new password for %s is:' ) + '</label>',
+ '<strong></strong>'
+ ) + ' <input id="new-application-password-value" type="text" class="code" readonly="readonly" value="" />';
</ins><span class="cx" style="display: block; padding: 0 10px"> $notice = $( '<div></div>' )
</span><span class="cx" style="display: block; padding: 0 10px"> .attr( 'role', 'alert' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .attr( 'tabindex', 0 )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .attr( 'tabindex', -1 )
</ins><span class="cx" style="display: block; padding: 0 10px"> .addClass( 'notice notice-success notice-alt' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .append( $( '<p></p>' ).addClass( 'application-password-display' ).html( message ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .append( $( '<p></p>' ).addClass( 'application-password-display' ).html( message ) )
+ .append( '<p>' + wp.i18n.__( 'Be sure to save this in a safe location. You will not be able to retrieve it.' ) + '</p>' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // We're using .text() to write the variables to avoid any chance of XSS.
</span><span class="cx" style="display: block; padding: 0 10px"> $( 'strong', $notice ).text( name );
</span></span></pre></div>
<a id="trunksrcwpadminauthorizeapplicationphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/authorize-application.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/authorize-application.php 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/wp-admin/authorize-application.php 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -171,15 +171,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $new_password ) : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="notice notice-success notice-alt below-h2">
</span><span class="cx" style="display: block; padding: 0 10px"> <p class="application-password-display">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- printf(
- /* translators: 1: Application name, 2: Generated password. */
- __( 'Your new password for %1$s is %2$s.' ),
- '<strong>' . esc_html( $app_name ) . '</strong>',
- sprintf( '<input type="text" class="code" readonly="readonly" value="%s" />', esc_attr( WP_Application_Passwords::chunk_password( $new_password ) ) )
- );
- ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label for="new-application-password-value">
+ <?php
+ printf(
+ /* translators: %s: Application name */
+ esc_html__( 'Your new password for %s is:' ),
+ '<strong>' . esc_html( $app_name ) . '</strong>'
+ );
+ ?>
+ </label>
+ <input id="new-application-password-value" type="text" class="code" readonly="readonly" value="<?php esc_attr( WP_Application_Passwords::chunk_password( $new_password ) ); ?>" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </p>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p><?php _e( 'Be sure to save this in a safe location. You will not be able to retrieve it.' ); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -204,7 +207,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="form-field">
</span><span class="cx" style="display: block; padding: 0 10px"> <label for="app_name"><?php _e( 'New Application Password Name' ); ?></label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="text" id="app_name" name="app_name" value="<?php echo esc_attr( $app_name ); ?>" placeholder="<?php esc_attr_e( 'WordPress App on My Phone' ); ?>" required aria-required="true" />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="text" id="app_name" name="app_name" value="<?php echo esc_attr( $app_name ); ?>" placeholder="<?php esc_attr_e( 'WordPress App on My Phone' ); ?>" required />
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span></span></pre></div>
<a id="trunksrcwpadmincssformscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/forms.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/forms.css 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/wp-admin/css/forms.css 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -864,7 +864,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-bottom: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.new-application-password-notice.notice {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#application-passwords-section .notice {
</ins><span class="cx" style="display: block; padding: 0 10px"> margin-top: 20px;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-bottom: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -873,6 +873,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> width: 19em;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.auth-app-card.card {
+ max-width: 768px;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /*------------------------------------------------------------------------------
</span><span class="cx" style="display: block; padding: 0 10px"> 19.0 - Tools
</span><span class="cx" style="display: block; padding: 0 10px"> ------------------------------------------------------------------------------*/
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpapplicationpasswordslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/wp-admin/includes/class-wp-application-passwords-list-table.php 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -117,7 +117,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> false,
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: the application password's given name. */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'title' => sprintf( __( 'Revoke "%s"' ), $item['name'] ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'aria-label' => sprintf( __( 'Revoke "%s"' ), $item['name'] ),
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -234,7 +234,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'revoke':
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<input type="submit" class="button delete" value="%1$s" title="%2$s">',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<input type="submit" class="button delete" value="%1$s" aria-label="%2$s">',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_attr( __( 'Revoke' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: the application password's given name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( __( 'Revoke "%s"' ), '{{ data.name }}' ) )
</span></span></pre></div>
<a id="trunksrcwpadminusereditphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/user-edit.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/user-edit.php 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/wp-admin/user-edit.php 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -742,7 +742,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="create-application-password form-wrap">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="form-field">
</span><span class="cx" style="display: block; padding: 0 10px"> <label for="new_application_password_name"><?php _e( 'New Application Password Name' ); ?></label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="text" size="30" id="new_application_password_name" name="new_application_password_name" placeholder="<?php esc_attr_e( 'WordPress App on My Phone' ); ?>" class="input" />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="text" size="30" id="new_application_password_name" name="new_application_password_name" placeholder="<?php esc_attr_e( 'WordPress App on My Phone' ); ?>" class="input" aria-required="true" aria-describedby="<?php esc_attr_e( 'Required to create an Application Password, but not to update the user.' ); ?>" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -756,7 +756,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> do_action( 'wp_create_application_password_form', $profileuser );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php submit_button( __( 'Add New' ), 'secondary', 'do_new_application_password' ); ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <?php submit_button( __( 'Add New Application Password' ), 'secondary', 'do_new_application_password' ); ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="application-passwords-list-table-wrapper">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -857,18 +857,20 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( isset( $application_passwords_list_table ) ) : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <script type="text/html" id="tmpl-new-application-password">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div class="notice notice-success is-dismissible new-application-password-notice" role="alert" tabindex="0">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="notice notice-success is-dismissible new-application-password-notice" role="alert" tabindex="-1">
</ins><span class="cx" style="display: block; padding: 0 10px"> <p class="application-password-display">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- printf(
- /* translators: 1: Application name, 2: Generated password. */
- esc_html__( 'Your new password for %1$s is: %2$s' ),
- '<strong>{{ data.name }}</strong>',
- '<input type="text" class="code" readonly="readonly" value="{{ data.password }}" />'
- );
- ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label for="new-application-password-value">
+ <?php
+ printf(
+ /* translators: %s: Application name */
+ __( 'Your new password for %s is:' ),
+ '<strong>{{ data.name }}</strong>'
+ );
+ ?>
+ </label>
+ <input id="new-application-password-value" type="text" class="code" readonly="readonly" value="{{ data.password }}" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </p>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><?php esc_attr_e( 'Be sure to save this in a safe location. You will not be able to retrieve it.' ); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p><?php _e( 'Be sure to save this in a safe location. You will not be able to retrieve it.' ); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="notice-dismiss">
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="screen-reader-text"><?php _e( 'Dismiss this notice.' ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> </button>
</span></span></pre></div>
<a id="trunksrcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/script-loader.php 2020-11-09 17:29:21 UTC (rev 49548)
+++ trunk/src/wp-includes/script-loader.php 2020-11-09 18:03:57 UTC (rev 49549)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1067,7 +1067,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $scripts->set_translations( 'password-strength-meter' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $scripts->add( 'application-passwords', "/wp-admin/js/application-passwords$suffix.js", array( 'jquery', 'wp-util', 'wp-api-request', 'wp-date', 'wp-i18n', 'wp-hooks', 'wp-a11y' ), false, 1 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $scripts->add( 'application-passwords', "/wp-admin/js/application-passwords$suffix.js", array( 'jquery', 'wp-util', 'wp-api-request', 'wp-date', 'wp-i18n', 'wp-hooks' ), false, 1 );
</ins><span class="cx" style="display: block; padding: 0 10px"> $scripts->set_translations( 'application-passwords' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $scripts->add( 'auth-app', "/wp-admin/js/auth-app$suffix.js", array( 'jquery', 'wp-api-request', 'wp-i18n', 'wp-hooks' ), false, 1 );
</span></span></pre>
</div>
</div>
</body>
</html>