<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[49215] trunk: General: Remove `noreferrer` from `wp_targeted_link_rel()` and other uses.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/49215">49215</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/49215","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-10-19 23:37:53 +0000 (Mon, 19 Oct 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>General: Remove `noreferrer` from `wp_targeted_link_rel()` and other uses.
When `noopener noreferrer` was originally added in <a href="https://core.trac.wordpress.org/ticket/37941">#37941</a> and related tickets, the `noreferrer` bit was specifically included due to Firefox not supporting `noopener` at the time.
Since `noopener` has been supported by all major browsers for a while, it should now be safe to remove the `noreferrer` attribute from core.
Props Mista-Flo, audrasjb, joostdevalk, jonoaldersonwp, peterwilsoncc, elgameel.
Fixes <a href="https://core.trac.wordpress.org/ticket/49558">#49558</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswpsitehealthphp">trunk/src/wp-admin/includes/class-wp-site-health.php</a></li>
<li><a href="#trunksrcwpadminincludesdashboardphp">trunk/src/wp-admin/includes/dashboard.php</a></li>
<li><a href="#trunksrcwpadminincludesmediaphp">trunk/src/wp-admin/includes/media.php</a></li>
<li><a href="#trunksrcwpincludesclasswalkernavmenuphp">trunk/src/wp-includes/class-walker-nav-menu.php</a></li>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
<li><a href="#trunksrcwpincludesformattingphp">trunk/src/wp-includes/formatting.php</a></li>
<li><a href="#trunksrcwpincludesfunctionsphp">trunk/src/wp-includes/functions.php</a></li>
<li><a href="#trunksrcwpincludesmediatemplatephp">trunk/src/wp-includes/media-template.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetcustomhtmlphp">trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgettextphp">trunk/src/wp-includes/widgets/class-wp-widget-text.php</a></li>
<li><a href="#trunksrcwploginphp">trunk/src/wp-login.php</a></li>
<li><a href="#trunktestsphpunittestsformattingWPTargetedLinkRelphp">trunk/tests/phpunit/tests/formatting/WPTargetedLinkRel.php</a></li>
<li><a href="#trunktestsphpunittestsmenuwalkernavmenuphp">trunk/tests/phpunit/tests/menu/walker-nav-menu.php</a></li>
<li><a href="#trunktestsphpunittestsprivacywpPrivacyGeneratePersonalDataExportFilephp">trunk/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php</a></li>
<li><a href="#trunktestsphpunittestsrestapirestattachmentscontrollerphp">trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php</a></li>
<li><a href="#trunktestsphpunittestsrestapirestpostscontrollerphp">trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php</a></li>
<li><a href="#trunktestsphpunittestswidgetscustomhtmlwidgetphp">trunk/tests/phpunit/tests/widgets/custom-html-widget.php</a></li>
<li><a href="#trunktestsphpunittestswidgetsmediaimagewidgetphp">trunk/tests/phpunit/tests/widgets/media-image-widget.php</a></li>
<li><a href="#trunktestsphpunittestswidgetstextwidgetphp">trunk/tests/phpunit/tests/widgets/text-widget.php</a></li>
<li><a href="#trunktestsqunitindexhtml">trunk/tests/qunit/index.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswpsitehealthphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-site-health.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-site-health.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-admin/includes/class-wp-site-health.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -730,7 +730,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'actions' => sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<p><a href="%s" target="_blank" rel="noopener noreferrer">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_url( wp_get_update_php_url() ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Learn more about updating PHP' ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Accessibility text. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -842,7 +842,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'The WordPress Hosting Team maintains a list of those modules, both recommended and required, in <a href="%1$s" %2$s>the team handbook%3$s</a>.' ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Localized team handbook, if one exists. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( __( 'https://make.wordpress.org/hosting/handbook/handbook/server-environment/#php-extensions' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'target="_blank" rel="noopener noreferrer"',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'target="_blank" rel="noopener"',
</ins><span class="cx" style="display: block; padding: 0 10px"> sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> ' <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span>',
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Accessibility text. */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1159,7 +1159,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'The SQL server is a required piece of software for the database WordPress uses to store all your site’s content and settings.' )
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'actions' => sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<p><a href="%s" target="_blank" rel="noopener noreferrer">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: Localized version of WordPress requirements if one exists. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( __( 'https://wordpress.org/about/requirements/' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Learn more about what WordPress requires to run.' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1396,7 +1396,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $result['actions'] = sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<p><a href="%s" target="_blank" rel="noopener noreferrer">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: Localized Support reference. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( __( 'https://wordpress.org/support' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Get help resolving this issue.' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1434,7 +1434,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Debug mode is often enabled to gather more details about an error or site failure, but may contain sensitive information which should not be available on a publicly available website.' )
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'actions' => sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<p><a href="%s" target="_blank" rel="noopener noreferrer">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: Documentation explaining debugging in WordPress. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( __( 'https://wordpress.org/support/article/debugging-in-wordpress/' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Learn more about debugging in WordPress.' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1503,7 +1503,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'An HTTPS connection is a more secure way of browsing the web. Many services now have HTTPS as a requirement. HTTPS allows you to take advantage of new features that can increase site speed, improve search rankings, and gain the trust of your visitors by helping to protect their online privacy.' )
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'actions' => sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<p><a href="%s" target="_blank" rel="noopener noreferrer">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: Documentation explaining HTTPS and why it should be used. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( __( 'https://wordpress.org/support/article/why-should-i-use-https/' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Learn more about why you should use HTTPS' ),
</span></span></pre></div>
<a id="trunksrcwpadminincludesdashboardphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/dashboard.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/dashboard.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-admin/includes/dashboard.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1761,7 +1761,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <p class="button-container">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener noreferrer">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_url( wp_get_update_php_url() ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Learn more about updating PHP' ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Accessibility text. */
</span></span></pre></div>
<a id="trunksrcwpadminincludesmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/media.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-admin/includes/media.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3216,7 +3216,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: 1: Link to tutorial, 2: Additional link attributes, 3: Accessibility text. */
</span><span class="cx" style="display: block; padding: 0 10px"> __( '<a href="%1$s" %2$s>Describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ),
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'target="_blank" rel="noopener noreferrer"',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'target="_blank" rel="noopener"',
</ins><span class="cx" style="display: block; padding: 0 10px"> sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<span class="screen-reader-text"> %s</span>',
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Accessibility text. */
</span></span></pre></div>
<a id="trunksrcwpincludesclasswalkernavmenuphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-walker-nav-menu.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-walker-nav-menu.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/class-walker-nav-menu.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -173,7 +173,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $atts['title'] = ! empty( $item->attr_title ) ? $item->attr_title : '';
</span><span class="cx" style="display: block; padding: 0 10px"> $atts['target'] = ! empty( $item->target ) ? $item->target : '';
</span><span class="cx" style="display: block; padding: 0 10px"> if ( '_blank' === $item->target && empty( $item->xfn ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $atts['rel'] = 'noopener noreferrer';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $atts['rel'] = 'noopener';
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $atts['rel'] = $item->xfn;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/comment.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3647,7 +3647,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'comment_link':
</span><span class="cx" style="display: block; padding: 0 10px"> $value = get_comment_link( $comment->comment_ID );
</span><span class="cx" style="display: block; padding: 0 10px"> $value = sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<a href="%s" target="_blank" rel="noreferrer noopener">%s</a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<a href="%s" target="_blank" rel="noopener">%s</a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_url( $value ),
</span><span class="cx" style="display: block; padding: 0 10px"> esc_html( $value )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span></span></pre></div>
<a id="trunksrcwpincludesformattingphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/formatting.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/formatting.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/formatting.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3153,9 +3153,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Adds rel noreferrer and noopener to all HTML A elements that have a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Adds `rel="noopener"` to all HTML A elements that have a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.1.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 5.6.0 Removed 'noreferrer' relationship.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $text Content that may contain HTML A elements.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string Converted content.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3188,15 +3189,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Callback to add rel="noreferrer noopener" string to HTML A element.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Callback to add `rel="noopener"` string to HTML A element.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Will not duplicate existing noreferrer and noopener values
- * to prevent from invalidating the HTML.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Will not duplicate an existing 'noopener' value to avoid invalidating the HTML.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.1.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 5.6.0 Removed 'noreferrer' relationship.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param array $matches Single Match
- * @return string HTML A Element with rel noreferrer noopener in addition to any existing values
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $matches Single match.
+ * @return string HTML A Element with `rel="noopener"` in addition to any existing values.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function wp_targeted_link_rel_callback( $matches ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $link_html = $matches[1];
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3219,7 +3220,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $rel The rel values.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $link_html The matched content of the link tag including all HTML attributes.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $rel = apply_filters( 'wp_targeted_link_rel', 'noopener noreferrer', $link_html );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $rel = apply_filters( 'wp_targeted_link_rel', 'noopener', $link_html );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Return early if no rel values to be added or if no actual target attribute.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $rel || ! isset( $atts['target'] ) ) {
</span></span></pre></div>
<a id="trunksrcwpincludesfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/functions.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/functions.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -7540,7 +7540,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<p class="button-container">';
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener noreferrer">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_url( $direct_update_url ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Update PHP' ),
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Accessibility text. */
</span></span></pre></div>
<a id="trunksrcwpincludesmediatemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media-template.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/media-template.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -160,7 +160,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: 1: Link to tutorial, 2: Additional link attributes, 3: Accessibility text. */
</span><span class="cx" style="display: block; padding: 0 10px"> __( '<a href="%1$s" %2$s>Describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ),
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( 'https://www.w3.org/WAI/tutorials/images/decision-tree' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'target="_blank" rel="noopener noreferrer"',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'target="_blank" rel="noopener"',
</ins><span class="cx" style="display: block; padding: 0 10px"> sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<span class="screen-reader-text"> %s</span>',
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Accessibility text. */
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetcustomhtmlphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -146,7 +146,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /** This filter is documented in wp-includes/widgets/class-wp-widget-text.php */
</span><span class="cx" style="display: block; padding: 0 10px"> $content = apply_filters( 'widget_text', $instance['content'], $simulated_text_widget_instance, $this );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Adds noreferrer and noopener relationships, without duplicating values, to all HTML A elements that have a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Adds 'noopener' relationship, without duplicating values, to all HTML A elements that have a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> $content = wp_targeted_link_rel( $content );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgettextphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-text.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-text.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-includes/widgets/class-wp-widget-text.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -331,7 +331,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $text = preg_replace_callback( '#<(video|iframe|object|embed)\s[^>]*>#i', array( $this, 'inject_video_max_width_style' ), $text );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Adds noreferrer and noopener relationships, without duplicating values, to all HTML A elements that have a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Adds 'noopener' relationship, without duplicating values, to all HTML A elements that have a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> $text = wp_targeted_link_rel( $text );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre></div>
<a id="trunksrcwploginphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-login.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-login.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/src/wp-login.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -689,7 +689,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $accessibility_text = sprintf( '<span class="screen-reader-text"> %s</span>', __( '(opens in a new tab)' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<a href="%s" rel="noopener noreferrer" target="_blank">%s%s</a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<a href="%s" rel="noopener" target="_blank">%s%s</a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> esc_url( $admin_email_help_url ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Why is this important?' ),
</span><span class="cx" style="display: block; padding: 0 10px"> $accessibility_text
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1540,7 +1540,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> for ( i in links ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( links[i].href ) {
</span><span class="cx" style="display: block; padding: 0 10px"> links[i].target = '_blank';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- links[i].rel = 'noreferrer noopener';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ links[i].rel = 'noopener';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } catch( er ) {}
</span></span></pre></div>
<a id="trunktestsphpunittestsformattingWPTargetedLinkRelphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/formatting/WPTargetedLinkRel.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/formatting/WPTargetedLinkRel.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/formatting/WPTargetedLinkRel.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,61 +8,61 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_add_to_links_with_target_blank() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" target="_blank">No rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" target="_blank" rel="noopener noreferrer">No rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" target="_blank" rel="noopener">No rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_add_to_links_with_target_foo() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" target="foo">No rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" target="foo" rel="noopener noreferrer">No rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" target="foo" rel="noopener">No rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_target_as_first_attribute() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a target="_blank" href="#">No rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a target="_blank" href="#" rel="noopener noreferrer">No rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a target="_blank" href="#" rel="noopener">No rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_add_to_existing_rel() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" rel="existing values" target="_blank">Existing rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" rel="existing values noopener noreferrer" target="_blank">Existing rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" rel="existing values noopener" target="_blank">Existing rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_no_duplicate_values_added() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" rel="existing noopener values" target="_blank">Existing rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" rel="existing noopener values noreferrer" target="_blank">Existing rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" rel="existing noopener values" target="_blank">Existing rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_rel_with_single_quote_delimiter() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" rel=\'existing values\' target="_blank">Existing rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" rel="existing values noopener noreferrer" target="_blank">Existing rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" rel="existing values noopener" target="_blank">Existing rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_rel_with_no_delimiter() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" rel=existing target="_blank">Existing rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" rel="existing noopener noreferrer" target="_blank">Existing rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" rel="existing noopener" target="_blank">Existing rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_rel_value_spaced_and_no_delimiter() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" rel = existing target="_blank">Existing rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" rel="existing noopener noreferrer" target="_blank">Existing rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" rel="existing noopener" target="_blank">Existing rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_escaped_quotes() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href=\"/\" rel=\"existing values\" target=\"_blank\">Existing rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href=\"/\" rel=\"existing values noopener noreferrer\" target=\"_blank\">Existing rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href=\"/\" rel=\"existing values noopener\" target=\"_blank\">Existing rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_ignore_links_with_no_target() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" target="_blank">Change me</a> <a href="/">Do not change me</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" target="_blank" rel="noopener noreferrer">Change me</a> <a href="/">Do not change me</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" target="_blank" rel="noopener">Change me</a> <a href="/">Do not change me</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -85,7 +85,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_targeted_link_rel_filters_run() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href="/" target="_blank">No rel</a></p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" target="_blank" rel="noopener noreferrer">No rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" target="_blank" rel="noopener">No rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $post = $this->factory()->post->create_and_get(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -103,7 +103,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_targeted_link_rel_should_preserve_json() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<p>Links: <a href=\"\/\" target=\"_blank\">No rel<\/a><\/p>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href=\"\/\" target=\"_blank\" rel=\"noopener noreferrer\">No rel<\/a><\/p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href=\"\/\" target=\"_blank\" rel=\"noopener\">No rel<\/a><\/p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -114,7 +114,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_targeted_link_rel_skips_style_and_scripts() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = '<style><a href="/" target=a></style><p>Links: <script>console.log("<a href=\'/\' target=a>hi</a>");</script><script>alert(1);</script>here <a href="/" target=_blank>aq</a></p><script>console.log("<a href=\'last\' target=\'_blank\'")</script>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<style><a href="/" target=a></style><p>Links: <script>console.log("<a href=\'/\' target=a>hi</a>");</script><script>alert(1);</script>here <a href="/" target="_blank" rel="noopener noreferrer">aq</a></p><script>console.log("<a href=\'last\' target=\'_blank\'")</script>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<style><a href="/" target=a></style><p>Links: <script>console.log("<a href=\'/\' target=a>hi</a>");</script><script>alert(1);</script>here <a href="/" target="_blank" rel="noopener">aq</a></p><script>console.log("<a href=\'last\' target=\'_blank\'")</script>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -131,7 +131,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_targeted_link_rel_tab_separated_values_are_split() {
</span><span class="cx" style="display: block; padding: 0 10px"> $content = "<p>Links: <a href=\"/\" target=\"_blank\" rel=\"ugc\t\tnoopener\t\">No rel</a></p>";
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected = '<p>Links: <a href="/" target="_blank" rel="ugc noopener noreferrer">No rel</a></p>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $expected = '<p>Links: <a href="/" target="_blank" rel="ugc noopener">No rel</a></p>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, wp_targeted_link_rel( $content ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsmenuwalkernavmenuphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/menu/walker-nav-menu.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/menu/walker-nav-menu.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/menu/walker-nav-menu.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -37,7 +37,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Tests when an item's target is _blank, that rel="noopener noreferrer" is added.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Tests when an item's target is _blank, that rel="noopener" is added.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 43290
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,7 +64,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->walker->start_el( $expected, (object) $item, 0, (object) $args );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertSame( "<li id=\"menu-item-{$post_id}\" class=\"menu-item-{$post_id}\"><a target=\"_blank\" rel=\"noopener noreferrer\">{$post_title}</a>", $expected );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertSame( "<li id=\"menu-item-{$post_id}\" class=\"menu-item-{$post_id}\"><a target=\"_blank\" rel=\"noopener\">{$post_title}</a>", $expected );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestsprivacywpPrivacyGeneratePersonalDataExportFilephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -478,7 +478,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'Comment URL',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'value' => '<a href="http://localhost:8888/46894/2020/01/31/hello-world/#comment-2" target="_blank" rel="noreferrer noopener">http://localhost:8888/46894/2020/01/31/hello-world/#comment-2</a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'value' => '<a href="http://localhost:8888/46894/2020/01/31/hello-world/#comment-2" target="_blank" rel="noopener">http://localhost:8888/46894/2020/01/31/hello-world/#comment-2</a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'comment-3' => array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -508,7 +508,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'Comment URL',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'value' => '<a href="http://localhost:8888/46894/2020/01/31/hello-world/#comment-3" target="_blank" rel="noreferrer noopener">http://localhost:8888/46894/2020/01/31/hello-world/#comment-3</a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'value' => '<a href="http://localhost:8888/46894/2020/01/31/hello-world/#comment-3" target="_blank" rel="noopener">http://localhost:8888/46894/2020/01/31/hello-world/#comment-3</a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -620,7 +620,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'Comment URL',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'value' => '<a href="http://localhost:8888/46894/2020/01/31/hello-world/#comment-2" target="_blank" rel="noreferrer noopener">http://localhost:8888/46894/2020/01/31/hello-world/#comment-2</a>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'value' => '<a href="http://localhost:8888/46894/2020/01/31/hello-world/#comment-2" target="_blank" rel="noopener">http://localhost:8888/46894/2020/01/31/hello-world/#comment-2</a>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span></span></pre></div>
<a id="trunktestsphpunittestsrestapirestattachmentscontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1162,12 +1162,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'rendered' => '<a href="#">link</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'raw' => '<a href="#" target="_blank" rel="noopener noreferrer">link</a>',
- 'rendered' => '<p><a href="#" target="_blank" rel="noopener noreferrer">link</a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'raw' => '<a href="#" target="_blank" rel="noopener">link</a>',
+ 'rendered' => '<p><a href="#" target="_blank" rel="noopener">link</a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'caption' => array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'raw' => '<a href="#" target="_blank" rel="noopener noreferrer">link</a>',
- 'rendered' => '<p><a href="#" target="_blank" rel="noopener noreferrer">link</a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'raw' => '<a href="#" target="_blank" rel="noopener">link</a>',
+ 'rendered' => '<p><a href="#" target="_blank" rel="noopener">link</a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span></span></pre></div>
<a id="trunktestsphpunittestsrestapirestpostscontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3696,12 +3696,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'rendered' => '<a href="#">link</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'content' => array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'raw' => '<a href="#" target="_blank" rel="noopener noreferrer">link</a>',
- 'rendered' => '<p><a href="#" target="_blank" rel="noopener noreferrer">link</a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'raw' => '<a href="#" target="_blank" rel="noopener">link</a>',
+ 'rendered' => '<p><a href="#" target="_blank" rel="noopener">link</a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'excerpt' => array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'raw' => '<a href="#" target="_blank" rel="noopener noreferrer">link</a>',
- 'rendered' => '<p><a href="#" target="_blank" rel="noopener noreferrer">link</a></p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'raw' => '<a href="#" target="_blank" rel="noopener">link</a>',
+ 'rendered' => '<p><a href="#" target="_blank" rel="noopener">link</a></p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span></span></pre></div>
<a id="trunktestsphpunittestswidgetscustomhtmlwidgetphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/widgets/custom-html-widget.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/widgets/custom-html-widget.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/widgets/custom-html-widget.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -304,7 +304,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Ensure that rel="noopener noreferrer" is added to links with a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Ensure that rel="noopener" is added to links with a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 46421
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -326,11 +326,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertContains( 'rel="noopener noreferrer"', $output );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertContains( 'rel="noopener"', $output );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Ensure that rel="noopener noreferrer" is not added to links without a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Ensure that rel="noopener" is not added to links without a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 46421
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -352,7 +352,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertNotContains( 'rel="noopener noreferrer"', $output );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertNotContains( 'rel="noopener"', $output );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestswidgetsmediaimagewidgetphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/widgets/media-image-widget.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/widgets/media-image-widget.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/widgets/media-image-widget.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -542,7 +542,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertContains( '<a href="https://example.org"', $output );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertContains( 'target="_blank"', $output );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertContains( 'rel="noopener noreferrer"', $output );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertContains( 'rel="noopener"', $output );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Populate caption in attachment.
</span><span class="cx" style="display: block; padding: 0 10px"> wp_update_post(
</span></span></pre></div>
<a id="trunktestsphpunittestswidgetstextwidgetphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/widgets/text-widget.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/widgets/text-widget.php 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/phpunit/tests/widgets/text-widget.php 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1003,7 +1003,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Ensure that rel="noopener noreferrer" is added to links with a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Ensure that rel="noopener" is added to links with a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 46421
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1026,11 +1026,11 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertContains( 'rel="noopener noreferrer"', $output );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertContains( 'rel="noopener"', $output );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Ensure that rel="noopener noreferrer" is not added to links without a target.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Ensure that rel="noopener" is not added to links without a target.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 46421
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1053,6 +1053,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertNotContains( 'rel="noopener noreferrer"', $output );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertNotContains( 'rel="noopener"', $output );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsqunitindexhtml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/qunit/index.html</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/qunit/index.html 2020-10-19 22:43:21 UTC (rev 49214)
+++ trunk/tests/qunit/index.html 2020-10-19 23:37:53 UTC (rev 49215)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1173,7 +1173,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="name">Alternative Text</span>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" value="{{ data.alt }}" aria-describedby="alt-text-description" {{ maybeReadOnly }} />
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener noreferrer">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span><span class="cx" style="display: block; padding: 0 10px"> <label class="setting" data-setting="title">
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="name">Title</span>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1338,7 +1338,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="name">Alt Text</span>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" value="{{ data.alt }}" aria-describedby="alt-text-description" {{ maybeReadOnly }} />
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener noreferrer">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span><span class="cx" style="display: block; padding: 0 10px"> <label class="setting" data-setting="title">
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="name">Title</span>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1630,7 +1630,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span>Alternative Text</span>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" data-setting="alt" aria-describedby="alt-text-description" />
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener noreferrer">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <label class="setting caption">
</span><span class="cx" style="display: block; padding: 0 10px"> <span>Caption</span>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1685,7 +1685,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span>Alternative Text</span>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" data-setting="alt" value="{{ data.model.alt }}" aria-describedby="alt-text-description" />
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener noreferrer">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="description" id="alt-text-description"><a href="https://www.w3.org/WAI/tutorials/images/decision-tree" target="_blank" rel="noopener">Describe the purpose of the image<span class="screen-reader-text"> (opens in a new tab)</span></a>. Leave empty if the image is purely decorative.</p>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <label class="setting caption">
</span><span class="cx" style="display: block; padding: 0 10px"> <span>Caption</span>
</span></span></pre>
</div>
</div>
</body>
</html>