<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[48717] trunk/src: Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340].</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/48717">48717</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/48717","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-08-04 13:15:52 +0000 (Tue, 04 Aug 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after <a href="https://core.trac.wordpress.org/changeset/48340">[48340]</a>.
Fixes <a href="https://core.trac.wordpress.org/ticket/49288">#49288</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminpostboxjs">trunk/src/js/_enqueues/admin/postbox.js</a></li>
<li><a href="#trunksrcwpadmincsscommoncss">trunk/src/wp-admin/css/common.css</a></li>
<li><a href="#trunksrcwpadmincssdashboardcss">trunk/src/wp-admin/css/dashboard.css</a></li>
<li><a href="#trunksrcwpadmincsseditcss">trunk/src/wp-admin/css/edit.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminpostboxjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/postbox.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/postbox.js 2020-08-04 12:45:57 UTC (rev 48716)
+++ trunk/src/js/_enqueues/admin/postbox.js 2020-08-04 13:15:52 UTC (rev 48717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -394,6 +394,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> opacity: 0.65,
</span><span class="cx" style="display: block; padding: 0 10px"> start: function() {
</span><span class="cx" style="display: block; padding: 0 10px"> $( 'body' ).addClass( 'is-dragging-metaboxes' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Refresh the cached positions of all the sortable items so that the min-height set while dragging works.
+ $( '.meta-box-sortables' ).sortable( 'refreshPositions' );
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> stop: function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var $el = $( this );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -520,13 +522,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return {void}
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> _mark_area : function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var visibleSortables = $( '#dashboard-widgets .meta-box-sortables:visible, #post-body .meta-box-sortables:visible' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var visible = $( 'div.postbox:visible' ).length,
+ visibleSortables = $( '#dashboard-widgets .meta-box-sortables:visible, #post-body .meta-box-sortables:visible' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> areAllVisibleSortablesEmpty = true;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> visibleSortables.each( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var t = $(this);
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( t.children('.postbox:visible').length ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( visible == 1 || t.children( '.postbox:visible' ).length ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> t.removeClass('empty-container');
</span><span class="cx" style="display: block; padding: 0 10px"> areAllVisibleSortablesEmpty = false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -543,6 +546,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.5.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param {Object} visibleSortables The jQuery object representing the visible sortable areas.
+ * @param {boolean} areAllVisibleSortablesEmpty Whether all the visible sortable areas are "empty".
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return {void}
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> updateEmptySortablesText: function( visibleSortables, areAllVisibleSortablesEmpty ) {
</span></span></pre></div>
<a id="trunksrcwpadmincsscommoncss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/common.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/common.css 2020-08-04 12:45:57 UTC (rev 48716)
+++ trunk/src/wp-admin/css/common.css 2020-08-04 13:15:52 UTC (rev 48717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -29,6 +29,46 @@
</span><span class="cx" style="display: block; padding: 0 10px"> overflow: visible;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* inner 2 column liquid layout */
+
+.inner-sidebar {
+ float: right;
+ clear: right;
+ display: none;
+ width: 281px;
+ position: relative;
+}
+
+.columns-2 .inner-sidebar {
+ margin-right: auto;
+ width: 286px;
+ display: block;
+}
+
+.inner-sidebar #side-sortables,
+.columns-2 .inner-sidebar #side-sortables {
+ min-height: 300px;
+ width: 280px;
+ padding: 0;
+}
+
+.has-right-sidebar .inner-sidebar {
+ display: block;
+}
+
+.has-right-sidebar #post-body {
+ float: left;
+ clear: left;
+ width: 100%;
+ margin-right: -2000px;
+}
+
+.has-right-sidebar #post-body-content {
+ margin-right: 300px;
+ float: none;
+ width: auto;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* 2 columns main area */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #col-left {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1945,9 +1985,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-top: 10px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.metabox-holder .postbox-container .empty-container {
- outline: 3px dashed #b4b9be;
- height: 250px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.metabox-holder .postbox-container .meta-box-sortables {
+ /* The jQuery UI Sortables need some initial height to work properly. */
+ min-height: 1px;
</ins><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadmincssdashboardcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/dashboard.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/dashboard.css 2020-08-04 12:45:57 UTC (rev 48716)
+++ trunk/src/wp-admin/css/dashboard.css 2020-08-04 13:15:52 UTC (rev 48717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -54,6 +54,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0 8px 20px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#dashboard-widgets .postbox-container .empty-container {
+ outline: 3px dashed #b4b9be;
+ height: 250px;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Only highlight drop zones when dragging and only in the 2 columns layout. */
</span><span class="cx" style="display: block; padding: 0 10px"> .is-dragging-metaboxes #dashboard-widgets .meta-box-sortables {
</span><span class="cx" style="display: block; padding: 0 10px"> outline: 3px dashed #606a73;
</span></span></pre></div>
<a id="trunksrcwpadmincsseditcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/edit.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/edit.css 2020-08-04 12:45:57 UTC (rev 48716)
+++ trunk/src/wp-admin/css/edit.css 2020-08-04 13:15:52 UTC (rev 48717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -148,25 +148,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Post Screen */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/* Only target the sortables in the post screen excluding the ones in the Dashboard. */
-#post-body .meta-box-sortables {
- /* Required min-height to make the jQuery UI Sortable drop zone work. */
- min-height: 1px;
-}
-
-/* Resets height and outline inherited from common.css. */
-#post-body.columns-1 #side-sortables.empty-container,
-#post-body #normal-sortables.empty-container,
-#post-body #advanced-sortables.empty-container {
- /* Sortables need some initial height to work correctly. */
- height: 1px;
- outline: none;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> /* Only highlight drop zones when dragging and only in the 2 columns layout. */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.is-dragging-metaboxes #post-body.columns-2 #side-sortables,
-.is-dragging-metaboxes #post-body #normal-sortables,
-.is-dragging-metaboxes #post-body #advanced-sortables {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.is-dragging-metaboxes .metabox-holder .postbox-container .meta-box-sortables {
</ins><span class="cx" style="display: block; padding: 0 10px"> outline: 3px dashed #606a73;
</span><span class="cx" style="display: block; padding: 0 10px"> /* Prevent margin on the child from collapsing with margin on the parent. */
</span><span class="cx" style="display: block; padding: 0 10px"> display: flow-root;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1542,7 +1525,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #poststuff #postbox-container-1 .empty-container,
</span><span class="cx" style="display: block; padding: 0 10px"> #poststuff #postbox-container-1 #side-sortables:empty {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- outline: none;
</del><span class="cx" style="display: block; padding: 0 10px"> height: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> min-height: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1552,6 +1534,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> width: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* Increase min-height while dragging for the #side-sortables and any potential sortables area with custom ID. */
+ .is-dragging-metaboxes #poststuff #postbox-container-1 .empty-container,
+ .is-dragging-metaboxes #poststuff #postbox-container-1 #side-sortables:empty,
+ .is-dragging-metaboxes #poststuff #post-body.columns-2 #side-sortables,
+ .is-dragging-metaboxes #poststuff #post-body.columns-2 .meta-box-sortables {
+ height: auto;
+ min-height: 60px;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* hide the radio buttons for column prefs */
</span><span class="cx" style="display: block; padding: 0 10px"> .screen-layout,
</span><span class="cx" style="display: block; padding: 0 10px"> .columns-prefs {
</span></span></pre>
</div>
</div>
</body>
</html>