<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[48460] trunk/src: Accessibility: Improve reordering of the post boxes in the block editor meta boxes area.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/48460">48460</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/48460","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-07-13 18:01:31 +0000 (Mon, 13 Jul 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Improve reordering of the post boxes in the block editor meta boxes area.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/48373">[48373]</a>.
- ignores hidden "sortables" areas
- hides the reorder buttons when there's only one post box
- makes the reorder buttons slightly bigger to match the side of the toggle button
Fixes <a href="https://core.trac.wordpress.org/ticket/39074">#39074</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminpostboxjs">trunk/src/js/_enqueues/admin/postbox.js</a></li>
<li><a href="#trunksrcwpadmincsscommoncss">trunk/src/wp-admin/css/common.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminpostboxjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/postbox.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/postbox.js 2020-07-13 17:06:57 UTC (rev 48459)
+++ trunk/src/js/_enqueues/admin/postbox.js 2020-07-13 18:01:31 UTC (rev 48460)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -203,17 +203,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return {void}
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> updateOrderButtonsProperties: function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var firstSortablesId = $( '.meta-box-sortables:first' ).attr( 'id' ),
- lastSortablesId = $( '.meta-box-sortables:last' ).attr( 'id' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var firstSortablesId = $( '.meta-box-sortables:visible:first' ).attr( 'id' ),
+ lastSortablesId = $( '.meta-box-sortables:visible:last' ).attr( 'id' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> firstPostbox = $( '.postbox:visible:first' ),
</span><span class="cx" style="display: block; padding: 0 10px"> lastPostbox = $( '.postbox:visible:last' ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ firstPostboxId = firstPostbox.attr( 'id' ),
+ lastPostboxId = lastPostbox.attr( 'id' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> firstPostboxSortablesId = firstPostbox.closest( '.meta-box-sortables' ).attr( 'id' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- lastPostboxSortablesId = lastPostbox.closest( '.meta-box-sortables' ).attr( 'id' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ lastPostboxSortablesId = lastPostbox.closest( '.meta-box-sortables' ).attr( 'id' ),
+ moveUpButtons = $( '.handle-order-higher' ),
+ moveDownButtons = $( '.handle-order-lower' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Enable all buttons as a reset first.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '.handle-order-higher' ).attr( 'aria-disabled', 'false' );
- $( '.handle-order-lower' ).attr( 'aria-disabled', 'false' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ moveUpButtons
+ .attr( 'aria-disabled', 'false' )
+ .removeClass( 'hidden' );
+ moveDownButtons
+ .attr( 'aria-disabled', 'false' )
+ .removeClass( 'hidden' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // When there's only one "sortables" area (e.g. in the block editor) and only one visible postbox, hide the buttons.
+ if ( firstSortablesId === lastSortablesId && firstPostboxId === lastPostboxId ) {
+ moveUpButtons.addClass( 'hidden' );
+ moveDownButtons.addClass( 'hidden' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Set an aria-disabled=true attribute on the first visible "move" buttons.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( firstSortablesId === firstPostboxSortablesId ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $( firstPostbox ).find( '.handle-order-higher' ).attr( 'aria-disabled', 'true' );
</span></span></pre></div>
<a id="trunksrcwpadmincsscommoncss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/common.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/common.css 2020-07-13 17:06:57 UTC (rev 48459)
+++ trunk/src/wp-admin/css/common.css 2020-07-13 18:01:31 UTC (rev 48460)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2011,6 +2011,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> flex-shrink: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* Post box order and toggle buttons. */
</ins><span class="cx" style="display: block; padding: 0 10px"> .postbox .handle-order-higher,
</span><span class="cx" style="display: block; padding: 0 10px"> .postbox .handle-order-lower,
</span><span class="cx" style="display: block; padding: 0 10px"> .postbox .handlediv {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2028,6 +2029,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> color: #72777c;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* Post box order buttons in the block editor meta boxes area. */
+.edit-post-meta-boxes-area .postbox .handle-order-higher,
+.edit-post-meta-boxes-area .postbox .handle-order-lower {
+ width: 44px;
+ height: 44px;
+ color: #191e23
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .postbox .handle-order-higher[aria-disabled="true"],
</span><span class="cx" style="display: block; padding: 0 10px"> .postbox .handle-order-lower[aria-disabled="true"] {
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: default;
</span></span></pre>
</div>
</div>
</body>
</html>