<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[48374] trunk/src/wp-admin/includes/class-wp-plugins-list-table.php: Plugins: Make sure the HTML ID attributes in plugin action links are unique.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/48374">48374</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/48374","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-07-07 13:41:30 +0000 (Tue, 07 Jul 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugins: Make sure the HTML ID attributes in plugin action links are unique.
Follow-up to <a href="https://core.trac.wordpress.org/changeset/47588">[47588]</a>.
Props mukesh27, roytanck, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/49916">#49916</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2020-07-07 12:58:10 UTC (rev 48373)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2020-07-07 13:41:30 UTC (rev 48374)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -677,11 +677,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function single_row( $item ) {
</span><span class="cx" style="display: block; padding: 0 10px"> global $status, $page, $s, $totals;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ static $plugin_id_attrs = array();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> list( $plugin_file, $plugin_data ) = $item;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $plugin_slug = isset( $plugin_data['slug'] ) ? $plugin_data['slug'] : sanitize_title( $plugin_data['Name'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $plugin_slug = isset( $plugin_data['slug'] ) ? $plugin_data['slug'] : sanitize_title( $plugin_data['Name'] );
+ $plugin_id_attr = $plugin_slug;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Ensure the ID attribute is unique.
+ $suffix = 2;
+ while ( in_array( $plugin_id_attr, $plugin_id_attrs, true ) ) {
+ $plugin_id_attr = "$plugin_slug-$suffix";
+ $suffix++;
+ }
+
+ $plugin_id_attrs[] = $plugin_id_attr;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $context = $status;
</span><span class="cx" style="display: block; padding: 0 10px"> $screen = $this->screen;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -739,7 +750,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['deactivate'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="deactivate-%s" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=deactivate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'deactivate-plugin_' . $plugin_file ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Network Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Network Deactivate' )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -750,7 +761,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['activate'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="activate-%s" class="edit" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=activate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'activate-plugin_' . $plugin_file ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Network Activate %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Network Activate' )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -761,7 +772,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['delete'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="delete-%s" class="delete" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=delete-selected&checked[]=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'bulk-plugins' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Delete %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Delete' )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -782,7 +793,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['deactivate'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="deactivate-%s" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=deactivate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'deactivate-plugin_' . $plugin_file ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Deactivate' )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -793,7 +804,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['resume'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="resume-%s" class="resume-link" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=resume&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'resume-plugin_' . $plugin_file ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Resume %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Resume' )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -804,7 +815,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['activate'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="activate-%s" class="edit" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=activate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'activate-plugin_' . $plugin_file ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Activate %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Activate' )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -815,7 +826,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['delete'] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" id="delete-%s" class="delete" aria-label="%s">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( 'plugins.php?action=delete-selected&checked[]=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'bulk-plugins' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr( $plugin_slug ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ esc_attr( $plugin_id_attr ),
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Plugin name. */
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( sprintf( _x( 'Delete %s', 'plugin' ), $plugin_data['Name'] ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Delete' )
</span></span></pre>
</div>
</div>
</body>
</html>