<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[48077] trunk/src/wp-admin: Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/48077">48077</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/48077","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-06-17 23:58:15 +0000 (Wed, 17 Jun 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link. This will let plugins show better/specific information when they are overriding the auto-update settings, for example "Updates are managed by ... plugin".
Introduces: `theme_auto_update_setting_html`, `plugin_auto_update_setting_html`, and `theme_auto_update_setting_template` filters.
Props audrasjb, pbiron, azaozz.
Fixes <a href="https://core.trac.wordpress.org/ticket/50280">#50280</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswpmsthemeslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminthemesphp">trunk/src/wp-admin/themes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswpmsthemeslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2020-06-17 19:45:56 UTC (rev 48076)
+++ trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2020-06-17 23:58:15 UTC (rev 48077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -742,24 +742,39 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $url = add_query_arg( $query_args, 'themes.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- printf(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html[] = sprintf(
</ins><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" class="toggle-auto-update" data-wp-action="%s">',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( $url, 'updates' ),
</span><span class="cx" style="display: block; padding: 0 10px"> $action
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
- echo '<span class="label">' . $text . '</span>';
- echo '</a>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html[] = '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
+ $html[] = '<span class="label">' . $text . '</span>';
+ $html[] = '</a>';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $available_updates = get_site_transient( 'update_themes' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $available_updates->response[ $stylesheet ] ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- printf(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html[] = sprintf(
</ins><span class="cx" style="display: block; padding: 0 10px"> '<div class="auto-update-time%s">%s</div>',
</span><span class="cx" style="display: block; padding: 0 10px"> $time_class,
</span><span class="cx" style="display: block; padding: 0 10px"> wp_get_auto_update_message()
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $html = implode( '', $html );
+
+ /**
+ * Filters the HTML of the auto-updates setting for each theme in the Themes list table.
+ *
+ * @since 5.5.0
+ *
+ * @param string $html The HTML for theme’s auto-update setting including toggle auto-update action link
+ * and time to next update.
+ * @param string $stylesheet Directory name of the theme.
+ * @param WP_Theme $theme WP_Theme object.
+ */
+ echo apply_filters( 'theme_auto_update_setting_html', $html, $stylesheet, $theme );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="auto-updates-error inline notice error hidden"><p></p></div>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2020-06-17 19:45:56 UTC (rev 48076)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2020-06-17 23:58:15 UTC (rev 48077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1041,6 +1041,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<td class='column-auto-updates{$extra_classes}'>";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html = array();
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $plugin_file, $auto_updates, true ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $text = __( 'Disable auto-updates' );
</span><span class="cx" style="display: block; padding: 0 10px"> $action = 'disable';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1060,20 +1062,20 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $url = add_query_arg( $query_args, 'plugins.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- printf(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html[] = sprintf(
</ins><span class="cx" style="display: block; padding: 0 10px"> '<a href="%s" class="toggle-auto-update" data-wp-action="%s">',
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_url( $url, 'updates' ),
</span><span class="cx" style="display: block; padding: 0 10px"> $action
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
- echo '<span class="label">' . $text . '</span>';
- echo '</a>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html[] = '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
+ $html[] = '<span class="label">' . $text . '</span>';
+ $html[] = '</a>';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $available_updates = get_site_transient( 'update_plugins' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $available_updates->response[ $plugin_file ] ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- printf(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html[] = sprintf(
</ins><span class="cx" style="display: block; padding: 0 10px"> '<div class="auto-update-time%s">%s</div>',
</span><span class="cx" style="display: block; padding: 0 10px"> $time_class,
</span><span class="cx" style="display: block; padding: 0 10px"> wp_get_auto_update_message()
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1080,6 +1082,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html = implode( '', $html );
+
+ /**
+ * Filters the HTML of the auto-updates setting for each plugin in the Plugins list table.
+ *
+ * @since 5.5.0
+ *
+ * @param string $html The HTML of the plugin's auto-update column content,
+ * including toggle auto-update action links and time to next update.
+ * @param string $plugin_file Path to the plugin file relative to the plugins directory.
+ * @param array $plugin_data An array of plugin data.
+ */
+ echo apply_filters( 'plugin_auto_update_setting_html', $html, $plugin_file, $plugin_data );
+
+
</ins><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="inline notice error hidden"><p></p></div>';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '</td>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminthemesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/themes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/themes.php 2020-06-17 19:45:56 UTC (rev 48076)
+++ trunk/src/wp-admin/themes.php 2020-06-17 23:58:15 UTC (rev 48077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -549,6 +549,52 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </div><!-- .wrap -->
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+/**
+ * Returns the template for displaying the auto-update setting for a theme.
+ *
+ * @since 5.5.0
+ *
+ * @return string Template
+ */
+function wp_theme_auto_update_setting_template() {
+ $template = '
+ <p class="theme-autoupdate">
+ <# if ( data.autoupdate ) { #>
+ <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
+ <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
+ <span class="label">' . __( 'Disable auto-updates' ) . '</span>
+ </a>
+ <# } else { #>
+ <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
+ <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
+ <span class="label">' . __( 'Enable auto-updates' ) . '</span>
+ </a>
+ <# } #>
+ <# if ( data.hasUpdate ) { #>
+ <# if ( data.autoupdate ) { #>
+ <span class="auto-update-time">
+ <# } else { #>
+ <span class="auto-update-time hidden">
+ <# } #>
+ <br />' . wp_get_auto_update_message() . '</span>
+ <# } #>
+ <span class="auto-updates-error hidden"><p></p></span>
+ </p>
+ ';
+
+ /**
+ * Filters the JavaScript template used in Backbone to display the auto-update setting for a theme (in the overlay).
+ *
+ * See {@see wp_prepare_themes_for_js()} for the properties of the `data` object.
+ *
+ * @since 5.5.0
+ *
+ * @param string $template The template for displaying the auto-update setting link.
+ */
+ return apply_filters( 'theme_auto_update_setting_template', $template );
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * The tmpl-theme template is synchronized with PHP above!
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -648,28 +694,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </p>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( data.actions.autoupdate ) { #>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="theme-autoupdate">
- <# if ( data.autoupdate ) { #>
- <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="disable">
- <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
- <span class="label"><?php _e( 'Disable auto-updates' ); ?></span>
- </a>
- <# } else { #>
- <a href="{{{ data.actions.autoupdate }}}" class="toggle-auto-update" data-slug="{{ data.id }}" data-wp-action="enable">
- <span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>
- <span class="label"><?php _e( 'Enable auto-updates' ); ?></span>
- </a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <?php echo wp_theme_auto_update_setting_template(); ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <# if ( data.hasUpdate ) { #>
- <# if ( data.autoupdate) { #>
- <span class="auto-update-time"><br /><?php echo wp_get_auto_update_message(); ?></span>
- <# } else { #>
- <span class="auto-update-time hidden"><br /><?php echo wp_get_auto_update_message(); ?></span>
- <# } #>
- <# } #>
- <span class="auto-updates-error hidden"><p></p></span>
- </p>
- <# } #>
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( data.hasUpdate ) { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="notice notice-warning notice-alt notice-large">
</span></span></pre>
</div>
</div>
</body>
</html>