<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[47902] trunk: General: Continuing to work towards a passing PHP Compatibility scan.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/47902">47902</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/47902","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-06-03 17:38:56 +0000 (Wed, 03 Jun 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>General: Continuing to work towards a passing PHP Compatibility scan.
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.
With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see <a href="https://core.trac.wordpress.org/ticket/49810">#49810</a> and <a href="https://core.trac.wordpress.org/ticket/41750">#41750</a>).
Props desrosj, johnbillion, jrf.
See <a href="https://core.trac.wordpress.org/ticket/49922">#49922</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkphpcompatxmldist">trunk/phpcompat.xml.dist</a></li>
<li><a href="#trunksrcwpadminincludesclassftpphp">trunk/src/wp-admin/includes/class-ftp.php</a></li>
<li><a href="#trunksrcwpincludesID3moduleaudiovideoquicktimephp">trunk/src/wp-includes/ID3/module.audio-video.quicktime.php</a></li>
<li><a href="#trunksrcwpincludescapabilitiesphp">trunk/src/wp-includes/capabilities.php</a></li>
<li><a href="#trunksrcwpincludesclassrequestsphp">trunk/src/wp-includes/class-requests.php</a></li>
<li><a href="#trunksrcwpincludesclasssimplepiephp">trunk/src/wp-includes/class-simplepie.php</a></li>
<li><a href="#trunksrcwpincludescronphp">trunk/src/wp-includes/cron.php</a></li>
<li><a href="#trunksrcwpincludesfunctionsphp">trunk/src/wp-includes/functions.php</a></li>
<li><a href="#trunksrcwpincludespluginphp">trunk/src/wp-includes/plugin.php</a></li>
<li><a href="#trunksrcwpincludespomostreamsphp">trunk/src/wp-includes/pomo/streams.php</a></li>
<li><a href="#trunksrcwpincludesrssphp">trunk/src/wp-includes/rss.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkphpcompatxmldist"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/phpcompat.xml.dist</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/phpcompat.xml.dist 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/phpcompat.xml.dist 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -74,7 +74,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </rule>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- Whitelist the WP DB Class for use of `mysql_` extension in PHP < 7.0. -->
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <rule ref="PHPCompatibility.Extensions.RemovedExtensions">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <rule ref="PHPCompatibility.Extensions.RemovedExtensions.mysql_DeprecatedRemoved">
</ins><span class="cx" style="display: block; padding: 0 10px"> <exclude-pattern>/src/wp-includes/wp-db\.php</exclude-pattern>
</span><span class="cx" style="display: block; padding: 0 10px"> </rule>
</span><span class="cx" style="display: block; padding: 0 10px"> </ruleset>
</span></span></pre></div>
<a id="trunksrcwpadminincludesclassftpphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-ftp.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-ftp.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-admin/includes/class-ftp.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -899,7 +899,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $mod_sockets = extension_loaded( 'sockets' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $mod_sockets && function_exists( 'dl' ) && is_callable( 'dl' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $prefix = ( PHP_SHLIB_SUFFIX == 'dll' ) ? 'php_' : '';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- @dl( $prefix . 'sockets.' . PHP_SHLIB_SUFFIX );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ @dl( $prefix . 'sockets.' . PHP_SHLIB_SUFFIX ); // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.dlDeprecated
</ins><span class="cx" style="display: block; padding: 0 10px"> $mod_sockets = extension_loaded( 'sockets' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesID3moduleaudiovideoquicktimephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/ID3/module.audio-video.quicktime.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/ID3/module.audio-video.quicktime.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/ID3/module.audio-video.quicktime.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -114,7 +114,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ($info['quicktime']['comments']['location.ISO6709'] as $ISO6709string) {
</span><span class="cx" style="display: block; padding: 0 10px"> $ISO6709parsed = array('latitude'=>false, 'longitude'=>false, 'altitude'=>false);
</span><span class="cx" style="display: block; padding: 0 10px"> if (preg_match('#^([\\+\\-])([0-9]{2}|[0-9]{4}|[0-9]{6})(\\.[0-9]+)?([\\+\\-])([0-9]{3}|[0-9]{5}|[0-9]{7})(\\.[0-9]+)?(([\\+\\-])([0-9]{3}|[0-9]{5}|[0-9]{7})(\\.[0-9]+)?)?/$#', $ISO6709string, $matches)) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- @list($dummy, $lat_sign, $lat_deg, $lat_deg_dec, $lon_sign, $lon_deg, $lon_deg_dec, $dummy, $alt_sign, $alt_deg, $alt_deg_dec) = $matches;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ @list($dummy, $lat_sign, $lat_deg, $lat_deg_dec, $lon_sign, $lon_deg, $lon_deg_dec, $dummy, $alt_sign, $alt_deg, $alt_deg_dec) = $matches; // phpcs:ignore PHPCompatibility.Lists.AssignmentOrder.Affected
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if (strlen($lat_deg) == 2) { // [+-]DD.D
</span><span class="cx" style="display: block; padding: 0 10px"> $ISO6709parsed['latitude'] = (($lat_sign == '-') ? -1 : 1) * floatval(ltrim($lat_deg, '0').$lat_deg_dec);
</span></span></pre></div>
<a id="trunksrcwpincludescapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/capabilities.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/capabilities.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -290,8 +290,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> case 'edit_user_meta':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'delete_user_meta':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'add_user_meta':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- list( $_, $object_type, $_ ) = explode( '_', $cap );
- $object_id = (int) $args[0];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $object_type = explode( '_', $cap )[1];
+ $object_id = (int) $args[0];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $object_subtype = get_object_subtype( $object_type, $object_id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesclassrequestsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-requests.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-requests.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/class-requests.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -187,7 +187,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Don't search for a transport if it's already been done for these $capabilities
</span><span class="cx" style="display: block; padding: 0 10px"> if (isset(self::$transport[$cap_string]) && self::$transport[$cap_string] !== null) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return new self::$transport[$cap_string]();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $class = self::$transport[$cap_string];
+ return new $class();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> // @codeCoverageIgnoreEnd
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -214,7 +215,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> throw new Requests_Exception('No working transports found', 'notransport', self::$transports);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return new self::$transport[$cap_string]();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $class = self::$transport[$cap_string];
+ return new $class();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**#@+
</span></span></pre></div>
<a id="trunksrcwpincludesclasssimplepiephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-simplepie.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-simplepie.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/class-simplepie.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3165,7 +3165,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $class = get_class($this);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $trace = debug_backtrace();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $trace = debug_backtrace(); // phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
</ins><span class="cx" style="display: block; padding: 0 10px"> $file = $trace[0]['file'];
</span><span class="cx" style="display: block; padding: 0 10px"> $line = $trace[0]['line'];
</span><span class="cx" style="display: block; padding: 0 10px"> trigger_error("Call to undefined method $class::$method() in $file on line $line", E_USER_ERROR);
</span></span></pre></div>
<a id="trunksrcwpincludescronphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/cron.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/cron.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/cron.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -402,7 +402,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Previously, this function took the arguments as discrete vars rather than an array like the rest of the API.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_array( $args ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> _deprecated_argument( __FUNCTION__, '3.0.0', __( 'This argument has changed to an array to match the behavior of the other cron functions.' ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $args = array_slice( func_get_args(), 1 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = array_slice( func_get_args(), 1 ); // phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunksrcwpincludesfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/functions.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/functions.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6627,7 +6627,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> static $overloaded = null;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( is_null( $overloaded ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $overloaded = function_exists( 'mb_internal_encoding' ) && ( ini_get( 'mbstring.func_overload' ) & 2 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $overloaded = function_exists( 'mb_internal_encoding' ) && ( ini_get( 'mbstring.func_overload' ) & 2 ); // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( false === $overloaded ) {
</span></span></pre></div>
<a id="trunksrcwpincludespluginphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/plugin.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/plugin.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/plugin.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -231,7 +231,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Do 'all' actions first.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $wp_filter['all'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $wp_current_filter[] = $tag;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $all_args = func_get_args();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $all_args = func_get_args(); // phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
</ins><span class="cx" style="display: block; padding: 0 10px"> _wp_call_all_hook( $all_args );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -453,7 +453,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Do 'all' actions first.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $wp_filter['all'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $wp_current_filter[] = $tag;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $all_args = func_get_args();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $all_args = func_get_args(); // phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
</ins><span class="cx" style="display: block; padding: 0 10px"> _wp_call_all_hook( $all_args );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -526,7 +526,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Do 'all' actions first.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $wp_filter['all'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $wp_current_filter[] = $tag;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $all_args = func_get_args();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $all_args = func_get_args(); // phpcs:ignore PHPCompatibility.FunctionUse.ArgumentFunctionsReportCurrentValue.NeedsInspection
</ins><span class="cx" style="display: block; padding: 0 10px"> _wp_call_all_hook( $all_args );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludespomostreamsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/pomo/streams.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/pomo/streams.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/pomo/streams.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,7 +18,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * PHP5 constructor.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function __construct() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->is_overloaded = ( ( ini_get( 'mbstring.func_overload' ) & 2 ) != 0 ) && function_exists( 'mb_substr' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->is_overloaded = ( ( ini_get( 'mbstring.func_overload' ) & 2 ) != 0 ) && function_exists( 'mb_substr' ); // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->_pos = 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesrssphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/rss.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/rss.php 2020-06-03 17:01:14 UTC (rev 47901)
+++ trunk/src/wp-includes/rss.php 2020-06-03 17:38:56 UTC (rev 47902)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -385,10 +385,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function error( $errormsg, $lvl = E_USER_WARNING ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // append PHP's error message if track_errors enabled
- if ( isset($php_errormsg) ) {
- $errormsg .= " ($php_errormsg)";
- }
</del><span class="cx" style="display: block; padding: 0 10px"> if ( MAGPIE_DEBUG ) {
</span><span class="cx" style="display: block; padding: 0 10px"> trigger_error( $errormsg, $lvl);
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -821,10 +817,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> Purpose: register error
</span><span class="cx" style="display: block; padding: 0 10px"> \*=======================================================================*/
</span><span class="cx" style="display: block; padding: 0 10px"> function error ($errormsg, $lvl=E_USER_WARNING) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // append PHP's error message if track_errors enabled
- if ( isset($php_errormsg) ) {
- $errormsg .= " ($php_errormsg)";
- }
</del><span class="cx" style="display: block; padding: 0 10px"> $this->ERROR = $errormsg;
</span><span class="cx" style="display: block; padding: 0 10px"> if ( MAGPIE_DEBUG ) {
</span><span class="cx" style="display: block; padding: 0 10px"> trigger_error( $errormsg, $lvl);
</span></span></pre>
</div>
</div>
</body>
</html>