<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[47304] trunk/src/wp-admin: Accessibility: Improve readability by removing unnecessary italic font style.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/47304">47304</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/47304","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-02-18 15:30:10 +0000 (Tue, 18 Feb 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Improve readability by removing unnecessary italic font style.
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.
Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help
Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See <a href="https://core.trac.wordpress.org/ticket/47327">#47327</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadmincssmediacss">trunk/src/wp-admin/css/media.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesimageeditphp">trunk/src/wp-admin/includes/image-edit.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2020-02-18 09:25:25 UTC (rev 47303)
+++ trunk/src/wp-admin/css/list-tables.css 2020-02-18 15:30:10 UTC (rev 47304)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -436,7 +436,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #commentsdiv .comments-box thead td {
</span><span class="cx" style="display: block; padding: 0 10px"> background: transparent;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0 7px 4px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- font-style: italic;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #commentsdiv .comments-box tr:last-child td {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1020,11 +1019,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> text-transform: uppercase;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.inline-edit-row fieldset span.title,
-.inline-edit-row fieldset span.checkbox-title {
- font-style: italic;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> /* Specific Elements */
</span><span class="cx" style="display: block; padding: 0 10px"> .inline-edit-row fieldset .inline-edit-date {
</span><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1318,7 +1312,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .plugins .paused .error-display p,
</span><span class="cx" style="display: block; padding: 0 10px"> .plugins .paused .error-display code {
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 90%;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- font-style: italic;
</del><span class="cx" style="display: block; padding: 0 10px"> color: rgba( 0, 0, 0, 0.7 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadmincssmediacss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/media.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/media.css 2020-02-18 09:25:25 UTC (rev 47303)
+++ trunk/src/wp-admin/css/media.css 2020-02-18 15:30:10 UTC (rev 47304)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1053,9 +1053,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .imgedit-help {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- font-style: italic;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ padding-bottom: 8px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.imgedit-help.imgedit-restore {
+ padding-bottom: 0;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* higher specificity than buttons */
</span><span class="cx" style="display: block; padding: 0 10px"> .image-editor .imgedit-settings .imgedit-help-toggle,
</span><span class="cx" style="display: block; padding: 0 10px"> .image-editor .imgedit-settings .imgedit-help-toggle:hover,
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2020-02-18 09:25:25 UTC (rev 47303)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2020-02-18 15:30:10 UTC (rev 47304)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1608,12 +1608,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="input-text-wrap"><input type="text" name="post_password" class="inline-edit-password-input" value="" /></span>
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <em class="alignleft inline-edit-or">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <span class="alignleft inline-edit-or">
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: Between password field and private checkbox on post quick edit interface. */
</span><span class="cx" style="display: block; padding: 0 10px"> _e( '–OR–' );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- </em>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ </span>
</ins><span class="cx" style="display: block; padding: 0 10px"> <label class="alignleft inline-edit-private">
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="checkbox" name="keep_private" value="private" />
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="checkbox-title"><?php _e( 'Private' ); ?></span>
</span></span></pre></div>
<a id="trunksrcwpadminincludesimageeditphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/image-edit.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/image-edit.php 2020-02-18 09:25:25 UTC (rev 47303)
+++ trunk/src/wp-admin/includes/image-edit.php 2020-02-18 15:30:10 UTC (rev 47304)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -91,7 +91,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="imgedit-group">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="imgedit-group-top">
</span><span class="cx" style="display: block; padding: 0 10px"> <h2><button type="button" onclick="imageEdit.toggleHelp(this);" class="button-link"><?php _e( 'Restore Original Image' ); ?> <span class="dashicons dashicons-arrow-down imgedit-help-toggle"></span></button></h2>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div class="imgedit-help">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="imgedit-help imgedit-restore">
</ins><span class="cx" style="display: block; padding: 0 10px"> <p>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> _e( 'Discard any changes and restore the original image.' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -159,7 +159,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="imgedit-group-top">
</span><span class="cx" style="display: block; padding: 0 10px"> <h2><?php _e( 'Thumbnail Settings' ); ?></h2>
</span><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="dashicons dashicons-editor-help imgedit-help-toggle" onclick="imageEdit.toggleHelp(this);return false;" aria-expanded="false"><span class="screen-reader-text"><?php esc_html_e( 'Thumbnail Settings Help' ); ?></span></button>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="imgedit-help"><?php _e( 'You can edit the image while preserving the thumbnail. For example, you may wish to have a square thumbnail that displays just a section of the image.' ); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="imgedit-help">
+ <p><?php _e( 'You can edit the image while preserving the thumbnail. For example, you may wish to have a square thumbnail that displays just a section of the image.' ); ?></p>
+ </div>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <figure class="imgedit-thumbnail-preview">
</span></span></pre>
</div>
</div>
</body>
</html>