<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[47221] trunk: Toolbar: Load toolbar in `wp_body_open` when available.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/47221">47221</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/47221","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joedolson</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-02-09 18:24:41 +0000 (Sun, 09 Feb 2020)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Toolbar: Load toolbar in `wp_body_open` when available.

For accessibility, the visual appearance and source order should match. Moving the toolbar to load in the new hook `wp_body_open` (5.2) fixes a long-standing source order problem.

Props jankimoradiya, afercia, SergeyBiryukov, audrasjb, ocean90, xkon, dinhtungdu.
Fixes <a href="https://core.trac.wordpress.org/ticket/47053">#47053</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkpackagelockjson">trunk/package-lock.json</a></li>
<li><a href="#trunksrcwpincludesdefaultfiltersphp">trunk/src/wp-includes/default-filters.php</a></li>
<li><a href="#trunksrcwpincludesgeneraltemplatephp">trunk/src/wp-includes/general-template.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkpackagelockjson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/package-lock.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/package-lock.json   2020-02-09 17:06:55 UTC (rev 47220)
+++ trunk/package-lock.json     2020-02-09 18:24:41 UTC (rev 47221)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5015,7 +5015,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "bl": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "1.2.2",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/bl/-/bl-1.2.2.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/bl/-/bl-1.2.2.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-e8tQYnZodmebYDWGH7KMRvtzKXaJHx3BbilrgZCfvyLUYdKpK1t5PSPmpkny/SgiTSCnjfLW7v5rlONXVFkQEA==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true,
</span><span class="cx" style="display: block; padding: 0 10px">                        "optional": true,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5206,7 +5206,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "browserify-aes": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "1.2.0",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/browserify-aes/-/browserify-aes-1.2.0.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-+7CHXqGuspUn/Sl5aO7Ea0xWGAtETPXNSAjHo48JfLdPWcMng33Xe4znFvQweqc/uzk5zSOI3H52CYnjCfb5hA==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true,
</span><span class="cx" style="display: block; padding: 0 10px">                        "requires": {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6496,7 +6496,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "create-hash": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "1.2.0",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/create-hash/-/create-hash-1.2.0.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-z00bCGNHDG8mHAkP7CtT1qVu+bFQUPjYq/4Iv3C3kWjTFV10zIjfSoeqXo9Asws8gwSHDGj/hl2u4OGIjapeCg==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true,
</span><span class="cx" style="display: block; padding: 0 10px">                        "requires": {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6509,7 +6509,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "create-hmac": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "1.1.7",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/create-hmac/-/create-hmac-1.1.7.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-MJG9liiZ+ogc4TzUwuvbER1JRdgvUFSB5+VR/g5h82fGaIRWMWddtKBHi7/sVhfjQZ6SehlyhvQYrcYkaUIpLg==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true,
</span><span class="cx" style="display: block; padding: 0 10px">                        "requires": {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6575,7 +6575,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "css-color-names": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "0.0.4",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/css-color-names/-/css-color-names-0.0.4.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/css-color-names/-/css-color-names-0.0.4.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha1-gIrcLnnPhHOAabZGyyDsJ762KeA=",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -7471,7 +7471,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "diffie-hellman": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "5.0.3",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/diffie-hellman/-/diffie-hellman-5.0.3.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-kqag/Nl+f3GwyK25fhUMYj81BUOrZ9IuJsjIcDE5icNM9FJHAVm3VcUDxdLPoQtTuUylWm6ZIknYJwwaPxsUzg==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true,
</span><span class="cx" style="display: block; padding: 0 10px">                        "requires": {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -7692,7 +7692,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "duplexer": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "0.1.1",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/duplexer/-/duplexer-0.1.1.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/duplexer/-/duplexer-0.1.1.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha1-rOb/gIwc5mtX0ev5eXessCM0z8E=",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16929,7 +16929,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        "dependencies": {
</span><span class="cx" style="display: block; padding: 0 10px">                                "progress": {
</span><span class="cx" style="display: block; padding: 0 10px">                                        "version": "1.1.8",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        "resolved": "http://registry.npmjs.org/progress/-/progress-1.1.8.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 "resolved": "https://registry.npmjs.org/progress/-/progress-1.1.8.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                                         "integrity": "sha1-4mDHj2Fhzdmw5WzD4Khd4Xx6V74=",
</span><span class="cx" style="display: block; padding: 0 10px">                                        "dev": true
</span><span class="cx" style="display: block; padding: 0 10px">                                }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18116,7 +18116,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "react-autosize-textarea": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "3.0.3",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/react-autosize-textarea/-/react-autosize-textarea-3.0.3.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/react-autosize-textarea/-/react-autosize-textarea-3.0.3.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-iOSZK7RUuJ+iEwkJ9rqYciqtjQgrG1CCRFL6h8Bk61kODnRyEq4tS74IgXpI1t4S6jBBZVm+6ugaU+tWTlVxXg==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "requires": {
</span><span class="cx" style="display: block; padding: 0 10px">                                "autosize": "^4.0.0",
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18528,7 +18528,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "regjsgen": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "0.2.0",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/regjsgen/-/regjsgen-0.2.0.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/regjsgen/-/regjsgen-0.2.0.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha1-bAFq3qxVT3WCP+N6wFuS1aTtsfc="
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "regjsparser": {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19497,7 +19497,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                },
</span><span class="cx" style="display: block; padding: 0 10px">                "sha.js": {
</span><span class="cx" style="display: block; padding: 0 10px">                        "version": "2.4.11",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "resolved": "http://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 "resolved": "https://registry.npmjs.org/sha.js/-/sha.js-2.4.11.tgz",
</ins><span class="cx" style="display: block; padding: 0 10px">                         "integrity": "sha512-QMEp5B7cftE7APOjk5Y6xgrbWu+WkLVQwk8JNjZ8nKRciZaByEW6MubieAiToS7+dwvrjGhH8jRXz3MVd0AYqQ==",
</span><span class="cx" style="display: block; padding: 0 10px">                        "dev": true,
</span><span class="cx" style="display: block; padding: 0 10px">                        "requires": {
</span></span></pre></div>
<a id="trunksrcwpincludesdefaultfiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/default-filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/default-filters.php 2020-02-09 17:06:55 UTC (rev 47220)
+++ trunk/src/wp-includes/default-filters.php   2020-02-09 18:24:41 UTC (rev 47221)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -537,7 +537,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_init', '_wp_admin_bar_init' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'before_signup_header', '_wp_admin_bar_init' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'activate_header', '_wp_admin_bar_init' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_action( 'wp_footer', 'wp_admin_bar_render', 1000 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+add_action( 'wp_body_open', 'wp_admin_bar_render', 0 );
</ins><span class="cx" style="display: block; padding: 0 10px"> add_action( 'in_admin_header', 'wp_admin_bar_render', 0 );
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px"> // Former admin filters that can also be hooked on the front end.
</span></span></pre></div>
<a id="trunksrcwpincludesgeneraltemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/general-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/general-template.php        2020-02-09 17:06:55 UTC (rev 47220)
+++ trunk/src/wp-includes/general-template.php  2020-02-09 18:24:41 UTC (rev 47221)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2890,6 +2890,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">  */
</span><span class="cx" style="display: block; padding: 0 10px"> function wp_footer() {
</span><span class="cx" style="display: block; padding: 0 10px">        /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         * Sets up the Admin Bar if the current theme does not use `wp_body_open`.
+        *
+        * @since 5.4.0
+        */
+       if ( ! did_action( 'wp_body_open' ) ) {
+               add_action( 'wp_footer', 'wp_admin_bar_render', 1000 );
+       }
+       /**
</ins><span class="cx" style="display: block; padding: 0 10px">          * Prints scripts or data before the closing body tag on the front end.
</span><span class="cx" style="display: block; padding: 0 10px">         *
</span><span class="cx" style="display: block; padding: 0 10px">         * @since 1.5.1
</span></span></pre>
</div>
</div>

</body>
</html>