<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[47168] trunk/tools/webpack/packages.js: Build: Copy block metadata files for dynamic blocks.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/47168">47168</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/47168","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>gziolo</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-02-02 19:17:07 +0000 (Sun, 02 Feb 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build: Copy block metadata files for dynamic blocks.
For dynamic blocks, there are several blocks whose metadata needs to be loaded in PHP. The attributes that are loaded via PHP are not exposed to the ReactNative components when Gutenberg loads the index.js files in the Mobile Apps. To support one master set of metadata that can be used to register in the PHP files and the Javascript files; with this patch, the block.json files are copied over with their corresponding PHP files.
Props chipsnyder and azaozz.
Fixes <a href="https://core.trac.wordpress.org/ticket/49196">#49196</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktoolswebpackpackagesjs">trunk/tools/webpack/packages.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktoolswebpackpackagesjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tools/webpack/packages.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tools/webpack/packages.js 2020-02-02 15:48:37 UTC (rev 47167)
+++ trunk/tools/webpack/packages.js 2020-02-02 19:17:07 UTC (rev 47168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -94,19 +94,30 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-polyfill-node-contains.min.js': 'polyfill-library/polyfills/Node/prototype/contains/polyfill.js',
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ const blockNames = [
+ 'archives',
+ 'block',
+ 'calendar',
+ 'categories',
+ 'latest-comments',
+ 'latest-posts',
+ 'rss',
+ 'search',
+ 'shortcode',
+ 'tag-cloud',
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px"> const phpFiles = {
</span><span class="cx" style="display: block; padding: 0 10px"> 'block-serialization-default-parser/parser.php': 'wp-includes/class-wp-block-parser.php',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'block-library/src/archives/index.php': 'wp-includes/blocks/archives.php',
- 'block-library/src/block/index.php': 'wp-includes/blocks/block.php',
- 'block-library/src/calendar/index.php': 'wp-includes/blocks/calendar.php',
- 'block-library/src/categories/index.php': 'wp-includes/blocks/categories.php',
- 'block-library/src/latest-comments/index.php': 'wp-includes/blocks/latest-comments.php',
- 'block-library/src/latest-posts/index.php': 'wp-includes/blocks/latest-posts.php',
- 'block-library/src/rss/index.php': 'wp-includes/blocks/rss.php',
- 'block-library/src/search/index.php': 'wp-includes/blocks/search.php',
- 'block-library/src/shortcode/index.php': 'wp-includes/blocks/shortcode.php',
- 'block-library/src/tag-cloud/index.php': 'wp-includes/blocks/tag-cloud.php',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ...blockNames.reduce( ( files, blockName ) => {
+ files[ `block-library/src/${ blockName }/index.php` ] = `wp-includes/blocks/${ blockName }.php`;
+ return files;
+ } , {} ),
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ const blockMetadataCopies = {
+ from: join( baseDir, `node_modules/@wordpress/block-library/src/+(${ blockNames.join( '|' ) })/block.json` ),
+ test: new RegExp( `\/([^/]+)\/block\.json$` ),
+ to: join( baseDir, `${ buildTarget }/blocks/[1]/block.json` ),
+ };
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> const developmentCopies = mapVendorCopies( vendors, buildTarget );
</span><span class="cx" style="display: block; padding: 0 10px"> const minifiedCopies = mapVendorCopies( minifiedVendors, buildTarget );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -231,6 +242,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ...vendorCopies,
</span><span class="cx" style="display: block; padding: 0 10px"> ...cssCopies,
</span><span class="cx" style="display: block; padding: 0 10px"> ...phpCopies,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ blockMetadataCopies,
</ins><span class="cx" style="display: block; padding: 0 10px"> ],
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span></span></pre>
</div>
</div>
</body>
</html>