<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[47164] trunk/src: Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/47164">47164</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/47164","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-02-02 04:13:25 +0000 (Sun, 02 Feb 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
The original script was deprecated in <a href="https://core.trac.wordpress.org/changeset/30338">[30338]</a> and removed in <a href="https://core.trac.wordpress.org/changeset/32677">[32677]</a>.
Props Presskopp, ketuchetan.
Fixes <a href="https://core.trac.wordpress.org/ticket/39448">#39448</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesdeprecatedmediagalleryjs">trunk/src/js/_enqueues/deprecated/media-gallery.js</a></li>
<li><a href="#trunksrcwpadminincludesupdatecorephp">trunk/src/wp-admin/includes/update-core.php</a></li>
<li><a href="#trunksrcwpincludesclasswpeditorphp">trunk/src/wp-includes/class-wp-editor.php</a></li>
<li><a href="#trunksrcwpincludesscriptloaderphp">trunk/src/wp-includes/script-loader.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesdeprecatedfullscreenstubjs">trunk/src/js/_enqueues/deprecated/fullscreen-stub.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesdeprecatedfullscreenstubjs"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/src/js/_enqueues/deprecated/fullscreen-stub.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/deprecated/fullscreen-stub.js 2020-02-02 04:07:50 UTC (rev 47163)
+++ trunk/src/js/_enqueues/deprecated/fullscreen-stub.js 2020-02-02 04:13:25 UTC (rev 47164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,40 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/**
- * Distraction-Free Writing (wp-fullscreen) backward compatibility stub.
- *
- * @deprecated 4.1
- * @removed 4.3.
- * @output wp-admin/js/wp-fullscreen-stub.js
- */
-( function() {
- var noop = function(){};
-
- window.wp = window.wp || {};
- window.wp.editor = window.wp.editor || {};
- window.wp.editor.fullscreen = {
- bind_resize: noop,
- dfwWidth: noop,
- off: noop,
- on: noop,
- refreshButtons: noop,
- resizeTextarea: noop,
- save: noop,
- switchmode: noop,
- toggleUI: noop,
-
- settings: {},
- pubsub: {
- publish: noop,
- subscribe: noop,
- unsubscribe: noop,
- topics: {}
- },
- fade: {
- In: noop,
- Out: noop
- },
- ui: {
- fade: noop,
- init: noop
- }
- };
-}());
</del></span></pre></div>
<a id="trunksrcjs_enqueuesdeprecatedmediagalleryjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/deprecated/media-gallery.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/deprecated/media-gallery.js 2020-02-02 04:07:50 UTC (rev 47163)
+++ trunk/src/js/_enqueues/deprecated/media-gallery.js 2020-02-02 04:13:25 UTC (rev 47164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,7 +1,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * This file is used on media-upload.php which has been replaced by media-new.php and upload.php
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @deprecated 3.5.0
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @deprecated 3.5.0
</ins><span class="cx" style="display: block; padding: 0 10px"> * @output wp-admin/js/media-gallery.js
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesupdatecorephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/update-core.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/update-core.php 2020-02-02 04:07:50 UTC (rev 47163)
+++ trunk/src/wp-admin/includes/update-core.php 2020-02-02 04:13:25 UTC (rev 47164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -789,6 +789,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // 5.3
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-includes/js/wp-a11y.js', // Moved to: wp-includes/js/dist/a11y.js
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-includes/js/wp-a11y.min.js', // Moved to: wp-includes/js/dist/a11y.min.js
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // 5.4
+ 'wp-admin/js/wp-fullscreen-stub.js',
+ 'wp-admin/js/wp-fullscreen-stub.min.js',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpeditorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-editor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-editor.php 2020-02-02 04:07:50 UTC (rev 47163)
+++ trunk/src/wp-includes/class-wp-editor.php 2020-02-02 04:13:25 UTC (rev 47164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,7 +25,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> private static $has_medialib = false;
</span><span class="cx" style="display: block; padding: 0 10px"> private static $editor_buttons_css = true;
</span><span class="cx" style="display: block; padding: 0 10px"> private static $drag_drop_upload = false;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- private static $old_dfw_compat = false;
</del><span class="cx" style="display: block; padding: 0 10px"> private static $translation;
</span><span class="cx" style="display: block; padding: 0 10px"> private static $tinymce_scripts_printed = false;
</span><span class="cx" style="display: block; padding: 0 10px"> private static $link_dialog_printed = false;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -58,8 +57,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $editor_class Extra classes to add to the editor textarea element. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $teeny Whether to output the minimal editor config. Examples include
</span><span class="cx" style="display: block; padding: 0 10px"> * Press This and the Comment editor. Default false.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @type bool $dfw Deprecated in 4.1. Since 4.3 used only to enqueue wp-fullscreen-stub.js
- * for backward compatibility.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type bool $dfw Deprecated in 4.1. Unused.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type bool|array $tinymce Whether to load TinyMCE. Can be used to pass settings directly to
</span><span class="cx" style="display: block; padding: 0 10px"> * TinyMCE using an array. Default true.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool|array $quicktags Whether to load Quicktags. Can be used to pass settings directly to
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -97,7 +95,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'editor_css' => '',
</span><span class="cx" style="display: block; padding: 0 10px"> 'editor_class' => '',
</span><span class="cx" style="display: block; padding: 0 10px"> 'teeny' => false,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'dfw' => false,
</del><span class="cx" style="display: block; padding: 0 10px"> '_content_editor_dfw' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'tinymce' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'quicktags' => true,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -123,10 +120,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> self::$has_quicktags = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $set['dfw'] ) {
- self::$old_dfw_compat = true;
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $set['editor_height'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return $set;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -872,10 +865,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'jquery-ui-autocomplete' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( self::$old_dfw_compat ) {
- wp_enqueue_script( 'wp-fullscreen-stub' );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( self::$has_medialib ) {
</span><span class="cx" style="display: block; padding: 0 10px"> add_thickbox();
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'media-upload' );
</span></span></pre></div>
<a id="trunksrcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/script-loader.php 2020-02-02 04:07:50 UTC (rev 47163)
+++ trunk/src/wp-includes/script-loader.php 2020-02-02 04:13:25 UTC (rev 47164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -716,9 +716,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $scripts->add( 'clipboard', "/wp-includes/js/clipboard$suffix.js", array(), false, 1 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Back-compat for old DFW. To-do: remove at the end of 2016.
- $scripts->add( 'wp-fullscreen-stub', "/wp-admin/js/wp-fullscreen-stub$suffix.js", array(), false, 1 );
-
</del><span class="cx" style="display: block; padding: 0 10px"> $scripts->add( 'wp-ajax-response', "/wp-includes/js/wp-ajax-response$suffix.js", array( 'jquery' ), false, 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> did_action( 'init' ) && $scripts->localize(
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-ajax-response',
</span></span></pre>
</div>
</div>
</body>
</html>