<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46864] trunk: Date/Time: XML-RPC: {U+0421}alculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46864">46864</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46864","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-12-09 19:54:16 +0000 (Mon, 09 Dec 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Date/Time: XML-RPC: {U+0421}alculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set.
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.
Add unit tests.
Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes <a href="https://core.trac.wordpress.org/ticket/30429">#30429</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpxmlrpcserverphp">trunk/src/wp-includes/class-wp-xmlrpc-server.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsdatexmlrpcphp">trunk/tests/phpunit/tests/date/xmlrpc.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswpxmlrpcserverphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-xmlrpc-server.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-xmlrpc-server.php 2019-12-09 19:00:18 UTC (rev 46863)
+++ trunk/src/wp-includes/class-wp-xmlrpc-server.php 2019-12-09 19:54:16 UTC (rev 46864)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1469,8 +1469,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $post_data['edit_date'] = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $dateCreated ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_data['post_date'] = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
- $post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post_data['post_date'] = iso8601_to_datetime( $dateCreated );
+ $post_data['post_date_gmt'] = iso8601_to_datetime( $dateCreated, 'gmt' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Flag the post date to be edited.
</span><span class="cx" style="display: block; padding: 0 10px"> $post_data['edit_date'] = true;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3766,8 +3766,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $content_struct['date_created_gmt'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // We know this is supposed to be GMT, so we're going to slap that Z on there by force
</span><span class="cx" style="display: block; padding: 0 10px"> $dateCreated = rtrim( $content_struct['date_created_gmt']->getIso(), 'Z' ) . 'Z';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $comment['comment_date'] = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
- $comment['comment_date_gmt'] = iso8601_to_datetime( $dateCreated, 'GMT' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $comment['comment_date'] = get_date_from_gmt( $dateCreated );
+ $comment['comment_date_gmt'] = iso8601_to_datetime( $dateCreated, 'gmt' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $content_struct['content'] ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5485,8 +5485,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $dateCreated ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_date = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
- $post_date_gmt = iso8601_to_datetime( $dateCreated, 'GMT' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post_date = iso8601_to_datetime( $dateCreated );
+ $post_date_gmt = iso8601_to_datetime( $dateCreated, 'gmt' );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $post_date = '';
</span><span class="cx" style="display: block; padding: 0 10px"> $post_date_gmt = '';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5874,8 +5874,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $edit_date = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $dateCreated ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_date = get_date_from_gmt( iso8601_to_datetime( $dateCreated ) );
- $post_date_gmt = iso8601_to_datetime( $dateCreated, 'GMT' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post_date = iso8601_to_datetime( $dateCreated );
+ $post_date_gmt = iso8601_to_datetime( $dateCreated, 'gmt' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Flag the post date to be edited.
</span><span class="cx" style="display: block; padding: 0 10px"> $edit_date = true;
</span></span></pre></div>
<a id="trunktestsphpunittestsdatexmlrpcphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/date/xmlrpc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/date/xmlrpc.php (rev 0)
+++ trunk/tests/phpunit/tests/date/xmlrpc.php 2019-12-09 19:54:16 UTC (rev 46864)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,240 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group date
+ * @group datetime
+ * @group xmlrpc
+ */
+class Tests_Date_XMLRPC extends WP_XMLRPC_UnitTestCase {
+
+ /**
+ * @ticket 30429
+ */
+ public function test_date_new_post() {
+ $timezone = 'Europe/Kiev';
+ update_option( 'timezone_string', $timezone );
+
+ $datetime = new DateTimeImmutable( 'now', new DateTimeZone( $timezone ) );
+ $datetimeutc = $datetime->setTimezone( new DateTimeZone( 'UTC' ) );
+
+ $this->make_user_by_role( 'editor' );
+
+ $post = get_post(
+ $this->myxmlrpcserver->mw_newPost(
+ array(
+ 1,
+ 'editor',
+ 'editor',
+ array(
+ 'title' => 'test',
+ 'post_content' => 'test',
+ 'dateCreated' => new IXR_Date( $datetimeutc->format( 'Ymd\TH:i:s\Z' ) ),
+ ),
+ )
+ )
+ );
+
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $post->post_date,
+ 'UTC time with explicit time zone into mw_newPost'
+ );
+
+ $post = get_post(
+ $this->myxmlrpcserver->mw_newPost(
+ array(
+ 1,
+ 'editor',
+ 'editor',
+ array(
+ 'title' => 'test',
+ 'post_content' => 'test',
+ 'dateCreated' => new IXR_Date( $datetime->format( 'Ymd\TH:i:s' ) ),
+ ),
+ )
+ )
+ );
+
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $post->post_date,
+ 'Local time w/o time zone into mw_newPost'
+ );
+
+ $post = get_post(
+ $this->myxmlrpcserver->mw_newPost(
+ array(
+ 1,
+ 'editor',
+ 'editor',
+ array(
+ 'title' => 'test',
+ 'post_content' => 'test',
+ 'date_created_gmt' => new IXR_Date( $datetimeutc->format( 'Ymd\TH:i:s' ) ),
+ ),
+ )
+ )
+ );
+
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $post->post_date,
+ 'UTC time into mw_newPost'
+ );
+
+ $post = get_post(
+ $this->myxmlrpcserver->wp_newPost(
+ array(
+ 1,
+ 'editor',
+ 'editor',
+ array(
+ 'title' => 'test',
+ 'post_content' => 'test',
+ 'post_date' => $datetime->format( 'Ymd\TH:i:s' ),
+ ),
+ )
+ )
+ );
+
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $post->post_date,
+ 'Local time into wp_newPost'
+ );
+
+ $post = get_post(
+ $this->myxmlrpcserver->wp_newPost(
+ array(
+ 1,
+ 'editor',
+ 'editor',
+ array(
+ 'title' => 'test',
+ 'post_content' => 'test',
+ 'post_date_gmt' => $datetimeutc->format( 'Ymd\TH:i:s' ),
+ ),
+ )
+ )
+ );
+
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $post->post_date,
+ 'UTC time into wp_newPost'
+ );
+ }
+
+ /**
+ * @ticket 30429
+ */
+ public function test_date_edit_post() {
+ $timezone = 'Europe/Kiev';
+ update_option( 'timezone_string', $timezone );
+
+ $datetime = new DateTimeImmutable( 'now', new DateTimeZone( $timezone ) );
+ $datetimeutc = $datetime->setTimezone( new DateTimeZone( 'UTC' ) );
+
+ $editor_id = $this->make_user_by_role( 'editor' );
+
+ $post_id = self::factory()->post->create(
+ array(
+ 'post_author' => $editor_id,
+ 'post_date' => $datetime->modify( '-1 hour' )->format( 'Y-m-d H:i:s' ),
+ )
+ );
+
+ $result = $this->myxmlrpcserver->mw_editPost(
+ array(
+ $post_id,
+ 'editor',
+ 'editor',
+ array(
+ 'dateCreated' => new IXR_Date( $datetime->format( 'Ymd\TH:i:s' ) ),
+ ),
+ )
+ );
+
+ $fetched_post = get_post( $post_id );
+
+ $this->assertTrue( $result );
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $fetched_post->post_date,
+ 'Local time into mw_editPost'
+ );
+
+ $post_id = self::factory()->post->create(
+ array(
+ 'post_author' => $editor_id,
+ 'post_date' => $datetime->modify( '-1 hour' )->format( 'Y-m-d H:i:s' ),
+ )
+ );
+
+ $result = $this->myxmlrpcserver->mw_editPost(
+ array(
+ $post_id,
+ 'editor',
+ 'editor',
+ array(
+ 'date_created_gmt' => new IXR_Date( $datetimeutc->format( 'Ymd\TH:i:s' ) ),
+ ),
+ )
+ );
+
+ $fetched_post = get_post( $post_id );
+
+ $this->assertTrue( $result );
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $fetched_post->post_date,
+ 'UTC time into mw_editPost'
+ );
+ }
+
+ /**
+ * @ticket 30429
+ */
+ function test_date_edit_comment() {
+ $timezone = 'Europe/Kiev';
+ update_option( 'timezone_string', $timezone );
+
+ $datetime = new DateTimeImmutable( 'now', new DateTimeZone( $timezone ) );
+ $datetime = $datetime->modify( '-1 hour' );
+ $datetimeutc = $datetime->setTimezone( new DateTimeZone( 'UTC' ) );
+
+ $this->make_user_by_role( 'administrator' );
+ $post_id = $this->factory->post->create();
+
+ $comment_data = array(
+ 'comment_post_ID' => $post_id,
+ 'comment_author' => 'Test commenter',
+ 'comment_author_url' => 'http://example.com/',
+ 'comment_author_email' => 'example@example.com',
+ 'comment_content' => rand_str( 100 ),
+ 'comment_approved' => '1',
+ );
+ $comment_id = wp_insert_comment( $comment_data );
+
+ $result = $this->myxmlrpcserver->wp_editComment(
+ array(
+ 1,
+ 'administrator',
+ 'administrator',
+ $comment_id,
+ array(
+ 'date_created_gmt' => new IXR_Date( $datetimeutc->format( 'Ymd\TH:i:s' ) ),
+ ),
+ )
+ );
+
+ $fetched_comment = get_comment( $comment_id );
+
+ $this->assertTrue( $result );
+ $this->assertEquals(
+ $datetime->format( 'Y-m-d H:i:s' ),
+ $fetched_comment->comment_date,
+ 'UTC time into wp_editComment'
+ );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/tests/date/xmlrpc.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>