<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46815] trunk/src/wp-admin/css/colors: Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46815">46815</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46815","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-12-05 21:30:58 +0000 (Thu, 05 Dec 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes <a href="https://core.trac.wordpress.org/ticket/48585">#48585</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsscolors_adminscss">trunk/src/wp-admin/css/colors/_admin.scss</a></li>
<li><a href="#trunksrcwpadmincsscolors_mixinsscss">trunk/src/wp-admin/css/colors/_mixins.scss</a></li>
<li><a href="#trunksrcwpadmincsscolors_variablesscss">trunk/src/wp-admin/css/colors/_variables.scss</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsscolors_adminscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/colors/_admin.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/colors/_admin.scss 2019-12-05 13:46:43 UTC (rev 46814)
+++ trunk/src/wp-admin/css/colors/_admin.scss 2019-12-05 21:30:58 UTC (rev 46815)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -75,33 +75,29 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-core-ui {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .button,
- .button-secondary {
- color: $button-color;
- border-color: $button-color;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .button {
+ border-color: #7e8993;
+ color: #32373c;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .button.hover,
</span><span class="cx" style="display: block; padding: 0 10px"> .button:hover,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .button-secondary:hover,
</del><span class="cx" style="display: block; padding: 0 10px"> .button.focus,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .button:focus,
- .button-secondary:focus {
- border-color: darken( $button-color, 5% );
- color: darken( $button-color, 5% );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .button:focus {
+ border-color: darken( #7e8993, 5% );
+ color: darken( #32373c, 5% );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .button.focus,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .button:focus,
- .button-secondary:focus {
- border-color: $button-color;
- color: darken( $button-color, 5% );
- box-shadow: 0 0 0 1px $button-color;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .button:focus {
+ border-color: $highlight-color;
+ box-shadow: 0 0 0 1px $highlight-color;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .button:active {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- background: darken( $button-color, 5% );
- border-color: darken( $button-color, 5% );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ border-color: #7e8993;
+ color: darken( #32373c, 5% );
+ box-shadow: none;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .button.active,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -108,8 +104,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .button.active:focus,
</span><span class="cx" style="display: block; padding: 0 10px"> .button.active:hover {
</span><span class="cx" style="display: block; padding: 0 10px"> border-color: darken( $button-color, 5% );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: darken( $button-color, 5% );
- box-shadow: inset 0 2px 5px -3px darken( $button-color, 5% );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ color: darken( $button-text-color, 5% );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .button-primary {
</span></span></pre></div>
<a id="trunksrcwpadmincsscolors_mixinsscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/colors/_mixins.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/colors/_mixins.scss 2019-12-05 13:46:43 UTC (rev 46814)
+++ trunk/src/wp-admin/css/colors/_mixins.scss 2019-12-05 21:30:58 UTC (rev 46815)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,13 +5,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> @mixin button( $button-color, $text-color: #fff ) {
</span><span class="cx" style="display: block; padding: 0 10px"> background: $button-color;
</span><span class="cx" style="display: block; padding: 0 10px"> border-color: $button-color;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: $text-color;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ color: $button-text-color;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> &:hover,
</span><span class="cx" style="display: block; padding: 0 10px"> &:focus {
</span><span class="cx" style="display: block; padding: 0 10px"> background: lighten( $button-color, 3% );
</span><span class="cx" style="display: block; padding: 0 10px"> border-color: darken( $button-color, 3% );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: $text-color;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ color: $button-text-color;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> &:focus {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -23,7 +23,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> &:active {
</span><span class="cx" style="display: block; padding: 0 10px"> background: darken( $button-color, 5% );
</span><span class="cx" style="display: block; padding: 0 10px"> border-color: darken( $button-color, 5% );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: $text-color;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ color: $button-text-color;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> &.active,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -30,7 +30,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> &.active:focus,
</span><span class="cx" style="display: block; padding: 0 10px"> &.active:hover {
</span><span class="cx" style="display: block; padding: 0 10px"> background: $button-color;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: $text-color;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ color: $button-text-color;
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: darken( $button-color, 15% );
</span><span class="cx" style="display: block; padding: 0 10px"> box-shadow: inset 0 2px 5px -3px darken( $button-color, 50% );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadmincsscolors_variablesscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/colors/_variables.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/colors/_variables.scss 2019-12-05 13:46:43 UTC (rev 46814)
+++ trunk/src/wp-admin/css/colors/_variables.scss 2019-12-05 21:30:58 UTC (rev 46815)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,8 +18,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $link-focus: lighten( $link, 10% ) !default;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $button-color: $highlight-color !default;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-$form-checked: $highlight-color !default;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+$button-text-color: $text-color !default;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+$form-checked: #7e8993 !default;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // admin menu & admin-bar
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>