<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46650] trunk: Login and Registration: Simplify the test for `wp_signon()` added in [46640].</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46650">46650</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46650","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-11-04 15:04:41 +0000 (Mon, 04 Nov 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Login and Registration: Simplify the test for `wp_signon()` added in <a href="https://core.trac.wordpress.org/changeset/46640">[46640]</a>.
Make sure it actually tests the change in behavior, previously it passed both before and after the patch.
Add `wp_unslash()` to the last remaining instance of `$_POST['user_login']` that didn't have it.
See <a href="https://core.trac.wordpress.org/ticket/38744">#38744</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwploginphp">trunk/src/wp-login.php</a></li>
<li><a href="#trunktestsphpunittestsauthphp">trunk/tests/phpunit/tests/auth.php</a></li>
<li><a href="#trunktestsphpunittestsuserphp">trunk/tests/phpunit/tests/user.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwploginphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-login.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-login.php 2019-11-04 12:57:17 UTC (rev 46649)
+++ trunk/src/wp-login.php 2019-11-04 15:04:41 UTC (rev 46650)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -373,7 +373,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $errors->add( 'invalid_email', __( '<strong>ERROR</strong>: There is no account with that username or email address.' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $login = trim( $_POST['user_login'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $login = trim( wp_unslash( $_POST['user_login'] ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $user_data = get_user_by( 'login', $login );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestsauthphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/auth.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/auth.php 2019-11-04 12:57:17 UTC (rev 46649)
+++ trunk/tests/phpunit/tests/auth.php 2019-11-04 15:04:41 UTC (rev 46650)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -387,7 +387,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 9568
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function test_log_in_using_email() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_log_in_using_email() {
</ins><span class="cx" style="display: block; padding: 0 10px"> $user_args = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'user_login' => 'johndoe',
</span><span class="cx" style="display: block; padding: 0 10px"> 'user_email' => 'mail@example.com',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -398,4 +398,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertInstanceOf( 'WP_User', wp_authenticate( $user_args['user_email'], $user_args['user_pass'] ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertInstanceOf( 'WP_User', wp_authenticate( $user_args['user_login'], $user_args['user_pass'] ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @ticket 38744
+ */
+ public function test_wp_signon_using_email_with_an_apostrophe() {
+ $user_args = array(
+ 'user_email' => "mail\'@example.com",
+ 'user_pass' => 'password',
+ );
+ $this->factory()->user->create( $user_args );
+
+ $_POST['log'] = $user_args['user_email'];
+ $_POST['pwd'] = $user_args['user_pass'];
+ $this->assertInstanceOf( 'WP_User', wp_signon() );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestsuserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/user.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user.php 2019-11-04 12:57:17 UTC (rev 46649)
+++ trunk/tests/phpunit/tests/user.php 2019-11-04 15:04:41 UTC (rev 46650)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,22 +35,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> self::$user_ids[] = self::$contrib_id;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- self::$user_ids[] = $factory->user->create(
- array(
- 'user_login' => "testemailaddress'@test.com",
- 'user_nicename' => 'user_email_with_apostrophe',
- 'user_pass' => 'password',
- 'first_name' => 'John',
- 'last_name' => 'Doe',
- 'display_name' => 'John Doe',
- 'user_email' => "testemailaddress'@test.com",
- 'user_url' => 'http://tacos.com',
- 'role' => 'contributor',
- 'nickname' => 'Johnny',
- 'description' => 'I am a WordPress user that cares about privacy.',
- )
- );
-
</del><span class="cx" style="display: block; padding: 0 10px"> self::$author_id = $factory->user->create(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'user_login' => 'author_login',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,8 +48,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> self::$user_ids[] = self::$admin_id;
</span><span class="cx" style="display: block; padding: 0 10px"> self::$editor_id = $factory->user->create(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'user_email' => 'test@test.com',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'role' => 'editor',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'user_email' => 'test@test.com',
</del><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> self::$user_ids[] = self::$editor_id;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -81,24 +65,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->author = clone self::$_author;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function test_that_you_can_login_with_an_email_that_has_apostrophe() {
-
- // Create the user with an email that has an apostrophe (see test setup).
-
- // Login as the user.
- $credentials = [
- 'user_login' => "testemailaddress'@test.com",
- 'user_password' => 'password',
- ];
-
- // Attempt to login.
- $user = wp_signon( $credentials );
-
- // Assert that the login was successfull.
- // If the login fails, an instance of WP_Error is returned rather than User object.
- $this->assertNotWPError( $user );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function test_get_users_of_blog() {
</span><span class="cx" style="display: block; padding: 0 10px"> // add one of each user role
</span><span class="cx" style="display: block; padding: 0 10px"> $nusers = array(
</span></span></pre>
</div>
</div>
</body>
</html>