<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46578] trunk/src/wp-admin/includes: Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46578">46578</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46578","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-10-25 12:49:40 +0000 (Fri, 25 Oct 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp.
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See <a href="https://core.trac.wordpress.org/ticket/48384">#48384</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswpmedialisttablephp">trunk/src/wp-admin/includes/class-wp-media-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswpmedialisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-media-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-media-list-table.php 2019-10-25 11:03:13 UTC (rev 46577)
+++ trunk/src/wp-admin/includes/class-wp-media-list-table.php 2019-10-25 12:49:40 UTC (rev 46578)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -452,19 +452,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( '0000-00-00 00:00:00' === $post->post_date ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $h_time = __( 'Unpublished' );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $m_time = $post->post_date;
- $time = get_post_time( 'G', true, $post, false );
- $t_diff = time() - $time;
- if ( ( abs( $t_diff ) ) < DAY_IN_SECONDS ) {
- if ( $t_diff < 0 ) {
- /* translators: %s: Human-readable time difference. */
- $h_time = sprintf( __( '%s from now' ), human_time_diff( $time ) );
- } else {
- /* translators: %s: Human-readable time difference. */
- $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $time = get_post_timestamp( $post );
+ $time_diff = time() - $time;
+
+ if ( $time && $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
+ /* translators: %s: Human-readable time difference. */
+ $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $h_time = mysql2date( __( 'Y/m/d' ), $m_time );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $h_time = get_the_time( __( 'Y/m/d' ), $post );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2019-10-25 11:03:13 UTC (rev 46577)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2019-10-25 12:49:40 UTC (rev 46578)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1066,17 +1066,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $h_time = $t_time;
</span><span class="cx" style="display: block; padding: 0 10px"> $time_diff = 0;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $t_time = get_the_time( __( 'Y/m/d g:i:s a' ) );
- $m_time = $post->post_date;
- $time = get_post_time( 'G', true, $post );
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $t_time = get_the_time( __( 'Y/m/d g:i:s a' ), $post );
+ $time = get_post_timestamp( $post );
</ins><span class="cx" style="display: block; padding: 0 10px"> $time_diff = time() - $time;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $time && $time_diff > 0 && $time_diff < DAY_IN_SECONDS ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Human-readable time difference. */
</span><span class="cx" style="display: block; padding: 0 10px"> $h_time = sprintf( __( '%s ago' ), human_time_diff( $time ) );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $h_time = mysql2date( __( 'Y/m/d' ), $m_time );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $h_time = get_the_time( __( 'Y/m/d' ), $post );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1584,6 +1582,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $users_opt['show_option_none'] = __( '— No Change —' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * Filters the arguments used to generate the Quick Edit authors drop-down.
+ *
+ * @since 5.3.0
+ *
+ * @see wp_dropdown_users()
+ *
+ * @param array $users_opt An array of arguments for wp_dropdown_users function.
+ * @param bool $bulk A boolean to know if it's a bulk action or not.
+ */
+ $users_opt = apply_filters( 'quick_edit_authors_query_args', $users_opt, $bulk );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $authors = wp_dropdown_users( $users_opt );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $authors ) :
</span><span class="cx" style="display: block; padding: 0 10px"> $authors_dropdown = '<label class="inline-edit-author">';
</span></span></pre>
</div>
</div>
</body>
</html>