<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46504] branches/3.8: Backporting several bug fixes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46504">46504</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46504","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>whyisjake</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-10-14 19:29:52 +0000 (Mon, 14 Oct 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Backporting several bug fixes.
- Query: Remove the static query property.
- HTTP API: Protect against hex interpretation.
- Filesystem API: Prevent directory travelersals when creating new folders.
- Administration: Ensure that admin referer nonce is valid.
- REST API: Send a Vary: Origin header on GET requests.
- Customizer: Properly sanitize background images.
Backports <a href="https://core.trac.wordpress.org/changeset/46474">[46474]</a>, <a href="https://core.trac.wordpress.org/changeset/46475">[46475]</a>, <a href="https://core.trac.wordpress.org/changeset/46476">[46476]</a>, <a href="https://core.trac.wordpress.org/changeset/46477">[46477]</a>, <a href="https://core.trac.wordpress.org/changeset/46478">[46478]</a>, <a href="https://core.trac.wordpress.org/changeset/46483">[46483]</a>, <a href="https://core.trac.wordpress.org/changeset/46485">[46485]</a> to the 3.8 branch.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches38packagejson">branches/3.8/package.json</a></li>
<li><a href="#branches38srcwpincludesclasswpphp">branches/3.8/src/wp-includes/class-wp.php</a></li>
<li><a href="#branches38srcwpincludesfunctionsphp">branches/3.8/src/wp-includes/functions.php</a></li>
<li><a href="#branches38srcwpincludeshttpphp">branches/3.8/src/wp-includes/http.php</a></li>
<li><a href="#branches38srcwpincludespluggablephp">branches/3.8/src/wp-includes/pluggable.php</a></li>
<li><a href="#branches38srcwpincludesqueryphp">branches/3.8/src/wp-includes/query.php</a></li>
<li><a href="#branches38testsphpunittestsauthphp">branches/3.8/tests/phpunit/tests/auth.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#branches38">branches/3.8/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/3.8
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/3.8 2019-10-14 19:26:08 UTC (rev 46503)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/3.8 2019-10-14 19:29:52 UTC (rev 46504)
</ins><a id="branches38"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/3.8</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/4.8:42478
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/4.9:42434
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.0:43988,43994,44014,44017,44047
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:26864,26874-26875,26885,26887-26888,26905,26919-26925,26928-26929,26932,26935,26952,26959,26961,26967,26970,26993,26999,27006-27007,27012,27021,27119,27134,27385,27511,27760,27822,27872,27905-27906,27928,27964,27975,27990,28053,28113,28129,29327,29378,29381-29382,29397,29404,29631,29783,30412,30417,30425,30430,30435,30438,30443,30458,30466,33124,33142,36083,36435,37651,38524,39645,39659,39759,39772,39795,39807-39808,39831,39850,39956,40148,40169,40183,40400,40604,40677,40692,40704,40723,40736,41393,41398,41457,41470,41483,41496,41522,41662,42056,42119-42120,42258-42261,42424,42433,42892-42893,44021,44048,44842,45936,45971,45997
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:26864,26874-26875,26885,26887-26888,26905,26919-26925,26928-26929,26932,26935,26952,26959,26961,26967,26970,26993,26999,27006-27007,27012,27021,27119,27134,27385,27511,27760,27822,27872,27905-27906,27928,27964,27975,27990,28053,28113,28129,29327,29378,29381-29382,29397,29404,29631,29783,30412,30417,30425,30430,30435,30438,30443,30458,30466,33124,33142,36083,36435,37651,38524,39645,39659,39759,39772,39795,39807-39808,39831,39850,39956,40148,40169,40183,40400,40604,40677,40692,40704,40723,40736,41393,41398,41457,41470,41483,41496,41522,41662,42056,42119-42120,42258-42261,42424,42433,42892-42893,44021,44048,44842,45936,45971,45997,46474-46478,46483,46485
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches38packagejson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/package.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/package.json 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/package.json 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -20,7 +20,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-contrib-concat": "~0.3.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-contrib-jshint": "~0.7.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-cssjanus": "git://github.com/yoavf/grunt-cssjanus.git#e0158f4087d1c4bb5a8d1648a63ef133338b5879",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "grunt-sass": "~0.8.0",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "grunt-sass": "~1.0.0",
</ins><span class="cx" style="display: block; padding: 0 10px"> "matchdep": "~0.1.2"
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="branches38srcwpincludesclasswpphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/src/wp-includes/class-wp.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/src/wp-includes/class-wp.php 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/src/wp-includes/class-wp.php 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -15,7 +15,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @access public
</span><span class="cx" style="display: block; padding: 0 10px"> * @var array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var $public_query_vars = array('m', 'p', 'posts', 'w', 'cat', 'withcomments', 'withoutcomments', 's', 'search', 'exact', 'sentence', 'calendar', 'page', 'paged', 'more', 'tb', 'pb', 'author', 'order', 'orderby', 'year', 'monthnum', 'day', 'hour', 'minute', 'second', 'name', 'category_name', 'tag', 'feed', 'author_name', 'static', 'pagename', 'page_id', 'error', 'comments_popup', 'attachment', 'attachment_id', 'subpost', 'subpost_id', 'preview', 'robots', 'taxonomy', 'term', 'cpage', 'post_type');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public $public_query_vars = array( 'm', 'p', 'posts', 'w', 'cat', 'withcomments', 'withoutcomments', 's', 'search', 'exact', 'sentence', 'calendar', 'page', 'paged', 'more', 'tb', 'pb', 'author', 'order', 'orderby', 'year', 'monthnum', 'day', 'hour', 'minute', 'second', 'name', 'category_name', 'tag', 'feed', 'author_name', 'pagename', 'page_id', 'error', 'comments_popup', 'attachment', 'attachment_id', 'subpost', 'subpost_id', 'preview', 'robots', 'taxonomy', 'term', 'cpage', 'post_type', 'embed' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Private query variables.
</span></span></pre></div>
<a id="branches38srcwpincludesfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/src/wp-includes/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/src/wp-includes/functions.php 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/src/wp-includes/functions.php 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1361,6 +1361,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( file_exists( $target ) )
</span><span class="cx" style="display: block; padding: 0 10px"> return @is_dir( $target );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Do not allow path traversals.
+ if ( false !== strpos( $target, '../' ) || false !== strpos( $target, '..' . DIRECTORY_SEPARATOR ) ) {
+ return false;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // We need to find the permissions of the parent folder that exists and inherit that.
</span><span class="cx" style="display: block; padding: 0 10px"> $target_parent = dirname( $target );
</span><span class="cx" style="display: block; padding: 0 10px"> while ( '.' != $target_parent && ! is_dir( $target_parent ) ) {
</span></span></pre></div>
<a id="branches38srcwpincludeshttpphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/src/wp-includes/http.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/src/wp-includes/http.php 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/src/wp-includes/http.php 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -476,8 +476,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $ip = $host;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $ip = gethostbyname( $host );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $ip === $host ) // Error condition for gethostbyname()
- $ip = false;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $ip === $host ) { // Error condition for gethostbyname()
+ return false;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $ip ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $parts = array_map( 'intval', explode( '.', $ip ) );
</span></span></pre></div>
<a id="branches38srcwpincludespluggablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/src/wp-includes/pluggable.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/src/wp-includes/pluggable.php 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/src/wp-includes/pluggable.php 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -805,18 +805,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $action Action nonce
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $query_arg where to look for nonce in $_REQUEST (since 2.5)
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function check_admin_referer($action = -1, $query_arg = '_wpnonce') {
- if ( -1 == $action )
- _doing_it_wrong( __FUNCTION__, __( 'You should specify a nonce action to be verified by using the first parameter.' ), '3.2' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function check_admin_referer( $action = -1, $query_arg = '_wpnonce' ) {
+ if ( -1 === $action )
+ _doing_it_wrong( __FUNCTION__, __( 'You should specify a nonce action to be verified by using the first parameter.' ), '3.2.0' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $adminurl = strtolower(admin_url());
</span><span class="cx" style="display: block; padding: 0 10px"> $referer = strtolower(wp_get_referer());
</span><span class="cx" style="display: block; padding: 0 10px"> $result = isset($_REQUEST[$query_arg]) ? wp_verify_nonce($_REQUEST[$query_arg], $action) : false;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !$result && !(-1 == $action && strpos($referer, $adminurl) === 0) ) {
- wp_nonce_ays($action);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Fires once the admin request has been validated or not.
+ *
+ * @since 1.5.1
+ *
+ * @param string $action The nonce action.
+ * @param bool $result Whether the admin request nonce was validated.
+ */
+ do_action( 'check_admin_referer', $action, $result );
+
+ if ( ! $result && ! ( -1 === $action && strpos( $referer, $adminurl ) === 0 ) ) {
+ wp_nonce_ays( $action );
</ins><span class="cx" style="display: block; padding: 0 10px"> die();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- do_action('check_admin_referer', $action, $result);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> return $result;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> endif;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -831,6 +842,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $query_arg where to look for nonce in $_REQUEST (since 2.5)
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function check_ajax_referer( $action = -1, $query_arg = false, $die = true ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( -1 === $action )
+ _doing_it_wrong( __FUNCTION__, __( 'You should specify a nonce action to be verified by using the first parameter.' ), '3.2.0' );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $nonce = '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $query_arg && isset( $_REQUEST[ $query_arg ] ) )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1857,36 +1871,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return $r;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> endif;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
-if ( ! function_exists( 'hash_equals' ) ) :
-/**
- * Compare two strings in constant time.
- *
- * This function is NOT pluggable. It is in this file (in addition to
- * compat.php) to prevent errors if, during an update, pluggable.php
- * copies over but compat.php does not.
- *
- * This function was added in PHP 5.6.
- * It can leak the length of a string.
- *
- * @since 3.9.2
- *
- * @param string $a Expected string.
- * @param string $b Actual string.
- * @return bool Whether strings are equal.
- */
-function hash_equals( $a, $b ) {
- $a_length = strlen( $a );
- if ( $a_length !== strlen( $b ) ) {
- return false;
- }
- $result = 0;
-
- // Do not attempt to "optimize" this.
- for ( $i = 0; $i < $a_length; $i++ ) {
- $result |= ord( $a[ $i ] ) ^ ord( $b[ $i ] );
- }
-
- return $result === 0;
-}
-endif;
</del></span></pre></div>
<a id="branches38srcwpincludesqueryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/src/wp-includes/query.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/src/wp-includes/query.php 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/src/wp-includes/query.php 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1396,7 +1396,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> , 'attachment'
</span><span class="cx" style="display: block; padding: 0 10px"> , 'attachment_id'
</span><span class="cx" style="display: block; padding: 0 10px"> , 'name'
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- , 'static'
</del><span class="cx" style="display: block; padding: 0 10px"> , 'pagename'
</span><span class="cx" style="display: block; padding: 0 10px"> , 'page_id'
</span><span class="cx" style="display: block; padding: 0 10px"> , 'second'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1504,7 +1503,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // If year, month, day, hour, minute, and second are set, a single
</span><span class="cx" style="display: block; padding: 0 10px"> // post is being queried.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->is_single = true;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } elseif ( '' != $qv['static'] || '' != $qv['pagename'] || !empty($qv['page_id']) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } elseif ( '' != $qv['pagename'] || !empty($qv['page_id']) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->is_page = true;
</span><span class="cx" style="display: block; padding: 0 10px"> $this->is_single = false;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span></span></pre></div>
<a id="branches38testsphpunittestsauthphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.8/tests/phpunit/tests/auth.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.8/tests/phpunit/tests/auth.php 2019-10-14 19:26:08 UTC (rev 46503)
+++ branches/3.8/tests/phpunit/tests/auth.php 2019-10-14 19:29:52 UTC (rev 46504)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -93,6 +93,49 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( wp_check_password( 'pass with vertial tab o_O', wp_hash_password( $password ) ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 29217
+ */
+ function test_wp_verify_nonce_with_empty_arg() {
+ $this->assertFalse( wp_verify_nonce( '' ) );
+ $this->assertFalse( wp_verify_nonce( null ) );
+ }
+
+ /**
+ * @ticket 29542
+ */
+ function test_wp_verify_nonce_with_integer_arg() {
+ $this->assertFalse( wp_verify_nonce( 1 ) );
+ }
+
+ /**
+ * @ticket 36361
+ */
+ public function test_check_admin_referer_with_no_action_triggers_doing_it_wrong() {
+ $this->setExpectedIncorrectUsage( 'check_admin_referer' );
+
+ // A valid nonce needs to be set so the check doesn't die()
+ $_REQUEST['_wpnonce'] = wp_create_nonce( -1 );
+ $result = check_admin_referer();
+ $this->assertSame( 1, $result );
+
+ unset( $_REQUEST['_wpnonce'] );
+ }
+
+ /**
+ * @ticket 36361
+ */
+ public function test_check_ajax_referer_with_no_action_triggers_doing_it_wrong() {
+ $this->setExpectedIncorrectUsage( 'check_ajax_referer' );
+
+ // A valid nonce needs to be set so the check doesn't die()
+ $_REQUEST['_wpnonce'] = wp_create_nonce( -1 );
+ $result = check_ajax_referer();
+ $this->assertSame( 1, $result );
+
+ unset( $_REQUEST['_wpnonce'] );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> function test_password_length_limit() {
</span><span class="cx" style="display: block; padding: 0 10px"> $passwords = array(
</span><span class="cx" style="display: block; padding: 0 10px"> str_repeat( 'a', 4095 ), // short
</span></span></pre>
</div>
</div>
</body>
</html>