<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46454] trunk: REST API: Do not addslash when receiving meta arrays of non-string values.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46454">46454</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46454","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>kadamwhite</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-10-09 17:34:20 +0000 (Wed, 09 Oct 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>REST API: Do not addslash when receiving meta arrays of non-string values.
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.
Props TimothyBlynJacobs, augustuswm.
Fixes <a href="https://core.trac.wordpress.org/ticket/48264">#48264</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesformattingphp">trunk/src/wp-includes/formatting.php</a></li>
<li><a href="#trunksrcwpincludesrestapifieldsclasswprestmetafieldsphp">trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php</a></li>
<li><a href="#trunktestsphpunittestsrestapirestpostmetafieldsphp">trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesformattingphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/formatting.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/formatting.php 2019-10-09 04:56:55 UTC (rev 46453)
+++ trunk/src/wp-includes/formatting.php 2019-10-09 17:34:20 UTC (rev 46454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5407,6 +5407,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Adds slashes to only string values in an array of values.
+ *
+ * This should be used when preparing data for core APIs that expect slashed data.
+ * This should not be used to escape data going directly into an SQL query.
+ *
+ * @since 5.3.0
+ *
+ * @param mixed $value Scalar or array of scalars.
+ * @return mixed Slashes $value
+ */
+function wp_slash_strings_only( $value ) {
+ return map_deep( $value, 'addslashes_strings_only' );
+}
+
+/**
+ * Adds slashes only if the provided value is a string.
+ *
+ * @since 5.3.0
+ *
+ * @param mixed $value
+ * @return mixed
+ */
+function addslashes_strings_only( $value ) {
+ return is_string( $value ) ? addslashes( $value ) : $value;
+}
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Extract and return the first URL from passed content.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.6.0
</span></span></pre></div>
<a id="trunksrcwpincludesrestapifieldsclasswprestmetafieldsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php 2019-10-09 04:56:55 UTC (rev 46453)
+++ trunk/src/wp-includes/rest-api/fields/class-wp-rest-meta-fields.php 2019-10-09 17:34:20 UTC (rev 46454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -365,7 +365,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! update_metadata( $meta_type, $object_id, wp_slash( $meta_key ), wp_slash( $value ) ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! update_metadata( $meta_type, $object_id, wp_slash( $meta_key ), wp_slash_strings_only( $value ) ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return new WP_Error(
</span><span class="cx" style="display: block; padding: 0 10px"> 'rest_meta_database_error',
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: Custom field key. */
</span></span></pre></div>
<a id="trunktestsphpunittestsrestapirestpostmetafieldsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php 2019-10-09 04:56:55 UTC (rev 46453)
+++ trunk/tests/phpunit/tests/rest-api/rest-post-meta-fields.php 2019-10-09 17:34:20 UTC (rev 46454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2265,6 +2265,340 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 48264
+ */
+ public function test_update_array_of_ints_meta() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'integer',
+ ),
+ ),
+ ),
+ )
+ );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( 1, 2, 3 ),
+ ),
+ )
+ );
+
+ rest_get_server()->dispatch( $request );
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_ints_meta_stored_strings_are_updated() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'integer',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( '1', '2', '3' ) );
+ $response = rest_get_server()->dispatch( new WP_REST_Request( 'GET', sprintf( '/wp/v2/posts/%d', self::$post_id ) ) );
+ $this->assertEquals( array( 1, 2, 3 ), $response->get_data()['meta']['items'] );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( 1, 2, 3 ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( 1, 2, 3 ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_ints_meta_string_request_data_is_set_as_ints() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'integer',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( 1, 2, 3 ) );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( '1', '2', '3' ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( 1, 2, 3 ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_ints_meta_string_request_data_and_string_stored_data() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'integer',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( '1', '2', '3' ) );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( '1', '2', '3' ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( 1, 2, 3 ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_bools_meta() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'boolean',
+ ),
+ ),
+ ),
+ )
+ );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( true, false ),
+ ),
+ )
+ );
+
+ rest_get_server()->dispatch( $request );
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_bools_meta_stored_strings_are_updated() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'boolean',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( '1', '0' ) );
+
+ $response = rest_get_server()->dispatch( new WP_REST_Request( 'GET', sprintf( '/wp/v2/posts/%d', self::$post_id ) ) );
+ $this->assertEquals( array( true, false ), $response->get_data()['meta']['items'] );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( true, false ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( true, false ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_bools_meta_string_request_data_is_set_as_bools() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'boolean',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( true, false ) );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( '1', '0' ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( true, false ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_bools_meta_string_request_data_and_string_stored_data() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'boolean',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( '1', '0' ) );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( '1', '0' ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( true, false ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
+ * @ticket 48264
+ */
+ public function test_update_array_of_bools_with_string_values_stored_and_opposite_request_data() {
+ $this->grant_write_permission();
+ register_post_meta(
+ 'post',
+ 'items',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'show_in_rest' => array(
+ 'schema' => array(
+ 'items' => array(
+ 'type' => 'boolean',
+ ),
+ ),
+ ),
+ )
+ );
+
+ update_post_meta( self::$post_id, 'items', array( '1', '0' ) );
+
+ $request = new WP_REST_Request( 'PUT', sprintf( '/wp/v2/posts/%d', self::$post_id ) );
+ $request->set_body_params(
+ array(
+ 'meta' => array(
+ 'items' => array( false, true ),
+ ),
+ )
+ );
+
+ $response = rest_get_server()->dispatch( $request );
+ $this->assertEquals( 200, $response->get_status() );
+ $this->assertSame( array( false, true ), get_post_meta( self::$post_id, 'items', true ) );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Internal function used to disable an insert query which
</span><span class="cx" style="display: block; padding: 0 10px"> * will trigger a wpdb error for testing purposes.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span></span></pre>
</div>
</div>
</body>
</html>