<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[46248] trunk/src/wp-admin/css: Accessibility: Improve and modernize user interface controls.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/46248">46248</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/46248","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-09-23 16:50:17 +0000 (Mon, 23 Sep 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units
Props kjellr, afercia, audrasjb.
Fixes <a href="https://core.trac.wordpress.org/ticket/47498">#47498</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsscolors_adminscss">trunk/src/wp-admin/css/colors/_admin.scss</a></li>
<li><a href="#trunksrcwpadmincssformscss">trunk/src/wp-admin/css/forms.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsscolors_adminscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/colors/_admin.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/colors/_admin.scss 2019-09-23 16:20:24 UTC (rev 46247)
+++ trunk/src/wp-admin/css/colors/_admin.scss 2019-09-23 16:50:17 UTC (rev 46248)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2,6 +2,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> @import 'variables';
</span><span class="cx" style="display: block; padding: 0 10px"> @import 'mixins';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@function url-friendly-colour( $color ) {
+ @return '%23' + str-slice( '#{ $color }', 2, -1 );
+}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> body {
</span><span class="cx" style="display: block; padding: 0 10px"> background: $body-background;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -30,11 +33,11 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Forms */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-input[type=checkbox]:checked:before {
- color: $form-checked;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+input[type=checkbox]:checked::before {
+ content: url("data:image/svg+xml;utf8,%3Csvg%20xmlns%3D%27http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%27%20viewBox%3D%270%200%2020%2020%27%3E%3Cpath%20d%3D%27M14.83%204.89l1.34.94-5.81%208.38H9.02L5.78%209.67l1.34-1.25%202.57%202.4z%27%20fill%3D%27#{url-friendly-colour($form-checked)}%27%2F%3E%3C%2Fsvg%3E");
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-input[type=radio]:checked:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+input[type=radio]:checked::before {
</ins><span class="cx" style="display: block; padding: 0 10px"> background: $form-checked;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadmincssformscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/forms.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/forms.css 2019-09-23 16:20:24 UTC (rev 46247)
+++ trunk/src/wp-admin/css/forms.css 2019-09-23 16:50:17 UTC (rev 46248)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -79,14 +79,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: pointer;
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- height: 16px;
- margin: -4px 4px 0 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ height: 1rem;
+ margin: -0.25rem 0.25rem 0 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> outline: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0 !important;
</span><span class="cx" style="display: block; padding: 0 10px"> text-align: center;
</span><span class="cx" style="display: block; padding: 0 10px"> vertical-align: middle;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- width: 16px;
- min-width: 16px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ width: 1rem;
+ min-width: 1rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> -webkit-appearance: none;
</span><span class="cx" style="display: block; padding: 0 10px"> box-shadow: inset 0 1px 2px rgba(0, 0, 0, 0.1);
</span><span class="cx" style="display: block; padding: 0 10px"> transition: .05s border-color ease-in-out;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -117,36 +117,35 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> input[type="radio"] {
</span><span class="cx" style="display: block; padding: 0 10px"> border-radius: 50%;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin-right: 4px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin-right: 0.25rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> line-height: 0.71428571;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-input[type="checkbox"]:checked:before,
-input[type="radio"]:checked:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+input[type="checkbox"]:checked::before,
+input[type="radio"]:checked::before {
</ins><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> vertical-align: middle;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- width: 16px;
- font: normal 21px/1 dashicons;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ width: 1rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> speak: none;
</span><span class="cx" style="display: block; padding: 0 10px"> -webkit-font-smoothing: antialiased;
</span><span class="cx" style="display: block; padding: 0 10px"> -moz-osx-font-smoothing: grayscale;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-input[type="checkbox"]:checked:before {
- content: "\f147";
- margin: -3px 0 0 -4px;
- color: #1e8cbe;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+input[type="checkbox"]:checked::before {
+ /* Use the "Yes" SVG Dashicon */
+ content: url("data:image/svg+xml;utf8,%3Csvg%20xmlns%3D%27http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%27%20viewBox%3D%270%200%2020%2020%27%3E%3Cpath%20d%3D%27M14.83%204.89l1.34.94-5.81%208.38H9.02L5.78%209.67l1.34-1.25%202.57%202.4z%27%20fill%3D%27%231e8cbe%27%2F%3E%3C%2Fsvg%3E");
+ margin: -0.1875rem 0 0 -0.25rem;
+ height: 1.3125rem;
+ width: 1.3125rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-input[type="radio"]:checked:before {
- content: "\2022";
- text-indent: -9999px;
- border-radius: 50px;
- font-size: 24px;
- width: 6px;
- height: 6px;
- margin: 4px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+input[type="radio"]:checked::before {
+ content: "";
+ border-radius: 50%;
+ width: 50%;
+ height: 50%;
+ margin: 25%;
</ins><span class="cx" style="display: block; padding: 0 10px"> line-height: 0.76190476;
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #1e8cbe;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1287,7 +1286,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .widefat thead td input[type="checkbox"],
</span><span class="cx" style="display: block; padding: 0 10px"> .widefat tfoot td input[type="checkbox"] {
</span><span class="cx" style="display: block; padding: 0 10px"> -webkit-appearance: none;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- padding: 10px;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .widefat th input[type="checkbox"],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1300,26 +1298,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .widefat th input[type="checkbox"]:before,
</span><span class="cx" style="display: block; padding: 0 10px"> .widefat thead td input[type="checkbox"]:before,
</span><span class="cx" style="display: block; padding: 0 10px"> .widefat tfoot td input[type="checkbox"]:before {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- font: normal 30px/1 dashicons;
- margin: -3px -5px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ width: 1.875rem;
+ height: 1.875rem;
+ margin: -0.1875rem -0.3125rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> input[type="radio"],
</span><span class="cx" style="display: block; padding: 0 10px"> input[type="checkbox"] {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- height: 25px;
- width: 25px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ height: 1.5625rem;
+ width: 1.5625rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-admin p input[type="checkbox"],
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-admin p input[type="radio"] {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin-top: -3px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin-top: -0.1875rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> input[type="radio"]:checked:before {
</span><span class="cx" style="display: block; padding: 0 10px"> vertical-align: middle;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- width: 9px;
- height: 9px;
- margin: 7px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ width: 0.5625rem;
+ height: 0.5625rem;
+ margin: 0.4375rem;
</ins><span class="cx" style="display: block; padding: 0 10px"> line-height: 0.76190476;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>