<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45835] branches/5.2/src/wp-admin: Accessibility: Improve settings tables and forms after [45403].</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/45835">45835</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/45835","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-08-19 04:14:38 +0000 (Mon, 19 Aug 2019)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Improve settings tables and forms after <a href="https://core.trac.wordpress.org/changeset/45403">[45403]</a>.

- adds `role="presentation"` to the edit comment table 
- removes a few pointless `<fieldset>` elements
- adds a few missing `<label>` elements
- adds the CSS class `class="td-full"` to table rows spanning to multiple cells
- adds explicit `scope="row"` attribute to the table headers in `options-permalink.php`: this table is better communicated as data table 
- uses consistent label association in the "Privacy Settings" page
- in the installation page "Set up your database connection": associates descriptions to their inout fields using `aria-describedby`
- improves the link to gravatar.com in the `user-edit.php` page

Props afercia.
Merges <a href="https://core.trac.wordpress.org/changeset/45416">[45416]</a> to the 5.2 branch.
See <a href="https://core.trac.wordpress.org/ticket/46899">#46899</a>.
Fixes <a href="https://core.trac.wordpress.org/ticket/47390">#47390</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branches52srcwpadmineditformcommentphp">branches/5.2/src/wp-admin/edit-form-comment.php</a></li>
<li><a href="#branches52srcwpadminincludesmsphp">branches/5.2/src/wp-admin/includes/ms.php</a></li>
<li><a href="#branches52srcwpadminincludesnetworkphp">branches/5.2/src/wp-admin/includes/network.php</a></li>
<li><a href="#branches52srcwpadminnetworksettingsphp">branches/5.2/src/wp-admin/network/settings.php</a></li>
<li><a href="#branches52srcwpadminnetworksiteinfophp">branches/5.2/src/wp-admin/network/site-info.php</a></li>
<li><a href="#branches52srcwpadminnetworksitenewphp">branches/5.2/src/wp-admin/network/site-new.php</a></li>
<li><a href="#branches52srcwpadminnetworksiteusersphp">branches/5.2/src/wp-admin/network/site-users.php</a></li>
<li><a href="#branches52srcwpadminnetworkusernewphp">branches/5.2/src/wp-admin/network/user-new.php</a></li>
<li><a href="#branches52srcwpadminoptionsdiscussionphp">branches/5.2/src/wp-admin/options-discussion.php</a></li>
<li><a href="#branches52srcwpadminoptionspermalinkphp">branches/5.2/src/wp-admin/options-permalink.php</a></li>
<li><a href="#branches52srcwpadminprivacyphp">branches/5.2/src/wp-admin/privacy.php</a></li>
<li><a href="#branches52srcwpadminsetupconfigphp">branches/5.2/src/wp-admin/setup-config.php</a></li>
<li><a href="#branches52srcwpadminusereditphp">branches/5.2/src/wp-admin/user-edit.php</a></li>
</ul>

<h3>Property Changed</h3>
<ul>
<li><a href="#branches52">branches/5.2/</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/5.2
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/5.2 2019-08-19 04:12:44 UTC (rev 45834)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/5.2  2019-08-19 04:14:38 UTC (rev 45835)
</ins><a id="branches52"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/5.2</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/3.4:21757
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/4.9:43557,43622
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43747,43751-43754,43758,43760-43765,43767-43770,43772,43774-43781,43783,43785,43790-43806,43808-43821,43825,43828,43830-43834,43836-43843,43846-43863,43867-43889,43891-43894,43897-43905,43908-43909,43911-43929,43931-43942,43946-43947,43949-43956,43959-43964,43967-43969,43988,43994,44014,44017,44047,44183,44185,44187-44206,44208-44213,44231-44232,44235,44248,44284,44287-44288
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:45285,45287,45289,45292,45296,45298,45300-45301,45308-45311,45316,45319,45322,45324,45326,45328,45331,45334,45336,45338,45340,45342,45344-45346,45348,45350,45352,45357,45365,45367,45403,45463,45481,45488,45495,45501-45503,45507,45515,45520,45522,45527,45529,45551,45563-45564,45619,45626,45655-45656,45727,45750
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:45285,45287,45289,45292,45296,45298,45300-45301,45308-45311,45316,45319,45322,45324,45326,45328,45331,45334,45336,45338,45340,45342,45344-45346,45348,45350,45352,45357,45365,45367,45403,45416,45463,45481,45488,45495,45501-45503,45507,45515,45520,45522,45527,45529,45551,45563-45564,45619,45626,45655-45656,45727,45750
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches52srcwpadmineditformcommentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/edit-form-comment.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/edit-form-comment.php   2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/edit-form-comment.php     2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -43,7 +43,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <h2 class="edit-comment-author"><?php _e( 'Author' ); ?></h2>
</span><span class="cx" style="display: block; padding: 0 10px"> <fieldset>
</span><span class="cx" style="display: block; padding: 0 10px"> <legend class="screen-reader-text"><?php _e( 'Comment Author' ); ?></legend>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<table class="form-table editcomment">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<table class="form-table editcomment" role="presentation">
</ins><span class="cx" style="display: block; padding: 0 10px"> <tbody>
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <td class="first"><label for="name"><?php _e( 'Name' ); ?></label></td>
</span></span></pre></div>
<a id="branches52srcwpadminincludesmsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/includes/ms.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/includes/ms.php 2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/includes/ms.php   2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -984,7 +984,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                echo '</fieldset></td></tr>';
</span><span class="cx" style="display: block; padding: 0 10px">                        } else {
</span><span class="cx" style="display: block; padding: 0 10px">                                ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <td><fieldset><p><legend><?php _e( 'User has no sites or content and will be deleted.' ); ?></legend></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         <td><p><?php _e( 'User has no sites or content and will be deleted.' ); ?></p></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                         <?php } ?>
</span><span class="cx" style="display: block; padding: 0 10px">                        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <?php
</span></span></pre></div>
<a id="branches52srcwpadminincludesnetworkphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/includes/network.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/includes/network.php    2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/includes/network.php      2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -347,9 +347,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">                        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <th scope='row'><?php esc_html_e( 'Network Title' ); ?></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         <th scope='row'><label for="sitename"><?php esc_html_e( 'Network Title' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                                 <td>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        <input name='sitename' type='text' size='45' value='<?php echo esc_attr( $site_name ); ?>' />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 <input name='sitename' id='sitename' type='text' size='45' value='<?php echo esc_attr( $site_name ); ?>' />
</ins><span class="cx" style="display: block; padding: 0 10px">                                         <p class="description">
</span><span class="cx" style="display: block; padding: 0 10px">                                                <?php _e( 'What would you like to call your network?' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px">                                        </p>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -356,9 +356,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                </td>
</span><span class="cx" style="display: block; padding: 0 10px">                        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <th scope='row'><?php esc_html_e( 'Network Admin Email' ); ?></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         <th scope='row'><label for="email"><?php esc_html_e( 'Network Admin Email' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                                 <td>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        <input name='email' type='text' size='45' value='<?php echo esc_attr( $admin_email ); ?>' />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 <input name='email' id='email' type='text' size='45' value='<?php echo esc_attr( $admin_email ); ?>' />
</ins><span class="cx" style="display: block; padding: 0 10px">                                         <p class="description">
</span><span class="cx" style="display: block; padding: 0 10px">                                                <?php _e( 'Your email address.' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px">                                        </p>
</span></span></pre></div>
<a id="branches52srcwpadminnetworksettingsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/network/settings.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/network/settings.php    2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/network/settings.php      2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -452,16 +452,15 @@
</span><span class="cx" style="display: block; padding: 0 10px">                         *
</span><span class="cx" style="display: block; padding: 0 10px">                         * @param string[] $admin_menus Associative array of the menu items available.
</span><span class="cx" style="display: block; padding: 0 10px">                         */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        $menu_items   = apply_filters( 'mu_menu_items', array( 'plugins' => __( 'Plugins' ) ) );
-                       $fieldset_end = '';
-                       if ( count( (array) $menu_items ) > 1 ) {
-                               echo '<fieldset><legend class="screen-reader-text">' . __( 'Enable menus' ) . '</legend>';
-                               $fieldset_end = '</fieldset>';
-                       }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 $menu_items = apply_filters( 'mu_menu_items', array( 'plugins' => __( 'Plugins' ) ) );
+
+                       echo '<fieldset><legend class="screen-reader-text">' . __( 'Enable menus' ) . '</legend>';
+
</ins><span class="cx" style="display: block; padding: 0 10px">                         foreach ( (array) $menu_items as $key => $val ) {
</span><span class="cx" style="display: block; padding: 0 10px">                                echo "<label><input type='checkbox' name='menu_items[" . $key . "]' value='1'" . ( isset( $menu_perms[ $key ] ) ? checked( $menu_perms[ $key ], '1', false ) : '' ) . ' /> ' . esc_html( $val ) . '</label><br/>';
</span><span class="cx" style="display: block; padding: 0 10px">                        }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        echo $fieldset_end;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+                       echo '</fieldset>';
</ins><span class="cx" style="display: block; padding: 0 10px">                         ?>
</span><span class="cx" style="display: block; padding: 0 10px">                                </td>
</span><span class="cx" style="display: block; padding: 0 10px">                        </tr>
</span></span></pre></div>
<a id="branches52srcwpadminnetworksiteinfophp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/network/site-info.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/network/site-info.php   2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/network/site-info.php     2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -166,7 +166,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                else :
</span><span class="cx" style="display: block; padding: 0 10px">                        ?>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr class="form-field form-required">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <th scope="row"><?php _e( 'Site Address (URL)' ); ?></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <th scope="row"><label for="url"><?php _e( 'Site Address (URL)' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                         <td><input name="blog[url]" type="text" id="url" value="<?php echo $parsed_scheme . '://' . esc_attr( $details->domain ) . esc_attr( $details->path ); ?>" /></td>
</span><span class="cx" style="display: block; padding: 0 10px">                </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <?php endif; ?>
</span></span></pre></div>
<a id="branches52srcwpadminnetworksitenewphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/network/site-new.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/network/site-new.php    2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/network/site-new.php      2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -281,7 +281,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        <td><input name="blog[email]" type="email" class="regular-text wp-suggest-user" id="admin-email" data-autocomplete-type="search" data-autocomplete-field="user_email" aria-describedby="site-admin-email" required /></td>
</span><span class="cx" style="display: block; padding: 0 10px">                </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr class="form-field">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td colspan="2"><p id="site-admin-email"><?php _e( 'A new user will be created if the above email address is not in the database.' ); ?><br /><?php _e( 'The username and a link to set the password will be mailed to this email address.' ); ?></p></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td colspan="2" class="td-full"><p id="site-admin-email"><?php _e( 'A new user will be created if the above email address is not in the database.' ); ?><br /><?php _e( 'The username and a link to set the password will be mailed to this email address.' ); ?></p></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        </table>
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span></span></pre></div>
<a id="branches52srcwpadminnetworksiteusersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/network/site-users.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/network/site-users.php  2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/network/site-users.php    2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -354,7 +354,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        </select></td>
</span><span class="cx" style="display: block; padding: 0 10px">                </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr class="form-field">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td colspan="2"><?php _e( 'A password reset link will be sent to the user via email.' ); ?></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td colspan="2" class="td-full"><?php _e( 'A password reset link will be sent to the user via email.' ); ?></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        </table>
</span><span class="cx" style="display: block; padding: 0 10px">        <?php wp_nonce_field( 'add-user', '_wpnonce_add-new-user' ); ?>
</span></span></pre></div>
<a id="branches52srcwpadminnetworkusernewphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/network/user-new.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/network/user-new.php    2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/network/user-new.php      2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -130,7 +130,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        <td><input type="email" class="regular-text" name="user[email]" id="email"/></td>
</span><span class="cx" style="display: block; padding: 0 10px">                </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr class="form-field">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td colspan="2"><?php _e( 'A password reset link will be sent to the user via email.' ); ?></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td colspan="2" class="td-full"><?php _e( 'A password reset link will be sent to the user via email.' ); ?></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        </table>
</span><span class="cx" style="display: block; padding: 0 10px">        <?php
</span></span></pre></div>
<a id="branches52srcwpadminoptionsdiscussionphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/options-discussion.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/options-discussion.php  2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/options-discussion.php    2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -221,12 +221,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <table class="form-table" role="presentation">
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <th scope="row"><?php _e( 'Avatar Display' ); ?></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<td><fieldset><legend class="screen-reader-text"><span><?php _e( 'Avatar Display' ); ?></span></legend>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<td>
</ins><span class="cx" style="display: block; padding: 0 10px">         <label for="show_avatars">
</span><span class="cx" style="display: block; padding: 0 10px">                <input type="checkbox" id="show_avatars" name="show_avatars" value="1" <?php checked( $show_avatars, 1 ); ?> />
</span><span class="cx" style="display: block; padding: 0 10px">                <?php _e( 'Show Avatars' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px">        </label>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-</fieldset></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+</td>
</ins><span class="cx" style="display: block; padding: 0 10px"> </tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <tr class="avatar-settings<?php echo $show_avatars_class; ?>">
</span><span class="cx" style="display: block; padding: 0 10px"> <th scope="row"><?php _e( 'Maximum Rating' ); ?></th>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -255,7 +255,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <th scope="row"><?php _e( 'Default Avatar' ); ?></th>
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="defaultavatarpicker"><fieldset><legend class="screen-reader-text"><span><?php _e( 'Default Avatar' ); ?></span></legend>
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<p>
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php _e( 'For users without a custom avatar of their own, you can either display a generic logo or a generated one based on their email address.' ); ?><br />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+</p>
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> $avatar_defaults = array(
</span></span></pre></div>
<a id="branches52srcwpadminoptionspermalinkphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/options-permalink.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/options-permalink.php   2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/options-permalink.php     2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -197,27 +197,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <h2 class="title"><?php _e( 'Common Settings' ); ?></h2>
</span><span class="cx" style="display: block; padding: 0 10px"> <table class="form-table permalink-structure">
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <th><label><input name="selection" type="radio" value="" <?php checked( '', $permalink_structure ); ?> /> <?php _e( 'Plain' ); ?></label></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <th scope="row"><label><input name="selection" type="radio" value="" <?php checked( '', $permalink_structure ); ?> /> <?php _e( 'Plain' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                 <td><code><?php echo get_option( 'home' ); ?>/?p=123</code></td>
</span><span class="cx" style="display: block; padding: 0 10px">        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <th><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[1] ); ?>" <?php checked( $structures[1], $permalink_structure ); ?> /> <?php _e( 'Day and name' ); ?></label></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <th scope="row"><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[1] ); ?>" <?php checked( $structures[1], $permalink_structure ); ?> /> <?php _e( 'Day and name' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                 <td><code><?php echo get_option( 'home' ) . $blog_prefix . $prefix . '/' . date( 'Y' ) . '/' . date( 'm' ) . '/' . date( 'd' ) . '/' . _x( 'sample-post', 'sample permalink structure' ) . '/'; ?></code></td>
</span><span class="cx" style="display: block; padding: 0 10px">        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <th><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[2] ); ?>" <?php checked( $structures[2], $permalink_structure ); ?> /> <?php _e( 'Month and name' ); ?></label></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <th scope="row"><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[2] ); ?>" <?php checked( $structures[2], $permalink_structure ); ?> /> <?php _e( 'Month and name' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                 <td><code><?php echo get_option( 'home' ) . $blog_prefix . $prefix . '/' . date( 'Y' ) . '/' . date( 'm' ) . '/' . _x( 'sample-post', 'sample permalink structure' ) . '/'; ?></code></td>
</span><span class="cx" style="display: block; padding: 0 10px">        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <th><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[3] ); ?>" <?php checked( $structures[3], $permalink_structure ); ?> /> <?php _e( 'Numeric' ); ?></label></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <th scope="row"><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[3] ); ?>" <?php checked( $structures[3], $permalink_structure ); ?> /> <?php _e( 'Numeric' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                 <td><code><?php echo get_option( 'home' ) . $blog_prefix . $prefix . '/' . _x( 'archives', 'sample permalink base' ) . '/123'; ?></code></td>
</span><span class="cx" style="display: block; padding: 0 10px">        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <th><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[4] ); ?>" <?php checked( $structures[4], $permalink_structure ); ?> /> <?php _e( 'Post name' ); ?></label></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <th scope="row"><label><input name="selection" type="radio" value="<?php echo esc_attr( $structures[4] ); ?>" <?php checked( $structures[4], $permalink_structure ); ?> /> <?php _e( 'Post name' ); ?></label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                 <td><code><?php echo get_option( 'home' ) . $blog_prefix . $prefix . '/' . _x( 'sample-post', 'sample permalink structure' ) . '/'; ?></code></td>
</span><span class="cx" style="display: block; padding: 0 10px">        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <th scope="row">
</ins><span class="cx" style="display: block; padding: 0 10px">                         <label><input name="selection" id="custom_selection" type="radio" value="custom" <?php checked( ! in_array( $permalink_structure, $structures ) ); ?> />
</span><span class="cx" style="display: block; padding: 0 10px">                        <?php _e( 'Custom Structure' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px">                        </label>
</span></span></pre></div>
<a id="branches52srcwpadminprivacyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/privacy.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/privacy.php     2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/privacy.php       2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -191,9 +191,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">        </p>
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        <hr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-        <table class="form-table tools-privacy-policy-page">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <table class="form-table tools-privacy-policy-page" role="presentation">
</ins><span class="cx" style="display: block; padding: 0 10px">                 <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <th scope="row">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <th scope="row"><label for="page_for_privacy_policy">
</ins><span class="cx" style="display: block; padding: 0 10px">                                 <?php
</span><span class="cx" style="display: block; padding: 0 10px">                                if ( $privacy_policy_page_exists ) {
</span><span class="cx" style="display: block; padding: 0 10px">                                        _e( 'Change your Privacy Policy page' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -201,7 +201,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                        _e( 'Select a Privacy Policy page' );
</span><span class="cx" style="display: block; padding: 0 10px">                                }
</span><span class="cx" style="display: block; padding: 0 10px">                                ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        </th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 </label></th>
</ins><span class="cx" style="display: block; padding: 0 10px">                         <td>
</span><span class="cx" style="display: block; padding: 0 10px">                                <?php
</span><span class="cx" style="display: block; padding: 0 10px">                                $has_pages = (bool) get_posts(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -218,9 +218,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                if ( $has_pages ) :
</span><span class="cx" style="display: block; padding: 0 10px">                                        ?>
</span><span class="cx" style="display: block; padding: 0 10px">                                        <form method="post" action="">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                                <label for="page_for_privacy_policy">
-                                                       <?php _e( 'Select an existing page:' ); ?>
-                                               </label>
</del><span class="cx" style="display: block; padding: 0 10px">                                                 <input type="hidden" name="action" value="set-privacy-page" />
</span><span class="cx" style="display: block; padding: 0 10px">                                                <?php
</span><span class="cx" style="display: block; padding: 0 10px">                                                wp_dropdown_pages(
</span></span></pre></div>
<a id="branches52srcwpadminsetupconfigphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/setup-config.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/setup-config.php        2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/setup-config.php  2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -210,23 +210,23 @@
</span><span class="cx" style="display: block; padding: 0 10px">        <table class="form-table" role="presentation">
</span><span class="cx" style="display: block; padding: 0 10px">                <tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <th scope="row"><label for="dbname"><?php _e( 'Database Name' ); ?></label></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td><input name="dbname" id="dbname" type="text" size="25" value="wordpress"<?php echo $autofocus; ?>/></td>
-                       <td><?php _e( 'The name of the database you want to use with WordPress.' ); ?></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td><input name="dbname" id="dbname" type="text" aria-describedby="dbname-desc" size="25" value="wordpress"<?php echo $autofocus; ?>/></td>
+                       <td id="dbname-desc"><?php _e( 'The name of the database you want to use with WordPress.' ); ?></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <th scope="row"><label for="uname"><?php _e( 'Username' ); ?></label></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td><input name="uname" id="uname" type="text" size="25" value="<?php echo htmlspecialchars( _x( 'username', 'example username' ), ENT_QUOTES ); ?>" /></td>
-                       <td><?php _e( 'Your database username.' ); ?></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td><input name="uname" id="uname" type="text" aria-describedby="uname-desc" size="25" value="<?php echo htmlspecialchars( _x( 'username', 'example username' ), ENT_QUOTES ); ?>" /></td>
+                       <td id="uname-desc"><?php _e( 'Your database username.' ); ?></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <th scope="row"><label for="pwd"><?php _e( 'Password' ); ?></label></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td><input name="pwd" id="pwd" type="text" size="25" value="<?php echo htmlspecialchars( _x( 'password', 'example password' ), ENT_QUOTES ); ?>" autocomplete="off" /></td>
-                       <td><?php _e( 'Your database password.' ); ?></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td><input name="pwd" id="pwd" type="text" aria-describedby="pwd-desc" size="25" value="<?php echo htmlspecialchars( _x( 'password', 'example password' ), ENT_QUOTES ); ?>" autocomplete="off" /></td>
+                       <td id="pwd-desc"><?php _e( 'Your database password.' ); ?></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <th scope="row"><label for="dbhost"><?php _e( 'Database Host' ); ?></label></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td><input name="dbhost" id="dbhost" type="text" size="25" value="localhost" /></td>
-                       <td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td><input name="dbhost" id="dbhost" type="text" aria-describedby="dbhost-desc" size="25" value="localhost" /></td>
+                       <td id="dbhost-desc">
</ins><span class="cx" style="display: block; padding: 0 10px">                         <?php
</span><span class="cx" style="display: block; padding: 0 10px">                                /* translators: %s: localhost */
</span><span class="cx" style="display: block; padding: 0 10px">                                printf( __( 'You should be able to get this info from your web host, if %s doesn&#8217;t work.' ), '<code>localhost</code>' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -235,8 +235,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">                </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <tr>
</span><span class="cx" style="display: block; padding: 0 10px">                        <th scope="row"><label for="prefix"><?php _e( 'Table Prefix' ); ?></label></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        <td><input name="prefix" id="prefix" type="text" value="wp_" size="25" /></td>
-                       <td><?php _e( 'If you want to run multiple WordPress installations in a single database, change this.' ); ?></td>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 <td><input name="prefix" id="prefix" type="text" aria-describedby="prefix-desc" value="wp_" size="25" /></td>
+                       <td id="prefix-desc"><?php _e( 'If you want to run multiple WordPress installations in a single database, change this.' ); ?></td>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        </table>
</span><span class="cx" style="display: block; padding: 0 10px">                <?php
</span></span></pre></div>
<a id="branches52srcwpadminusereditphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.2/src/wp-admin/user-edit.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.2/src/wp-admin/user-edit.php   2019-08-19 04:12:44 UTC (rev 45834)
+++ branches/5.2/src/wp-admin/user-edit.php     2019-08-19 04:14:38 UTC (rev 45835)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -568,7 +568,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        if ( IS_PROFILE_PAGE ) {
</span><span class="cx" style="display: block; padding: 0 10px">                                /* translators: %s: Gravatar URL */
</span><span class="cx" style="display: block; padding: 0 10px">                                $description = sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        __( 'You can change your profile picture on <a href="%s">Gravatar</a>.' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 __( '<a href="%s">You can change your profile picture on Gravatar</a>.' ),
</ins><span class="cx" style="display: block; padding: 0 10px">                                         __( 'https://en.gravatar.com/' )
</span><span class="cx" style="display: block; padding: 0 10px">                                );
</span><span class="cx" style="display: block; padding: 0 10px">                        } else {
</span></span></pre>
</div>
</div>

</body>
</html>