<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45673] trunk/src: Upgrade/Install: Bring some consistency to installation screen styles.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/45673">45673</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/45673","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-07-25 19:10:33 +0000 (Thu, 25 Jul 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Upgrade/Install: Bring some consistency to installation screen styles.
* Include `forms.css` and `l10n.css`, for consistency with login screen and other admin screens.
* Remove redundant `@import` directives from `login.css` for files already declared as dependencies.
* Adjust margin on password strength meter for consistency with other fields.
* Increase font size for "You will need this password to log in" notice.
* Fix misaligned icon on "Hide" button for the password.
Props iseulde, dan@micamedia.com, bassgang, cdog, johnbillion, nmenescardi, mukesh27, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/35776">#35776</a>, <a href="https://core.trac.wordpress.org/ticket/47757">#47757</a>, <a href="https://core.trac.wordpress.org/ticket/47758">#47758</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincssformscss">trunk/src/wp-admin/css/forms.css</a></li>
<li><a href="#trunksrcwpadmincssinstallcss">trunk/src/wp-admin/css/install.css</a></li>
<li><a href="#trunksrcwpadmincsslogincss">trunk/src/wp-admin/css/login.css</a></li>
<li><a href="#trunksrcwpadmininstallphp">trunk/src/wp-admin/install.php</a></li>
<li><a href="#trunksrcwpadminmaintrepairphp">trunk/src/wp-admin/maint/repair.php</a></li>
<li><a href="#trunksrcwpincludesscriptloaderphp">trunk/src/wp-includes/script-loader.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincssformscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/forms.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/forms.css 2019-07-25 15:18:05 UTC (rev 45672)
+++ trunk/src/wp-admin/css/forms.css 2019-07-25 19:10:33 UTC (rev 45673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -464,7 +464,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #eee;
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #ddd;
</span><span class="cx" style="display: block; padding: 0 10px"> color: #23282d;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin: -1px 0 5px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin: -1px 1px 5px;
</ins><span class="cx" style="display: block; padding: 0 10px"> padding: 3px 5px;
</span><span class="cx" style="display: block; padding: 0 10px"> text-align: center;
</span><span class="cx" style="display: block; padding: 0 10px"> width: 25em;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -522,7 +522,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-pwd [type="text"],
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-pwd [type="password"] {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin: 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin-bottom: 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Same height as the buttons */
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 20px;
</span><span class="cx" style="display: block; padding: 0 10px"> min-height: 28px;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -542,10 +542,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.form-table span.description.important {
- font-size: 12px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> p.search-box {
</span><span class="cx" style="display: block; padding: 0 10px"> float: right;
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span></span></pre></div>
<a id="trunksrcwpadmincssinstallcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/install.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/install.css 2019-07-25 15:18:05 UTC (rev 45672)
+++ trunk/src/wp-admin/css/install.css 2019-07-25 19:10:33 UTC (rev 45673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -174,8 +174,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .form-table input[type=text],
</span><span class="cx" style="display: block; padding: 0 10px"> .form-table input[type=email],
</span><span class="cx" style="display: block; padding: 0 10px"> .form-table input[type=url],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.form-table input[type=password] {
- width: 206px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.form-table input[type=password],
+#pass-strength-result {
+ width: 218px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .form-table th p {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -212,66 +213,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> font-family: Consolas, Monaco, monospace;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.wp-hide-pw > .dashicons {
- line-height: inherit;
-}
-
-#pass-strength-result {
- background-color: #eee;
- border: 1px solid #ddd;
- color: #23282d;
- margin: -2px 5px 5px 0px;
- padding: 3px 5px;
- text-align: center;
- width: 218px;
- box-sizing: border-box;
- opacity: 0;
-}
-
-#pass-strength-result.short {
- background-color: #f1adad;
- border-color: #e35b5b;
- opacity: 1;
-}
-
-#pass-strength-result.bad {
- background-color: #fbc5a9;
- border-color: #f78b53;
- opacity: 1;
-}
-
-#pass-strength-result.good {
- background-color: #ffe399;
- border-color: #ffc733;
- opacity: 1;
-}
-
-#pass-strength-result.strong {
- background-color: #c1e1b9;
- border-color: #83c373;
- opacity: 1;
-}
-
-#pass1.short, #pass1-text.short {
- border-color: #e35b5b;
-}
-
-#pass1.bad, #pass1-text.bad {
- border-color: #f78b53;
-}
-
-#pass1.good, #pass1-text.good {
- border-color: #ffc733;
-}
-
-#pass1.strong, #pass1-text.strong {
- border-color: #83c373;
-}
-
-.pw-weak {
- display: none;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .message {
</span><span class="cx" style="display: block; padding: 0 10px"> border-left: 4px solid #dc3232;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: .7em .6em;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -291,21 +232,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> direction: ltr;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#pass1-text,
-.show-password #pass1 {
- display: none;
-}
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.show-password #pass1-text
-{
- display: inline-block;
-}
-
-.form-table span.description.important {
- font-size: 12px;
-}
-
-
</del><span class="cx" style="display: block; padding: 0 10px"> /* localization */
</span><span class="cx" style="display: block; padding: 0 10px"> body.rtl,
</span><span class="cx" style="display: block; padding: 0 10px"> .rtl textarea,
</span></span></pre></div>
<a id="trunksrcwpadmincsslogincss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/login.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/login.css 2019-07-25 15:18:05 UTC (rev 45672)
+++ trunk/src/wp-admin/css/login.css 2019-07-25 19:10:33 UTC (rev 45673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,6 +1,3 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-@import url(forms.css);
-@import url(l10n.css);
-
</del><span class="cx" style="display: block; padding: 0 10px"> html,
</span><span class="cx" style="display: block; padding: 0 10px"> body {
</span><span class="cx" style="display: block; padding: 0 10px"> height: 100%;
</span></span></pre></div>
<a id="trunksrcwpadmininstallphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/install.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/install.php 2019-07-25 15:18:05 UTC (rev 45672)
+++ trunk/src/wp-admin/install.php 2019-07-25 19:10:33 UTC (rev 45673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -71,10 +71,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
</span><span class="cx" style="display: block; padding: 0 10px"> <meta name="robots" content="noindex,nofollow" />
</span><span class="cx" style="display: block; padding: 0 10px"> <title><?php _e( 'WordPress › Installation' ); ?></title>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- wp_admin_css( 'install', true );
- wp_admin_css( 'dashicons', true );
- ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <?php wp_admin_css( 'install', true ); ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> </head>
</span><span class="cx" style="display: block; padding: 0 10px"> <body class="wp-core-ui<?php echo $body_classes; ?>">
</span><span class="cx" style="display: block; padding: 0 10px"> <p id="logo"><a href="<?php echo esc_url( __( 'https://wordpress.org/' ) ); ?>"><?php _e( 'WordPress' ); ?></a></p>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -142,7 +139,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><span class="cx" style="display: block; padding: 0 10px"> </th>
</span><span class="cx" style="display: block; padding: 0 10px"> <td>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div class="">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="wp-pwd">
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php $initial_password = isset( $_POST['admin_password'] ) ? stripslashes( $_POST['admin_password'] ) : wp_generate_password( 18 ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="password" name="admin_password" id="pass1" class="regular-text" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" aria-describedby="pass-strength-result" />
</span><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="button wp-hide-pw hide-if-no-js" data-start-masked="<?php echo (int) isset( $_POST['admin_password'] ); ?>" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
</span></span></pre></div>
<a id="trunksrcwpadminmaintrepairphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/maint/repair.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/maint/repair.php 2019-07-25 15:18:05 UTC (rev 45672)
+++ trunk/src/wp-admin/maint/repair.php 2019-07-25 19:10:33 UTC (rev 45673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,9 +18,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
</span><span class="cx" style="display: block; padding: 0 10px"> <meta name="robots" content="noindex,nofollow" />
</span><span class="cx" style="display: block; padding: 0 10px"> <title><?php _e( 'WordPress › Database Repair' ); ?></title>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- wp_admin_css( 'install', true );
- ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <?php wp_admin_css( 'install', true ); ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> </head>
</span><span class="cx" style="display: block; padding: 0 10px"> <body class="wp-core-ui">
</span><span class="cx" style="display: block; padding: 0 10px"> <p id="logo"><a href="<?php echo esc_url( __( 'https://wordpress.org/' ) ); ?>"><?php _e( 'WordPress' ); ?></a></p>
</span></span></pre></div>
<a id="trunksrcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/script-loader.php 2019-07-25 15:18:05 UTC (rev 45672)
+++ trunk/src/wp-includes/script-loader.php 2019-07-25 19:10:33 UTC (rev 45673)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1948,7 +1948,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'wp-admin', false, array( 'dashicons', 'common', 'forms', 'admin-menu', 'dashboard', 'list-tables', 'edit', 'revisions', 'media', 'themes', 'about', 'nav-menus', 'widgets', 'site-icon', 'l10n' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'login', "/wp-admin/css/login$suffix.css", array( 'dashicons', 'buttons', 'forms', 'l10n' ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $styles->add( 'install', "/wp-admin/css/install$suffix.css", array( 'buttons' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $styles->add( 'install', "/wp-admin/css/install$suffix.css", array( 'dashicons', 'buttons', 'forms', 'l10n' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'wp-color-picker', "/wp-admin/css/color-picker$suffix.css" );
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'customize-controls', "/wp-admin/css/customize-controls$suffix.css", array( 'wp-admin', 'colors', 'ie', 'imgareaselect' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'customize-widgets', "/wp-admin/css/customize-widgets$suffix.css", array( 'wp-admin', 'colors' ) );
</span></span></pre>
</div>
</div>
</body>
</html>