<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45580] trunk: Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/45580">45580</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/45580","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-07-01 08:00:12 +0000 (Mon, 01 Jul 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
See <a href="https://core.trac.wordpress.org/ticket/47632">#47632</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesfilephp">trunk/src/wp-admin/includes/file.php</a></li>
<li><a href="#trunksrcwpadminincludesmiscphp">trunk/src/wp-admin/includes/misc.php</a></li>
<li><a href="#trunksrcwpadminincludesupgradephp">trunk/src/wp-admin/includes/upgrade.php</a></li>
<li><a href="#trunksrcwpadminlinkparseopmlphp">trunk/src/wp-admin/link-parse-opml.php</a></li>
<li><a href="#trunksrcwpincludesauthortemplatephp">trunk/src/wp-includes/author-template.php</a></li>
<li><a href="#trunksrcwpincludescategorytemplatephp">trunk/src/wp-includes/category-template.php</a></li>
<li><a href="#trunksrcwpincludescategoryphp">trunk/src/wp-includes/category.php</a></li>
<li><a href="#trunksrcwpincludesclasshttpphp">trunk/src/wp-includes/class-http.php</a></li>
<li><a href="#trunksrcwpincludesclasswphttpcookiephp">trunk/src/wp-includes/class-wp-http-cookie.php</a></li>
<li><a href="#trunksrcwpincludesclasswphttpresponsephp">trunk/src/wp-includes/class-wp-http-response.php</a></li>
<li><a href="#trunksrcwpincludescommenttemplatephp">trunk/src/wp-includes/comment-template.php</a></li>
<li><a href="#trunksrcwpincludescompatphp">trunk/src/wp-includes/compat.php</a></li>
<li><a href="#trunksrcwpincludesformattingphp">trunk/src/wp-includes/formatting.php</a></li>
<li><a href="#trunksrcwpincludesfunctionsphp">trunk/src/wp-includes/functions.php</a></li>
<li><a href="#trunksrcwpincludesgeneraltemplatephp">trunk/src/wp-includes/general-template.php</a></li>
<li><a href="#trunksrcwpincludesloadphp">trunk/src/wp-includes/load.php</a></li>
<li><a href="#trunksrcwpincludesmsfunctionsphp">trunk/src/wp-includes/ms-functions.php</a></li>
<li><a href="#trunksrcwpincludespomostreamsphp">trunk/src/wp-includes/pomo/streams.php</a></li>
<li><a href="#trunksrcwpincludesposttemplatephp">trunk/src/wp-includes/post-template.php</a></li>
<li><a href="#trunksrcxmlrpcphp">trunk/src/xmlrpc.php</a></li>
<li><a href="#trunktestsphpunitincludesclassbasicobjectphp">trunk/tests/phpunit/includes/class-basic-object.php</a></li>
<li><a href="#trunktestsphpunitincludesfunctionsphp">trunk/tests/phpunit/includes/functions.php</a></li>
<li><a href="#trunktestsphpunitincludesobjectcachephp">trunk/tests/phpunit/includes/object-cache.php</a></li>
<li><a href="#trunktestsphpunitincludesphpunit6compatphp">trunk/tests/phpunit/includes/phpunit6/compat.php</a></li>
<li><a href="#trunktestsphpunitincludestracphp">trunk/tests/phpunit/includes/trac.php</a></li>
<li><a href="#trunktestsphpunitincludesutilsphp">trunk/tests/phpunit/includes/utils.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesfilephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/file.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/file.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-admin/includes/file.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1720,7 +1720,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param bool $allow_relaxed_file_ownership Optional. Whether to allow Group/World writable. Default false.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool|null True on success, false on failure, null if the filesystem method class file does not exist.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function WP_Filesystem( $args = false, $context = false, $allow_relaxed_file_ownership = false ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function WP_Filesystem( $args = false, $context = false, $allow_relaxed_file_ownership = false ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wp_filesystem;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> require_once( ABSPATH . 'wp-admin/includes/class-wp-filesystem-base.php' );
</span></span></pre></div>
<a id="trunksrcwpadminincludesmiscphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/misc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/misc.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-admin/includes/misc.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -831,7 +831,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param DOMDocument $doc
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $filename
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function saveDomDocument( $doc, $filename ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function saveDomDocument( $doc, $filename ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $config = $doc->saveXML();
</span><span class="cx" style="display: block; padding: 0 10px"> $config = preg_replace( "/([^\r])\n/", "$1\r\n", $config );
</span><span class="cx" style="display: block; padding: 0 10px"> $fp = fopen( $filename, 'w' );
</span></span></pre></div>
<a id="trunksrcwpadminincludesupgradephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/upgrade.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/upgrade.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-admin/includes/upgrade.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2453,7 +2453,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $setting Option name.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return mixed
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __get_option( $setting ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __get_option( $setting ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $setting == 'home' && defined( 'WP_HOME' ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2522,7 +2522,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Default true.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array Strings containing the results of the various update queries.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function dbDelta( $queries = '', $execute = true ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function dbDelta( $queries = '', $execute = true ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $queries, array( '', 'all', 'blog', 'global', 'ms_global' ), true ) ) {
</span></span></pre></div>
<a id="trunksrcwpadminlinkparseopmlphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/link-parse-opml.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/link-parse-opml.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-admin/link-parse-opml.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -31,7 +31,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $tagName XML element name.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $attrs XML element attributes.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function startElement( $parser, $tagName, $attrs ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function startElement( $parser, $tagName, $attrs ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> global $names, $urls, $targets, $descriptions, $feeds;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'OUTLINE' === $tagName ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -68,7 +68,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param mixed $parser XML Parser resource.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $tagName XML tag name.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function endElement( $parser, $tagName ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function endElement( $parser, $tagName ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> // Nothing to do.
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesauthortemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/author-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/author-template.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/author-template.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -563,6 +563,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.2.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @access private
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __clear_multi_author_cache() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __clear_multi_author_cache() { //phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> delete_transient( 'is_multi_author' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludescategorytemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/category-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/category-template.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/category-template.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -105,7 +105,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $cat_ID Category ID.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string|WP_Error Category name on success, WP_Error on failure.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function get_the_category_by_ID( $cat_ID ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function get_the_category_by_ID( $cat_ID ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $cat_ID = (int) $cat_ID;
</span><span class="cx" style="display: block; padding: 0 10px"> $category = get_term( $cat_ID );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludescategoryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/category.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/category.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/category.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -197,7 +197,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $cat_name Category name.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return int 0, if failure and ID of category on success.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function get_cat_ID( $cat_name ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function get_cat_ID( $cat_name ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $cat = get_term_by( 'name', $cat_name, 'category' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $cat ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return $cat->term_id;
</span></span></pre></div>
<a id="trunksrcwpincludesclasshttpphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-http.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-http.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/class-http.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -647,7 +647,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $strResponse The full response string
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array Array with 'headers' and 'body' keys.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public static function processResponse( $strResponse ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function processResponse( $strResponse ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $res = explode( "\r\n\r\n", $strResponse, 2 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -669,7 +669,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array Processed string headers. If duplicate headers are encountered,
</span><span class="cx" style="display: block; padding: 0 10px"> * Then a numbered array is returned as the value of that header-key.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public static function processHeaders( $headers, $url = '' ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function processHeaders( $headers, $url = '' ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> // Split headers, one per array element.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( is_string( $headers ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Tolerate line terminator: CRLF = LF (RFC 2616 19.3).
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -752,7 +752,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $r Full array of args passed into ::request()
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public static function buildCookieHeader( &$r ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function buildCookieHeader( &$r ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $r['cookies'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Upgrade any name => value cookie pairs to WP_HTTP_Cookie instances.
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $r['cookies'] as $name => $value ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -788,7 +788,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $body Body content
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string Chunked decoded body on success or raw body on failure.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public static function chunkTransferDecode( $body ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function chunkTransferDecode( $body ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> // The body is not chunked encoded or is malformed.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! preg_match( '/^([0-9a-f]+)[^\r\n]*\r\n/i', trim( $body ) ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return $body;
</span></span></pre></div>
<a id="trunksrcwpincludesclasswphttpcookiephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-http-cookie.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-http-cookie.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/class-wp-http-cookie.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -211,7 +211,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string Header encoded cookie name and value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function getHeaderValue() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function getHeaderValue() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $this->name ) || ! isset( $this->value ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return '';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -234,7 +234,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function getFullHeader() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function getFullHeader() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> return 'Cookie: ' . $this->getHeaderValue();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesclasswphttpresponsephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-http-response.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-http-response.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/class-wp-http-response.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -147,7 +147,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return mixed Any JSON-serializable value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function jsonSerialize() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function jsonSerialize() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> return $this->get_data();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludescommenttemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment-template.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/comment-template.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -262,7 +262,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Default current comment.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string Comment author's IP address.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function get_comment_author_IP( $comment_ID = 0 ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function get_comment_author_IP( $comment_ID = 0 ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $comment = get_comment( $comment_ID );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -287,7 +287,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int|WP_Comment $comment_ID Optional. WP_Comment or the ID of the comment for which to print the author's IP address.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default current comment.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function comment_author_IP( $comment_ID = 0 ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function comment_author_IP( $comment_ID = 0 ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> echo esc_html( get_comment_author_IP( $comment_ID ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -651,7 +651,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return int The comment ID.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function get_comment_ID() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function get_comment_ID() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $comment = get_comment();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -671,7 +671,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 0.71
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function comment_ID() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function comment_ID() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> echo get_comment_ID();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludescompatphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/compat.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/compat.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/compat.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -434,6 +434,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.4.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> interface JsonSerializable {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> public function jsonSerialize();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludesformattingphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/formatting.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/formatting.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/formatting.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2427,7 +2427,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param bool $force If true, forces balancing, ignoring the value of the option. Default false.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string Balanced text
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function balanceTags( $text, $force = false ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function balanceTags( $text, $force = false ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $force || get_option( 'use_balanceTags' ) == 1 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return force_balance_tags( $text );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span></span></pre></div>
<a id="trunksrcwpincludesfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/functions.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/functions.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5631,7 +5631,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return true True.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __return_true() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __return_true() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5646,7 +5646,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return false False.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __return_false() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __return_false() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5659,7 +5659,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return int 0.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __return_zero() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __return_zero() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> return 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5672,7 +5672,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array Empty array.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __return_empty_array() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __return_empty_array() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> return array();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5685,7 +5685,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return null Null value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __return_null() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __return_null() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> return null;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5700,7 +5700,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string Empty string.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __return_empty_string() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __return_empty_string() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> return '';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesgeneraltemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/general-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/general-template.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/general-template.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4548,7 +4548,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $type The type of checked|selected|disabled|readonly we are doing
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string html attribute or empty string
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function __checked_selected_helper( $helper, $current, $echo, $type ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function __checked_selected_helper( $helper, $current, $echo, $type ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionDoubleUnderscore
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( (string) $helper === (string) $current ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $result = " $type='$type'";
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span></span></pre></div>
<a id="trunksrcwpincludesloadphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/load.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/load.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/load.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -26,7 +26,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @access private
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function wp_unregister_GLOBALS() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function wp_unregister_GLOBALS() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! ini_get( 'register_globals' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludesmsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/ms-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/ms-functions.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/ms-functions.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2252,7 +2252,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $url URL
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string URL with https as the scheme
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function filter_SSL( $url ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function filter_SSL( $url ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_string( $url ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return get_bloginfo( 'url' ); // Return home blog url with proper scheme
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludespomostreamsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/pomo/streams.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/pomo/streams.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/pomo/streams.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,7 +34,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $endian Set the endianness of the file. Accepts 'big', or 'little'.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function setEndian( $endian ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function setEndian( $endian ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->endian = $endian;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesposttemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post-template.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/wp-includes/post-template.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,7 +13,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 0.71
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function the_ID() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function the_ID() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> echo get_the_ID();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,7 +24,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return int|false The ID of the current item in the WordPress Loop. False if $post is not set.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function get_the_ID() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function get_the_ID() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $post = get_post();
</span><span class="cx" style="display: block; padding: 0 10px"> return ! empty( $post ) ? $post->ID : false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcxmlrpcphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/xmlrpc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/xmlrpc.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/src/xmlrpc.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -96,7 +96,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $io Whether input or output
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $msg Information describing logging reason.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function logIO( $io, $msg ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function logIO( $io, $msg ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> _deprecated_function( __FUNCTION__, '3.4.0', 'error_log()' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $GLOBALS['xmlrpc_logging'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> error_log( $io . ' - ' . $msg );
</span></span></pre></div>
<a id="trunktestsphpunitincludesclassbasicobjectphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/class-basic-object.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/class-basic-object.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/tests/phpunit/includes/class-basic-object.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -37,6 +37,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return call_user_func_array( array( $this, $name ), $arguments );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> private function callMe() {
</span><span class="cx" style="display: block; padding: 0 10px"> return 'maybe';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunitincludesfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/functions.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/tests/phpunit/includes/functions.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,7 +21,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Resets various `$_SERVER` variables that can get altered during tests.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function tests_reset__SERVER() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function tests_reset__SERVER() { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> $_SERVER['HTTP_HOST'] = WP_TESTS_DOMAIN;
</span><span class="cx" style="display: block; padding: 0 10px"> $_SERVER['REMOTE_ADDR'] = '127.0.0.1';
</span><span class="cx" style="display: block; padding: 0 10px"> $_SERVER['REQUEST_METHOD'] = 'GET';
</span></span></pre></div>
<a id="trunktestsphpunitincludesobjectcachephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/object-cache.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/object-cache.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/tests/phpunit/includes/object-cache.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -761,6 +761,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $wp_object_cache->add_non_persistent_groups( $groups );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+// phpcs:disable WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> class WP_Object_Cache {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2160,3 +2161,4 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->blog_prefix = ( is_multisite() ? $blog_id : $table_prefix ) . ':';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+// phpcs:enable
</ins></span></pre></div>
<a id="trunktestsphpunitincludesphpunit6compatphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/phpunit6/compat.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/phpunit6/compat.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/tests/phpunit/includes/phpunit6/compat.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -17,6 +17,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> class PHPUnit_Util_Test {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> public static function getTickets( $className, $methodName ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $annotations = PHPUnit\Util\Test::parseTestMethodAnnotations( $className, $methodName );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunitincludestracphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/trac.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/trac.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/tests/phpunit/includes/trac.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,7 +13,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool|null true if the ticket is resolved, false if not resolved, null on error
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public static function isTracTicketClosed( $trac_url, $ticket_id ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function isTracTicketClosed( $trac_url, $ticket_id ) { // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! extension_loaded( 'openssl' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $trac_url = preg_replace( '/^https:/', 'http:', $trac_url );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -44,6 +44,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return ! in_array( $ticket_id, self::$trac_ticket_cache[ $trac_url ] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> public static function usingLocalCache() {
</span><span class="cx" style="display: block; padding: 0 10px"> echo PHP_EOL . "\x1b[0m\x1b[30;43m\x1b[2K";
</span><span class="cx" style="display: block; padding: 0 10px"> echo 'INFO: Trac was inaccessible, so a local ticket status cache was used.' . PHP_EOL;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,6 +51,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo "\x1b[0m\x1b[2K";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // phpcs:ignore WordPress.NamingConventions.ValidFunctionName.MethodNameInvalid
</ins><span class="cx" style="display: block; padding: 0 10px"> public static function forcingKnownBugs() {
</span><span class="cx" style="display: block; padding: 0 10px"> echo PHP_EOL . "\x1b[0m\x1b[37;41m\x1b[2K";
</span><span class="cx" style="display: block; padding: 0 10px"> echo "ERROR: Trac was inaccessible, so known bugs weren't able to be skipped." . PHP_EOL;
</span></span></pre></div>
<a id="trunktestsphpunitincludesutilsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/utils.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/utils.php 2019-07-01 03:46:30 UTC (rev 45579)
+++ trunk/tests/phpunit/includes/utils.php 2019-07-01 08:00:12 UTC (rev 45580)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -182,7 +182,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // convert valid xml to an array tree structure
</span><span class="cx" style="display: block; padding: 0 10px"> // kinda lame but it works with a default php 4 installation
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-class testXMLParser {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+class TestXMLParser {
</ins><span class="cx" style="display: block; padding: 0 10px"> var $xml;
</span><span class="cx" style="display: block; padding: 0 10px"> var $data = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -193,8 +193,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->xml = xml_parser_create();
</span><span class="cx" style="display: block; padding: 0 10px"> xml_set_object( $this->xml, $this );
</span><span class="cx" style="display: block; padding: 0 10px"> xml_parser_set_option( $this->xml, XML_OPTION_CASE_FOLDING, 0 );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- xml_set_element_handler( $this->xml, array( $this, 'startHandler' ), array( $this, 'endHandler' ) );
- xml_set_character_data_handler( $this->xml, array( $this, 'dataHandler' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ xml_set_element_handler( $this->xml, array( $this, 'start_handler' ), array( $this, 'end_handler' ) );
+ xml_set_character_data_handler( $this->xml, array( $this, 'data_handler' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->parse( $in );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -214,7 +214,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function startHandler( $parser, $name, $attributes ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function start_handler( $parser, $name, $attributes ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $data['name'] = $name;
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $attributes ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $data['attributes'] = $attributes; }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -221,12 +221,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->data[] = $data;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function dataHandler( $parser, $data ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function data_handler( $parser, $data ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $index = count( $this->data ) - 1;
</span><span class="cx" style="display: block; padding: 0 10px"> @$this->data[ $index ]['content'] .= $data;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function endHandler( $parser, $name ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function end_handler( $parser, $name ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( count( $this->data ) > 1 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $data = array_pop( $this->data );
</span><span class="cx" style="display: block; padding: 0 10px"> $index = count( $this->data ) - 1;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -236,7 +236,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function xml_to_array( $in ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $p = new testXMLParser( $in );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $p = new TestXMLParser( $in );
</ins><span class="cx" style="display: block; padding: 0 10px"> return $p->data;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>