<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[45143] trunk: Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Text and HTML widgets.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/45143">45143</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/45143","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-04-08 23:17:35 +0000 (Mon, 08 Apr 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Widgets: Add `rel="noopener noreferrer"` to links with `target="_blank"` in the Text and HTML widgets.
Props audrasjb, birgire, mukesh27.
Fixes <a href="https://core.trac.wordpress.org/ticket/46421">#46421</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetcustomhtmlphp">trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgettextphp">trunk/src/wp-includes/widgets/class-wp-widget-text.php</a></li>
<li><a href="#trunktestsphpunittestswidgetscustomhtmlwidgetphp">trunk/tests/phpunit/tests/widgets/custom-html-widget.php</a></li>
<li><a href="#trunktestsphpunittestswidgetstextwidgetphp">trunk/tests/phpunit/tests/widgets/text-widget.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludeswidgetsclasswpwidgetcustomhtmlphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php 2019-04-08 23:11:36 UTC (rev 45142)
+++ trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php 2019-04-08 23:17:35 UTC (rev 45143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -143,6 +143,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /** This filter is documented in wp-includes/widgets/class-wp-widget-text.php */
</span><span class="cx" style="display: block; padding: 0 10px"> $content = apply_filters( 'widget_text', $instance['content'], $simulated_text_widget_instance, $this );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Adds noreferrer and noopener relationships, without duplicating values, to all HTML A elements that have a target.
+ $content = wp_targeted_link_rel( $content );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Filters the content of the Custom HTML widget.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgettextphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-text.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-text.php 2019-04-08 23:11:36 UTC (rev 45142)
+++ trunk/src/wp-includes/widgets/class-wp-widget-text.php 2019-04-08 23:17:35 UTC (rev 45143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -328,6 +328,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $text = preg_replace_callback( '#<(video|iframe|object|embed)\s[^>]*>#i', array( $this, 'inject_video_max_width_style' ), $text );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Adds noreferrer and noopener relationships, without duplicating values, to all HTML A elements that have a target.
+ $text = wp_targeted_link_rel( $text );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="textwidget"><?php echo $text; ?></div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span></span></pre></div>
<a id="trunktestsphpunittestswidgetscustomhtmlwidgetphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/widgets/custom-html-widget.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/widgets/custom-html-widget.php 2019-04-08 23:11:36 UTC (rev 45142)
+++ trunk/tests/phpunit/tests/widgets/custom-html-widget.php 2019-04-08 23:17:35 UTC (rev 45143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -302,4 +302,57 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertContains( 'Use the Custom HTML widget to add arbitrary HTML code to your widget areas.', $help_tab['content'] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Ensure that rel="noopener noreferrer" is added to links with a target.
+ *
+ * @ticket 46421
+ */
+ function test_render_links_with_target() {
+ $widget = new WP_Widget_Custom_HTML();
+
+ $content = 'Test content with an external <a href="https://example.org" target="_blank">link</a>.';
+
+ $args = array(
+ 'before_title' => '<h2>',
+ 'after_title' => '</h2>',
+ 'before_widget' => '',
+ 'after_widget' => '',
+ );
+
+ $instance = array(
+ 'title' => 'Foo',
+ 'content' => $content,
+ );
+
+ $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
+ $this->assertContains( 'rel="noopener noreferrer"', $output );
+ }
+
+ /**
+ * Ensure that rel="noopener noreferrer" is not added to links without a target.
+ *
+ * @ticket 46421
+ */
+ function test_render_links_without_target() {
+ $widget = new WP_Widget_Custom_HTML();
+
+ $content = 'Test content with an internal <a href="/">link</a>.';
+
+ $args = array(
+ 'before_title' => '<h2>',
+ 'after_title' => '</h2>',
+ 'before_widget' => '',
+ 'after_widget' => '',
+ );
+
+ $instance = array(
+ 'title' => 'Foo',
+ 'content' => $content,
+ );
+
+ $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
+ $this->assertNotContains( 'rel="noopener noreferrer"', $output );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestswidgetstextwidgetphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/widgets/text-widget.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/widgets/text-widget.php 2019-04-08 23:11:36 UTC (rev 45142)
+++ trunk/tests/phpunit/tests/widgets/text-widget.php 2019-04-08 23:17:35 UTC (rev 45143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1001,4 +1001,58 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertContains( '<script type="text/html" id="tmpl-widget-text-control-fields">', $output );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Ensure that rel="noopener noreferrer" is added to links with a target.
+ *
+ * @ticket 46421
+ */
+ function test_render_links_with_target() {
+ $widget = new WP_Widget_Text();
+
+ $text = 'Test content with an external <a href="https://example.org" target="_blank">link</a>.';
+
+ $args = array(
+ 'before_title' => '<h2>',
+ 'after_title' => '</h2>',
+ 'before_widget' => '',
+ 'after_widget' => '',
+ );
+
+ $instance = array(
+ 'title' => 'Foo',
+ 'text' => $text,
+ );
+
+ $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
+
+ $this->assertContains( 'rel="noopener noreferrer"', $output );
+ }
+
+ /**
+ * Ensure that rel="noopener noreferrer" is not added to links without a target.
+ *
+ * @ticket 46421
+ */
+ function test_render_links_without_target() {
+ $widget = new WP_Widget_Text();
+
+ $text = 'Test content with an internal <a href="/">link</a>.';
+
+ $args = array(
+ 'before_title' => '<h2>',
+ 'after_title' => '</h2>',
+ 'before_widget' => '',
+ 'after_widget' => '',
+ );
+
+ $instance = array(
+ 'title' => 'Foo',
+ 'text' => $text,
+ );
+
+ $output = get_echo( array( $widget, 'widget' ), array( $args, $instance ) );
+
+ $this->assertNotContains( 'rel="noopener noreferrer"', $output );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>