<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44896] trunk/src: Accessibility: Improve the placeholder "prompt" text in the post title and Quick Draft widget.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44896">44896</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44896","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-03-14 17:38:36 +0000 (Thu, 14 Mar 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Improve the placeholder "prompt" text in the post title and Quick Draft widget.
Old browsers didn't support the HTML placeholder attribute. For a number of years, `<label>` elements have been used in a few places in WordPress to emulate placeholders. It's time to improve semantics and interaction, use real placeholders when possible, and clean up some JavaScript.
- Quick Draft widget: it now uses visible `<label>` elements and a real `placeholder` attribute
- removes the related JavaScript
- Post title:
- keeps the "prompt" label for backwards compatibility
- improves the JavaScript to make the "prompt" label stay visible on focus and disappear when typing, like real placeholder do
- changes the post "prompt" text from "Enter title here" to "Add title" for consistency with the Block Editor
- cleans-up some CSS
Props Cheffheid, afercia.
Fixes <a href="https://core.trac.wordpress.org/ticket/42390">#42390</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminpostjs">trunk/src/js/_enqueues/admin/post.js</a></li>
<li><a href="#trunksrcjs_enqueueswpdashboardjs">trunk/src/js/_enqueues/wp/dashboard.js</a></li>
<li><a href="#trunksrcwpadmincssdashboardcss">trunk/src/wp-admin/css/dashboard.css</a></li>
<li><a href="#trunksrcwpadmineditformadvancedphp">trunk/src/wp-admin/edit-form-advanced.php</a></li>
<li><a href="#trunksrcwpadminincludesdashboardphp">trunk/src/wp-admin/includes/dashboard.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminpostjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/post.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/post.js 2019-03-13 23:36:45 UTC (rev 44895)
+++ trunk/src/js/_enqueues/admin/post.js 2019-03-14 17:38:36 UTC (rev 44896)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1040,8 +1040,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Adds screen reader text to the title prompt when needed.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Adds screen reader text to the title label when needed.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Use the 'screen-reader-text' class to emulate a placeholder attribute
+ * and hide the label when entering a value.
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param {string} id Optional. HTML ID to add the screen reader helper text to.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1048,28 +1051,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @returns void
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- window.wptitlehint = function(id) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ window.wptitlehint = function( id ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> id = id || 'title';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var title = $('#' + id), titleprompt = $('#' + id + '-prompt-text');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var title = $( '#' + id ), titleprompt = $( '#' + id + '-prompt-text' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( '' === title.val() )
- titleprompt.removeClass('screen-reader-text');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( '' === title.val() ) {
+ titleprompt.removeClass( 'screen-reader-text' );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- titleprompt.click(function(){
- $(this).addClass('screen-reader-text');
- title.focus();
- });
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ title.on( 'input', function() {
+ if ( '' === this.value ) {
+ titleprompt.removeClass( 'screen-reader-text' );
+ return;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- title.blur(function(){
- if ( '' === this.value )
- titleprompt.removeClass('screen-reader-text');
- }).focus(function(){
- titleprompt.addClass('screen-reader-text');
- }).keydown(function(e){
- titleprompt.addClass('screen-reader-text');
- $(this).unbind(e);
- });
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ titleprompt.addClass( 'screen-reader-text' );
+ } );
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wptitlehint();
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpdashboardjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/dashboard.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/dashboard.js 2019-03-13 23:36:45 UTC (rev 44895)
+++ trunk/src/js/_enqueues/wp/dashboard.js 2019-03-14 17:38:36 UTC (rev 44896)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -173,37 +173,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Change the QuickPost action to the publish value.
</span><span class="cx" style="display: block; padding: 0 10px"> $('#publish').click( function() { act.val( 'post-quickpress-publish' ); } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /**
- * Adds accessibility context to inputs.
- *
- * Use the 'screen-reader-text' class to hide the label when entering a value.
- * Apply it when the input is not empty or the input has focus.
- *
- * @returns {void}
- */
- $('#title, #tags-input, #content').each( function() {
- var input = $(this), prompt = $('#' + this.id + '-prompt-text');
-
- if ( '' === this.value ) {
- prompt.removeClass('screen-reader-text');
- }
-
- prompt.click( function() {
- $(this).addClass('screen-reader-text');
- input.focus();
- });
-
- input.blur( function() {
- if ( '' === this.value ) {
- prompt.removeClass('screen-reader-text');
- }
- });
-
- input.focus( function() {
- prompt.addClass('screen-reader-text');
- });
- });
-
</del><span class="cx" style="display: block; padding: 0 10px"> $('#quick-press').on( 'click focusin', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> wpActiveEditor = 'content';
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span></span></pre></div>
<a id="trunksrcwpadmincssdashboardcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/dashboard.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/dashboard.css 2019-03-13 23:36:45 UTC (rev 44895)
+++ trunk/src/wp-admin/css/dashboard.css 2019-03-14 17:38:36 UTC (rev 44896)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -599,25 +599,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 12px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#dashboard_quick_press .drafts,
-#dashboard_quick_press .easy-blogging {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#dashboard_quick_press .drafts {
</ins><span class="cx" style="display: block; padding: 0 10px"> padding: 10px 0 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Dashboard Quick Draft - Form styling */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-input#save-post {
- float: left;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#dashboard_quick_press label {
+ display: inline-block;
+ margin-bottom: 4px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-form.initial-form.quickpress-open label.prompt {
- font-style: normal;
-}
-
-form.initial-form.quickpress-open input#title {
- height: auto;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> #dashboard_quick_press input,
</span><span class="cx" style="display: block; padding: 0 10px"> #dashboard_quick_press textarea {
</span><span class="cx" style="display: block; padding: 0 10px"> box-sizing: border-box;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -624,10 +616,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#dashboard_quick_press textarea {
- resize: vertical;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> #dashboard-widgets .postbox form .submit {
</span><span class="cx" style="display: block; padding: 0 10px"> margin: -39px 0;
</span><span class="cx" style="display: block; padding: 0 10px"> float: right;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -637,39 +625,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin-top: 12px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#title-wrap #title-prompt-text,
-.textarea-wrap #content-prompt-text {
- color: #72777c;
-}
-
-#title-wrap #title-prompt-text {
- font-size: 1.1em;
- padding: 7px 8px;
-}
-
-.input-text-wrap,
-.textarea-wrap {
- position: relative;
-}
-
-.input-text-wrap .prompt,
-.textarea-wrap .prompt {
- position: absolute;
-}
-
-.textarea-wrap #content-prompt-text {
- font-size: 1.1em;
- padding: 7px 8px;
-}
-
-.textarea-wrap textarea#content {
- margin: 0 0 8px;
- padding: 6px 7px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> #quick-press textarea#content {
</span><span class="cx" style="display: block; padding: 0 10px"> min-height: 90px;
</span><span class="cx" style="display: block; padding: 0 10px"> max-height: 1300px;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin: 0 0 8px;
+ padding: 6px 7px;
</ins><span class="cx" style="display: block; padding: 0 10px"> resize: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1000,24 +960,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 13px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/* QuickDraft */
-
-#title-wrap label,
-#description-wrap label {
- cursor: text;
-}
-
-#title-wrap #title {
- padding: 2px 6px;
- font-size: 1.3em;
- outline: none;
-}
-
-#title-wrap #title-prompt-text {
- font-size: 1.1em;
- padding: 5px 8px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> /* Feeds */
</span><span class="cx" style="display: block; padding: 0 10px"> .rss-widget ul {
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span></span></pre></div>
<a id="trunksrcwpadmineditformadvancedphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/edit-form-advanced.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/edit-form-advanced.php 2019-03-13 23:36:45 UTC (rev 44895)
+++ trunk/src/wp-admin/edit-form-advanced.php 2019-03-14 17:38:36 UTC (rev 44896)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -477,10 +477,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $text Placeholder text. Default 'Enter title here'.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $text Placeholder text. Default 'Add title'.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Post $post Post object.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $title_placeholder = apply_filters( 'enter_title_here', __( 'Enter title here' ), $post );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $title_placeholder = apply_filters( 'enter_title_here', __( 'Add title' ), $post );
</ins><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <label class="screen-reader-text" id="title-prompt-text" for="title"><?php echo $title_placeholder; ?></label>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" name="post_title" size="30" value="<?php echo esc_attr( $post->post_title ); ?>" id="title" spellcheck="true" autocomplete="off" />
</span></span></pre></div>
<a id="trunksrcwpadminincludesdashboardphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/dashboard.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/dashboard.php 2019-03-13 23:36:45 UTC (rev 44895)
+++ trunk/src/wp-admin/includes/dashboard.php 2019-03-14 17:38:36 UTC (rev 44896)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -519,8 +519,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="input-text-wrap" id="title-wrap">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="screen-reader-text prompt" for="title" id="title-prompt-text">
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label for="title">
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /** This filter is documented in wp-admin/edit-form-advanced.php */
</span><span class="cx" style="display: block; padding: 0 10px"> echo apply_filters( 'enter_title_here', __( 'Title' ), $post );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -530,8 +529,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="textarea-wrap" id="description-wrap">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="screen-reader-text prompt" for="content" id="content-prompt-text"><?php _e( 'What’s on your mind?' ); ?></label>
- <textarea name="content" id="content" class="mceEditor" rows="3" cols="15" autocomplete="off"></textarea>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label for="content"><?php _e( 'Content' ); ?></label>
+ <textarea name="content" id="content" placeholder="<?php esc_attr_e( 'What’s on your mind?' ); ?>" class="mceEditor" rows="3" cols="15" autocomplete="off"></textarea>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <p class="submit">
</span></span></pre>
</div>
</div>
</body>
</html>