<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44793] trunk/src/wp-includes: Accessibility: Hide the Toolbar sub-menu CSS generated icons from assistive technologies.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44793">44793</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44793","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-03-04 22:45:24 +0000 (Mon, 04 Mar 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Hide the Toolbar sub-menu CSS generated icons from assistive technologies.
CSS generated content is rendered for speech output. When it's not meant to be announced by assistive technologies, for example with font icons, special care should be used to hide it. At the moment, the only reliable way to do this is making use of a wrapper element and set `aria-hidden="true"` on it.
Fixes <a href="https://core.trac.wordpress.org/ticket/37513">#37513</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpadminbarphp">trunk/src/wp-includes/class-wp-admin-bar.php</a></li>
<li><a href="#trunksrcwpincludescssadminbarcss">trunk/src/wp-includes/css/admin-bar.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclasswpadminbarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-admin-bar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-admin-bar.php 2019-03-04 22:19:05 UTC (rev 44792)
+++ trunk/src/wp-includes/class-wp-admin-bar.php 2019-03-04 22:45:24 UTC (rev 44793)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -501,8 +501,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $is_parent = ! empty( $node->children );
- $has_link = ! empty( $node->href );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $is_parent = ! empty( $node->children );
+ $has_link = ! empty( $node->href );
+ $is_root_top_item = 'root-default' === $node->parent;
+ $is_top_secondary_item = 'top-secondary' === $node->parent;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Allow only numeric values, then casted to integers, and allow a tabindex value of `0` for a11y.
</span><span class="cx" style="display: block; padding: 0 10px"> $tabindex = ( isset( $node->meta['tabindex'] ) && is_numeric( $node->meta['tabindex'] ) ) ? (int) $node->meta['tabindex'] : '';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -509,6 +511,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $aria_attributes = ( '' !== $tabindex ) ? ' tabindex="' . $tabindex . '"' : '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $menuclass = '';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $arrow = '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $is_parent ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $menuclass = 'menupop ';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -519,6 +522,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $menuclass .= $node->meta['class'];
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Print the arrow icon for the menu children with children.
+ if ( ! $is_root_top_item && ! $is_top_secondary_item && $is_parent ) {
+ $arrow = '<span class="wp-admin-bar-arrow" aria-hidden="true"></span>';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $menuclass ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $menuclass = ' class="' . esc_attr( trim( $menuclass ) ) . '"';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -542,7 +550,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo ">{$node->title}";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo ">{$arrow}{$node->title}";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $has_link ) {
</span><span class="cx" style="display: block; padding: 0 10px"> echo '</a>';
</span></span></pre></div>
<a id="trunksrcwpincludescssadminbarcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/css/admin-bar.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/css/admin-bar.css 2019-03-04 22:19:05 UTC (rev 44792)
+++ trunk/src/wp-includes/css/admin-bar.css 2019-03-04 22:45:24 UTC (rev 44793)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -231,7 +231,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #wpadminbar > #wp-toolbar > #wp-admin-bar-root-default .ab-icon,
</span><span class="cx" style="display: block; padding: 0 10px"> #wpadminbar .ab-icon,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#wpadminbar .ab-item:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#wpadminbar .ab-item:before,
+.wp-admin-bar-arrow {
</ins><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="cx" style="display: block; padding: 0 10px"> font: normal 20px/1 dashicons;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -308,7 +309,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> color: #00b9eb;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#wpadminbar .menupop .menupop > .ab-item:before,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#wpadminbar .menupop .menupop > .ab-item .wp-admin-bar-arrow:before,
</ins><span class="cx" style="display: block; padding: 0 10px"> #wpadminbar .ab-top-secondary .menupop .menupop > .ab-item:before {
</span><span class="cx" style="display: block; padding: 0 10px"> position: absolute;
</span><span class="cx" style="display: block; padding: 0 10px"> font: normal 17px/1 dashicons;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -322,9 +323,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-right: 2em;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#wpadminbar .menupop .menupop > .ab-item:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#wpadminbar .menupop .menupop > .ab-item .wp-admin-bar-arrow:before {
</ins><span class="cx" style="display: block; padding: 0 10px"> top: 1px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- right: 4px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ right: 10px;
+ padding: 4px 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> content: "\f139";
</span><span class="cx" style="display: block; padding: 0 10px"> color: inherit;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -334,7 +336,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-right: 1em;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#wpadminbar .ab-top-secondary .menupop .menupop > .ab-item:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#wpadminbar .ab-top-secondary .menupop .menupop > .ab-item .wp-admin-bar-arrow:before {
</ins><span class="cx" style="display: block; padding: 0 10px"> top: 1px;
</span><span class="cx" style="display: block; padding: 0 10px"> left: 6px;
</span><span class="cx" style="display: block; padding: 0 10px"> content: "\f141";
</span></span></pre>
</div>
</div>
</body>
</html>