<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44717] trunk: Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44717">44717</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44717","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>flixos90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-01-30 11:00:30 +0000 (Wed, 30 Jan 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.
Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.
Fixes <a href="https://core.trac.wordpress.org/ticket/46141">#46141</a>. See <a href="https://core.trac.wordpress.org/ticket/44458">#44458</a>, <a href="https://core.trac.wordpress.org/ticket/45932">#45932</a>, <a href="https://core.trac.wordpress.org/ticket/45940">#45940</a>, <a href="https://core.trac.wordpress.org/ticket/46038">#46038</a>, <a href="https://core.trac.wordpress.org/ticket/46047">#46047</a>, <a href="https://core.trac.wordpress.org/ticket/46068">#46068</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesadminfiltersphp">trunk/src/wp-admin/includes/admin-filters.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludespluginphp">trunk/src/wp-admin/includes/plugin.php</a></li>
<li><a href="#trunksrcwpadminincludesthemephp">trunk/src/wp-admin/includes/theme.php</a></li>
<li><a href="#trunksrcwpadminpluginsphp">trunk/src/wp-admin/plugins.php</a></li>
<li><a href="#trunksrcwpadminthemesphp">trunk/src/wp-admin/themes.php</a></li>
<li><a href="#trunksrcwpincludescapabilitiesphp">trunk/src/wp-includes/capabilities.php</a></li>
<li><a href="#trunksrcwpincludesclasswpthemephp">trunk/src/wp-includes/class-wp-theme.php</a></li>
<li><a href="#trunksrcwpincludesloadphp">trunk/src/wp-includes/load.php</a></li>
<li><a href="#trunksrcwpincludesmsloadphp">trunk/src/wp-includes/ms-load.php</a></li>
<li><a href="#trunksrcwpsettingsphp">trunk/src/wp-settings.php</a></li>
<li><a href="#trunktestsphpunittestsusercapabilitiesphp">trunk/tests/phpunit/tests/user/capabilities.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclasswpfatalerrorhandlerphp">trunk/src/wp-includes/class-wp-fatal-error-handler.php</a></li>
<li><a href="#trunksrcwpincludesclasswppausedextensionsstoragephp">trunk/src/wp-includes/class-wp-paused-extensions-storage.php</a></li>
<li><a href="#trunksrcwpincludeserrorprotectionphp">trunk/src/wp-includes/error-protection.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/css/list-tables.css 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1301,31 +1301,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> text-decoration: underline;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.plugins tr.paused th.check-column {
- border-left: 4px solid #d54e21;
-}
-
-.plugins tr.paused th,
-.plugins tr.paused td {
- background-color: #fef7f1;
-}
-
-.plugins tr.paused .plugin-title,
-.plugins .paused .dashicons-warning {
- color: #dc3232;
-}
-
-.plugins .paused .error-display p,
-.plugins .paused .error-display code {
- font-size: 90%;
- font-style: italic;
- color: rgb( 0, 0, 0, 0.7 );
-}
-
-.plugins .resume-link {
- color: #dc3232;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .plugin-card .update-now:before {
</span><span class="cx" style="display: block; padding: 0 10px"> color: #f56e28;
</span><span class="cx" style="display: block; padding: 0 10px"> content: "\f463";
</span></span></pre></div>
<a id="trunksrcwpadminincludesadminfiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/admin-filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/admin-filters.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/includes/admin-filters.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -117,8 +117,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'load-themes.php', 'wp_theme_update_rows', 20 ); // After wp_update_themes() is called.
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_notices', 'update_nag', 3 );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_action( 'admin_notices', 'paused_plugins_notice', 5 );
-add_action( 'admin_notices', 'paused_themes_notice', 5 );
</del><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_notices', 'maintenance_nag', 10 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'update_footer', 'core_update_footer' );
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -40,7 +40,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $status = 'all';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( isset( $_REQUEST['plugin_status'] ) && in_array( $_REQUEST['plugin_status'], array( 'active', 'inactive', 'recently_activated', 'upgrade', 'mustuse', 'dropins', 'search', 'paused' ) ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( isset( $_REQUEST['plugin_status'] ) && in_array( $_REQUEST['plugin_status'], array( 'active', 'inactive', 'recently_activated', 'upgrade', 'mustuse', 'dropins', 'search' ) ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $status = $_REQUEST['plugin_status'];
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -99,7 +99,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'upgrade' => array(),
</span><span class="cx" style="display: block; padding: 0 10px"> 'mustuse' => array(),
</span><span class="cx" style="display: block; padding: 0 10px"> 'dropins' => array(),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'paused' => array(),
</del><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $screen = $this->screen;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -210,9 +209,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $show_network_active ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // On the non-network screen, show network-active plugins if allowed
</span><span class="cx" style="display: block; padding: 0 10px"> $plugins['active'][ $plugin_file ] = $plugin_data;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( is_plugin_paused( $plugin_file ) ) {
- $plugins['paused'][ $plugin_file ] = $plugin_data;
- }
</del><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> // On the non-network screen, filter out network-active plugins
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $plugins['all'][ $plugin_file ] );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -222,9 +218,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // On the non-network screen, populate the active list with plugins that are individually activated
</span><span class="cx" style="display: block; padding: 0 10px"> // On the network-admin screen, populate the active list with plugins that are network activated
</span><span class="cx" style="display: block; padding: 0 10px"> $plugins['active'][ $plugin_file ] = $plugin_data;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( is_plugin_paused( $plugin_file ) ) {
- $plugins['paused'][ $plugin_file ] = $plugin_data;
- }
</del><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $recently_activated[ $plugin_file ] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Populate the recently activated list with plugins that have been recently activated
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -452,10 +445,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin count */
</span><span class="cx" style="display: block; padding: 0 10px"> $text = _n( 'Drop-ins <span class="count">(%s)</span>', 'Drop-ins <span class="count">(%s)</span>', $count );
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'paused':
- /* translators: %s: plugin count */
- $text = _n( 'Paused <span class="count">(%s)</span>', 'Paused <span class="count">(%s)</span>', $count );
- break;
</del><span class="cx" style="display: block; padding: 0 10px"> case 'upgrade':
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin count */
</span><span class="cx" style="display: block; padding: 0 10px"> $text = _n( 'Update Available <span class="count">(%s)</span>', 'Update Available <span class="count">(%s)</span>', $count );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -644,19 +633,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin name */
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['deactivate'] = '<a href="' . wp_nonce_url( 'plugins.php?action=deactivate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'deactivate-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Network Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Network Deactivate' ) . '</a>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( current_user_can( 'manage_network_plugins' ) && count_paused_plugin_sites_for_network( $plugin_file ) ) {
- /* translators: %s: plugin name */
- $actions['resume'] = '<a class="resume-link" href="' . wp_nonce_url( 'plugins.php?action=resume&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'resume-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Network Resume %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Network Resume' ) . '</a>';
- }
</del><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'manage_network_plugins' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin name */
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['activate'] = '<a href="' . wp_nonce_url( 'plugins.php?action=activate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'activate-plugin_' . $plugin_file ) . '" class="edit" aria-label="' . esc_attr( sprintf( _x( 'Network Activate %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Network Activate' ) . '</a>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( current_user_can( 'manage_network_plugins' ) && count_paused_plugin_sites_for_network( $plugin_file ) ) {
- /* translators: %s: plugin name */
- $actions['resume'] = '<a class="resume-link" href="' . wp_nonce_url( 'plugins.php?action=resume&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'resume-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Network Resume %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Network Resume' ) . '</a>';
- }
</del><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'delete_plugins' ) && ! is_plugin_active( $plugin_file ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin name */
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['delete'] = '<a href="' . wp_nonce_url( 'plugins.php?action=delete-selected&checked[]=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'bulk-plugins' ) . '" class="delete" aria-label="' . esc_attr( sprintf( _x( 'Delete %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Delete' ) . '</a>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -667,10 +648,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actions = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'network_active' => __( 'Network Active' ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! $restrict_network_only && current_user_can( 'resume_plugin', $plugin_file ) && is_plugin_paused( $plugin_file ) ) {
- /* translators: %s: plugin name */
- $actions['resume'] = '<a class="resume-link" href="' . wp_nonce_url( 'plugins.php?action=resume&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'resume-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Resume %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Resume' ) . '</a>';
- }
</del><span class="cx" style="display: block; padding: 0 10px"> } elseif ( $restrict_network_only ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $actions = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'network_only' => __( 'Network Only' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -680,10 +657,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin name */
</span><span class="cx" style="display: block; padding: 0 10px"> $actions['deactivate'] = '<a href="' . wp_nonce_url( 'plugins.php?action=deactivate&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'deactivate-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Deactivate %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Deactivate' ) . '</a>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( current_user_can( 'resume_plugin', $plugin_file ) && is_plugin_paused( $plugin_file ) ) {
- /* translators: %s: plugin name */
- $actions['resume'] = '<a class="resume-link" href="' . wp_nonce_url( 'plugins.php?action=resume&plugin=' . urlencode( $plugin_file ) . '&plugin_status=' . $context . '&paged=' . $page . '&s=' . $s, 'resume-plugin_' . $plugin_file ) . '" aria-label="' . esc_attr( sprintf( _x( 'Resume %s', 'plugin' ), $plugin_data['Name'] ) ) . '">' . __( 'Resume' ) . '</a>';
- }
</del><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'activate_plugin', $plugin_file ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: plugin name */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -791,12 +764,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $class .= ' update';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $paused = is_plugin_paused( $plugin_file );
- $paused_on_network_sites_count = $screen->in_admin( 'network' ) ? count_paused_plugin_sites_for_network( $plugin_file ) : 0;
- if ( $paused || $paused_on_network_sites_count ) {
- $class .= ' paused';
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> $plugin_slug = isset( $plugin_data['slug'] ) ? $plugin_data['slug'] : sanitize_title( $plugin_name );
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<tr class="%s" data-slug="%s" data-plugin="%s">',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -878,7 +845,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $plugin_data An array of plugin data.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $status Status of the plugin. Defaults are 'All', 'Active',
</span><span class="cx" style="display: block; padding: 0 10px"> * 'Inactive', 'Recently Activated', 'Upgrade', 'Must-Use',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 'Drop-ins', 'Search', 'Paused'.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 'Drop-ins', 'Search'.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin_meta = apply_filters( 'plugin_row_meta', $plugin_meta, $plugin_file, $plugin_data, $status );
</span><span class="cx" style="display: block; padding: 0 10px"> echo implode( ' | ', $plugin_meta );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -885,46 +852,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo '</div>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $paused || $paused_on_network_sites_count ) {
- $notice_text = __( 'This plugin failed to load properly and was paused within the admin backend.' );
- if ( $screen->in_admin( 'network' ) && $paused_on_network_sites_count ) {
- $notice_text = sprintf(
- /* translators: %s: number of sites */
- _n( 'This plugin failed to load properly and was paused within the admin backend for %s site.', 'This plugin failed to load properly and was paused within the admin backend for %s sites.', $paused_on_network_sites_count ),
- number_format_i18n( $paused_on_network_sites_count )
- );
- }
-
- printf( '<p><span class="dashicons dashicons-warning"></span> <strong>%s</strong></p>', $notice_text );
-
- $error = wp_get_plugin_error( $plugin_file );
-
- if ( false !== $error ) {
- $constants = get_defined_constants( true );
- $constants = isset( $constants['Core'] ) ? $constants['Core'] : $constants['internal'];
-
- foreach ( $constants as $constant => $value ) {
- if ( 0 === strpos( $constant, 'E_' ) ) {
- $core_errors[ $value ] = $constant;
- }
- }
-
- $error['type'] = $core_errors[ $error['type'] ];
-
- printf(
- '<div class="error-display"><p>%s</p></div>',
- sprintf(
- /* translators: 1: error type, 2: error line number, 3: error file name, 4: error message */
- __( 'The plugin caused an error of type %1$s in line %2$s of the file %3$s. Error message: %4$s' ),
- "<code>{$error['type']}</code>",
- "<code>{$error['line']}</code>",
- "<code>{$error['file']}</code>",
- "<code>{$error['message']}</code>"
- )
- );
- }
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> echo '</td>';
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> default:
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -958,7 +885,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $plugin_data An array of plugin data.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $status Status of the plugin. Defaults are 'All', 'Active',
</span><span class="cx" style="display: block; padding: 0 10px"> * 'Inactive', 'Recently Activated', 'Upgrade', 'Must-Use',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 'Drop-ins', 'Search', 'Paused'.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 'Drop-ins', 'Search'.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> do_action( 'after_plugin_row', $plugin_file, $plugin_data, $status );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -974,7 +901,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $plugin_data An array of plugin data.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $status Status of the plugin. Defaults are 'All', 'Active',
</span><span class="cx" style="display: block; padding: 0 10px"> * 'Inactive', 'Recently Activated', 'Upgrade', 'Must-Use',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 'Drop-ins', 'Search', 'Paused'.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 'Drop-ins', 'Search'.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> do_action( "after_plugin_row_{$plugin_file}", $plugin_file, $plugin_data, $status );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludespluginphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/plugin.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/plugin.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/includes/plugin.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -468,14 +468,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function _get_dropins() {
</span><span class="cx" style="display: block; padding: 0 10px"> $dropins = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'advanced-cache.php' => array( __( 'Advanced caching plugin.' ), 'WP_CACHE' ), // WP_CACHE
- 'db.php' => array( __( 'Custom database class.' ), true ), // auto on load
- 'db-error.php' => array( __( 'Custom database error message.' ), true ), // auto on error
- 'install.php' => array( __( 'Custom installation script.' ), true ), // auto on installation
- 'maintenance.php' => array( __( 'Custom maintenance message.' ), true ), // auto on maintenance
- 'object-cache.php' => array( __( 'External object cache.' ), true ), // auto on load
- 'php-error.php' => array( __( 'Custom PHP error message.' ), true ), // auto on error
- 'fatal-error-handler.php' => array( __( 'Custom PHP fatal error handler.' ), true ), // auto on error
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'advanced-cache.php' => array( __( 'Advanced caching plugin.' ), 'WP_CACHE' ), // WP_CACHE
+ 'db.php' => array( __( 'Custom database class.' ), true ), // auto on load
+ 'db-error.php' => array( __( 'Custom database error message.' ), true ), // auto on error
+ 'install.php' => array( __( 'Custom installation script.' ), true ), // auto on installation
+ 'maintenance.php' => array( __( 'Custom maintenance message.' ), true ), // auto on maintenance
+ 'object-cache.php' => array( __( 'External object cache.' ), true ), // auto on load
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( is_multisite() ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -529,84 +527,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Determines whether a plugin is technically active but was paused while
- * loading.
- *
- * For more information on this and similar theme functions, check out
- * the {@link https://developer.wordpress.org/themes/basics/conditional-tags/
- * Conditional Tags} article in the Theme Developer Handbook.
- *
- * @since 5.1.0
- *
- * @param string $plugin Path to the plugin file relative to the plugins directory.
- * @return bool True, if in the list of paused plugins. False, not in the list.
- */
-function is_plugin_paused( $plugin ) {
- if ( ! isset( $GLOBALS['_paused_plugins'] ) ) {
- return false;
- }
-
- if ( ! is_plugin_active( $plugin ) && ! is_plugin_active_for_network( $plugin ) ) {
- return false;
- }
-
- list( $plugin ) = explode( '/', $plugin );
-
- return array_key_exists( $plugin, $GLOBALS['_paused_plugins'] );
-}
-
-/**
- * Gets the error that was recorded for a paused plugin.
- *
- * @since 5.1.0
- *
- * @param string $plugin Path to the plugin file relative to the plugins
- * directory.
- * @return array|false Array of error information as it was returned by
- * `error_get_last()`, or false if none was recorded.
- */
-function wp_get_plugin_error( $plugin ) {
- if ( ! isset( $GLOBALS['_paused_plugins'] ) ) {
- return false;
- }
-
- list( $plugin ) = explode( '/', $plugin );
-
- if ( ! array_key_exists( $plugin, $GLOBALS['_paused_plugins'] ) ) {
- return false;
- }
-
- return $GLOBALS['_paused_plugins'][ $plugin ];
-}
-
-/**
- * Gets the number of sites on which a specific plugin is paused.
- *
- * @since 5.1.0
- *
- * @param string $plugin Path to the plugin file relative to the plugins directory.
- * @return int Site count.
- */
-function count_paused_plugin_sites_for_network( $plugin ) {
- if ( ! is_multisite() ) {
- return is_plugin_paused( $plugin ) ? 1 : 0;
- }
-
- list( $plugin ) = explode( '/', $plugin );
-
- $query_args = array(
- 'count' => true,
- 'number' => 0,
- 'network_id' => get_current_network_id(),
- 'meta_query' => array(
- wp_paused_plugins()->get_site_meta_query_clause( $plugin ),
- ),
- );
-
- return get_sites( $query_args );
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Determines whether the plugin is active for the entire network.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Only plugins installed in the plugins/ folder can be active.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -803,11 +723,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> continue;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Clean up the database before deactivating the plugin.
- if ( is_plugin_paused( $plugin ) ) {
- resume_plugin( $plugin );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> $network_deactivating = false !== $network_wide && is_plugin_active_for_network( $plugin );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $silent ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1002,11 +917,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> uninstall_plugin( $plugin_file );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Clean up the database before removing the plugin.
- if ( is_plugin_paused( $plugin_file ) ) {
- resume_plugin( $plugin_file );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Fires immediately before a plugin deletion attempt.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1085,57 +995,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Tries to resume a single plugin.
- *
- * If a redirect was provided, we first ensure the plugin does not throw fatal
- * errors anymore.
- *
- * The way it works is by setting the redirection to the error before trying to
- * include the plugin file. If the plugin fails, then the redirection will not
- * be overwritten with the success message and the plugin will not be resumed.
- *
- * @since 5.1.0
- *
- * @param string $plugin Single plugin to resume.
- * @param string $redirect Optional. URL to redirect to. Default empty string.
- * @param bool $network_wide Optional. Whether to resume the plugin for the entire
- * network. Default false.
- * @return bool|WP_Error True on success, false if `$plugin` was not paused,
- * `WP_Error` on failure.
- */
-function resume_plugin( $plugin, $redirect = '', $network_wide = false ) {
- /*
- * We'll override this later if the plugin could be included without
- * creating a fatal error.
- */
- if ( ! empty( $redirect ) ) {
- wp_redirect(
- add_query_arg(
- '_error_nonce',
- wp_create_nonce( 'plugin-resume-error_' . $plugin ),
- $redirect
- )
- );
-
- // Load the plugin to test whether it throws a fatal error.
- ob_start();
- plugin_sandbox_scrape( $plugin );
- ob_clean();
- }
-
- $result = wp_forget_extension_error( 'plugins', $plugin, $network_wide );
-
- if ( ! $result ) {
- return new WP_Error(
- 'could_not_resume_plugin',
- __( 'Could not resume the plugin.' )
- );
- }
-
- return true;
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Validate active plugins
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Validate all active plugins, deactivates invalid and
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2242,33 +2101,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> WP_Privacy_Policy_Content::add( $plugin_name, $policy_text );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
-/**
- * Renders an admin notice in case some plugins have been paused due to errors.
- *
- * @since 5.1.0
- */
-function paused_plugins_notice() {
- if ( 'plugins.php' === $GLOBALS['pagenow'] ) {
- return;
- }
-
- if ( ! current_user_can( 'deactivate_plugins' ) ) {
- return;
- }
-
- if ( ! isset( $GLOBALS['_paused_plugins'] ) || empty( $GLOBALS['_paused_plugins'] ) ) {
- return;
- }
-
- printf(
- '<div class="notice notice-error"><p><strong>%s</strong><br>%s</p><p>%s</p></div>',
- __( 'One or more plugins failed to load properly.' ),
- __( 'You can find more details and make changes on the Plugins screen.' ),
- sprintf(
- '<a href="%s">%s</a>',
- admin_url( 'plugins.php?plugin_status=paused' ),
- 'Go to the Plugins screen'
- )
- );
-}
</del></span></pre></div>
<a id="trunksrcwpadminincludesthemephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/theme.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/theme.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/includes/theme.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -768,127 +768,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
-/**
- * Determines whether a theme is technically active but was paused while
- * loading.
- *
- * For more information on this and similar theme functions, check out
- * the {@link https://developer.wordpress.org/themes/basics/conditional-tags/
- * Conditional Tags} article in the Theme Developer Handbook.
- *
- * @since 5.1.0
- *
- * @param string $theme Path to the theme directory relative to the themes directory.
- * @return bool True, if in the list of paused themes. False, not in the list.
- */
-function is_theme_paused( $theme ) {
- if ( ! isset( $GLOBALS['_paused_themes'] ) ) {
- return false;
- }
-
- if ( $theme !== get_stylesheet() && $theme !== get_template() ) {
- return false;
- }
-
- return array_key_exists( $theme, $GLOBALS['_paused_themes'] );
-}
-
-/**
- * Gets the error that was recorded for a paused theme.
- *
- * @since 5.1.0
- *
- * @param string $theme Path to the theme directory relative to the themes
- * directory.
- * @return array|false Array of error information as it was returned by
- * `error_get_last()`, or false if none was recorded.
- */
-function wp_get_theme_error( $theme ) {
- if ( ! isset( $GLOBALS['_paused_themes'] ) ) {
- return false;
- }
-
- if ( ! array_key_exists( $theme, $GLOBALS['_paused_themes'] ) ) {
- return false;
- }
-
- return $GLOBALS['_paused_themes'][ $theme ];
-}
-
-/**
- * Gets the number of sites on which a specific theme is paused.
- *
- * @since 5.1.0
- *
- * @param string $theme Path to the theme directory relative to the themes directory.
- * @return int Site count.
- */
-function count_paused_theme_sites_for_network( $theme ) {
- if ( ! is_multisite() ) {
- return is_theme_paused( $theme ) ? 1 : 0;
- }
-
- $query_args = array(
- 'count' => true,
- 'number' => 0,
- 'network_id' => get_current_network_id(),
- 'meta_query' => array(
- wp_paused_themes()->get_site_meta_query_clause( $theme ),
- ),
- );
-
- return get_sites( $query_args );
-}
-
-/**
- * Tries to resume a single theme.
- *
- * @since 5.1.0
- *
- * @param string $theme Single theme to resume.
- * @return bool|WP_Error True on success, false if `$theme` was not paused,
- * `WP_Error` on failure.
- */
-function resume_theme( $theme ) {
- $result = wp_forget_extension_error( 'themes', $theme );
-
- if ( ! $result ) {
- return new WP_Error(
- 'could_not_resume_theme',
- __( 'Could not resume the theme.' )
- );
- }
-
- return true;
-}
-
-/**
- * Renders an admin notice in case some themes have been paused due to errors.
- *
- * @since 5.1.0
- */
-function paused_themes_notice() {
- if ( 'themes.php' === $GLOBALS['pagenow'] ) {
- return;
- }
-
- if ( ! current_user_can( 'switch_themes' ) ) {
- return;
- }
-
- if ( ! isset( $GLOBALS['_paused_themes'] ) || empty( $GLOBALS['_paused_themes'] ) ) {
- return;
- }
-
- printf(
- '<div class="notice notice-error"><p><strong>%s</strong><br>%s</p><p>%s</p></div>',
- __( 'One or more themes failed to load properly.' ),
- __( 'You can find more details and make changes on the Themes screen.' ),
- sprintf(
- '<a href="%s">%s</a>',
- admin_url( 'themes.php' ),
- 'Go to the Themes screen'
- )
- );
-}
</del></span></pre></div>
<a id="trunksrcwpadminpluginsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/plugins.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/plugins.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/plugins.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -389,27 +389,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'resume':
- if ( ! current_user_can( 'resume_plugin', $plugin ) ) {
- wp_die( __( 'Sorry, you are not allowed to resume this plugin.' ) );
- }
-
- if ( is_multisite() && ! is_network_admin() && is_network_only_plugin( $plugin ) ) {
- wp_redirect( self_admin_url( "plugins.php?plugin_status=$status&paged=$page&s=$s" ) );
- exit;
- }
-
- check_admin_referer( 'resume-plugin_' . $plugin );
-
- $result = resume_plugin( $plugin, self_admin_url( 'plugins.php?error=resuming' ), is_network_admin() );
-
- if ( is_wp_error( $result ) ) {
- wp_die( $result );
- }
-
- wp_redirect( self_admin_url( "plugins.php?resume=true&plugin_status=$status&paged=$page&s=$s" ) );
- exit;
-
</del><span class="cx" style="display: block; padding: 0 10px"> default:
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $_POST['checked'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> check_admin_referer( 'bulk-plugins' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -509,8 +488,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $_GET['charsout']
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $errmsg .= ' ' . __( 'If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } elseif ( 'resuming' === $_GET['error'] ) {
- $errmsg = __( 'Plugin could not be resumed because it triggered a <strong>fatal error</strong>.' );
</del><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $errmsg = __( 'Plugin could not be activated because it triggered a <strong>fatal error</strong>.' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -564,8 +541,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="message" class="updated notice is-dismissible"><p><?php _e( 'Selected plugins <strong>deactivated</strong>.' ); ?></p></div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php elseif ( 'update-selected' == $action ) : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="message" class="updated notice is-dismissible"><p><?php _e( 'All selected plugins are up to date.' ); ?></p></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php elseif ( isset( $_GET['resume'] ) ) : ?>
- <div id="message" class="updated notice is-dismissible"><p><?php _e( 'Plugin <strong>resumed</strong>.' ); ?></p></div>
</del><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="wrap">
</span></span></pre></div>
<a id="trunksrcwpadminthemesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/themes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/themes.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-admin/themes.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -33,26 +33,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> switch_theme( $theme->get_stylesheet() );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_redirect( admin_url( 'themes.php?activated=true' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> exit;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } elseif ( 'resume' === $_GET['action'] ) {
- check_admin_referer( 'resume-theme_' . $_GET['stylesheet'] );
- $theme = wp_get_theme( $_GET['stylesheet'] );
-
- if ( ! current_user_can( 'resume_themes' ) ) {
- wp_die(
- '<h1>' . __( 'You need a higher level of permission.' ) . '</h1>' .
- '<p>' . __( 'Sorry, you are not allowed to resume this theme.' ) . '</p>',
- 403
- );
- }
-
- $result = resume_theme( $theme->get_stylesheet() );
-
- if ( is_wp_error( $result ) ) {
- wp_die( $result );
- }
-
- wp_redirect( admin_url( 'themes.php?resumed=true' ) );
- exit;
</del><span class="cx" style="display: block; padding: 0 10px"> } elseif ( 'delete' == $_GET['action'] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> check_admin_referer( 'delete-theme_' . $_GET['stylesheet'] );
</span><span class="cx" style="display: block; padding: 0 10px"> $theme = wp_get_theme( $_GET['stylesheet'] );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -215,10 +195,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="message4" class="error"><p><?php _e( 'You cannot delete a theme while it has an active child theme.' ); ?></p></div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-} elseif ( isset( $_GET['resumed'] ) ) {
- ?>
- <div id="message5" class="updated notice is-dismissible"><p><?php _e( 'Theme resumed.' ); ?></p></div>
- <?php
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $ct = wp_get_theme();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -372,7 +348,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <p><?php _e( 'The following themes are installed but incomplete.' ); ?></p>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $can_resume = current_user_can( 'resume_themes' );
</del><span class="cx" style="display: block; padding: 0 10px"> $can_delete = current_user_can( 'delete_themes' );
</span><span class="cx" style="display: block; padding: 0 10px"> $can_install = current_user_can( 'install_themes' );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -380,9 +355,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <th><?php _ex( 'Name', 'theme name' ); ?></th>
</span><span class="cx" style="display: block; padding: 0 10px"> <th><?php _e( 'Description' ); ?></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php if ( $can_resume ) { ?>
- <td></td>
- <?php } ?>
</del><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $can_delete ) { ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <td></td>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php } ?>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -395,27 +367,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <td><?php echo $broken_theme->get( 'Name' ) ? $broken_theme->display( 'Name' ) : $broken_theme->get_stylesheet(); ?></td>
</span><span class="cx" style="display: block; padding: 0 10px"> <td><?php echo $broken_theme->errors()->get_error_message(); ?></td>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $can_resume ) {
- if ( 'theme_paused' === $broken_theme->errors()->get_error_code() ) {
- $stylesheet = $broken_theme->get_stylesheet();
- $resume_url = add_query_arg(
- array(
- 'action' => 'resume',
- 'stylesheet' => urlencode( $stylesheet ),
- ),
- admin_url( 'themes.php' )
- );
- $resume_url = wp_nonce_url( $resume_url, 'resume-theme_' . $stylesheet );
- ?>
- <td><a href="<?php echo esc_url( $resume_url ); ?>" class="button resume-theme"><?php _e( 'Resume' ); ?></a></td>
- <?php
- } else {
- ?>
- <td></td>
- <?php
- }
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( $can_delete ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $stylesheet = $broken_theme->get_stylesheet();
</span><span class="cx" style="display: block; padding: 0 10px"> $delete_url = add_query_arg(
</span></span></pre></div>
<a id="trunksrcwpincludescapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/capabilities.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/capabilities.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -464,14 +464,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'resume_plugin':
- // Even in a multisite, regular administrators should be able to resume a plugin.
- $caps[] = 'activate_plugins';
- break;
- case 'resume_themes':
- // Even in a multisite, regular administrators should be able to resume a theme.
- $caps[] = 'switch_themes';
- break;
</del><span class="cx" style="display: block; padding: 0 10px"> case 'delete_user':
</span><span class="cx" style="display: block; padding: 0 10px"> case 'delete_users':
</span><span class="cx" style="display: block; padding: 0 10px"> // If multisite only super admins can delete users.
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpfatalerrorhandlerphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/src/wp-includes/class-wp-fatal-error-handler.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-fatal-error-handler.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/class-wp-fatal-error-handler.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,200 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-/**
- * Error Protection API: WP_Fatal_Error_Handler class
- *
- * @package WordPress
- * @since 5.1.0
- */
-
-/**
- * Core class used as the default shutdown handler for fatal errors.
- *
- * A drop-in 'fatal-error-handler.php' can be used to override the instance of this class and use a custom
- * implementation for the fatal error handler that WordPress registers. The custom class should extend this class and
- * can override its methods individually as necessary. The file must return the instance of the class that should be
- * registered.
- *
- * @since 5.1.0
- */
-class WP_Fatal_Error_Handler {
-
- /**
- * Runs the shutdown handler.
- *
- * This method is registered via `register_shutdown_function()`.
- *
- * @since 5.1.0
- */
- public function handle() {
- // Bail if WordPress executed successfully.
- if ( defined( 'WP_EXECUTION_SUCCEEDED' ) && WP_EXECUTION_SUCCEEDED ) {
- return;
- }
-
- try {
- // Bail if no error found.
- $error = $this->detect_error();
- if ( ! $error ) {
- return;
- }
-
- // If the error was stored and thus the extension paused,
- // redirect the request to catch multiple errors in one go.
- if ( $this->store_error( $error ) ) {
- $this->redirect_protected();
- }
-
- // Display the PHP error template.
- $this->display_error_template();
- } catch ( Exception $e ) {
- // Catch exceptions and remain silent.
- }
- }
-
- /**
- * Detects the error causing the crash if it should be handled.
- *
- * @since 5.1.0
- *
- * @return array|null Error that was triggered, or null if no error received or if the error should not be handled.
- */
- protected function detect_error() {
- $error = error_get_last();
-
- // No error, just skip the error handling code.
- if ( null === $error ) {
- return null;
- }
-
- // Bail if this error should not be handled.
- if ( ! wp_should_handle_error( $error ) ) {
- return null;
- }
-
- return $error;
- }
-
- /**
- * Stores the given error so that the extension causing it is paused.
- *
- * @since 5.1.0
- *
- * @param array $error Error that was triggered.
- * @return bool True if the error was stored successfully, false otherwise.
- */
- protected function store_error( $error ) {
- // Do not pause extensions if they only crash on a non-protected endpoint.
- if ( ! is_protected_endpoint() ) {
- return false;
- }
-
- return wp_record_extension_error( $error );
- }
-
- /**
- * Redirects the current request to allow recovering multiple errors in one go.
- *
- * The redirection will only happen when on a protected endpoint.
- *
- * It must be ensured that this method is only called when an error actually occurred and will not occur on the
- * next request again. Otherwise it will create a redirect loop.
- *
- * @since 5.1.0
- */
- protected function redirect_protected() {
- // Do not redirect requests on non-protected endpoints.
- if ( ! is_protected_endpoint() ) {
- return;
- }
-
- // Pluggable is usually loaded after plugins, so we manually include it here for redirection functionality.
- if ( ! function_exists( 'wp_redirect' ) ) {
- include ABSPATH . WPINC . '/pluggable.php';
- }
-
- $scheme = is_ssl() ? 'https://' : 'http://';
-
- $url = "{$scheme}{$_SERVER['HTTP_HOST']}{$_SERVER['REQUEST_URI']}";
- wp_redirect( $url );
- exit;
- }
-
- /**
- * Displays the PHP error template and sends the HTTP status code, typically 500.
- *
- * A drop-in 'php-error.php' can be used as a custom template. This drop-in should control the HTTP status code and
- * print the HTML markup indicating that a PHP error occurred. Note that this drop-in may potentially be executed
- * very early in the WordPress bootstrap process, so any core functions used that are not part of
- * `wp-includes/load.php` should be checked for before being called.
- *
- * If no such drop-in is available, this will call {@see WP_Fatal_Error_Handler::display_default_error_template()}.
- *
- * @since 5.1.0
- */
- protected function display_error_template() {
- if ( defined( 'WP_CONTENT_DIR' ) ) {
- // Load custom PHP error template, if present.
- $php_error_pluggable = WP_CONTENT_DIR . '/php-error.php';
- if ( is_readable( $php_error_pluggable ) ) {
- require_once $php_error_pluggable;
- return;
- }
- }
-
- // Otherwise, display the default error template.
- $this->display_default_error_template();
- }
-
- /**
- * Displays the default PHP error template.
- *
- * This method is called conditionally if no 'php-error.php' drop-in is available.
- *
- * It calls {@see wp_die()} with a message indicating that the site is experiencing technical difficulties and a
- * login link to the admin backend. The {@see 'wp_php_error_message'} and {@see 'wp_php_error_args'} filters can
- * be used to modify these parameters.
- *
- * @since 5.1.0
- */
- protected function display_default_error_template() {
- if ( ! function_exists( '__' ) ) {
- wp_load_translations_early();
- }
-
- if ( ! function_exists( 'wp_die' ) ) {
- require_once ABSPATH . WPINC . '/functions.php';
- }
-
- $message = __( 'The site is experiencing technical difficulties.' );
-
- $args = array(
- 'response' => 500,
- 'exit' => false,
- );
- if ( function_exists( 'admin_url' ) ) {
- $args['link_url'] = admin_url();
- $args['link_text'] = __( 'Log into the admin backend to fix this.' );
- }
-
- /**
- * Filters the message that the default PHP error template displays.
- *
- * @since 5.1.0
- *
- * @param string $message HTML error message to display.
- */
- $message = apply_filters( 'wp_php_error_message', $message );
-
- /**
- * Filters the arguments passed to {@see wp_die()} for the default PHP error template.
- *
- * @since 5.1.0
- *
- * @param array $args Associative array of arguments passed to `wp_die()`. By default these contain a
- * 'response' key, and optionally 'link_url' and 'link_text' keys.
- */
- $args = apply_filters( 'wp_php_error_args', $args );
-
- wp_die( $message, '', $args );
- }
-}
</del></span></pre></div>
<a id="trunksrcwpincludesclasswppausedextensionsstoragephp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/src/wp-includes/class-wp-paused-extensions-storage.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-paused-extensions-storage.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/class-wp-paused-extensions-storage.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,221 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-/**
- * Error Protection API: WP_Paused_Extensions_Storage class
- *
- * @package WordPress
- * @since 5.1.0
- */
-
-/**
- * Core class used for storing paused extensions.
- *
- * @since 5.1.0
- */
-class WP_Paused_Extensions_Storage {
-
- /**
- * Option name for storing paused extensions.
- *
- * @since 5.1.0
- * @var string
- */
- protected $option_name;
-
- /**
- * Prefix for paused extensions stored as site metadata.
- *
- * @since 5.1.0
- * @var string
- */
- protected $meta_prefix;
-
- /**
- * Constructor.
- *
- * @since 5.1.0
- *
- * @param string $option_name Option name for storing paused extensions.
- * @param string $meta_prefix Prefix for paused extensions stored as site metadata.
- */
- public function __construct( $option_name, $meta_prefix ) {
- $this->option_name = $option_name;
- $this->meta_prefix = $meta_prefix;
- }
-
- /**
- * Records an extension error.
- *
- * Only one error is stored per extension, with subsequent errors for the same extension overriding the
- * previously stored error.
- *
- * @since 5.1.0
- *
- * @param string $extension Plugin or theme directory name.
- * @param array $error {
- * Error that was triggered.
- *
- * @type string $type The error type.
- * @type string $file The name of the file in which the error occurred.
- * @type string $line The line number in which the error occurred.
- * @type string $message The error message.
- * }
- * @return bool True on success, false on failure.
- */
- public function record( $extension, $error ) {
- if ( ! $this->is_api_loaded() ) {
- return false;
- }
-
- if ( is_multisite() && is_site_meta_supported() ) {
- // Do not update if the error is already stored.
- if ( get_site_meta( get_current_blog_id(), $this->meta_prefix . $extension, true ) === $error ) {
- return true;
- }
-
- return (bool) update_site_meta( get_current_blog_id(), $this->meta_prefix . $extension, $error );
- }
-
- $paused_extensions = $this->get_all();
-
- // Do not update if the error is already stored.
- if ( isset( $paused_extensions[ $extension ] ) && $paused_extensions[ $extension ] === $error ) {
- return true;
- }
-
- $paused_extensions[ $extension ] = $error;
-
- return update_option( $this->option_name, $paused_extensions );
- }
-
- /**
- * Forgets a previously recorded extension error.
- *
- * @since 5.1.0
- *
- * @param string $extension Plugin or theme directory name.
- * @return bool True on success, false on failure.
- */
- public function forget( $extension ) {
- if ( ! $this->is_api_loaded() ) {
- return false;
- }
-
- if ( is_multisite() && is_site_meta_supported() ) {
- // Do not delete if no error is stored.
- if ( get_site_meta( get_current_blog_id(), $this->meta_prefix . $extension ) === array() ) {
- return true;
- }
-
- return (bool) delete_site_meta( get_current_blog_id(), $this->meta_prefix . $extension );
- }
-
- $paused_extensions = $this->get_all();
-
- // Do not delete if no error is stored.
- if ( ! isset( $paused_extensions[ $extension ] ) ) {
- return true;
- }
-
- // Clean up the entire option if we're removing the only error.
- if ( count( $paused_extensions ) === 1 ) {
- return delete_option( $this->option_name );
- }
-
- unset( $paused_extensions[ $extension ] );
-
- return update_option( $this->option_name, $paused_extensions );
- }
-
- /**
- * Gets the error for an extension, if paused.
- *
- * @since 5.1.0
- *
- * @param string $extension Plugin or theme directory name.
- * @return array|null Error that is stored, or null if the extension is not paused.
- */
- public function get( $extension ) {
- if ( ! $this->is_api_loaded() ) {
- return null;
- }
-
- if ( is_multisite() && is_site_meta_supported() ) {
- $error = get_site_meta( get_current_blog_id(), $this->meta_prefix . $extension, true );
- if ( ! $error ) {
- return null;
- }
-
- return $error;
- }
-
- $paused_extensions = $this->get_all();
-
- if ( ! isset( $paused_extensions[ $extension ] ) ) {
- return null;
- }
-
- return $paused_extensions[ $extension ];
- }
-
- /**
- * Gets the paused extensions with their errors.
- *
- * @since 5.1.0
- *
- * @return array Associative array of $extension => $error pairs.
- */
- public function get_all() {
- if ( ! $this->is_api_loaded() ) {
- return array();
- }
-
- if ( is_multisite() && is_site_meta_supported() ) {
- $site_metadata = get_site_meta( get_current_blog_id() );
-
- $paused_extensions = array();
- foreach ( $site_metadata as $meta_key => $meta_values ) {
- if ( 0 !== strpos( $meta_key, $this->meta_prefix ) ) {
- continue;
- }
-
- $error = maybe_unserialize( array_shift( $meta_values ) );
-
- $paused_extensions[ substr( $meta_key, strlen( $this->meta_prefix ) ) ] = $error;
- }
-
- return $paused_extensions;
- }
-
- return (array) get_option( $this->option_name, array() );
- }
-
- /**
- * Gets the site meta query clause for querying sites with paused extensions.
- *
- * @since 5.1.0
- *
- * @param string $extension Plugin or theme directory name.
- * @return array A single clause to add to a meta query.
- */
- public function get_site_meta_query_clause( $extension ) {
- return array(
- 'key' => $this->meta_prefix . $extension,
- 'compare_key' => '=',
- );
- }
-
- /**
- * Checks whether the underlying API to store paused extensions is loaded.
- *
- * @since 5.1.0
- *
- * @return bool True if the API is loaded, false otherwise.
- */
- protected function is_api_loaded() {
- if ( is_multisite() ) {
- return function_exists( 'is_site_meta_supported' ) && function_exists( 'get_site_meta' );
- }
-
- return function_exists( 'get_option' );
- }
-}
</del></span></pre></div>
<a id="trunksrcwpincludesclasswpthemephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-theme.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-theme.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/class-wp-theme.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -371,10 +371,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->parent = new WP_Theme( $this->template, isset( $theme_root_template ) ? $theme_root_template : $this->theme_root, $this );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( wp_paused_themes()->get( $this->stylesheet ) && ( ! is_wp_error( $this->errors ) || ! isset( $this->errors->errors['theme_paused'] ) ) ) {
- $this->errors = new WP_Error( 'theme_paused', __( 'This theme failed to load properly and was paused within the admin backend.' ) );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> // We're good. If we didn't retrieve from cache, set it.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_array( $cache ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $cache = array(
</span></span></pre></div>
<a id="trunksrcwpincludeserrorprotectionphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/src/wp-includes/error-protection.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/error-protection.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/error-protection.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,199 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-/**
- * Error Protection API: Functions
- *
- * @package WordPress
- * @since 5.1.0
- */
-
-/**
- * Gets the instance for storing paused plugins.
- *
- * @since 5.1.0
- *
- * @return WP_Paused_Extensions_Storage Paused plugins storage.
- */
-function wp_paused_plugins() {
- static $wp_paused_plugins_storage = null;
-
- if ( null === $wp_paused_plugins_storage ) {
- $wp_paused_plugins_storage = new WP_Paused_Extensions_Storage( 'paused_plugins', 'paused_plugin_' );
- }
-
- return $wp_paused_plugins_storage;
-}
-
-/**
- * Gets the instance for storing paused themes.
- *
- * @since 5.1.0
- *
- * @return WP_Paused_Extensions_Storage Paused themes storage.
- */
-function wp_paused_themes() {
- static $wp_paused_themes_storage = null;
-
- if ( null === $wp_paused_themes_storage ) {
- $wp_paused_themes_storage = new WP_Paused_Extensions_Storage( 'paused_themes', 'paused_theme_' );
- }
-
- return $wp_paused_themes_storage;
-}
-
-/**
- * Records the extension error as a database option.
- *
- * @since 5.1.0
- *
- * @global array $wp_theme_directories
- *
- * @param array $error Error that was triggered.
- * @return bool Whether the error was correctly recorded.
- */
-function wp_record_extension_error( $error ) {
- global $wp_theme_directories;
-
- if ( ! isset( $error['file'] ) ) {
- return false;
- }
-
- if ( ! defined( 'WP_PLUGIN_DIR' ) ) {
- return false;
- }
-
- $error_file = wp_normalize_path( $error['file'] );
- $wp_plugin_dir = wp_normalize_path( WP_PLUGIN_DIR );
-
- if ( 0 === strpos( $error_file, $wp_plugin_dir ) ) {
- $callback = 'wp_paused_plugins';
- $path = str_replace( $wp_plugin_dir . '/', '', $error_file );
- } else {
- if ( empty( $wp_theme_directories ) ) {
- return false;
- }
-
- foreach ( $wp_theme_directories as $theme_directory ) {
- $theme_directory = wp_normalize_path( $theme_directory );
- if ( 0 === strpos( $error_file, $theme_directory ) ) {
- $callback = 'wp_paused_themes';
- $path = str_replace( $theme_directory . '/', '', $error_file );
- }
- }
- }
-
- if ( empty( $callback ) || empty( $path ) ) {
- return false;
- }
-
- $parts = explode( '/', $path );
- $extension = array_shift( $parts );
-
- return call_user_func( $callback )->record( $extension, $error );
-}
-
-/**
- * Forgets a previously recorded extension error again.
- *
- * @since 5.1.0
- *
- * @param string $type Type of the extension.
- * @param string $extension Relative path of the extension.
- * @param bool $network_wide Optional. Whether to resume the plugin for the entire
- * network. Default false.
- * @return bool Whether the extension error was successfully forgotten.
- */
-function wp_forget_extension_error( $type, $extension, $network_wide = false ) {
- switch ( $type ) {
- case 'plugins':
- $callback = 'wp_paused_plugins';
- list( $extension ) = explode( '/', $extension );
- break;
- case 'themes':
- $callback = 'wp_paused_themes';
- list( $extension ) = explode( '/', $extension );
- break;
- }
-
- if ( empty( $callback ) || empty( $extension ) ) {
- return false;
- }
-
- // Handle manually since the regular APIs do not expose this functionality.
- if ( $network_wide && is_site_meta_supported() ) {
- $site_meta_query_clause = call_user_func( $callback )->get_site_meta_query_clause( $extension );
- return delete_metadata( 'blog', 0, $site_meta_query_clause['key'], '', true );
- }
-
- return call_user_func( $callback )->forget( $extension );
-}
-
-/**
- * Determines whether we are dealing with an error that WordPress should handle
- * in order to protect the admin backend against WSODs.
- *
- * @param array $error Error information retrieved from error_get_last().
- *
- * @return bool Whether WordPress should handle this error.
- */
-function wp_should_handle_error( $error ) {
- if ( ! isset( $error['type'] ) ) {
- return false;
- }
-
- $error_types_to_handle = array(
- E_ERROR,
- E_PARSE,
- E_USER_ERROR,
- E_COMPILE_ERROR,
- E_RECOVERABLE_ERROR,
- );
-
- return in_array( $error['type'], $error_types_to_handle, true );
-}
-
-/**
- * Registers the shutdown handler for fatal errors.
- *
- * The handler will only be registered if {@see wp_is_fatal_error_handler_enabled()} returns true.
- *
- * @since 5.1.0
- */
-function wp_register_fatal_error_handler() {
- if ( ! wp_is_fatal_error_handler_enabled() ) {
- return;
- }
-
- $handler = null;
- if ( defined( 'WP_CONTENT_DIR' ) && is_readable( WP_CONTENT_DIR . '/fatal-error-handler.php' ) ) {
- $handler = include WP_CONTENT_DIR . '/fatal-error-handler.php';
- }
-
- if ( ! is_object( $handler ) || ! is_callable( array( $handler, 'handle' ) ) ) {
- $handler = new WP_Fatal_Error_Handler();
- }
-
- register_shutdown_function( array( $handler, 'handle' ) );
-}
-
-/**
- * Checks whether the fatal error handler is enabled.
- *
- * A constant `WP_DISABLE_FATAL_ERROR_HANDLER` can be set in `wp-config.php` to disable it, or alternatively the
- * {@see 'wp_fatal_error_handler_enabled'} filter can be used to modify the return value.
- *
- * @since 5.1.0
- *
- * @return bool True if the fatal error handler is enabled, false otherwise.
- */
-function wp_is_fatal_error_handler_enabled() {
- $enabled = ! defined( 'WP_DISABLE_FATAL_ERROR_HANDLER' ) || ! WP_DISABLE_FATAL_ERROR_HANDLER;
-
- /**
- * Filters whether the fatal error handler is enabled.
- *
- * @since 5.1.0
- *
- * @param bool $enabled True if the fatal error handler is enabled, false otherwise.
- */
- return apply_filters( 'wp_fatal_error_handler_enabled', $enabled );
-}
</del></span></pre></div>
<a id="trunksrcwpincludesloadphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/load.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/load.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/load.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -697,47 +697,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * Remove plugins from the list of active plugins when we're on an endpoint
- * that should be protected against WSODs and the plugin is paused.
- */
- if ( is_protected_endpoint() ) {
- $plugins = wp_skip_paused_plugins( $plugins );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> return $plugins;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Filters a given list of plugins, removing any paused plugins from it.
- *
- * @since 5.1.0
- *
- * @param array $plugins List of absolute plugin main file paths.
- * @return array Filtered value of $plugins, without any paused plugins.
- */
-function wp_skip_paused_plugins( array $plugins ) {
- $paused_plugins = wp_paused_plugins()->get_all();
-
- if ( empty( $paused_plugins ) ) {
- return $plugins;
- }
-
- foreach ( $plugins as $index => $plugin ) {
- list( $plugin ) = explode( '/', plugin_basename( $plugin ) );
-
- if ( array_key_exists( $plugin, $paused_plugins ) ) {
- unset( $plugins[ $index ] );
-
- // Store list of paused plugins for displaying an admin notice.
- $GLOBALS['_paused_plugins'][ $plugin ] = $paused_plugins[ $plugin ];
- }
- }
-
- return $plugins;
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Retrieves an array of active and valid themes.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * While upgrading or installing WordPress, no themes are returned.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -762,52 +725,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $themes[] = TEMPLATEPATH;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * Remove themes from the list of active themes when we're on an endpoint
- * that should be protected against WSODs and the theme is paused.
- */
- if ( is_protected_endpoint() ) {
- $themes = wp_skip_paused_themes( $themes );
-
- // If no active and valid themes exist, skip loading themes.
- if ( empty( $themes ) ) {
- add_filter( 'wp_using_themes', '__return_false' );
- }
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> return $themes;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Filters a given list of themes, removing any paused themes from it.
- *
- * @since 5.1.0
- *
- * @param array $themes List of absolute theme directory paths.
- * @return array Filtered value of $themes, without any paused themes.
- */
-function wp_skip_paused_themes( array $themes ) {
- $paused_themes = wp_paused_themes()->get_all();
-
- if ( empty( $paused_themes ) ) {
- return $themes;
- }
-
- foreach ( $themes as $index => $theme ) {
- $theme = basename( $theme );
-
- if ( array_key_exists( $theme, $paused_themes ) ) {
- unset( $themes[ $index ] );
-
- // Store list of paused themes for displaying an admin notice.
- $GLOBALS['_paused_themes'][ $theme ] = $paused_themes[ $theme ];
- }
- }
-
- return $themes;
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Set internal encoding.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * In most cases the default internal encoding is latin1, which is
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1290,88 +1211,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Determines whether we are currently on an endpoint that should be protected against WSODs.
- *
- * @since 5.1.0
- *
- * @return bool True if the current endpoint should be protected.
- */
-function is_protected_endpoint() {
- // Protect login pages.
- if ( isset( $GLOBALS['pagenow'] ) && 'wp-login.php' === $GLOBALS['pagenow'] ) {
- return true;
- }
-
- // Protect the admin backend.
- if ( is_admin() && ! wp_doing_ajax() ) {
- return true;
- }
-
- // Protect AJAX actions that could help resolve a fatal error should be available.
- if ( is_protected_ajax_action() ) {
- return true;
- }
-
- /**
- * Filters whether the current request is against a protected endpoint.
- *
- * This filter is only fired when an endpoint is requested which is not already protected by
- * WordPress core. As such, it exclusively allows providing further protected endpoints in
- * addition to the admin backend, login pages and protected AJAX actions.
- *
- * @since 5.1.0
- *
- * @param bool $is_protected_endpoint Whether the currently requested endpoint is protected. Default false.
- */
- return (bool) apply_filters( 'is_protected_endpoint', false );
-}
-
-/**
- * Determines whether we are currently handling an AJAX action that should be protected against WSODs.
- *
- * @since 5.1.0
- *
- * @return bool True if the current AJAX action should be protected.
- */
-function is_protected_ajax_action() {
- if ( ! wp_doing_ajax() ) {
- return false;
- }
-
- if ( ! isset( $_REQUEST['action'] ) ) {
- return false;
- }
-
- $actions_to_protect = array(
- 'edit-theme-plugin-file', // Saving changes in the core code editor.
- 'heartbeat', // Keep the heart beating.
- 'install-plugin', // Installing a new plugin.
- 'install-theme', // Installing a new theme.
- 'search-plugins', // Searching in the list of plugins.
- 'search-install-plugins', // Searching for a plugin in the plugin install screen.
- 'update-plugin', // Update an existing plugin.
- 'update-theme', // Update an existing theme.
- );
-
- /**
- * Filters the array of protected AJAX actions.
- *
- * This filter is only fired when doing AJAX and the AJAX request has an 'action' property.
- *
- * @since 5.1.0
- *
- * @param array $actions_to_protect Array of strings with AJAX actions to protect.
- */
- $actions_to_protect = (array) apply_filters( 'wp_protected_ajax_actions', $actions_to_protect );
-
- if ( ! in_array( $_REQUEST['action'], $actions_to_protect, true ) ) {
- return false;
- }
-
- return true;
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Determines whether the current request is a WordPress cron request.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.8.0
</span></span></pre></div>
<a id="trunksrcwpincludesmsloadphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/ms-load.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/ms-load.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-includes/ms-load.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -53,14 +53,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * Remove plugins from the list of active plugins when we're on an endpoint
- * that should be protected against WSODs and the plugin is paused.
- */
- if ( is_protected_endpoint() ) {
- $plugins = wp_skip_paused_plugins( $plugins );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> return $plugins;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpsettingsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-settings.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-settings.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/src/wp-settings.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -17,15 +17,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Include files required for initialization.
</span><span class="cx" style="display: block; padding: 0 10px"> require( ABSPATH . WPINC . '/load.php' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-require( ABSPATH . WPINC . '/class-wp-paused-extensions-storage.php' );
-require( ABSPATH . WPINC . '/class-wp-fatal-error-handler.php' );
-require( ABSPATH . WPINC . '/error-protection.php' );
</del><span class="cx" style="display: block; padding: 0 10px"> require( ABSPATH . WPINC . '/default-constants.php' );
</span><span class="cx" style="display: block; padding: 0 10px"> require_once( ABSPATH . WPINC . '/plugin.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-// Make sure we register the shutdown handler for fatal errors as soon as possible.
-wp_register_fatal_error_handler();
-
</del><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * These can't be directly globalized in version.php. When updating,
</span><span class="cx" style="display: block; padding: 0 10px"> * we're including version.php from another installation and don't want
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -530,12 +524,3 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.0.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> do_action( 'wp_loaded' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
-/*
- * Store the fact that we could successfully execute the entire WordPress
- * lifecycle. This is used to skip the premature shutdown handler, as it cannot
- * be unregistered.
- */
-if ( ! defined( 'WP_EXECUTION_SUCCEEDED' ) ) {
- define( 'WP_EXECUTION_SUCCEEDED', true );
-}
</del></span></pre></div>
<a id="trunktestsphpunittestsusercapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/user/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user/capabilities.php 2019-01-30 10:06:47 UTC (rev 44716)
+++ trunk/tests/phpunit/tests/user/capabilities.php 2019-01-30 11:00:30 UTC (rev 44717)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -257,7 +257,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'export_others_personal_data' => array( 'administrator' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'erase_others_personal_data' => array( 'administrator' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'manage_privacy_options' => array( 'administrator' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'resume_themes' => array( 'administrator' ),
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> 'edit_categories' => array( 'administrator', 'editor' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'delete_categories' => array( 'administrator', 'editor' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -297,7 +296,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'customize' => array( 'administrator' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'delete_site' => array( 'administrator' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'add_users' => array( 'administrator' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'resume_themes' => array( 'administrator' ),
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> 'edit_categories' => array( 'administrator', 'editor' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'delete_categories' => array( 'administrator', 'editor' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -456,7 +454,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Singular object meta capabilities (where an object ID is passed) are not tested:
</span><span class="cx" style="display: block; padding: 0 10px"> $expected['activate_plugin'],
</span><span class="cx" style="display: block; padding: 0 10px"> $expected['deactivate_plugin'],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $expected['resume_plugin'],
</del><span class="cx" style="display: block; padding: 0 10px"> $expected['remove_user'],
</span><span class="cx" style="display: block; padding: 0 10px"> $expected['promote_user'],
</span><span class="cx" style="display: block; padding: 0 10px"> $expected['edit_user'],
</span></span></pre>
</div>
</div>
</body>
</html>