<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44705] trunk: Coding Standards: Replace spaced indentation sections of `phpunit.xml.dist`, `multisite.xml`, and `build.xml` with tabs.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44705">44705</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44705","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-01-28 17:20:06 +0000 (Mon, 28 Jan 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Coding Standards: Replace spaced indentation sections of `phpunit.xml.dist`, `multisite.xml`, and `build.xml` with tabs.
Props netweb, desrosj.
See <a href="https://core.trac.wordpress.org/ticket/43218">#43218</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkphpunitxmldist">trunk/phpunit.xml.dist</a></li>
<li><a href="#trunktestsphpunitbuildxml">trunk/tests/phpunit/build.xml</a></li>
<li><a href="#trunktestsphpunitmultisitexml">trunk/tests/phpunit/multisite.xml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkphpunitxmldist"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/phpunit.xml.dist</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/phpunit.xml.dist 2019-01-28 17:19:14 UTC (rev 44704)
+++ trunk/phpunit.xml.dist 2019-01-28 17:20:06 UTC (rev 44705)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,44 +1,44 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <phpunit
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- bootstrap="tests/phpunit/includes/bootstrap.php"
- backupGlobals="false"
- colors="true"
- beStrictAboutTestsThatDoNotTestAnything="true"
- >
- <testsuites>
- <!-- Default test suite to run all tests -->
- <testsuite name="default">
- <directory suffix=".php">tests/phpunit/tests</directory>
- <file phpVersion="5.3.0">tests/phpunit/tests/actions/closures.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/image/editor.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/image/editorGd.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/image/editorImagick.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/oembed/headers.php</file>
- <exclude>tests/phpunit/tests/actions/closures.php</exclude>
- <exclude>tests/phpunit/tests/image/editor.php</exclude>
- <exclude>tests/phpunit/tests/image/editorGd.php</exclude>
- <exclude>tests/phpunit/tests/image/editorImagick.php</exclude>
- <exclude>tests/phpunit/tests/oembed/headers.php</exclude>
- <exclude>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</exclude>
- </testsuite>
- <!-- Sets the DOING_AUTOSAVE constant, so needs to be run last -->
- <testsuite name="restapi-autosave">
- <file>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</file>
- </testsuite>
- </testsuites>
- <groups>
- <exclude>
- <group>ajax</group>
- <group>ms-files</group>
- <group>ms-required</group>
- <group>external-http</group>
- </exclude>
- </groups>
- <logging>
- <log type="junit" target="tests/phpunit/build/logs/junit.xml" />
- </logging>
- <php>
- <const name="WP_RUN_CORE_TESTS" value="1" />
- </php>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ bootstrap="tests/phpunit/includes/bootstrap.php"
+ backupGlobals="false"
+ colors="true"
+ beStrictAboutTestsThatDoNotTestAnything="true"
+ >
+ <testsuites>
+ <!-- Default test suite to run all tests -->
+ <testsuite name="default">
+ <directory suffix=".php">tests/phpunit/tests</directory>
+ <file phpVersion="5.3.0">tests/phpunit/tests/actions/closures.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/image/editor.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/image/editorGd.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/image/editorImagick.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/oembed/headers.php</file>
+ <exclude>tests/phpunit/tests/actions/closures.php</exclude>
+ <exclude>tests/phpunit/tests/image/editor.php</exclude>
+ <exclude>tests/phpunit/tests/image/editorGd.php</exclude>
+ <exclude>tests/phpunit/tests/image/editorImagick.php</exclude>
+ <exclude>tests/phpunit/tests/oembed/headers.php</exclude>
+ <exclude>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</exclude>
+ </testsuite>
+ <!-- Sets the DOING_AUTOSAVE constant, so needs to be run last -->
+ <testsuite name="restapi-autosave">
+ <file>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</file>
+ </testsuite>
+ </testsuites>
+ <groups>
+ <exclude>
+ <group>ajax</group>
+ <group>ms-files</group>
+ <group>ms-required</group>
+ <group>external-http</group>
+ </exclude>
+ </groups>
+ <logging>
+ <log type="junit" target="tests/phpunit/build/logs/junit.xml" />
+ </logging>
+ <php>
+ <const name="WP_RUN_CORE_TESTS" value="1" />
+ </php>
</ins><span class="cx" style="display: block; padding: 0 10px"> <listeners>
</span><span class="cx" style="display: block; padding: 0 10px"> <listener class="SpeedTrapListener" file="tests/phpunit/includes/listener-loader.php">
</span><span class="cx" style="display: block; padding: 0 10px"> <arguments>
</span></span></pre></div>
<a id="trunktestsphpunitbuildxml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/build.xml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/build.xml 2019-01-28 17:19:14 UTC (rev 44704)
+++ trunk/tests/phpunit/build.xml 2019-01-28 17:20:06 UTC (rev 44705)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,15 +1,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?xml version="1.0" encoding="utf-8"?>
</span><span class="cx" style="display: block; padding: 0 10px"> <project name="WordPress Unit Tests" default="build" basedir=".">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <target name="clean">
- <delete dir="build" />
- </target>
- <target name="prepare">
- <mkdir dir="build/logs" />
- <mkdir dir="build/phpunitreport" />
- </target>
- <target name="phpunit">
- <exec command="phpunit" passthru="true"></exec>
- <phpunitreport infile="build/logs/junit.xml" format="frames" todir="build/phpunitreport" usesorttable="true" />
- </target>
- <target name="build" depends="clean,prepare,phpunit" />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <target name="clean">
+ <delete dir="build" />
+ </target>
+ <target name="prepare">
+ <mkdir dir="build/logs" />
+ <mkdir dir="build/phpunitreport" />
+ </target>
+ <target name="phpunit">
+ <exec command="phpunit" passthru="true"></exec>
+ <phpunitreport infile="build/logs/junit.xml" format="frames" todir="build/phpunitreport" usesorttable="true" />
+ </target>
+ <target name="build" depends="clean,prepare,phpunit" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </project>
</span><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span></span></pre></div>
<a id="trunktestsphpunitmultisitexml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/multisite.xml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/multisite.xml 2019-01-28 17:19:14 UTC (rev 44704)
+++ trunk/tests/phpunit/multisite.xml 2019-01-28 17:20:06 UTC (rev 44705)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,58 +1,58 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <phpunit
</span><span class="cx" style="display: block; padding: 0 10px"> bootstrap="includes/bootstrap.php"
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- backupGlobals="false"
- colors="true"
- beStrictAboutTestsThatDoNotTestAnything="true"
- >
- <php>
- <const name="WP_TESTS_MULTISITE" value="1" />
- </php>
- <testsuites>
- <!-- Default test suite to run all tests -->
- <testsuite name="default">
- <directory suffix=".php">tests</directory>
- <file phpVersion="5.3.0">tests/phpunit/tests/actions/closures.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/image/editor.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/image/editorGd.php</file>
- <file phpVersion="5.3.0">tests/phpunit/tests/image/editorImagick.php</file>
- <exclude>tests/phpunit/tests/actions/closures.php</exclude>
- <exclude>tests/phpunit/tests/image/editor.php</exclude>
- <exclude>tests/phpunit/tests/image/editorGd.php</exclude>
- <exclude>tests/phpunit/tests/image/editorImagick.php</exclude>
- <!-- Path relative to the checkout root, for PHPUnit 3.6.x -->
- <exclude>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</exclude>
- <!-- Same path relative to the configuration file, for PHPUnit 4.0.0+ -->
- <exclude>tests/rest-api/rest-autosaves-controller.php</exclude>
- </testsuite>
- <!-- Sets the DOING_AUTOSAVE constant, so needs to be run last -->
- <testsuite name="restapi-autosave">
- <!-- Path relative to the checkout root, for PHPUnit 3.6.x -->
- <file>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</file>
- <!-- Same path relative to the configuration file, for PHPUnit 4.0.0+ -->
- <file>tests/rest-api/rest-autosaves-controller.php</file>
- </testsuite>
- </testsuites>
- <groups>
- <exclude>
- <group>ajax</group>
- <group>ms-files</group>
- <group>ms-excluded</group>
- <group>external-http</group>
- <group>oembed-headers</group>
- </exclude>
- </groups>
- <php>
- <const name="WP_RUN_CORE_TESTS" value="1" />
- </php>
- <listeners>
- <listener class="SpeedTrapListener" file="tests/phpunit/includes/listener-loader.php">
- <arguments>
- <array>
- <element key="slowThreshold">
- <integer>150</integer>
- </element>
- </array>
- </arguments>
- </listener>
- </listeners>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ backupGlobals="false"
+ colors="true"
+ beStrictAboutTestsThatDoNotTestAnything="true"
+ >
+ <php>
+ <const name="WP_TESTS_MULTISITE" value="1" />
+ </php>
+ <testsuites>
+ <!-- Default test suite to run all tests -->
+ <testsuite name="default">
+ <directory suffix=".php">tests</directory>
+ <file phpVersion="5.3.0">tests/phpunit/tests/actions/closures.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/image/editor.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/image/editorGd.php</file>
+ <file phpVersion="5.3.0">tests/phpunit/tests/image/editorImagick.php</file>
+ <exclude>tests/phpunit/tests/actions/closures.php</exclude>
+ <exclude>tests/phpunit/tests/image/editor.php</exclude>
+ <exclude>tests/phpunit/tests/image/editorGd.php</exclude>
+ <exclude>tests/phpunit/tests/image/editorImagick.php</exclude>
+ <!-- Path relative to the checkout root, for PHPUnit 3.6.x -->
+ <exclude>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</exclude>
+ <!-- Same path relative to the configuration file, for PHPUnit 4.0.0+ -->
+ <exclude>tests/rest-api/rest-autosaves-controller.php</exclude>
+ </testsuite>
+ <!-- Sets the DOING_AUTOSAVE constant, so needs to be run last -->
+ <testsuite name="restapi-autosave">
+ <!-- Path relative to the checkout root, for PHPUnit 3.6.x -->
+ <file>tests/phpunit/tests/rest-api/rest-autosaves-controller.php</file>
+ <!-- Same path relative to the configuration file, for PHPUnit 4.0.0+ -->
+ <file>tests/rest-api/rest-autosaves-controller.php</file>
+ </testsuite>
+ </testsuites>
+ <groups>
+ <exclude>
+ <group>ajax</group>
+ <group>ms-files</group>
+ <group>ms-excluded</group>
+ <group>external-http</group>
+ <group>oembed-headers</group>
+ </exclude>
+ </groups>
+ <php>
+ <const name="WP_RUN_CORE_TESTS" value="1" />
+ </php>
+ <listeners>
+ <listener class="SpeedTrapListener" file="tests/phpunit/includes/listener-loader.php">
+ <arguments>
+ <array>
+ <element key="slowThreshold">
+ <integer>150</integer>
+ </element>
+ </array>
+ </arguments>
+ </listener>
+ </listeners>
</ins><span class="cx" style="display: block; padding: 0 10px"> </phpunit>
</span></span></pre>
</div>
</div>
</body>
</html>