<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44664] trunk/src: Dev Tools: Load the `wp-admin` build instructions from `src`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44664">44664</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44664","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-01-21 04:59:55 +0000 (Mon, 21 Jan 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Dev Tools: Load the `wp-admin` build instructions from `src`.
This de-duplicates the content, so it only needs to be modified in one place.
Additionally, we now link to the NPM/Grunt install guides on the build instructions page.
Props pento, ocean90.
Fixes <a href="https://core.trac.wordpress.org/ticket/43732">#43732</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcindexphp">trunk/src/index.php</a></li>
<li><a href="#trunksrcwpadminindexphp">trunk/src/wp-admin/index.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/index.php 2019-01-21 04:49:06 UTC (rev 44663)
+++ trunk/src/index.php 2019-01-21 04:59:55 UTC (rev 44664)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,8 +50,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $die .= '<p>' . sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: 1: NPM URL, 2: Grunt URL, 3: Handbook URL */
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'This requires <a href="%1$s">NPM</a> and <a href="%2$s">Grunt</a>. <a href="%3$s">Read more about setting up your local development environment</a>.' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'https://www.npmjs.com/',
- 'https://gruntjs.com/',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'https://www.npmjs.com/get-npm',
+ 'https://gruntjs.com/getting-started',
</ins><span class="cx" style="display: block; padding: 0 10px"> __( 'https://make.wordpress.org/core/handbook/tutorials/installing-wordpress-locally/' )
</span><span class="cx" style="display: block; padding: 0 10px"> ) . '</p>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/index.php 2019-01-21 04:49:06 UTC (rev 44663)
+++ trunk/src/wp-admin/index.php 2019-01-21 04:59:55 UTC (rev 44664)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -11,48 +11,4 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/** Define ABSPATH as this file's directory */
-if ( ! defined( 'ABSPATH' ) ) {
- define( 'ABSPATH', dirname( __FILE__ ) . '/../' );
-}
-
-define( 'WPINC', 'wp-includes' );
-require_once( ABSPATH . WPINC . '/load.php' );
-
-// Standardize $_SERVER variables across setups.
-wp_fix_server_vars();
-
-require_once( ABSPATH . WPINC . '/functions.php' );
-define( 'WP_CONTENT_DIR', ABSPATH . 'wp-content' );
-require_once( ABSPATH . WPINC . '/version.php' );
-
-wp_check_php_mysql_versions();
-wp_load_translations_early();
-
-// Die with an error message
-$die = __( 'You are running WordPress without JavaScript and CSS files. These need to be built.' ) . '</p>';
-
-$die .= '<p>' . sprintf(
- /* translators: %s: npm install */
- __( 'Before running any grunt tasks you need to make sure the dependencies are installed. You can install these by running %s.' ),
- '<code style="color: green;">npm install</code>'
-) . '</p>';
-
-$die .= '<ul>';
-$die .= '<li>' . __( 'To build WordPress while developing, run:' ) . '<br /><br />';
-$die .= '<code style="color: green;">grunt build --dev</code></li>';
-$die .= '<li>' . __( 'To build files automatically when changing the source files, run:' ) . '<br /><br />';
-$die .= '<code style="color: green;">grunt watch</code></li>';
-$die .= '<li>' . __( 'To create a production build of WordPress, run:' ) . '<br /><br />';
-$die .= '<code style="color: green;">grunt build</code></li>';
-$die .= '</ul>';
-
-$die .= '<p>' . sprintf(
- /* translators: 1: NPM URL, 2: Grunt URL, 3: Handbook URL */
- __( 'This requires <a href="%1$s">NPM</a> and <a href="%2$s">Grunt</a>. <a href="%3$s">Read more about setting up your local development environment</a>.' ),
- 'https://www.npmjs.com/',
- 'https://gruntjs.com/',
- __( 'https://make.wordpress.org/core/handbook/tutorials/installing-wordpress-locally/' )
-) . '</p>';
-
-wp_die( $die, __( 'WordPress › Error' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+require_once dirname( dirname( __FILE__ ) ) . '/index.php';
</ins></span></pre>
</div>
</div>
</body>
</html>