<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44539] trunk/src/js/_enqueues: Admin: Don't use the `keyup` event in addition to the `input` event.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44539">44539</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44539","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-01-10 02:56:24 +0000 (Thu, 10 Jan 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Admin: Don't use the `keyup` event in addition to the `input` event.
The `keyup` event was used to provide support for IE8, where which doesn't support the `input` event. As we dropped IE8 support some time ago, this was simply adding unnecessary complexity and double-event triggers.
Props dlh, afercia.
Fixes <a href="https://core.trac.wordpress.org/ticket/32882">#32882</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcjs_enqueuesadminuserprofilejs">trunk/src/js/_enqueues/admin/user-profile.js</a></li>
<li><a href="#trunksrcjs_enqueueslibnavmenujs">trunk/src/js/_enqueues/lib/nav-menu.js</a></li>
<li><a href="#trunksrcjs_enqueueswpcustomizenavmenusjs">trunk/src/js/_enqueues/wp/customize/nav-menus.js</a></li>
<li><a href="#trunksrcjs_enqueueswpcustomizewidgetsjs">trunk/src/js/_enqueues/wp/customize/widgets.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcjs_enqueuesadminuserprofilejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/admin/user-profile.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/admin/user-profile.js 2019-01-10 02:49:23 UTC (rev 44538)
+++ trunk/src/js/_enqueues/admin/user-profile.js 2019-01-10 02:56:24 UTC (rev 44539)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -17,20 +17,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $toggleButton,
</span><span class="cx" style="display: block; padding: 0 10px"> $submitButtons,
</span><span class="cx" style="display: block; padding: 0 10px"> $submitButton,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- currentPass,
- inputEvent;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ currentPass;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * Use feature detection to determine whether password inputs should use
- * the `keyup` or `input` event. Input is preferred but lacks support
- * in legacy browsers.
- */
- if ( 'oninput' in document.createElement( 'input' ) ) {
- inputEvent = 'input';
- } else {
- inputEvent = 'keyup';
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function generatePassword() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( typeof zxcvbn !== 'function' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> setTimeout( generatePassword, 50 );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -71,7 +59,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .addClass( $pass1[0].className )
</span><span class="cx" style="display: block; padding: 0 10px"> .data( 'pw', $pass1.data( 'pw' ) )
</span><span class="cx" style="display: block; padding: 0 10px"> .val( $pass1.val() )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .on( inputEvent, function () {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .on( 'input', function () {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $pass1Text.val() === currentPass ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -86,7 +74,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> generatePassword();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pass1.on( inputEvent + ' pwupdate', function () {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pass1.on( 'input' + ' pwupdate', function () {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $pass1.val() === currentPass ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -188,7 +176,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * This fixes the issue by copying any changes from the hidden
</span><span class="cx" style="display: block; padding: 0 10px"> * pass2 field to the pass1 field, then running check_pass_strength.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pass2 = $('#pass2').on( inputEvent, function () {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pass2 = $( '#pass2' ).on( 'input', function () {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $pass2.val().length > 0 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $pass1.val( $pass2.val() );
</span><span class="cx" style="display: block; padding: 0 10px"> $pass2.val('');
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -336,7 +324,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> current_name = select.val(),
</span><span class="cx" style="display: block; padding: 0 10px"> greeting = $( '#wp-admin-bar-my-account' ).find( '.display-name' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#pass1').val('').on( inputEvent + ' pwupdate', check_pass_strength );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '#pass1' ).val( '' ).on( 'input' + ' pwupdate', check_pass_strength );
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#pass-strength-result').show();
</span><span class="cx" style="display: block; padding: 0 10px"> $('.color-palette').click( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> $(this).siblings('input[name="admin_color"]').prop('checked', true);
</span></span></pre></div>
<a id="trunksrcjs_enqueueslibnavmenujs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/lib/nav-menu.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/lib/nav-menu.js 2019-01-10 02:49:23 UTC (rev 44538)
+++ trunk/src/js/_enqueues/lib/nav-menu.js 2019-01-10 02:56:24 UTC (rev 44539)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -873,8 +873,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> attachQuickSearchListeners : function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var searchTimer,
- inputEvent;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var searchTimer;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Prevent form submission.
</span><span class="cx" style="display: block; padding: 0 10px"> $( '#nav-menu-meta' ).on( 'submit', function( event ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -881,18 +880,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> event.preventDefault();
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * Use feature detection to determine whether inputs should use
- * the `keyup` or `input` event. Input is preferred but lacks support
- * in legacy browsers. See changeset 34078, see also ticket #26600#comment:59
- */
- if ( 'oninput' in document.createElement( 'input' ) ) {
- inputEvent = 'input';
- } else {
- inputEvent = 'keyup';
- }
-
- $( '#nav-menu-meta' ).on( inputEvent, '.quick-search', function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '#nav-menu-meta' ).on( 'input', '.quick-search', function() {
</ins><span class="cx" style="display: block; padding: 0 10px"> var $this = $( this );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this.attr( 'autocomplete', 'off' );
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpcustomizenavmenusjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/customize/nav-menus.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/customize/nav-menus.js 2019-01-10 02:49:23 UTC (rev 44538)
+++ trunk/src/js/_enqueues/wp/customize/nav-menus.js 2019-01-10 02:56:24 UTC (rev 44539)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -156,7 +156,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> events: {
</span><span class="cx" style="display: block; padding: 0 10px"> 'input #menu-items-search': 'debounceSearch',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'keyup #menu-items-search': 'debounceSearch',
</del><span class="cx" style="display: block; padding: 0 10px"> 'focus .menu-item-tpl': 'focus',
</span><span class="cx" style="display: block; padding: 0 10px"> 'click .menu-item-tpl': '_submit',
</span><span class="cx" style="display: block; padding: 0 10px"> 'click #custom-menu-item-submit': '_submitLink',
</span></span></pre></div>
<a id="trunksrcjs_enqueueswpcustomizewidgetsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/js/_enqueues/wp/customize/widgets.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/js/_enqueues/wp/customize/widgets.js 2019-01-10 02:49:23 UTC (rev 44538)
+++ trunk/src/js/_enqueues/wp/customize/widgets.js 2019-01-10 02:56:24 UTC (rev 44539)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -144,7 +144,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> events: {
</span><span class="cx" style="display: block; padding: 0 10px"> 'input #widgets-search': 'search',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'keyup #widgets-search': 'search',
</del><span class="cx" style="display: block; padding: 0 10px"> 'focus .widget-tpl' : 'focus',
</span><span class="cx" style="display: block; padding: 0 10px"> 'click .widget-tpl' : '_submit',
</span><span class="cx" style="display: block; padding: 0 10px"> 'keypress .widget-tpl' : '_submit',
</span></span></pre>
</div>
</div>
</body>
</html>